openrewrite-migrate-python 0.13.0.dev20260820170959__tar.gz → 0.13.1__tar.gz

{openrewrite_migrate_python-0.13.0.dev20260820170959 → openrewrite_migrate_python-0.13.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openrewrite-migrate-python
-Version: 0.13.0.dev20260820170959
+Version: 0.13.1
 Summary: OpenRewrite recipes for migrating Python codebases to newer Python versions.
 Author-email: "Moderne Inc." <support@moderne.io>
 License: Moderne Proprietary

{openrewrite_migrate_python-0.13.0.dev20260820170959 → openrewrite_migrate_python-0.13.1}/pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"
 [project]
 name = "openrewrite-migrate-python"
 description = "OpenRewrite recipes for migrating Python codebases to newer Python versions."
-version = "0.13.0.dev20260820170959"  # Updated dynamically during release
+version = "0.13.1"  # Updated dynamically during release
 authors = [{ name = "Moderne Inc.", email = "support@moderne.io" }]
 license = { text = "Moderne Proprietary" }
 readme = "README.md"

openrewrite_migrate_python-0.13.1/src/openrewrite_code_quality_python/codequality/find_suspicious_chained_comparison.py

@@ -0,0 +1,122 @@
+"""
+Recipe to find suspicious chained comparisons with conflicting direction.
+
+Python evaluates ``a < b < c`` as ``(a < b) and (b < c)``. When the two
+links point in opposite directions--one of ``<``/``<=`` and the other of
+``>``/``>=``--the chain is almost always a mistake, e.g. ``0 <= x >= 10``
+was likely meant to be ``0 <= x <= 10``. This is a search recipe: the
+intent is ambiguous, so it flags the expression rather than rewriting it.
+"""
+
+from typing import Any, List, Optional
+
+from rewrite import ExecutionContext, Recipe, TreeVisitor
+from rewrite.category import CategoryDescriptor
+from rewrite.decorators import categorize
+from rewrite.marketplace import Python
+from rewrite.markers import Markers, SearchResult
+from rewrite.python.visitor import PythonVisitor
+from rewrite.java.tree import Binary as JBinary, Expression
+from rewrite.utils import random_id
+
+_CodeQuality = [
+    *Python,
+    CategoryDescriptor(display_name="Code quality"),
+]
+
+_LESS = (JBinary.Type.LessThan, JBinary.Type.LessThanOrEqual)
+_GREATER = (JBinary.Type.GreaterThan, JBinary.Type.GreaterThanOrEqual)
+
+
+def _direction(operator: JBinary.Type) -> Optional[str]:
+    """Classify an ordering operator as ``"less"``, ``"greater"``, or None."""
+    if operator in _LESS:
+        return "less"
+    if operator in _GREATER:
+        return "greater"
+    return None
+
+
+def _mark(tree: Expression) -> Expression:
+    """Attach a SearchResult flagging the conflicting chained comparison."""
+    message = (
+        "Suspicious chained comparison: the two comparisons point in "
+        "opposite directions, so the chain narrows to a surprising range. "
+        "Did you mean to keep both comparisons in the same direction?"
+    )
+    marker = SearchResult(random_id(), message)
+    current = tree.markers
+    return tree.replace(
+        _markers=Markers(current.id, list(current.markers) + [marker])
+    )
+
+
+@categorize(_CodeQuality)
+class FindSuspiciousChainedComparison(Recipe):
+    """
+    Find chained comparisons whose links point in opposite directions.
+
+    A chain such as ``0 <= x >= 10`` reads as ``0 <= x and x >= 10``, which
+    is a needlessly convoluted way to say ``x >= 10`` and is almost always a
+    typo for ``0 <= x <= 10``. Mixing ``<``/``<=`` with ``>``/``>=`` in a
+    single chain is the tell-tale sign.
+
+    Example:
+        Flagged:
+            if 0 <= x >= 10:
+                pass
+
+        Not flagged (monotonic):
+            if 0 <= x <= 10:
+                pass
+    """
+
+    @property
+    def name(self) -> str:
+        return "org.openrewrite.python.codequality.FindSuspiciousChainedComparison"
+
+    @property
+    def display_name(self) -> str:
+        return "Find suspicious chained comparisons"
+
+    @property
+    def description(self) -> str:
+        return (
+            "Find chained comparisons that mix `<`/`<=` with `>`/`>=` (for "
+            "example `0 <= x >= 10`), where the links point in opposite "
+            "directions and the chain is almost always a mistake."
+        )
+
+    @property
+    def tags(self) -> List[str]:
+        return ["python", "code-quality"]
+
+    @property
+    def estimated_effort_per_occurrence(self) -> int:
+        return 5
+
+    def editor(self) -> TreeVisitor[Any, ExecutionContext]:
+        class Visitor(PythonVisitor[ExecutionContext]):
+            def visit_binary(
+                self, binary: JBinary, p: ExecutionContext
+            ) -> Optional[Expression]:
+                binary = super().visit_binary(binary, p)
+
+                if not isinstance(binary, JBinary):
+                    return binary
+
+                outer = _direction(binary.operator)
+                if outer is None:
+                    return binary
+
+                inner = binary.left
+                if not isinstance(inner, JBinary):
+                    return binary
+
+                left = _direction(inner.operator)
+                if left is None or left == outer:
+                    return binary
+
+                return _mark(binary)
+
+        return Visitor()

{openrewrite_migrate_python-0.13.0.dev20260820170959 → openrewrite_migrate_python-0.13.1}/src/openrewrite_migrate_python.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openrewrite-migrate-python
-Version: 0.13.0.dev20260820170959
+Version: 0.13.1
 Summary: OpenRewrite recipes for migrating Python codebases to newer Python versions.
 Author-email: "Moderne Inc." <support@moderne.io>
 License: Moderne Proprietary

{openrewrite_migrate_python-0.13.0.dev20260820170959 → openrewrite_migrate_python-0.13.1}/src/openrewrite_migrate_python.egg-info/SOURCES.txt

@@ -5,6 +5,7 @@ src/openrewrite_code_quality_python/codequality/_semantically_equal.py
 src/openrewrite_code_quality_python/codequality/all_branches_identical.py
 src/openrewrite_code_quality_python/codequality/boolean_checks_not_inverted.py
 src/openrewrite_code_quality_python/codequality/collapsible_if_statements.py
+src/openrewrite_code_quality_python/codequality/find_suspicious_chained_comparison.py
 src/openrewrite_code_quality_python/codequality/merge_identical_branches.py
 src/openrewrite_code_quality_python/codequality/remove_duplicate_conditions.py
 src/openrewrite_code_quality_python/codequality/remove_self_assignment.py