openhands-tools 1.56.0__tar.gz → 1.58.0__tar.gz

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openhands-tools
-Version: 1.56.0
+Version: 1.58.0
 Summary: OpenHands Tools - Runtime tools for AI agents
 Project-URL: Source, https://github.com/OpenHands/software-agent-sdk
 Project-URL: Homepage, https://github.com/OpenHands/software-agent-sdk

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/openhands/tools/browser_use/impl.py

@@ -147,15 +147,25 @@ def _standard_chromium_paths(platform: str | None = None) -> list[Path]:
 
 
 def _playwright_cache_dirs(platform: str | None = None) -> list[Path]:
+    # Playwright installs browsers into $PLAYWRIGHT_BROWSERS_PATH when set.
+    # "0" is its special value for browsers inside the installed package,
+    # which is not a directory path, so it is ignored here.
+    dirs: list[Path] = []
+    if (browsers_path := os.environ.get("PLAYWRIGHT_BROWSERS_PATH")) and (
+        browsers_path != "0"
+    ):
+        dirs.append(Path(browsers_path).expanduser())
     match _current_platform(platform):
         case "darwin":
-            return [Path.home() / "Library" / "Caches" / "ms-playwright"]
+            dirs.append(Path.home() / "Library" / "Caches" / "ms-playwright")
         case "win32":
             if local_app_data := os.environ.get("LOCALAPPDATA"):
-                return [Path(local_app_data) / "ms-playwright"]
-            return [Path.home() / "AppData" / "Local" / "ms-playwright"]
+                dirs.append(Path(local_app_data) / "ms-playwright")
+            else:
+                dirs.append(Path.home() / "AppData" / "Local" / "ms-playwright")
         case _:
-            return [Path.home() / ".cache" / "ms-playwright"]
+            dirs.append(Path.home() / ".cache" / "ms-playwright")
+    return dirs
 
 
 def _playwright_chromium_paths(

openhands_tools-1.58.0/openhands/tools/terminal/terminal/process_priority.py

@@ -0,0 +1,39 @@
+"""Lower the CPU priority of agent terminals so they cannot starve the server."""
+
+import os
+import platform
+import shutil
+from collections.abc import Mapping
+from typing import Final
+
+
+TERMINAL_PROCESS_PRIORITY_ENV: Final[str] = "OH_TERMINAL_PROCESS_PRIORITY"
+
+# macOS largely ignores nice; the utility QoS clamp is what keeps the server
+# responsive. Avoid the background clamp: it also throttles I/O heavily.
+_TASKPOLICY_PATH: Final[str] = "/usr/sbin/taskpolicy"
+_LINUX_NICE_INCREMENT: Final[str] = "10"
+
+
+def should_lower_process_priority(env: Mapping[str, str]) -> bool:
+    """Return False when the terminal env opts out with ``none``."""
+    value = env.get(TERMINAL_PROCESS_PRIORITY_ENV, "")
+    return value.strip().lower() != "none"
+
+
+def process_priority_prefix(env: Mapping[str, str]) -> list[str]:
+    """Return an argv prefix that runs the shell at lower CPU priority.
+
+    This must be an argv prefix rather than a ``preexec_fn``: a macOS QoS class
+    set on the calling thread does not survive ``exec``. Both ``taskpolicy``
+    and ``nice`` are inherited by every process the shell starts.
+    """
+    if not should_lower_process_priority(env):
+        return []
+
+    system = platform.system()
+    if system == "Darwin" and os.path.exists(_TASKPOLICY_PATH):
+        return [_TASKPOLICY_PATH, "-c", "utility"]
+    if system == "Linux" and (nice_path := shutil.which("nice")) is not None:
+        return [nice_path, "-n", _LINUX_NICE_INCREMENT]
+    return []

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/openhands/tools/terminal/terminal/subprocess_terminal.py

@@ -35,6 +35,9 @@ from openhands.tools.terminal.env import (
 from openhands.tools.terminal.metadata import CmdOutputMetadata
 from openhands.tools.terminal.terminal import TerminalInterface
 from openhands.tools.terminal.terminal.interface import parse_ctrl_key
+from openhands.tools.terminal.terminal.process_priority import (
+    process_priority_prefix,
+)
 
 
 logger = get_logger(__name__)
@@ -151,7 +154,7 @@ class SubprocessTerminal(TerminalInterface):
         env["PS2"] = ""
         env["TERM"] = "xterm-256color"
 
-        bash_cmd = [resolved_shell_path, "-i"]
+        bash_cmd = [*process_priority_prefix(env), resolved_shell_path, "-i"]
 
         # Create a PTY; give the slave to the child, keep the master
         master_fd, slave_fd = pty.openpty()

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/openhands/tools/terminal/terminal/tmux_pane_pool.py

@@ -6,6 +6,7 @@ tmux session, enabling concurrent command execution across panes.
 
 from __future__ import annotations
 
+import shlex
 import threading
 import time
 import uuid
@@ -27,6 +28,9 @@ from openhands.tools.terminal.env import (
     build_terminal_env,
     normalize_terminal_env,
 )
+from openhands.tools.terminal.terminal.process_priority import (
+    process_priority_prefix,
+)
 from openhands.tools.terminal.terminal.tmux_terminal import (
     TmuxTerminal,
     _new_owned_session,
@@ -169,13 +173,14 @@ class TmuxPanePool:
         """Create a new PooledTmuxTerminal within the shared session."""
         assert self._session is not None
 
-        shell_command = "/bin/bash"
+        shell_command = ["/bin/bash"]
         if self.username in ["root", "openhands"]:
-            shell_command = f"su {self.username} -"
+            shell_command = ["su", self.username, "-"]
+        priority_prefix = process_priority_prefix(build_terminal_env(self.env))
 
         window = self._session.new_window(
             window_name=f"pane-{len(self._all_panes)}",
-            window_shell=shell_command,
+            window_shell=shlex.join([*priority_prefix, *shell_command]),
             start_directory=self.work_dir,
         )
         active_pane = window.active_pane

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/openhands/tools/terminal/terminal/tmux_terminal.py

@@ -2,6 +2,7 @@
 
 import logging
 import os
+import shlex
 import sys
 import time
 import uuid
@@ -29,6 +30,9 @@ from openhands.tools.terminal.env import (
 from openhands.tools.terminal.metadata import CmdOutputMetadata
 from openhands.tools.terminal.terminal import TerminalInterface
 from openhands.tools.terminal.terminal.interface import parse_ctrl_key
+from openhands.tools.terminal.terminal.process_priority import (
+    process_priority_prefix,
+)
 
 
 logger = get_logger(__name__)
@@ -145,7 +149,6 @@ def _new_owned_session(
         server = libtmux.Server(
             socket_name=None if fallback else socket_name,
             socket_path=str(socket_dir / socket_name) if fallback else None,
-            environment=dict(env),
         )
         session = server.new_session(
             session_name=session_name,
@@ -155,7 +158,11 @@ def _new_owned_session(
             y=y,
         )
         mark_socket_owner(server)
-        return server, session
+    # A tmux server starts with this process's environment rather than *env*,
+    # and new windows inherit it, so unset what sanitization removed.
+    for key in os.environ.keys() - env.keys():
+        server.unset_environment(key)
+    return server, session
 
 
 # Map normalized special key names to tmux key names.
@@ -212,12 +219,12 @@ class TmuxTerminal(TerminalInterface):
         # auto-launch `less` on a TTY don't capture the pane and wedge the session.
         env.setdefault("GIT_PAGER", "cat")
         env.setdefault("PAGER", "cat")
-        _shell_command = "/bin/bash"
+        shell_command = ["/bin/bash"]
         if self.username in ["root", "openhands"]:
             # This starts a non-login (new) shell for the given user
-            _shell_command = f"su {self.username} -"
+            shell_command = ["su", self.username, "-"]
 
-        window_command = _shell_command
+        window_command = shlex.join([*process_priority_prefix(env), *shell_command])
 
         logger.debug(f"Initializing tmux terminal with command: {window_command}")
         # Never reuse a socket: tmux numeric IDs restart at zero after server exit.

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/openhands/tools/terminal/terminal/windows_terminal.py

@@ -26,6 +26,9 @@ from openhands.tools.terminal.terminal.interface import (
     TerminalInterface,
     parse_ctrl_key,
 )
+from openhands.tools.terminal.terminal.process_priority import (
+    should_lower_process_priority,
+)
 
 
 logger = get_logger(__name__)
@@ -92,6 +95,10 @@ class WindowsTerminal(TerminalInterface):
         if self._initialized:
             return
 
+        env = build_terminal_env(self._env)
+        env.setdefault("PYTHONIOENCODING", "utf-8")
+        env.setdefault("PYTHONUTF8", "1")
+
         startupinfo = None
         creationflags = 0
         if platform.system() == "Windows":
@@ -101,10 +108,9 @@ class WindowsTerminal(TerminalInterface):
                 startupinfo.dwFlags |= getattr(subprocess, "STARTF_USESHOWWINDOW", 0)
             creationflags = getattr(subprocess, "CREATE_NEW_PROCESS_GROUP", 0)
             creationflags |= getattr(subprocess, "CREATE_NO_WINDOW", 0)
-
-        env = build_terminal_env(self._env)
-        env.setdefault("PYTHONIOENCODING", "utf-8")
-        env.setdefault("PYTHONUTF8", "1")
+            # Not PROCESS_MODE_BACKGROUND_BEGIN: it also throttles disk I/O.
+            if should_lower_process_priority(env):
+                creationflags |= getattr(subprocess, "BELOW_NORMAL_PRIORITY_CLASS", 0)
 
         self.process = subprocess.Popen(
             [self.shell_path, "-NoLogo", "-NoProfile"],

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/openhands_tools.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openhands-tools
-Version: 1.56.0
+Version: 1.58.0
 Summary: OpenHands Tools - Runtime tools for AI agents
 Project-URL: Source, https://github.com/OpenHands/software-agent-sdk
 Project-URL: Homepage, https://github.com/OpenHands/software-agent-sdk

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/openhands_tools.egg-info/SOURCES.txt

@@ -84,6 +84,7 @@ pyproject.toml
 ./openhands/tools/terminal/terminal/__init__.py
 ./openhands/tools/terminal/terminal/factory.py
 ./openhands/tools/terminal/terminal/interface.py
+./openhands/tools/terminal/terminal/process_priority.py
 ./openhands/tools/terminal/terminal/subprocess_terminal.py
 ./openhands/tools/terminal/terminal/terminal_session.py
 ./openhands/tools/terminal/terminal/tmux_pane_pool.py
@@ -185,6 +186,7 @@ openhands/tools/terminal/timeout_policy.py
 openhands/tools/terminal/terminal/__init__.py
 openhands/tools/terminal/terminal/factory.py
 openhands/tools/terminal/terminal/interface.py
+openhands/tools/terminal/terminal/process_priority.py
 openhands/tools/terminal/terminal/subprocess_terminal.py
 openhands/tools/terminal/terminal/terminal_session.py
 openhands/tools/terminal/terminal/tmux_pane_pool.py

{openhands_tools-1.56.0 → openhands_tools-1.58.0}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "openhands-tools"
-version = "1.56.0"
+version = "1.58.0"
 description = "OpenHands Tools - Runtime tools for AI agents"
 
 requires-python = ">=3.12"