openfeature-provider-flagd 0.2.4__tar.gz → 0.2.6__tar.gz

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/.gitignore

@@ -54,3 +54,6 @@ docs/_build/
 
 # vscode
 .vscode/
+
+# test coverage
+/providers/openfeature-provider-env-var/tests-results.xml

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## [0.2.6](https://github.com/open-feature/python-sdk-contrib/compare/openfeature-provider-flagd/v0.2.5...openfeature-provider-flagd/v0.2.6) (2025-07-22)
+
+
+### 🐛 Bug Fixes
+
+* **flagd:** Add upperbound to protobuf version to reduce potential conflict with other version ([5ad2896](https://github.com/open-feature/python-sdk-contrib/commit/5ad289683a0d9128a53d142d2804f9fffb9dd36f))
+* **flagd:** adjust flagd to updated error codes ([#285](https://github.com/open-feature/python-sdk-contrib/issues/285)) ([64d755b](https://github.com/open-feature/python-sdk-contrib/commit/64d755b869a076216a91b2d409b1ba5d627ebe08))
+* **flagd:** fix protobuf version for file generation to lowest 5.x version ([#280](https://github.com/open-feature/python-sdk-contrib/issues/280)) ([5ad2896](https://github.com/open-feature/python-sdk-contrib/commit/5ad289683a0d9128a53d142d2804f9fffb9dd36f))
+
+## [0.2.5](https://github.com/open-feature/python-sdk-contrib/compare/openfeature-provider-flagd/v0.2.4...openfeature-provider-flagd/v0.2.5) (2025-07-08)
+
+
+### 🐛 Bug Fixes
+
+* **flagd:** reduce loglevel of expected logs ([#277](https://github.com/open-feature/python-sdk-contrib/issues/277)) ([cca865f](https://github.com/open-feature/python-sdk-contrib/commit/cca865f490cc699ecf038c934dfccacad9bda8d2))
+
 ## [0.2.4](https://github.com/open-feature/python-sdk-contrib/compare/openfeature-provider-flagd/v0.2.3...openfeature-provider-flagd/v0.2.4) (2025-06-10)
 
 

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openfeature-provider-flagd
-Version: 0.2.4
+Version: 0.2.6
 Summary: OpenFeature provider for the flagd flag evaluation engine
 Project-URL: Homepage, https://github.com/open-feature/python-sdk-contrib
 Author-email: OpenFeature <openfeature-core@groups.io>
@@ -215,7 +215,7 @@ Requires-Dist: grpcio>=1.68.1
 Requires-Dist: mmh3>=4.1.0
 Requires-Dist: openfeature-sdk>=0.6.0
 Requires-Dist: panzi-json-logic>=1.0.1
-Requires-Dist: protobuf>=4.29.2
+Requires-Dist: protobuf>=5.26.1
 Requires-Dist: pyyaml>=6.0.1
 Requires-Dist: semver<4,>=3
 Description-Content-Type: text/markdown

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "openfeature-provider-flagd"
-version = "0.2.4"
+version = "0.2.6"
 description = "OpenFeature provider for the flagd flag evaluation engine"
 readme = "README.md"
 authors = [{ name = "OpenFeature", email = "openfeature-core@groups.io" }]
@@ -19,7 +19,7 @@ keywords = []
 dependencies = [
   "openfeature-sdk>=0.6.0",
   "grpcio>=1.68.1",
-  "protobuf>=4.29.2",
+  "protobuf>=5.26.1",
   "mmh3>=4.1.0",
   "panzi-json-logic>=1.0.1",
   "semver>=3,<4",
@@ -40,7 +40,7 @@ dependencies = [
   "pytest-bdd",
   "testcontainers",
   "asserts",
-  "grpcio-health-checking==1.73.0",
+  "grpcio-health-checking",
 ]
 pre-install-commands = [
   "hatch build",
@@ -77,6 +77,7 @@ run = "mypy"
 [tool.hatch.build.hooks.protobuf]
 generate_pyi = false
 dependencies = [
+    "protobuf==5.26.1",
     "hatch-protobuf",
     "mypy-protobuf~=3.0",
 ]

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/contrib/provider/flagd/resolvers/in_process.py

@@ -5,13 +5,13 @@ from openfeature.contrib.provider.flagd.resolvers.process.connector.file_watcher
 )
 from openfeature.evaluation_context import EvaluationContext
 from openfeature.event import ProviderEventDetails
-from openfeature.exception import FlagNotFoundError, ParseError
+from openfeature.exception import ErrorCode, FlagNotFoundError, GeneralError, ParseError
 from openfeature.flag_evaluation import FlagResolutionDetails, Reason
 
 from ..config import Config
 from .process.connector import FlagStateConnector
 from .process.connector.grpc_watcher import GrpcWatcher
-from .process.flags import FlagStore
+from .process.flags import Flag, FlagStore
 from .process.targeting import targeting
 
 T = typing.TypeVar("T")
@@ -128,26 +128,30 @@ class InProcessResolver:
             )
 
         if not flag.targeting:
-            variant, value = flag.default
-            return FlagResolutionDetails(
-                value, variant=variant, flag_metadata=metadata, reason=Reason.STATIC
-            )
+            return _default_resolve(flag, metadata, Reason.STATIC)
 
-        variant = targeting(flag.key, flag.targeting, evaluation_context)
+        try:
+            variant = targeting(flag.key, flag.targeting, evaluation_context)
+            if variant is None:
+                return _default_resolve(flag, metadata, Reason.DEFAULT)
 
-        if variant is None:
-            variant, value = flag.default
-            return FlagResolutionDetails(
-                value, variant=variant, flag_metadata=metadata, reason=Reason.DEFAULT
-            )
-        if not isinstance(variant, (str, bool)):
-            raise ParseError(
-                "Parsed JSONLogic targeting did not return a string or bool"
-            )
+            # convert to string to support shorthand (boolean in python is with capital T hence the special case)
+            if isinstance(variant, bool):
+                variant = str(variant).lower()
+            elif not isinstance(variant, str):
+                variant = str(variant)
+
+            if variant not in flag.variants:
+                raise GeneralError(
+                    f"Resolved variant {variant} not in variants config."
+                )
+
+        except ReferenceError:
+            raise ParseError(f"Invalid targeting {targeting}") from ReferenceError
 
         variant, value = flag.get_variant(variant)
         if value is None:
-            raise ParseError(f"Resolved variant {variant} not in variants config.")
+            raise GeneralError(f"Resolved variant {variant} not in variants config.")
 
         return FlagResolutionDetails(
             value,
@@ -155,3 +159,24 @@ class InProcessResolver:
             reason=Reason.TARGETING_MATCH,
             flag_metadata=metadata,
         )
+
+
+def _default_resolve(
+    flag: Flag,
+    metadata: typing.Mapping[str, typing.Union[float, int, str, bool]],
+    reason: Reason,
+) -> FlagResolutionDetails:
+    variant, value = flag.default
+    if variant is None:
+        return FlagResolutionDetails(
+            value,
+            variant=variant,
+            reason=Reason.ERROR,
+            error_code=ErrorCode.FLAG_NOT_FOUND,
+            flag_metadata=metadata,
+        )
+    if variant not in flag.variants:
+        raise GeneralError(f"Resolved variant {variant} not in variants config.")
+    return FlagResolutionDetails(
+        value, variant=variant, flag_metadata=metadata, reason=reason
+    )

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py

@@ -258,7 +258,7 @@ class GrpcWatcher(FlagStateConnector):
                         logger.debug("Terminating gRPC sync thread")
                         return
             except grpc.RpcError as e:  # noqa: PERF203
-                logger.error(f"SyncFlags stream error, {e.code()=} {e.details()=}")
+                logger.debug(f"SyncFlags stream error, {e.code()=} {e.details()=}")
             except json.JSONDecodeError:
                 logger.exception(
                     f"Could not parse JSON flag data from SyncFlags endpoint: {flag_str=}"

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py

@@ -72,30 +72,22 @@ class Flag:
     key: str
     state: str
     variants: typing.Mapping[str, typing.Any]
-    default_variant: typing.Union[bool, str]
+    default_variant: typing.Optional[typing.Union[bool, str]] = None
     targeting: typing.Optional[dict] = None
     metadata: typing.Optional[
         typing.Mapping[str, typing.Union[float, int, str, bool]]
     ] = None
 
     def __post_init__(self) -> None:
-        if not self.state or not isinstance(self.state, str):
+        if not self.state or not (self.state == "ENABLED" or self.state == "DISABLED"):
             raise ParseError("Incorrect 'state' value provided in flag config")
 
         if not self.variants or not isinstance(self.variants, dict):
             raise ParseError("Incorrect 'variants' value provided in flag config")
 
-        if not self.default_variant or not isinstance(
-            self.default_variant, (str, bool)
-        ):
+        if self.default_variant and not isinstance(self.default_variant, (str, bool)):
             raise ParseError("Incorrect 'defaultVariant' value provided in flag config")
 
-        if self.targeting and not isinstance(self.targeting, dict):
-            raise ParseError("Incorrect 'targeting' value provided in flag config")
-
-        if self.default_variant not in self.variants:
-            raise ParseError("Default variant does not match set of variants")
-
         if self.metadata:
             if not isinstance(self.metadata, dict):
                 raise ParseError("Flag metadata is not a valid json object")
@@ -106,6 +98,8 @@ class Flag:
     def from_dict(cls, key: str, data: dict) -> "Flag":
         if "defaultVariant" in data:
             data["default_variant"] = data["defaultVariant"]
+            if data["default_variant"] == "":
+                data["default_variant"] = None
             del data["defaultVariant"]
 
         data.pop("source", None)
@@ -119,13 +113,16 @@ class Flag:
             raise ParseError from err
 
     @property
-    def default(self) -> tuple[str, typing.Any]:
+    def default(self) -> tuple[typing.Optional[str], typing.Any]:
         return self.get_variant(self.default_variant)
 
     def get_variant(
-        self, variant_key: typing.Union[str, bool]
-    ) -> tuple[str, typing.Any]:
+        self, variant_key: typing.Union[str, bool, None]
+    ) -> tuple[typing.Optional[str], typing.Any]:
         if isinstance(variant_key, bool):
             variant_key = str(variant_key).lower()
 
+        if not variant_key:
+            return None, None
+
         return variant_key, self.variants.get(variant_key)

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/contrib/provider/flagd/resolvers/process/targeting.py

@@ -5,6 +5,7 @@ from json_logic import builtins, jsonLogic
 from json_logic.types import JsonValue
 
 from openfeature.evaluation_context import EvaluationContext
+from openfeature.exception import ParseError
 
 from .custom_ops import (
     ends_with,
@@ -27,6 +28,9 @@ def targeting(
     targeting: dict,
     evaluation_context: typing.Optional[EvaluationContext] = None,
 ) -> JsonValue:
+    if not isinstance(targeting, dict):
+        raise ParseError(f"Invalid 'targeting' value in flag: {targeting}")
+
     json_logic_context = evaluation_context.attributes if evaluation_context else {}
     json_logic_context["$flagd"] = {"flagKey": key, "timestamp": int(time.time())}
     json_logic_context["targetingKey"] = (

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/schemas/protobuf/flagd/evaluation/v1/evaluation_pb2.py

@@ -2,7 +2,7 @@
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
 # NO CHECKED-IN PROTOBUF GENCODE
 # source: openfeature/schemas/protobuf/flagd/evaluation/v1/evaluation.proto
-# Protobuf Python Version: 6.31.0
+# Protobuf Python Version: 5.29.0
 """Generated protocol buffer code."""
 from google.protobuf import descriptor as _descriptor
 from google.protobuf import descriptor_pool as _descriptor_pool
@@ -11,8 +11,8 @@ from google.protobuf import symbol_database as _symbol_database
 from google.protobuf.internal import builder as _builder
 _runtime_version.ValidateProtobufRuntimeVersion(
     _runtime_version.Domain.PUBLIC,
-    6,
-    31,
+    5,
+    29,
     0,
     '',
     'openfeature/schemas/protobuf/flagd/evaluation/v1/evaluation.proto'

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/schemas/protobuf/flagd/evaluation/v1/evaluation_pb2_grpc.py

@@ -5,7 +5,7 @@ import warnings
 
 from openfeature.schemas.protobuf.flagd.evaluation.v1 import evaluation_pb2 as openfeature_dot_schemas_dot_protobuf_dot_flagd_dot_evaluation_dot_v1_dot_evaluation__pb2
 
-GRPC_GENERATED_VERSION = '1.73.0'
+GRPC_GENERATED_VERSION = '1.71.2'
 GRPC_VERSION = grpc.__version__
 _version_not_supported = False
 

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/schemas/protobuf/flagd/sync/v1/sync_pb2.py

@@ -2,7 +2,7 @@
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
 # NO CHECKED-IN PROTOBUF GENCODE
 # source: openfeature/schemas/protobuf/flagd/sync/v1/sync.proto
-# Protobuf Python Version: 6.31.0
+# Protobuf Python Version: 5.29.0
 """Generated protocol buffer code."""
 from google.protobuf import descriptor as _descriptor
 from google.protobuf import descriptor_pool as _descriptor_pool
@@ -11,8 +11,8 @@ from google.protobuf import symbol_database as _symbol_database
 from google.protobuf.internal import builder as _builder
 _runtime_version.ValidateProtobufRuntimeVersion(
     _runtime_version.Domain.PUBLIC,
-    6,
-    31,
+    5,
+    29,
     0,
     '',
     'openfeature/schemas/protobuf/flagd/sync/v1/sync.proto'

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/schemas/protobuf/flagd/sync/v1/sync_pb2_grpc.py

@@ -5,7 +5,7 @@ import warnings
 
 from openfeature.schemas.protobuf.flagd.sync.v1 import sync_pb2 as openfeature_dot_schemas_dot_protobuf_dot_flagd_dot_sync_dot_v1_dot_sync__pb2
 
-GRPC_GENERATED_VERSION = '1.73.0'
+GRPC_GENERATED_VERSION = '1.71.2'
 GRPC_VERSION = grpc.__version__
 _version_not_supported = False
 

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/schemas/protobuf/schema/v1/schema_pb2.py

@@ -2,7 +2,7 @@
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
 # NO CHECKED-IN PROTOBUF GENCODE
 # source: openfeature/schemas/protobuf/schema/v1/schema.proto
-# Protobuf Python Version: 6.31.0
+# Protobuf Python Version: 5.29.0
 """Generated protocol buffer code."""
 from google.protobuf import descriptor as _descriptor
 from google.protobuf import descriptor_pool as _descriptor_pool
@@ -11,8 +11,8 @@ from google.protobuf import symbol_database as _symbol_database
 from google.protobuf.internal import builder as _builder
 _runtime_version.ValidateProtobufRuntimeVersion(
     _runtime_version.Domain.PUBLIC,
-    6,
-    31,
+    5,
+    29,
     0,
     '',
     'openfeature/schemas/protobuf/schema/v1/schema.proto'

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/schemas/protobuf/schema/v1/schema_pb2_grpc.py

@@ -5,7 +5,7 @@ import warnings
 
 from openfeature.schemas.protobuf.schema.v1 import schema_pb2 as openfeature_dot_schemas_dot_protobuf_dot_schema_dot_v1_dot_schema__pb2
 
-GRPC_GENERATED_VERSION = '1.73.0'
+GRPC_GENERATED_VERSION = '1.71.2'
 GRPC_VERSION = grpc.__version__
 _version_not_supported = False
 

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/schemas/protobuf/sync/v1/sync_service_pb2.py

@@ -2,7 +2,7 @@
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
 # NO CHECKED-IN PROTOBUF GENCODE
 # source: openfeature/schemas/protobuf/sync/v1/sync_service.proto
-# Protobuf Python Version: 6.31.0
+# Protobuf Python Version: 5.29.0
 """Generated protocol buffer code."""
 from google.protobuf import descriptor as _descriptor
 from google.protobuf import descriptor_pool as _descriptor_pool
@@ -11,8 +11,8 @@ from google.protobuf import symbol_database as _symbol_database
 from google.protobuf.internal import builder as _builder
 _runtime_version.ValidateProtobufRuntimeVersion(
     _runtime_version.Domain.PUBLIC,
-    6,
-    31,
+    5,
+    29,
     0,
     '',
     'openfeature/schemas/protobuf/sync/v1/sync_service.proto'

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/src/openfeature/schemas/protobuf/sync/v1/sync_service_pb2_grpc.py

@@ -5,7 +5,7 @@ import warnings
 
 from openfeature.schemas.protobuf.sync.v1 import sync_service_pb2 as openfeature_dot_schemas_dot_protobuf_dot_sync_dot_v1_dot_sync__service__pb2
 
-GRPC_GENERATED_VERSION = '1.73.0'
+GRPC_GENERATED_VERSION = '1.71.2'
 GRPC_VERSION = grpc.__version__
 _version_not_supported = False
 

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/tests/e2e/flagd_container.py

@@ -48,7 +48,7 @@ class FlagdContainer(DockerContainer):
         return self
 
     @wait_container_is_ready(ConnectionError)
-    def _checker(self, host: str, port: str) -> None:
+    def _checker(self, host: str, port: int) -> None:
         # First we wait for Flagd to say it's listening
         wait_for_logs(
             self,
@@ -58,7 +58,7 @@ class FlagdContainer(DockerContainer):
 
         time.sleep(1)
         # Second we use the GRPC health check endpoint
-        with grpc.insecure_channel(host + ":" + port) as channel:
+        with grpc.insecure_channel(host + ":" + str(port)) as channel:
             health_stub = health_pb2_grpc.HealthStub(channel)
 
             def health_check_call(stub: health_pb2_grpc.HealthStub):

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/tests/e2e/step/context_steps.py

@@ -36,6 +36,18 @@ def update_context(
     evaluation_context.attributes[key] = type_cast[type_info](value)
 
 
+@given(
+    parsers.cfparse(
+        'a context containing a key "{key}", with type "{type_info}" and with value ""'
+    ),
+)
+def update_context_without_value(
+    evaluation_context: EvaluationContext, key: str, type_info: str
+):
+    """a context containing a key and value."""
+    update_context(evaluation_context, key, type_info, "")
+
+
 @when(
     parsers.cfparse(
         'context contains keys {fields:s} with values "{svalue}", "{svalue2}", {ivalue:d}, "{bvalue:bool}"',

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/tests/e2e/step/flag_step.py

@@ -1,5 +1,5 @@
 import requests
-from asserts import assert_equal
+from asserts import assert_equal, assert_is_none
 from pytest_bdd import given, parsers, then, when
 
 from openfeature.client import OpenFeatureClient
@@ -96,6 +96,25 @@ def resolve_details_reason(
     assert_equal(details.reason, Reason(reason))
 
 
+@then(
+    parsers.cfparse('the error-code should be "{error_code}"'),
+)
+def resolve_details_error_code(
+    details: FlagEvaluationDetails[JsonPrimitive],
+    error_code: str,
+):
+    assert_equal(details.error_code, error_code)
+
+
+@then(
+    parsers.cfparse('the error-code should be ""'),
+)
+def resolve_details_empty_error_code(
+    details: FlagEvaluationDetails[JsonPrimitive],
+):
+    assert_is_none(details.error_code)
+
+
 @then(parsers.cfparse("the resolved metadata should contain"))
 def metadata_contains(details: FlagEvaluationDetails[JsonPrimitive], datatable):
     assert_equal(len(details.flag_metadata), len(datatable) - 1)  # skip table header

openfeature_provider_flagd-0.2.6/tests/flags/basic-flag-without-default.json

@@ -0,0 +1,12 @@
+{
+  "flags": {
+    "basic-flag": {
+      "state": "ENABLED",
+      "variants": {
+        "true": true,
+        "false": false
+      },
+      "targeting": {}
+    }
+  }
+}

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/tests/test_errors.py

@@ -23,11 +23,9 @@ def create_client(provider: FlagdProvider):
         "not-a-flag.json",
         "basic-flag-wrong-structure.json",
         "basic-flag-invalid.not-json",
-        "basic-flag-wrong-variant.json",
         "basic-flag-broken-state.json",
         "basic-flag-broken-variants.json",
         "basic-flag-broken-default.json",
-        "basic-flag-broken-targeting.json",
     ],
 )
 def test_file_load_errors(file_name: str):
@@ -46,6 +44,38 @@ def test_file_load_errors(file_name: str):
     assert res.error_code == ErrorCode.FLAG_NOT_FOUND
 
 
+def test_non_existent_variant():
+    path = os.path.abspath(os.path.join(os.path.dirname(__file__), "./flags/"))
+    client = create_client(
+        FlagdProvider(
+            resolver_type=ResolverType.IN_PROCESS,
+            offline_flag_source_path=f"{path}/basic-flag-wrong-variant.json",
+        )
+    )
+
+    res = client.get_boolean_details("basic-flag", False)
+
+    assert res.value is False
+    assert res.reason == Reason.ERROR
+    assert res.error_code == ErrorCode.GENERAL
+
+
+def test_broken_targeting():
+    path = os.path.abspath(os.path.join(os.path.dirname(__file__), "./flags/"))
+    client = create_client(
+        FlagdProvider(
+            resolver_type=ResolverType.IN_PROCESS,
+            offline_flag_source_path=f"{path}/basic-flag-broken-targeting.json",
+        )
+    )
+
+    res = client.get_boolean_details("basic-flag", False)
+
+    assert res.value is False
+    assert res.reason == Reason.ERROR
+    assert res.error_code == ErrorCode.PARSE_ERROR
+
+
 @pytest.mark.parametrize(
     "file_name",
     [

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/tests/test_file_store.py

@@ -21,6 +21,7 @@ def create_client(provider: FlagdProvider):
     "file_name",
     [
         "basic-flag.json",
+        "basic-flag-without-default.json",
         "basic-flag.yaml",
     ],
 )

{openfeature_provider_flagd-0.2.4 → openfeature_provider_flagd-0.2.6}/tests/test_in_process.py

@@ -6,7 +6,7 @@ from openfeature.contrib.provider.flagd.config import Config
 from openfeature.contrib.provider.flagd.resolvers.in_process import InProcessResolver
 from openfeature.contrib.provider.flagd.resolvers.process.flags import Flag, FlagStore
 from openfeature.evaluation_context import EvaluationContext
-from openfeature.exception import FlagNotFoundError, ParseError
+from openfeature.exception import FlagNotFoundError, GeneralError
 
 
 def targeting():
@@ -79,7 +79,7 @@ def test_resolve_boolean_details_invalid_variant(resolver, flag):
 
     resolver.flag_store.get_flag = Mock(return_value=flag)
 
-    with pytest.raises(ParseError):
+    with pytest.raises(GeneralError):
         resolver.resolve_boolean_details("flag", False)