openfactory 0.2.1__tar.gz → 0.3.0__tar.gz

{openfactory-0.2.1/openfactory.egg-info → openfactory-0.3.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openfactory
-Version: 0.2.1
+Version: 0.3.0
 Summary: A framework to run software tickets autonomously with coding agents — policies authorize actions, humans evaluate results.
 Author: The OpenFactory Authors
 License-Expression: Apache-2.0

{openfactory-0.2.1 → openfactory-0.3.0}/openfactory/__init__.py

@@ -4,4 +4,4 @@ Policies authorize actions; humans evaluate results. See
 docs/adr/0001-foundational-conceptual-model.md for the conceptual model.
 """
 
-__version__ = "0.2.1"
+__version__ = "0.3.0"

{openfactory-0.2.1 → openfactory-0.3.0}/openfactory/actions/__init__.py

@@ -99,7 +99,13 @@ class _Catalog:
     eagerly would put `temporalio` on the import path of every front end — including the panel,
     which is explicitly built to serve without the `runtime` extra installed. The bodies already
     import lazily; this keeps the module itself lazy too, so the guard tests can walk the table on
-    a machine that has none of it."""
+    a machine that has none of it.
+
+    THAT PROMISE IS HELD BY A GUARD SINCE #178, because for a while it was only written down: the
+    page's own words came from `view.py` and `workflow.py`, so `/` and `/api/floor` answered 500
+    on exactly the install this paragraph describes. It asks every GET route in an interpreter
+    where `temporalio` cannot be found:
+    `tests/test_the_panel_serves_without_the_engines_client.py`."""
 
     def __getitem__(self, name: str) -> ActionSpec:
         return _catalog()[name]
@@ -220,8 +226,6 @@ async def perform(name: str, *, by: Actor, **params: object) -> Outcome:
     walks the chain, because an error crossing a Temporal activity boundary otherwise arrives as
     the fixed string "Activity task failed" (#66).
     """
-    from openfactory.util.causes import first_message
-
     key = (name or "").strip().lower()
     found = _catalog().get(key)
     if found is None:
@@ -264,9 +268,7 @@ async def perform(name: str, *, by: Actor, **params: object) -> Outcome:
         outcome = await found.run(by=by, **params)
     except Exception as exc:  # noqa: BLE001 — an action must never take its caller down
         log.exception("action %s raised for %s", key, by)
-        return refused(
-            FAILED, f"could not {key}: {first_message(exc)}",
-        )
+        return refused(FAILED, f"could not {key}: {_why(exc)}")
     if not isinstance(outcome, Outcome):  # an action that returns None is a silent success (F5)
         log.error("action %s returned %r, not an Outcome", key, type(outcome).__name__)
         return refused(
@@ -285,6 +287,29 @@ async def perform(name: str, *, by: Actor, **params: object) -> Outcome:
 _SECRET = frozenset({"password", "token", "secret", "key"})
 
 
+def _why(exc: Exception) -> str:
+    """What the refusal says an action died of — the install, when the install is what is missing.
+
+    THE ROWS THAT ARE THE ENGINE'S IMPORT ITS MODULES INSIDE THEIR BODIES, by design: that is what
+    keeps `temporalio` off every front end's import path (see `_Catalog`). So on an install made
+    without the `runtime` extra, `start`, `stop`, `approve` and the rest raise here, and the person
+    read `could not start: No module named 'temporalio'` — a cause with no remedy. The catch-all
+    above is the one guard all of them share, so it is the one place that names the install:
+    `host.CLIENT_MISSING`, the sentence every other surface gives for that condition (#178)."""
+    from openfactory.runtime.host import CLIENT_MISSING, the_client_is_what_is_missing
+    from openfactory.util.causes import first_message
+
+    # The chain, not only its head: a row that wraps its own failures still died of the import.
+    link: BaseException | None = exc
+    for _ in range(8):  # bounded: a chain is short, and a hand-built cyclic one must not spin
+        if link is None:
+            break
+        if the_client_is_what_is_missing(link):
+            return CLIENT_MISSING
+        link = link.__cause__ or link.__context__
+    return first_message(exc)
+
+
 def _loggable(params: dict[str, object]) -> dict[str, object]:
     return {k: ("***" if k in _SECRET else v) for k, v in params.items()}