openedx-learning 0.9.1__tar.gz → 0.9.3__tar.gz

{openedx_learning-0.9.1/openedx_learning.egg-info → openedx_learning-0.9.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: openedx-learning
-Version: 0.9.1
+Version: 0.9.3
 Summary: An experiment.
 Home-page: https://github.com/openedx/openedx-learning
 Author: David Ormsbee
@@ -20,9 +20,9 @@ Classifier: Programming Language :: Python :: 3.12
 Requires-Python: >=3.8
 License-File: LICENSE.txt
 Requires-Dist: djangorestframework<4.0
-Requires-Dist: attrs
-Requires-Dist: edx-drf-extensions
 Requires-Dist: Django<5.0
+Requires-Dist: edx-drf-extensions
+Requires-Dist: attrs
 Requires-Dist: celery
 Requires-Dist: rules<4.0
 

{openedx_learning-0.9.1 → openedx_learning-0.9.3}/openedx_learning/__init__.py

@@ -1,4 +1,4 @@
 """
 Open edX Learning ("Learning Core").
 """
-__version__ = "0.9.1"
+__version__ = "0.9.3"

{openedx_learning-0.9.1 → openedx_learning-0.9.3/openedx_learning.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: openedx-learning
-Version: 0.9.1
+Version: 0.9.3
 Summary: An experiment.
 Home-page: https://github.com/openedx/openedx-learning
 Author: David Ormsbee
@@ -20,9 +20,9 @@ Classifier: Programming Language :: Python :: 3.12
 Requires-Python: >=3.8
 License-File: LICENSE.txt
 Requires-Dist: djangorestframework<4.0
-Requires-Dist: attrs
-Requires-Dist: edx-drf-extensions
 Requires-Dist: Django<5.0
+Requires-Dist: edx-drf-extensions
+Requires-Dist: attrs
 Requires-Dist: celery
 Requires-Dist: rules<4.0
 

{openedx_learning-0.9.1 → openedx_learning-0.9.3}/openedx_tagging/core/tagging/rest_api/v1/serializers.py

@@ -140,7 +140,14 @@ class ObjectTagMinimalSerializer(UserPermissionsSerializerMixin, serializers.Mod
         fields = ["value", "lineage", "can_delete_objecttag"]
 
     lineage = serializers.ListField(child=serializers.CharField(), source="get_lineage", read_only=True)
-    can_delete_objecttag = serializers.SerializerMethodField(method_name='get_can_delete')
+    can_delete_objecttag = serializers.SerializerMethodField()
+
+    def get_can_delete_objecttag(self, instance) -> bool | None:
+        """
+        Returns True if the current request user may delete object tags on this taxonomy
+        """
+        perm_name = f'{self.app_label}.remove_objecttag_objectid'
+        return self._can(perm_name, instance.object_id)
 
 
 class ObjectTagSerializer(ObjectTagMinimalSerializer):
@@ -342,7 +349,7 @@ class TaxonomyImportNewBodySerializer(TaxonomyImportBodySerializer):  # pylint:
     """
     taxonomy_name = serializers.CharField(required=True)
     taxonomy_description = serializers.CharField(default="")
-    taxonomy_export_id = serializers.CharField(required=True)
+    taxonomy_export_id = serializers.CharField(required=False)
 
 
 class TagImportTaskSerializer(serializers.ModelSerializer):

{openedx_learning-0.9.1 → openedx_learning-0.9.3}/openedx_tagging/core/tagging/rest_api/v1/views.py

@@ -304,12 +304,18 @@ class TaxonomyView(ModelViewSet):
         body.is_valid(raise_exception=True)
 
         taxonomy_name = body.validated_data["taxonomy_name"]
-        taxonomy_export_id = body.validated_data["taxonomy_export_id"]
+        taxonomy_export_id = body.validated_data.get("taxonomy_export_id")
         taxonomy_description = body.validated_data["taxonomy_description"]
         file = body.validated_data["file"].file
         parser_format = body.validated_data["parser_format"]
 
-        taxonomy = create_taxonomy(taxonomy_name, taxonomy_description, export_id=taxonomy_export_id)
+        # If no taxonomy_export_id provided, a unique export id will be generated
+        taxonomy = create_taxonomy(
+            taxonomy_name,
+            taxonomy_description,
+            export_id=taxonomy_export_id,
+        )
+
         try:
             import_success, task, _plan = import_tags(taxonomy, file, parser_format)
 

{openedx_learning-0.9.1 → openedx_learning-0.9.3}/openedx_tagging/core/tagging/rules.py

@@ -137,6 +137,16 @@ def can_change_object_tag_objectid(_user: UserType, _object_id: str) -> bool:
     return False
 
 
+@rules.predicate
+def can_remove_object_tag_objectid(_user: UserType, _object_id: str) -> bool:
+    """
+    Nobody can remove object tags without checking the permission for the tagged object.
+
+    This rule could be defined in other apps for proper permission checking.
+    """
+    return can_change_object_tag_objectid(_user, _object_id)
+
+
 @rules.predicate
 def can_change_object_tag(
     user: UserType, perm_obj: ObjectTagPermissionItem | None = None
@@ -194,3 +204,4 @@ rules.add_perm("oel_tagging.view_objecttag_objectid", can_view_object_tag_object
 rules.add_perm("oel_tagging.view_objecttag_taxonomy", can_view_object_tag_taxonomy)
 rules.add_perm("oel_tagging.change_objecttag_taxonomy", can_view_object_tag_taxonomy)
 rules.add_perm("oel_tagging.change_objecttag_objectid", can_change_object_tag_objectid)
+rules.add_perm("oel_tagging.remove_objecttag_objectid", can_remove_object_tag_objectid)

{openedx_learning-0.9.1 → openedx_learning-0.9.3}/openedx_learning.egg-info/requires.txt

@@ -1,6 +1,6 @@
 djangorestframework<4.0
-attrs
-edx-drf-extensions
 Django<5.0
+edx-drf-extensions
+attrs
 celery
 rules<4.0