opencos-eda 0.2.42__tar.gz → 0.2.43__tar.gz

{opencos_eda-0.2.42/opencos_eda.egg-info → opencos_eda-0.2.43}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: opencos-eda
-Version: 0.2.42
+Version: 0.2.43
 Summary: A simple Python package for wrapping RTL simuliatons and synthesis
 Author-email: Simon Sabato <simon@cognichip.ai>, Drew Ranck <drew@cognichip.ai>
 Project-URL: Homepage, https://github.com/cognichip/opencos

{opencos_eda-0.2.42 → opencos_eda-0.2.43}/opencos/eda_base.py

@@ -696,6 +696,7 @@ class CommandDesign(Command):
 
         self.cached_deps = {} # key = abspath of DEPS markup file, has sub-dicts for 'data' and 'line_numbers'.
         self.targets_dict = {} # key = targets that we've already processed in DEPS files
+        self.last_added_source_file_inferred_top = ''
 
     def run_dep_commands(self):
         # Run any shell@ commands from DEPS files
@@ -1036,6 +1037,11 @@ class CommandDesign(Command):
             file_ext = known_file_ext_dict.get(forced_extension, [''])[0]
             util.debug(f"{forced_extension=} for {filename=} as type '{file_ext}'")
 
+
+        if not add_to_non_sources and \
+           file_ext in known_file_ext_dict.get('inferred_top', []):
+            self.last_added_source_file_inferred_top = file_abspath
+
         if add_to_non_sources:
             self.files_non_source.append(file_abspath)
             util.debug("Added non-source file file %s as %s" % (filename, file_abspath))
@@ -1114,8 +1120,8 @@ class CommandDesign(Command):
 
         # by this point hopefully this is a target ... is it a simple filename?
         remove_list = []
-        last_potential_top = None # used for 'top' if top not specified.
-        last_potential_top_path = None
+        last_potential_top_file = ('', '')   # (top, fpath)
+        last_potential_top_target = ('', '') # (top, path/to/full-target-name)
         last_potential_top_isfile = False
         caller_info = ''
         for token in unparsed:
@@ -1131,21 +1137,13 @@ class CommandDesign(Command):
                 else:
                     self.add_file(filename=fpath, caller_info=caller_info,
                                   forced_extension=forced_extension)
-
-                    known_file_ext_dict = self.config.get('file_extensions', {})
-                    if forced_extension:
-                        # If forced_extension='systemverilog', then use the first known extension for
-                        # it ('.sv', from eda_config_defaults.yml):
-                        file_ext = known_file_ext_dict.get(forced_extension, [''])[0]
-
-                    if not self.args['top'] and \
-                       file_ext and \
-                       file_ext in known_file_ext_dict.get('inferred_top', []):
-                        # if we haven't yet been given a top, or inferred one, we take the last one we get
-                        # from a raw list of RTL file names (from args or command line tokens)
-                        last_potential_top_path = file_abspath
-                        last_potential_top = self.get_top_name(file_abspath)
-                        last_potential_top_isfile = True
+                    if not self.args['top']:
+                        known_file_ext_dict = self.config.get('file_extensions', {})
+                        if forced_extension:
+                            file_ext = known_file_ext_dict.get(forced_extension, [''])[0]
+                        if file_ext in known_file_ext_dict.get('inferred_top', []):
+                            # last cmd line arg was a filename that could have inferred top.
+                            last_potential_top_isfile = True
 
                     remove_list.append(token)
                     continue # done with token, consume it, we added the file.
@@ -1158,12 +1156,9 @@ class CommandDesign(Command):
 
             util.debug(f'Calling self.resolve_target on {target_name=}')
             if self.resolve_target(target_name, caller_info=caller_info):
-                if self.args['top'] == '':
-                    # if we haven't yet been given a top, or inferred one, we take the last named target
-                    # from args or command line tokens
-                    # from a target name
-                    last_potential_top = self.get_top_name(target_name)
-                    last_potential_top_path = target_name
+                if not self.args['top']:
+                    # last cmd line arg was a target that we'll likely use for inferred top.
+                    last_potential_top_target = (self.get_top_name(target_name), target_name)
                     last_potential_top_isfile = False
 
                 remove_list.append(token)
@@ -1176,16 +1171,35 @@ class CommandDesign(Command):
         if process_all and len(unparsed) > 0:
             self.error(f"Didn't understand command remaining tokens {unparsed=} in CommandDesign")
 
-        # handle a missing self.args['top'] with last filepath.
-        if self.args.get('top', '') == '' and last_potential_top is not None:
-            self.args['top'] = last_potential_top
-            self.args['top-path'] = last_potential_top_path
-            util.info(f"Inferred --top {self.args['top']} {self.args['top-path']}")
-            if last_potential_top_isfile:
-                # top wasn't set, we're using the final command-line 'arg' filename (not from DEPS.yml)
-                # need to override self.target if that was set. Otherwise it won't save to the correct
-                # work-dir:
-                self.target = last_potential_top
+        # handle a missing self.args['top'] with last filepath or last target:
+        if not self.args.get('top', ''):
+            if not last_potential_top_isfile and last_potential_top_target[0]:
+                # If we have a target name from DEPS, prefer to use that.
+                self.args['top'], self.args['top-path'] = last_potential_top_target
+                util.info("--top not specified, inferred from target:",
+                          f"{self.args['top']} ({self.args['top-path']})")
+
+            else:
+                best_top_fname = self.last_added_source_file_inferred_top
+                if best_top_fname:
+                    last_potential_top_file = (self.get_top_name(best_top_fname), best_top_fname)
+
+            if not self.args['top'] and last_potential_top_file[0]:
+                # If we don't have a target name, and no top name yet, then go looking for the
+                # module name in the final source file added.
+                self.args['top-path'] = last_potential_top_file[1] # from tuple: (top, fpath)
+                self.args['top'] = util.get_inferred_top_module_name(
+                    module_guess=last_potential_top_file[0],
+                    module_fpath=last_potential_top_file[1]
+                )
+                if self.args['top']:
+                    util.info("--top not specified, inferred from final source file:",
+                              f"{self.args['top']} ({self.args['top-path']})")
+                    # If top wasn't set, and we're using the final command-line 'arg' filename
+                    # (not from DEPS.yml) we need to override self.target if that was set. Otherwise
+                    # it won't save to the correct work-dir:
+                    self.target = self.args['top']
+
         if self.error_on_missing_top and not self.args.get('top', ''):
             self.error(f"Did not get a --top or DEPS top, required to run command",
                        f"'{self.command_name}' for tool={self.args.get('tool', None)}")

{opencos_eda-0.2.42 → opencos_eda-0.2.43}/opencos/tests/helpers.py

@@ -19,7 +19,7 @@ def can_run_eda_command(*commands, config: dict) -> bool:
         if not handler:
             return False
         if handler and getattr(handler, 'CHECK_REQUIRES', []):
-            if not all(isinstance(handler, x) for x in getattr(handler, 'CHECK_REQUIRES', [])):
+            if not all(issubclass(handler, x) for x in getattr(handler, 'CHECK_REQUIRES', [])):
                 return False
         runnable.append(True)
     return runnable and all(runnable)

{opencos_eda-0.2.42 → opencos_eda-0.2.43}/opencos/tools/verilator.py

@@ -166,6 +166,10 @@ class VerilatorSim(CommandSim, ToolVerilator):
             # don't run this if we're stopping before/after compile/elab
             return
 
+        if not os.path.isfile(os.path.join(self.args['work-dir'], 'obj_dir', 'sim.exe')):
+            self.error('Verilated executable obj_dir/sim.exe does not exist')
+            return
+
         # Note that this is not returning a pass/fail bash return code,
         # so we will likely have to log-scrape to deterimine pass/fail.
         # Also, if we ran in cc-mode, we will not get the "R e p o r t: Verilator"

{opencos_eda-0.2.42 → opencos_eda-0.2.43}/opencos/util.py

@@ -635,6 +635,38 @@ def write_eda_config_and_args(dirpath : str, filename='eda_output_config.yml', c
     yaml_safe_writer(data=data, filepath=fullpath)
 
 
+def get_inferred_top_module_name(module_guess: str, module_fpath: str) -> str:
+    '''Returns the best guess as the 'top' module name name, given a fpath where
+
+    module_fpath = /some/path/to/module_guess.[v|sv]
+
+    Use the module_guess if it exists in the file as: module <module_guess>
+    Otherwise use the last observed: module <best_guess>
+    Otherwise use blank str
+    '''
+
+    best_guess = ''
+    if not os.path.isfile(module_fpath):
+        return ''
+    with open(module_fpath, encoding='utf-8') as f:
+        for line in f.readlines():
+            line = line.strip()
+            if line.startswith('module '):
+                parts = line.split()
+                module_name = parts[1]
+                rstrip_nonword_pattern = r'\W+$'
+                module_name = re.sub(rstrip_nonword_pattern, '', module_name)
+                if bool(re.fullmatch(r'^\w+$', module_name)):
+                    if module_name == module_guess:
+                        return module_guess
+                    elif module_name:
+                        best_guess = module_name
+    if best_guess:
+        return best_guess
+    else:
+        return ''
+
+
 def subprocess_run(work_dir, command_list, fake:bool=False, shell=False) -> int:
     ''' Run command_list in the foreground, with preference to use bash if shell=True.'''
 

{opencos_eda-0.2.42 → opencos_eda-0.2.43/opencos_eda.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: opencos-eda
-Version: 0.2.42
+Version: 0.2.43
 Summary: A simple Python package for wrapping RTL simuliatons and synthesis
 Author-email: Simon Sabato <simon@cognichip.ai>, Drew Ranck <drew@cognichip.ai>
 Project-URL: Homepage, https://github.com/cognichip/opencos

{opencos_eda-0.2.42 → opencos_eda-0.2.43}/pyproject.toml

@@ -2,7 +2,7 @@
 
 [project]
 name = "opencos-eda"
-version = "0.2.42"
+version = "0.2.43"
 dependencies = [
   # opencos/eda.py dependencies
   "mergedeep >= 1.3.4",