openbadgeslib 4.4.0__tar.gz → 4.4.2__tar.gz

{openbadgeslib-4.4.0 → openbadgeslib-4.4.2}/Changelog.txt

@@ -4,6 +4,36 @@ OpenBadgesLib - Changelog
 Newest first. Dates are ISO 8601 (YYYY-MM-DD).
 
 
+* v4.4.2 - 2026-08-13
+
+  - fix(cli): key generation no longer crashes on Windows, where
+    `os.fchmod` does not exist. `_write_pem_file` now guards the fchmod
+    call with `hasattr` and skips the permission dance on platforms
+    without it — there the POSIX mode bits are not the access control
+    (NTFS ACLs are), so skipping is the honest behaviour rather than a
+    best-effort `os.chmod` that would only toggle the read-only bit.
+    Regression introduced in v4.3.1 by #289; caught by the Windows CI leg.
+  - fix(tests): the v4.4.1 regression test for the above itself raised on
+    Windows (`monkeypatch.delattr` on an attribute the platform does not
+    have); it now skips where `os.fchmod` is already absent.
+
+
+* v4.4.1 - 2026-08-13
+
+  Superseded the same day: its own regression test failed on Windows
+  (`monkeypatch.delattr` on an attribute the platform does not have), so
+  the release went out with the Windows CI leg still red. The library fix
+  below is correct and is carried forward unchanged; use v4.4.2.
+
+  - fix(cli): key generation no longer crashes on Windows, where
+    `os.fchmod` does not exist. `_write_pem_file` now guards the fchmod
+    call with `hasattr` and skips the permission dance on platforms
+    without it — there the POSIX mode bits are not the access control
+    (NTFS ACLs are), so skipping is the honest behaviour rather than a
+    best-effort `os.chmod` that would only toggle the read-only bit.
+    Regression introduced in v4.3.1 by #289; caught by the Windows CI leg.
+
+
 * v4.4.0 - 2026-08-13
 
   Track openvc-core 1.25: the OID4VCI discovery documents this library

{openbadgeslib-4.4.0 → openbadgeslib-4.4.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openbadgeslib
-Version: 4.4.0
+Version: 4.4.2
 Summary: Production-ready Python library & CLI for Open Badges 3.0 (W3C Verifiable Credentials): issue, verify, and revoke JWT-VC credentials with Bitstring Status Lists and did:web — plus strict OB 2.0 and legacy OB 1.0.
 Author-email: Luis González Fernández <luisgf@luisgf.es>, Jesús Cea Avión <jcea@jcea.es>
 License: LGPLv3

{openbadgeslib-4.4.0 → openbadgeslib-4.4.2}/openbadgeslib/openbadges_keygenerator.py

@@ -58,6 +58,12 @@ def _write_pem_file(path: str, data: bytes, mode: int) -> None:
     with a symlink and redirect the permission change onto another file the
     invoking user owns (#289). ``O_CREAT|O_EXCL`` already prevents following a
     pre-planted symlink at create time; ``fchmod`` closes the post-close gap.
+
+    Windows has no ``os.fchmod`` and its ``os.chmod`` only toggles the
+    read-only bit, so there the mode argument is left to the platform and the
+    permission dance is skipped outright: NTFS ACLs, not POSIX bits, are the
+    access control, and the calling user's own profile directory is the
+    boundary that matters there.
     """
     flags = os.O_WRONLY | os.O_CREAT | os.O_EXCL
     fd = os.open(path, flags, mode)
@@ -65,7 +71,8 @@ def _write_pem_file(path: str, data: bytes, mode: int) -> None:
         with os.fdopen(fd, 'wb') as f:
             fd = -1                         # ownership transferred to the file object
             f.write(data)
-            os.fchmod(f.fileno(), mode)
+            if hasattr(os, 'fchmod'):
+                os.fchmod(f.fileno(), mode)
     except Exception:
         if fd >= 0:
             os.close(fd)

{openbadgeslib-4.4.0 → openbadgeslib-4.4.2}/openbadgeslib/util.py

@@ -21,7 +21,7 @@
         License along with this library.
 """
 
-__version__ = '4.4.0'
+__version__ = '4.4.2'
 
 import contextlib
 import hashlib

{openbadgeslib-4.4.0 → openbadgeslib-4.4.2}/openbadgeslib.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openbadgeslib
-Version: 4.4.0
+Version: 4.4.2
 Summary: Production-ready Python library & CLI for Open Badges 3.0 (W3C Verifiable Credentials): issue, verify, and revoke JWT-VC credentials with Bitstring Status Lists and did:web — plus strict OB 2.0 and legacy OB 1.0.
 Author-email: Luis González Fernández <luisgf@luisgf.es>, Jesús Cea Avión <jcea@jcea.es>
 License: LGPLv3

{openbadgeslib-4.4.0 → openbadgeslib-4.4.2}/tests/test_key_operation.py

@@ -256,3 +256,17 @@ class TestKeyGeneratorFileWrites:
         path = tmp_path / 'no' / 'such' / 'dir' / 'key.pem'
         with pytest.raises(OSError):
             _write_pem_file(str(path), b'private-key', 0o600)
+
+    @pytest.mark.skipif(not hasattr(os, 'fchmod'),
+                        reason='already the platform under simulation')
+    def test_write_pem_file_survives_a_platform_without_fchmod(
+            self, tmp_path, monkeypatch):
+        # Windows has no os.fchmod (its chmod toggles only the read-only bit),
+        # so the permission dance is skipped there and the write must still
+        # succeed — v4.3.1 crashed key generation on Windows with
+        # AttributeError on exactly this path.
+        import openbadgeslib.openbadges_keygenerator as module
+        monkeypatch.delattr(module.os, 'fchmod')
+        path = tmp_path / 'sign.pem'
+        _write_pem_file(str(path), b'private-key', 0o600)
+        assert path.read_bytes() == b'private-key'