open-document-lib 1.0.2__tar.gz → 1.2.0__tar.gz

{open_document_lib-1.0.2 → open_document_lib-1.2.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: open-document-lib
-Version: 1.0.2
+Version: 1.2.0
 Summary: Standard-library toolkit for reading, editing, and writing OpenDocument Format files (ODT, ODP, ODS, ODG)
 Author: Patrick Leiverkus
 License: MIT

{open_document_lib-1.0.2 → open_document_lib-1.2.0}/README.md

@@ -1,13 +1,20 @@
 # Open Document Skills
 
 [![Tests](https://github.com/leiverkus/open-document-skills/actions/workflows/tests.yml/badge.svg)](https://github.com/leiverkus/open-document-skills/actions/workflows/tests.yml)
+[![PyPI](https://img.shields.io/pypi/v/open-document-lib)](https://pypi.org/project/open-document-lib/)
+[![Python](https://img.shields.io/pypi/pyversions/open-document-lib)](https://pypi.org/project/open-document-lib/)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](LICENSE)
-[![Release](https://img.shields.io/github/v/release/leiverkus/open-document-skills)](https://github.com/leiverkus/open-document-skills/releases)
 
 **Native ODT / ODP / ODS / ODG generation and editing for agents — no DOCX round-trips, no LibreOffice dependency for the core path.**
 
 Four self-contained skills for Codex, Claude Code, and OpenCode that teach an agent to create, inspect, and edit OpenDocument files directly via Python (stdlib only). Edits preserve inline structure (`text:span`, `text:note`, `text:bookmark`, `text:a`), `meta.xml` is updated on every save, and flat single-XML formats (`.fodt`/`.fodp`/`.fods`/`.fodg`) give you Git-friendly diffs. LibreOffice is optional and only needed for rendering, recalculation, and PDF export.
 
+<p align="center">
+  <img src="docs/assets/hero.png" alt="A branded presentation title slide generated from a JSON spec — deep-blue theme, white typography, logo" width="640">
+  <br>
+  <em>A branded title slide generated from a JSON spec and rendered with LibreOffice — a curated theme injected as <code>styles.xml</code>, in pure Python. See <a href="examples/deck/">examples/deck</a>.</em>
+</p>
+
 ```bash
 # Generate, edit, validate, version — all from the agent shell:
 python skills/odt/scripts/create_minimal_odt.py spec.json doc.odt
@@ -31,11 +38,11 @@ python skills/odt/scripts/validate_refs.py out.odt
 - **Stdlib-only core.** Every generator, validator, and edit script runs without `pip install` — `xml.etree.ElementTree` and `zipfile` only. LibreOffice is needed only for rendering and recalculation.
 - **Structure-preserving edits.** `replace_text` keeps footnotes, hyperlinks, and inline formatting intact. `add_image` updates the manifest and `meta.xml`. `replace_cells` handles typed values and formulas.
 - **Audit-friendly.** Every edit writes `meta:modification-date`, `meta:generator`, and increments `meta:editing-cycles`. Pack to `.fodt` and `git diff` works.
-- **Tested.** 76 unit + integration tests run on every push; CI installs LibreOffice so the render/recalc paths are exercised too.
+- **Tested.** Over 200 unit and integration tests run on every push across Python 3.10–3.13; CI installs LibreOffice so the render/recalc paths are exercised too.
 
 ## What this is not
 
-Not a LibreOffice replacement. Not a substitute for full ODF feature coverage (tracked changes, complex TOCs, Impress animations, Calc pivots, Draw glue points, RelaxNG schema validation are explicit non-goals — see [Current Limits](#current-limits)). The goal is to make the 80% of ODF automation that agents need safe, repeatable, and dependency-light.
+Not a LibreOffice replacement, and not a substitute for full ODF feature coverage. Tracked changes, generated tables of contents, Calc pivot tables, and DOCX/PPTX/XLSX import-and-edit are explicit non-goals — see [Current Limits](#current-limits). The goal is to make the 80% of ODF automation that agents need safe, repeatable, and dependency-light.
 
 ## Repository Layout
 
@@ -80,6 +87,7 @@ Detailed documentation lives in [docs/index.md](docs/index.md):
 - [Agent Compatibility](docs/agent-compatibility.md)
 - [OpenDocument Workflows](docs/workflows.md)
 - [Script Reference](docs/script-reference.md)
+- [Library API](docs/library-api.md)
 
 ## Installation
 
@@ -228,136 +236,6 @@ LibreOffice usually provides `soffice` inside the app bundle, not directly on th
 
 The render/recalc scripts look for that macOS path automatically. They also check common Linux and Windows locations.
 
-## Skills
-
-### ODT
-
-OpenDocument Text / LibreOffice Writer.
-
-Focus:
-
-- template-first document editing
-- direct ODT XML generation
-- headings, paragraphs, lists, tables, footnotes, images
-- style/page-layout awareness
-- PDF QA through LibreOffice
-
-Useful scripts:
-
-```bash
-python skills/odt/scripts/create_minimal_odt.py document.json output.odt
-python skills/odt/scripts/extract_text.py output.odt
-python skills/odt/scripts/inspect_package.py output.odt
-python skills/odt/scripts/replace_text.py input.odt "{{NAME}}" "Patrick Leiverkus" -o output.odt
-python skills/odt/scripts/add_image.py input.odt figure.png -o output.odt
-python skills/odt/scripts/add_footnote.py input.odt --anchor "claim" --body "Source: ..." -o output.odt
-python skills/odt/scripts/fill_citations.py template.odt --source refs.bib -o output.odt
-python skills/odt/scripts/add_bookmark.py input.odt --name K1 --anchor "Chapter 1" -o output.odt
-python skills/odt/scripts/add_math.py input.odt --latex 'E = mc^2' --anchor "Equation" -o output.odt
-python skills/odt/scripts/pack_fodt.py output.odt -o output.fodt
-python skills/odt/scripts/validate_refs.py output.odt
-```
-
-Script reference: see [docs/script-reference.md](docs/script-reference.md).
-
-### ODP
-
-OpenDocument Presentation / LibreOffice Impress.
-
-Focus:
-
-- template-first presentations
-- direct ODP XML generation
-- `draw:page`, speaker notes, master pages
-- slide text/media inspection
-- package and visual QA
-
-Useful scripts:
-
-```bash
-python skills/odp/scripts/create_minimal_odp.py slides.json output.odp
-python skills/odp/scripts/extract_text.py output.odp
-python skills/odp/scripts/inspect_package.py output.odp
-python skills/odp/scripts/clone_slide.py template.odp --source-slide 1 --name "Agenda" -o output.odp
-python skills/odp/scripts/add_image.py input.odp figure.png -o output.odp
-python skills/odp/scripts/validate_refs.py output.odp
-```
-
-Script reference: see [docs/script-reference.md](docs/script-reference.md).
-
-### ODS
-
-OpenDocument Spreadsheet / LibreOffice Calc.
-
-Focus:
-
-- direct ODS XML generation
-- template-first spreadsheet editing
-- typed cell values
-- formulas
-- repeated rows/cells
-- CSV export and formula QA
-
-Useful scripts:
-
-```bash
-python skills/ods/scripts/create_minimal_ods.py workbook.json output.ods
-python skills/ods/scripts/extract_sheets.py output.ods
-python skills/ods/scripts/extract_formulas.py output.ods
-python skills/ods/scripts/replace_cells.py input.ods 'Data!B2=42' 'Data!C2=formula:of:=[.B2]*2' -o output.ods
-python skills/ods/scripts/export_csv.py output.ods --sheet Data --output data.csv
-python skills/ods/scripts/validate_refs.py output.ods
-```
-
-Script reference: see [docs/script-reference.md](docs/script-reference.md).
-
-### ODG
-
-OpenDocument Graphics / LibreOffice Draw.
-
-Focus:
-
-- direct ODG XML generation
-- template-first diagram editing
-- vector shapes, text boxes, lines, connectors, images
-- geometry inspection
-- PDF/SVG/PNG export QA
-
-Useful scripts:
-
-```bash
-python skills/odg/scripts/create_minimal_odg.py drawing.json output.odg
-python skills/odg/scripts/extract_text.py output.odg
-python skills/odg/scripts/extract_shapes.py output.odg
-python skills/odg/scripts/inspect_package.py output.odg
-python skills/odg/scripts/replace_text.py input.odg "{{LABEL}}" "Updated label" -o output.odg
-python skills/odg/scripts/validate_refs.py output.odg
-```
-
-Script reference: see [docs/script-reference.md](docs/script-reference.md).
-
-## Testing
-
-Run the test suite:
-
-```bash
-python -m unittest discover -s tests
-```
-
-The tests create minimal ODT, ODP, ODS, and ODG files, then exercise extraction, validation, editing, media insertion, and export helpers.
-
-LibreOffice integration tests are included. They render ODT/ODP/ODG files and recalculate ODS files when `soffice` is available. If LibreOffice is not available, those tests are skipped.
-
-GitHub Actions runs the same suite on every push and pull request. The workflow installs LibreOffice and Poppler with `apt` on Ubuntu so the LibreOffice integration tests run in CI instead of being skipped.
-
-Reusable example inputs live in `tests/fixtures/`:
-
-- `odt_document.json`
-- `odp_slides.json`
-- `ods_workbook.json`
-- `odg_drawing.json`
-- `image.svg`
-
 ## Examples
 
 Runnable examples live in `examples/`. They are meant as a practical first test layer for users of the skills:
@@ -452,27 +330,11 @@ Out of scope — use LibreOffice for these:
 
 See [ROADMAP.md](ROADMAP.md) for what is planned next.
 
-## Development
-
-Recommended loop:
-
-```bash
-python -m unittest discover -s tests
-git status --short
-```
-
-When adding a new script or behavior:
-
-1. Add the smallest useful script interface.
-2. Add or update a smoke test.
-3. Run local tests.
-4. Push and let GitHub Actions verify the repo.
-
-See [CONTRIBUTING.md](CONTRIBUTING.md) for the full development and release checklist.
-
-## Release Status
+## Contributing & releases
 
-Current release: `v0.9.0` — a robustness release. Every helper is now exercised against a committed corpus of 17 LibreOffice-native ODF fixtures (`tests/test_corpus.py`), which uncovered and fixed two foreign-ODF bugs in `validate_refs` and the flat-ODF roundtrip. No new features — all four skills (ODT/ODP/ODS/ODG) remain at production-level depth. See [ROADMAP.md](ROADMAP.md) for v1.0 (PyPI publication + final polish + ecosystem maturity).
+Development setup, the test loop, and the release checklist live in
+[CONTRIBUTING.md](CONTRIBUTING.md). Version history is in
+[CHANGELOG.md](CHANGELOG.md); planned work is in [ROADMAP.md](ROADMAP.md).
 
 ## License
 

{open_document_lib-1.0.2 → open_document_lib-1.2.0}/odf_lib/odf_common.py

@@ -19,7 +19,7 @@ from datetime import datetime, timezone
 from pathlib import Path
 from xml.etree import ElementTree as ET
 
-VERSION = "1.0.2"  # keep in sync with pyproject.toml (see CONTRIBUTING.md)
+VERSION = "1.2.0"  # keep in sync with pyproject.toml (see CONTRIBUTING.md)
 
 ODF_NAMESPACES: dict[str, str] = {
     "office": "urn:oasis:names:tc:opendocument:xmlns:office:1.0",
@@ -221,7 +221,14 @@ def inject_styles_from_file(
         v = node.attrib.get(f"{{{text_ns}}}style-name")
         if v:
             used.add(v)
-    missing: list[str] = sorted(used - defined_names - parent_names)
+    # Styles defined in content.xml's own automatic-styles satisfy a reference
+    # too — only swapping styles.xml never touches them.
+    content_defined: set[str] = set()
+    for style_el in content_root.iter(f"{{{style_ns}}}style"):
+        name = style_el.attrib.get(f"{{{style_ns}}}name")
+        if name:
+            content_defined.add(name)
+    missing: list[str] = sorted(used - defined_names - parent_names - content_defined)
 
     write_odf_with_replacements(
         input_path,

{open_document_lib-1.0.2 → open_document_lib-1.2.0}/open_document_lib.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: open-document-lib
-Version: 1.0.2
+Version: 1.2.0
 Summary: Standard-library toolkit for reading, editing, and writing OpenDocument Format files (ODT, ODP, ODS, ODG)
 Author: Patrick Leiverkus
 License: MIT

{open_document_lib-1.0.2 → open_document_lib-1.2.0}/open_document_lib.egg-info/SOURCES.txt

@@ -29,8 +29,10 @@ tests/test_meta_lifecycle.py
 tests/test_odg_connectors.py
 tests/test_odg_gluepoints.py
 tests/test_odg_groups.py
+tests/test_odg_styling.py
 tests/test_odp_animations.py
 tests/test_odp_master.py
+tests/test_odp_styling.py
 tests/test_odp_transitions.py
 tests/test_ods_charts.py
 tests/test_ods_named_ranges.py

{open_document_lib-1.0.2 → open_document_lib-1.2.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "open-document-lib"
-version = "1.0.2"
+version = "1.2.0"
 description = "Standard-library toolkit for reading, editing, and writing OpenDocument Format files (ODT, ODP, ODS, ODG)"
 readme = "docs/library-api.md"
 requires-python = ">=3.10"

{open_document_lib-1.0.2 → open_document_lib-1.2.0}/tests/test_libreoffice_integration.py

@@ -6,7 +6,7 @@ import tempfile
 import unittest
 from pathlib import Path
 
-from helpers import FIXTURES, SKILLS, run_script
+from helpers import FIXTURES, ROOT, SKILLS, run_script
 
 # Import shared find_soffice from lib
 _repo_root = Path(__file__).resolve().parents[1]
@@ -64,6 +64,52 @@ class LibreOfficeIntegrationTests(unittest.TestCase):
             self.assertTrue(pdf.exists())
             self.assertGreater(pdf.stat().st_size, 0)
 
+    def test_branded_odp_deck_renders_to_pdf(self) -> None:
+        """A base ODP with the branded deck styles.xml injected + logo embedded
+        must render to a non-empty PDF."""
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp_path = Path(tmp)
+            scripts = SKILLS / "odp" / "scripts"
+            sys.path.insert(0, str(scripts))
+            from odp_common import embed_pictures, inject_styles_from_file
+
+            deck = ROOT / "examples" / "deck"
+            base = tmp_path / "base.odp"
+            run_script(scripts / "create_minimal_odp.py", deck / "spec.json", base)
+            styled = tmp_path / "styled.odp"
+            inject_styles_from_file(base, deck / "styles.xml", styled)
+            final = tmp_path / "deck.odp"
+            embed_pictures(styled, {"Pictures/logo.png": deck / "logo-placeholder.png"}, final)
+            run_script(scripts / "validate_refs.py", final)
+
+            outdir = tmp_path / "qa"
+            run_script(scripts / "render.py", final, "--outdir", outdir)
+            pdf = outdir / "deck.pdf"
+            self.assertTrue(pdf.exists())
+            self.assertGreater(pdf.stat().st_size, 0)
+
+    def test_branded_odg_diagram_renders_to_pdf(self) -> None:
+        """A base ODG with the branded diagram styles.xml injected must render
+        to a non-empty PDF."""
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp_path = Path(tmp)
+            scripts = SKILLS / "odg" / "scripts"
+            sys.path.insert(0, str(scripts))
+            from odg_common import inject_styles_from_file
+
+            diagram = ROOT / "examples" / "diagram"
+            base = tmp_path / "base.odg"
+            run_script(scripts / "create_minimal_odg.py", diagram / "spec.json", base)
+            final = tmp_path / "diagram.odg"
+            inject_styles_from_file(base, diagram / "styles.xml", final)
+            run_script(scripts / "validate_refs.py", final)
+
+            outdir = tmp_path / "qa"
+            run_script(scripts / "render.py", final, "--outdir", outdir, "--formats", "pdf")
+            pdf = outdir / "diagram.pdf"
+            self.assertTrue(pdf.exists())
+            self.assertGreater(pdf.stat().st_size, 0)
+
     def test_libreoffice_opens_flat_fodt(self) -> None:
         import subprocess
 

open_document_lib-1.2.0/tests/test_odg_styling.py

@@ -0,0 +1,250 @@
+"""Tests for ODG drawing styling — designed graphic styles (no generic blue),
+per-shape fill/stroke/text overrides, and the styles.xml inject path."""
+
+from __future__ import annotations
+
+import json
+import sys
+import tempfile
+import unittest
+import zipfile
+from pathlib import Path
+from xml.etree import ElementTree as ET
+
+from helpers import ROOT, SKILLS, run_script
+
+NS = {
+    "office": "urn:oasis:names:tc:opendocument:xmlns:office:1.0",
+    "style": "urn:oasis:names:tc:opendocument:xmlns:style:1.0",
+    "draw": "urn:oasis:names:tc:opendocument:xmlns:drawing:1.0",
+    "fo": "urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0",
+    "text": "urn:oasis:names:tc:opendocument:xmlns:text:1.0",
+    "svg": "urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0",
+}
+
+ODG_SCRIPTS = SKILLS / "odg" / "scripts"
+DIAGRAM_STYLES = ROOT / "examples" / "diagram" / "styles.xml"
+GENERIC_BLUE = "#729fcf"  # LibreOffice's default graphic-style fill
+
+
+def q(prefix: str, local: str) -> str:
+    return f"{{{NS[prefix]}}}{local}"
+
+
+def member(path: Path, name: str) -> ET.Element:
+    with zipfile.ZipFile(path) as archive:
+        return ET.fromstring(archive.read(name))
+
+
+def make_drawing(tmp_path: Path) -> Path:
+    """Generate an ODG with a plain shape, a styled shape, and a text frame."""
+    spec = tmp_path / "d.json"
+    spec.write_text(
+        json.dumps(
+            {
+                "pages": [
+                    {
+                        "name": "P",
+                        "items": [
+                            {"type": "text", "text": "Heading", "x": "1cm", "y": "1cm"},
+                            {"type": "rect", "name": "Plain", "text": "Plain", "x": "1cm", "y": "4cm"},
+                            {
+                                "type": "rect",
+                                "name": "Styled",
+                                "text": "Styled",
+                                "x": "8cm",
+                                "y": "4cm",
+                                "fill": "#F4C542",
+                                "stroke": "#7A5C00",
+                                "text-color": "#3A2E00",
+                                "font-size": "20pt",
+                            },
+                            {"type": "ellipse", "name": "Round", "text": "Round", "x": "15cm", "y": "4cm"},
+                            {"type": "line", "x1": "1cm", "y1": "8cm", "x2": "10cm", "y2": "8cm"},
+                        ],
+                    }
+                ]
+            }
+        ),
+        encoding="utf-8",
+    )
+    odg = tmp_path / "d.odg"
+    run_script(ODG_SCRIPTS / "create_minimal_odg.py", spec, odg)
+    return odg
+
+
+def styles_named(root: ET.Element) -> dict[str, ET.Element]:
+    out: dict[str, ET.Element] = {}
+    for st in root.iter(q("style", "style")):
+        name = st.attrib.get(q("style", "name"))
+        if name:
+            out[name] = st
+    return out
+
+
+class GeneratedStylingTests(unittest.TestCase):
+    def test_no_generic_blue_anywhere(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odg = make_drawing(Path(tmp))
+            for part in ("styles.xml", "content.xml"):
+                raw = zipfile.ZipFile(odg).read(part).decode("utf-8").lower()
+                self.assertNotIn(GENERIC_BLUE, raw, f"{part} still carries LibreOffice's default blue")
+
+    def test_every_shape_references_a_style(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odg = make_drawing(Path(tmp))
+            content = member(odg, "content.xml")
+            shapes = [el for el in content.iter() if el.tag.split("}")[-1] in {"rect", "ellipse", "line", "frame"}]
+            self.assertGreaterEqual(len(shapes), 5)
+            for shape in shapes:
+                self.assertIsNotNone(
+                    shape.attrib.get(q("draw", "style-name")),
+                    f"{shape.tag} carries no draw:style-name",
+                )
+
+    def test_standard_style_has_chosen_properties(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odg = make_drawing(Path(tmp))
+            styles = styles_named(member(odg, "styles.xml"))
+            self.assertIn("standard", styles)
+            props = styles["standard"].find(q("style", "graphic-properties"))
+            assert props is not None
+            fill = props.attrib.get(q("draw", "fill-color"))
+            self.assertIsNotNone(fill)
+            self.assertNotEqual((fill or "").lower(), GENERIC_BLUE)
+
+    def test_text_and_image_roles_are_unfilled(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odg = make_drawing(Path(tmp))
+            styles = styles_named(member(odg, "styles.xml"))
+            for name in ("gr-text", "gr-image"):
+                self.assertIn(name, styles)
+                props = styles[name].find(q("style", "graphic-properties"))
+                assert props is not None
+                self.assertEqual(props.attrib.get(q("draw", "fill")), "none")
+                self.assertEqual(props.attrib.get(q("draw", "stroke")), "none")
+
+    def test_drawing_page_background_referenced_by_master(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odg = member(make_drawing(Path(tmp)), "styles.xml")
+            master = next(
+                m for m in odg.iter(q("style", "master-page")) if m.attrib.get(q("style", "name")) == "Default"
+            )
+            dp_name = master.attrib.get(q("draw", "style-name"))
+            self.assertIsNotNone(dp_name, "master page must reference a drawing-page style")
+            # The drawing-page style must sit in office:automatic-styles.
+            auto = odg.find(q("office", "automatic-styles"))
+            assert auto is not None
+            dp = next(
+                s
+                for s in auto.findall(q("style", "style"))
+                if s.attrib.get(q("style", "name")) == dp_name and s.attrib.get(q("style", "family")) == "drawing-page"
+            )
+            props = dp.find(q("style", "drawing-page-properties"))
+            assert props is not None
+            self.assertEqual(props.attrib.get(q("draw", "fill")), "solid")
+
+
+class PerShapeStylingTests(unittest.TestCase):
+    def test_graphic_overrides_produce_an_automatic_style(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            content = member(make_drawing(Path(tmp)), "content.xml")
+            styled = next(el for el in content.iter(q("draw", "rect")) if el.attrib.get(q("draw", "name")) == "Styled")
+            style_name = styled.attrib.get(q("draw", "style-name"))
+            self.assertTrue((style_name or "").startswith("gr-auto-"))
+            auto = content.find(q("office", "automatic-styles"))
+            assert auto is not None
+            style = next(s for s in auto.findall(q("style", "style")) if s.attrib.get(q("style", "name")) == style_name)
+            self.assertEqual(style.attrib.get(q("style", "parent-style-name")), "gr-shape")
+            props = style.find(q("style", "graphic-properties"))
+            assert props is not None
+            self.assertEqual(props.attrib.get(q("draw", "fill-color")), "#F4C542")
+            self.assertEqual(props.attrib.get(q("svg", "stroke-color")), "#7A5C00")
+
+    def test_text_overrides_produce_paragraph_and_text_styles(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            content = member(make_drawing(Path(tmp)), "content.xml")
+            styled = next(el for el in content.iter(q("draw", "rect")) if el.attrib.get(q("draw", "name")) == "Styled")
+            paragraph = styled.find(q("text", "p"))
+            assert paragraph is not None
+            p_name = paragraph.attrib.get(q("text", "style-name"))
+            self.assertIsNotNone(p_name)
+            span = paragraph.find(q("text", "span"))
+            assert span is not None
+            t_name = span.attrib.get(q("text", "style-name"))
+            self.assertIsNotNone(t_name)
+            # The text style must carry the overridden colour.
+            auto = content.find(q("office", "automatic-styles"))
+            assert auto is not None
+            t_style = next(s for s in auto.findall(q("style", "style")) if s.attrib.get(q("style", "name")) == t_name)
+            tp = t_style.find(q("style", "text-properties"))
+            assert tp is not None
+            self.assertEqual(tp.attrib.get(q("fo", "color")), "#3A2E00")
+            self.assertEqual(tp.attrib.get(q("fo", "font-size")), "20pt")
+
+    def test_plain_shape_uses_role_style_directly(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            content = member(make_drawing(Path(tmp)), "content.xml")
+            plain = next(el for el in content.iter(q("draw", "rect")) if el.attrib.get(q("draw", "name")) == "Plain")
+            self.assertEqual(plain.attrib.get(q("draw", "style-name")), "gr-shape")
+
+    def test_corner_radius_lands_on_the_rect(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp_path = Path(tmp)
+            spec = tmp_path / "s.json"
+            spec.write_text(
+                json.dumps(
+                    {"pages": [{"name": "P", "items": [{"type": "rect", "name": "R", "corner-radius": "0.4cm"}]}]}
+                ),
+                encoding="utf-8",
+            )
+            odg = tmp_path / "s.odg"
+            run_script(ODG_SCRIPTS / "create_minimal_odg.py", spec, odg)
+            rect = next(member(odg, "content.xml").iter(q("draw", "rect")))
+            self.assertEqual(rect.attrib.get(q("draw", "corner-radius")), "0.4cm")
+
+
+class InjectStylesTests(unittest.TestCase):
+    def test_inject_branded_styles_roundtrip(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp_path = Path(tmp)
+            odg = make_drawing(tmp_path)
+            sys.path.insert(0, str(ODG_SCRIPTS))
+            from odg_common import inject_styles_from_file
+
+            out = tmp_path / "branded.odg"
+            missing = inject_styles_from_file(odg, DIAGRAM_STYLES, out)
+            # The branded styles.xml redefines every role style, and per-shape
+            # P/T styles live in content.xml — so nothing should dangle.
+            self.assertEqual(missing, [])
+            styles = styles_named(member(out, "styles.xml"))
+            self.assertIn("standard", styles)
+            self.assertIn("gr-shape", styles)
+            with zipfile.ZipFile(out) as archive:
+                self.assertEqual(archive.namelist()[0], "mimetype")
+
+    def test_embed_pictures_adds_manifest_entry(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp_path = Path(tmp)
+            odg = make_drawing(tmp_path)
+            sys.path.insert(0, str(ODG_SCRIPTS))
+            from odg_common import embed_pictures
+
+            png = tmp_path / "logo.png"
+            png.write_bytes(
+                bytes.fromhex(
+                    "89504e470d0a1a0a0000000d49484452000000010000000108060000001f15c4"
+                    "890000000a49444154789c6360000000020001e221bc330000000049454e44ae426082"
+                )
+            )
+            out = tmp_path / "withpic.odg"
+            embed_pictures(odg, {"Pictures/logo.png": png}, out)
+            with zipfile.ZipFile(out) as archive:
+                self.assertIn("Pictures/logo.png", archive.namelist())
+                manifest = ET.fromstring(archive.read("META-INF/manifest.xml"))
+            paths = {e.attrib.get("{urn:oasis:names:tc:opendocument:xmlns:manifest:1.0}full-path") for e in manifest}
+            self.assertIn("Pictures/logo.png", paths)
+
+
+if __name__ == "__main__":
+    unittest.main()

{open_document_lib-1.0.2 → open_document_lib-1.2.0}/tests/test_odp_master.py

@@ -63,7 +63,16 @@ class MasterPageTests(unittest.TestCase):
             master = next(
                 m for m in styles.iter(q("style", "master-page")) if m.attrib.get(q("style", "name")) == "Default"
             )
-            props = master.find(q("style", "drawing-page-properties"))
+            # The background lives in the drawing-page style the master
+            # references via draw:style-name — not on the master element.
+            dp_name = master.attrib.get(q("draw", "style-name"))
+            self.assertIsNotNone(dp_name)
+            dp_style = next(
+                s
+                for s in styles.iter(q("style", "style"))
+                if s.attrib.get(q("style", "name")) == dp_name and s.attrib.get(q("style", "family")) == "drawing-page"
+            )
+            props = dp_style.find(q("style", "drawing-page-properties"))
             assert props is not None
             self.assertEqual(props.attrib.get(q("draw", "fill")), "solid")
             self.assertEqual(props.attrib.get(q("draw", "fill-color")), "#02416C")

open_document_lib-1.2.0/tests/test_odp_styling.py

@@ -0,0 +1,186 @@
+"""Tests for ODP presentation styling — drawing-page background, graphic
+frame styles (no blue boxes), text colours, and the styles.xml inject path."""
+
+from __future__ import annotations
+
+import json
+import tempfile
+import unittest
+import zipfile
+from pathlib import Path
+from xml.etree import ElementTree as ET
+
+from helpers import ROOT, SKILLS, run_script
+
+NS = {
+    "office": "urn:oasis:names:tc:opendocument:xmlns:office:1.0",
+    "style": "urn:oasis:names:tc:opendocument:xmlns:style:1.0",
+    "draw": "urn:oasis:names:tc:opendocument:xmlns:drawing:1.0",
+    "fo": "urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0",
+    "text": "urn:oasis:names:tc:opendocument:xmlns:text:1.0",
+}
+
+ODP_SCRIPTS = SKILLS / "odp" / "scripts"
+DECK_STYLES = ROOT / "examples" / "deck" / "styles.xml"
+
+
+def q(prefix: str, local: str) -> str:
+    return f"{{{NS[prefix]}}}{local}"
+
+
+def member(path: Path, name: str) -> ET.Element:
+    with zipfile.ZipFile(path) as archive:
+        return ET.fromstring(archive.read(name))
+
+
+def make_deck(tmp_path: Path) -> Path:
+    spec = tmp_path / "deck.json"
+    spec.write_text(
+        json.dumps(
+            {
+                "title": "Styling test",
+                "slides": [
+                    {"name": "A", "title": "Hello", "body": ["one", "two"]},
+                    {"name": "B", "title": "World", "body": "single"},
+                ],
+            }
+        ),
+        encoding="utf-8",
+    )
+    odp = tmp_path / "deck.odp"
+    run_script(ODP_SCRIPTS / "create_minimal_odp.py", spec, odp)
+    return odp
+
+
+def graphic_styles(styles: ET.Element) -> dict[str, ET.Element]:
+    out: dict[str, ET.Element] = {}
+    for st in styles.iter(q("style", "style")):
+        if st.attrib.get(q("style", "family")) == "graphic":
+            name = st.attrib.get(q("style", "name"))
+            if name:
+                out[name] = st
+    return out
+
+
+class GeneratedStylingTests(unittest.TestCase):
+    def test_frames_reference_a_graphic_style(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odp = make_deck(Path(tmp))
+            content = member(odp, "content.xml")
+            frames = list(content.iter(q("draw", "frame")))
+            self.assertGreater(len(frames), 0)
+            for frame in frames:
+                self.assertIsNotNone(
+                    frame.attrib.get(q("draw", "style-name")),
+                    "every generated frame must carry a draw:style-name",
+                )
+
+    def test_graphic_styles_suppress_default_fill(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odp = make_deck(Path(tmp))
+            styles = member(odp, "styles.xml")
+            grs = graphic_styles(styles)
+            for name in ("gr-title", "gr-body", "gr-notes", "gr-image"):
+                self.assertIn(name, grs, f"missing graphic style {name}")
+                props = grs[name].find(q("style", "graphic-properties"))
+                assert props is not None
+                self.assertEqual(props.attrib.get(q("draw", "fill")), "none")
+                self.assertEqual(props.attrib.get(q("draw", "stroke")), "none")
+
+    def test_drawing_page_background_style_is_referenced_by_master(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odp = make_deck(Path(tmp))
+            styles = member(odp, "styles.xml")
+            master = next(
+                m for m in styles.iter(q("style", "master-page")) if m.attrib.get(q("style", "name")) == "Default"
+            )
+            dp_name = master.attrib.get(q("draw", "style-name"))
+            self.assertIsNotNone(dp_name, "master page must reference a drawing-page style")
+            dp_style = next(
+                s
+                for s in styles.iter(q("style", "style"))
+                if s.attrib.get(q("style", "name")) == dp_name and s.attrib.get(q("style", "family")) == "drawing-page"
+            )
+            props = dp_style.find(q("style", "drawing-page-properties"))
+            assert props is not None
+            self.assertEqual(props.attrib.get(q("draw", "fill")), "solid")
+            self.assertIsNotNone(props.attrib.get(q("draw", "fill-color")))
+
+    def test_paragraph_styles_carry_explicit_colour(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            odp = make_deck(Path(tmp))
+            styles = member(odp, "styles.xml")
+            for name in ("Title", "Body", "Notes"):
+                style = next(
+                    s
+                    for s in styles.iter(q("style", "style"))
+                    if s.attrib.get(q("style", "name")) == name and s.attrib.get(q("style", "family")) == "paragraph"
+                )
+                tp = style.find(q("style", "text-properties"))
+                assert tp is not None
+                self.assertIsNotNone(tp.attrib.get(q("fo", "color")), f"{name} must set fo:color")
+
+
+class InjectStylesTests(unittest.TestCase):
+    def test_inject_branded_styles_roundtrip(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp_path = Path(tmp)
+            odp = make_deck(tmp_path)
+
+            import sys
+
+            sys.path.insert(0, str(ODP_SCRIPTS))
+            from odp_common import inject_styles_from_file
+
+            out = tmp_path / "branded.odp"
+            missing = inject_styles_from_file(odp, DECK_STYLES, out)
+            # The branded styles.xml redefines every named style the
+            # generator emits, so no content reference should dangle.
+            self.assertEqual(missing, [])
+
+            styles = member(out, "styles.xml")
+            dp = next(s for s in styles.iter(q("style", "style")) if s.attrib.get(q("style", "name")) == "dp-default")
+            props = dp.find(q("style", "drawing-page-properties"))
+            assert props is not None
+            self.assertEqual(props.attrib.get(q("draw", "fill-color")), "#02416C")
+            # mimetype must stay the first, stored entry.
+            with zipfile.ZipFile(out) as archive:
+                self.assertEqual(archive.namelist()[0], "mimetype")
+
+
+class CustomizeMasterBackgroundTests(unittest.TestCase):
+    def test_background_color_lands_in_drawing_page_style(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            tmp_path = Path(tmp)
+            odp = make_deck(tmp_path)
+            out = tmp_path / "bg.odp"
+            run_script(
+                ODP_SCRIPTS / "customize_master.py",
+                odp,
+                "--master",
+                "Default",
+                "--background-color",
+                "#123456",
+                "-o",
+                out,
+            )
+            styles = member(out, "styles.xml")
+            master = next(
+                m for m in styles.iter(q("style", "master-page")) if m.attrib.get(q("style", "name")) == "Default"
+            )
+            dp_name = master.attrib.get(q("draw", "style-name"))
+            dp_style = next(
+                s
+                for s in styles.iter(q("style", "style"))
+                if s.attrib.get(q("style", "name")) == dp_name and s.attrib.get(q("style", "family")) == "drawing-page"
+            )
+            props = dp_style.find(q("style", "drawing-page-properties"))
+            assert props is not None
+            self.assertEqual(props.attrib.get(q("draw", "fill-color")), "#123456")
+            # The customized background must not be written onto the master
+            # element itself — that variant does not render.
+            self.assertIsNone(master.find(q("style", "drawing-page-properties")))
+
+
+if __name__ == "__main__":
+    unittest.main()