onetick-py 1.163.0__tar.gz → 1.164.0__tar.gz

{onetick_py-1.163.0 → onetick_py-1.164.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: onetick-py
-Version: 1.163.0
+Version: 1.164.0
 Summary: Python package that allows you to work with OneTick
 Author-email: solutions <solutions@onetick.com>
 License-Expression: MIT

{onetick_py-1.163.0 → onetick_py-1.164.0}/pyproject.toml

@@ -44,3 +44,4 @@ where = ["src"]
 
 [tool.black]
 line-length = 120
+skip-string-normalization = true

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/locator_parser/actions.py

@@ -14,7 +14,7 @@ class Add(Action):
     def __init__(self, obj):
         self.what_to_add = obj.to_lines()
 
-        super(Add, self).__init__()
+        super().__init__()
 
         if obj.__class__.PARENT is not Entity:
             self._add_conditions[(obj.__class__.PARENT.TAG.lower(), None, None)] = False
@@ -36,7 +36,7 @@ class Modify(Action):
 
     def __init__(self, **kwargs):
         if len(kwargs) > 1:
-            raise Exception("It is not supported to set multiple keys yet!")
+            raise ValueError("It is not supported to set multiple keys yet!")
 
         field, value = "", ""
         delete = False
@@ -49,7 +49,7 @@ class Modify(Action):
 
         self.init(field, value, delete)
 
-        super(Modify, self).__init__()
+        super().__init__()
 
     def init(self, field, value, delete):
         self.field = field.lower()
@@ -58,7 +58,7 @@ class Modify(Action):
 
     def do(self, obj, all_lines, properties_lines, writer):
         if not obj.__class__.HAS_PROPERTIES:
-            raise Exception("Entity with tag '" + obj.__class__.TAG + "' does not expect to have properties!")
+            raise AttributeError("Entity with tag '" + obj.__class__.TAG + "' does not expect to have properties!")
 
         new_properties = list(properties_lines)
 
@@ -69,12 +69,10 @@ class Modify(Action):
                 if end_pos != -1:
                     if line.find("/>") != -1 and line.find("/>") < end_pos:
                         end_pos = line.find("/>")
-                    # if
 
                     line = line[:end_pos] + " %s=%s" % (self.field, self.value) + line[end_pos:]
+                    new_properties[-1] = line
                     break
-
-            new_properties[-1] = line
         else:
             for inx, line in enumerate(new_properties):
                 pos = line.lower().find(self.field + "=")
@@ -90,11 +88,9 @@ class Modify(Action):
                             line[pos: pos + len(self.field) + 1] + t_line,
                             line[pos: pos + len(self.field) + 1] + self.value,
                         )
-
+                    new_properties[inx] = line
                     break
 
-            new_properties[inx] = line
-
         writer.modify(len(all_lines), properties_lines, new_properties)
 
 
@@ -134,7 +130,7 @@ class Get(Action):
         double_quotes_count = 0
         single_quotes_count = 0
 
-        for token in filter(lambda x: x != "" and x != "<" and x != "/>" and x != ">", properties_lines.split()[1:]):
+        for token in filter(lambda x: x not in ("", "<", "/>", ">"), properties_lines.split()[1:]):
             # ---------------------
             # Logic to combine values in quotes are separated
             # by space
@@ -165,10 +161,10 @@ class Get(Action):
 
             key, value = t_list[0], t_list[1]
 
-            if value[-2:] == "/>":
+            if value.endswith("/>"):
                 value = value[:-2]
 
-            if value[-1:] == ">" or value[-1:] == "/":
+            if value.endswith(">") or value.endswith("/"):
                 value = value[:-1]
 
             properties_dict[key.lower()] = value.replace('"', "")
@@ -183,7 +179,7 @@ class Get(Action):
 class GetAll(Action):
 
     def __init__(self):
-        super(GetAll, self).__init__()
+        super().__init__()
         self.result = []
 
     def do(self, obj, all_lines, properties_lines, writer):

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/locator_parser/common.py

@@ -23,7 +23,7 @@ def get_properties(declaration):
     return properties
 
 
-class Generator(object):
+class Generator:
 
     def __iter__(self):
         return self
@@ -105,14 +105,12 @@ class Action(ABC):
         return True
 
     def add_where(self, tag, **kwargs):
-        if type(tag) is str:
-            tag = tag
-        else:
+        if not isinstance(tag, str):
             # for case when it's class name
             tag = tag.TAG
 
         if len(kwargs) > 1:
-            raise Exception("It is not support to set multiple keys yet!")
+            raise ValueError("It is not support to set multiple keys yet!")
 
         if len(kwargs) == 0:
             self.conditions[(tag.lower(), None, None)] = False
@@ -120,10 +118,13 @@ class Action(ABC):
             self.conditions[(tag.lower(), list(kwargs.keys())[0].lower(), list(kwargs.values())[0])] = False
 
 
-def apply_actions(func, reader, writer, actions=[], flush=False):
+def apply_actions(func, reader, writer, actions=None, flush=False):
     from locator_parser.io import LinesReader
     from locator_parser.actions import DoNothing
 
+    if actions is None:
+        actions = []
+
     if len(actions) == 0:
         actions.append(DoNothing())
 
@@ -173,7 +174,7 @@ class Writer(ABC):
             elif msg_type == Writer.NEW_MSG:
                 lines = yield
 
-                assert type(lines) is list
+                assert isinstance(lines, list)
 
                 self.lines = self.lines[:-1] + lines + self.lines[-1:]
             elif msg_type == Writer.MODIFY_MSG:
@@ -316,9 +317,11 @@ class Entity(Generator, ABC):
                     self.finish(writer, action)
                     return
 
-            line = next(reader)
-
-            yield line
+            try:
+                line = next(reader)
+                yield line
+            except StopIteration:
+                return
 
     def finish(self, writer, action):
         if self.__do:

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/locator_parser/io.py

@@ -7,12 +7,12 @@ class FileWriter(Writer):
     def __init__(self, file_path):
         self.__path = file_path
 
-        super(FileWriter, self).__init__()
+        super().__init__()
 
     def flush(self):
         with open(self.__path, "w") as fout:
             for line in self.lines:
-                if line[-1:] != "\n":
+                if not line.endswith("\n"):
                     line += "\n"
 
                 fout.write(line)
@@ -27,10 +27,12 @@ class PrintWriter(Writer):
 class FileReader(Reader):
 
     def __init__(self, file_path):
+        # pylint: disable-next=consider-using-with
         self.iterable_object = open(file_path.replace('"', ""), "r")
+        # pylint: disable-next=unused-private-member
         self.__finalizer = weakref.finalize(self, lambda x: x.close(), self.iterable_object)
 
-        super(FileReader, self).__init__()
+        super().__init__()
 
 
 class LinesReader(Reader):
@@ -38,4 +40,4 @@ class LinesReader(Reader):
     def __init__(self, lines):
         self.iterable_object = lines.split("\n")
 
-        super(LinesReader, self).__init__()
+        super().__init__()

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/locator_parser/locator.py

@@ -18,7 +18,7 @@ class Include(Entity):
         # env variable found in the path
         if matched:
             if matched.group(0)[2:-1] not in os.environ:
-                raise Exception("Includes use not defined environment variable: % s" % matched.group(0))
+                raise RuntimeError("Includes use not defined environment variable: % s" % matched.group(0))
 
             path = path.replace(matched.group(0), os.environ[matched.group(0)[2:-1]])
 

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/doc_utilities/ot_doctest.py

@@ -3,7 +3,6 @@ import re
 import inspect
 
 from typing import Union, Optional
-from onetick.py.backports import Literal
 
 
 def snippet_name(example: Union[doctest.Example, str], value):
@@ -24,6 +23,7 @@ def skip_example(example, value, caller=None):
     if isinstance(example, doctest.Example):
         example.skip = True
         return example
+    return None
 
 
 OT_DIRECTIVES = {'skip-example': skip_example,

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/doc_utilities/snippets.py

@@ -218,8 +218,7 @@ class Snippets:
             self.append(item)
 
     def __iter__(self):
-        for s in self._snippets.values():
-            yield s
+        yield from self._snippets.values()
 
     def dict_view(self):
         """Format snippets for nbextension-contrib-snippets"""

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/lib/instance.py

@@ -76,8 +76,8 @@ class OneTickLib:
             if log_file:
                 self.set_log_file(log_file)
         elif args != OneTickLib.__args and args:
-            raise Exception("OneTickLib was already initialized with different "
-                            "parameters: Was: {} Now: {}".format(OneTickLib.__args, args))
+            raise ValueError("OneTickLib was already initialized with different "
+                             "parameters: Was: {} Now: {}".format(OneTickLib.__args, args))
 
     def __eq__(self, otl):
         return self.__dict__ == otl.__dict__
@@ -134,5 +134,8 @@ class OneTickLib:
         :param config_parameter_value: new value of the param
         """
         if OneTickLib.__instance:
-            raise Exception('This method should be called before OneTickLib object is constructed to have effect.')
-        pyomd.OneTickLib.override_config_value(config_parameter_name, config_parameter_value)
+            raise RuntimeError('This method should be called before OneTickLib object is constructed to have effect.')
+        try:
+            pyomd.OneTickLib.override_config_value(config_parameter_name, config_parameter_value)  # noqa
+        except NameError:
+            raise RuntimeError('This method is not available in WebAPI mode')

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/__init__.py

@@ -2,7 +2,7 @@
 import os
 from . import _version
 __version__ = _version.VERSION
-__webapi__: bool = bool(os.getenv("OTP_WEBAPI", False))
+__webapi__: bool = bool(os.getenv("OTP_WEBAPI"))
 
 
 def __validate_onetick_query_integration():  # noqa
@@ -13,10 +13,9 @@ def __validate_onetick_query_integration():  # noqa
     before raising an exception, we check if onetick.query_webapi is installed.
     If it is installed, we set OTP_WEBAPI environment variable and avoid raising any exception/warning.
     """
-    import os
     global __webapi__
 
-    if os.getenv("OTP_SKIP_OTQ_VALIDATION", False):
+    if os.getenv("OTP_SKIP_OTQ_VALIDATION"):
         return
 
     _otq_import_ex = None
@@ -86,7 +85,7 @@ def __validate_onetick_query_integration():  # noqa
     except ImportError:
         print('onetick.query_webapi is not available')
 
-    if type(_otq_import_ex) is ImportError:
+    if isinstance(_otq_import_ex, ImportError):
         raise ImportError(
             'The above exception is probably raised '
             'because your python version is unsupported in this OneTick build'
@@ -127,7 +126,6 @@ def __validate_onetick_query_integration():  # noqa
 
 
 def __get_missed_paths(env, *paths, found_callback=None):
-    import os
     from pathlib import Path
 
     missed_paths = []
@@ -147,9 +145,7 @@ def __get_missed_paths(env, *paths, found_callback=None):
 
 
 def __set_onetick_path_variables():
-    import os
-    global __webapi__
-    if __webapi__ or os.getenv("OTP_SKIP_OTQ_VALIDATION", False):
+    if __webapi__ or os.getenv("OTP_SKIP_OTQ_VALIDATION"):
         return
     import warnings
     import onetick.query as otq
@@ -157,6 +153,7 @@ def __set_onetick_path_variables():
 
     onetick_query_init = Path(otq.__file__)
 
+    # pylint: disable=global-variable-undefined
     global __main_one_tick_dir__, __one_tick_bin_dir__, __one_tick_python_dir__
     __one_tick_python_dir__ = str(onetick_query_init.parents[2])
     __one_tick_bin_dir__ = str(onetick_query_init.parents[3])
@@ -196,7 +193,6 @@ from onetick.py.sources import (Tick, TTicks, Ticks, Orders, Trades, NBBO, Quote
                                 by_symbol, ODBC, SplitQueryOutputBySymbol, DataFile, PointInTime,
                                 ReadSnapshot, ShowSnapshotList, FindSnapshotSymbols)
 from onetick.py.utils import adaptive, range, perf
-from onetick.py.core.eval_query import eval
 from onetick.py.session import Session, TestSession, Config, Locator, HTTPSession
 from onetick.py.servers import RemoteTS, LoadBalancing, FaultTolerance
 from onetick.py.db import DB, RefDB

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/_version.py

@@ -1,2 +1,2 @@
 # This file was generated automatically. DO NOT CHANGE.
-VERSION = '1.163.0'
+VERSION = '1.164.0'

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/aggregations/_base.py

@@ -78,6 +78,7 @@ def operation_replacer(method):
             aggs = aggrs.values()
         else:
             name = args[0] if args else kwargs.get('name')
+            # pylint: disable-next=unidiomatic-typecheck
             if type(obj.column_name) is _Operation and name is None:
                 raise ValueError('Output field name must be specified when aggregating operation')
             aggs = [obj]
@@ -85,6 +86,7 @@ def operation_replacer(method):
         # Add operation from each aggregation object to source `res` as column
         # and replace *column_name* property in each aggregation object with this column's name.
         for i, agg in enumerate(aggs):
+            # pylint: disable-next=unidiomatic-typecheck
             if type(agg.column_name) is _Operation:
                 tmp_name = f'__TMP_AGG_COLUMN_{i}__'
                 res[tmp_name] = agg.column_name
@@ -242,7 +244,7 @@ class _Aggregation(ABC):
         """
         Abstract method that implements common logic for aggregations
         """
-        if type(column) is list:
+        if isinstance(column, list):
             column = ','.join(map(str, column))
 
         column_name: Union[str, _Operation] = str(column)
@@ -251,6 +253,7 @@ class _Aggregation(ABC):
             # TODO: need to understand how to better work with alias
             column_name = "TIMESTAMP"
 
+        # pylint: disable-next=unidiomatic-typecheck
         if type(column) is _Operation:
             column_name = column
 
@@ -314,7 +317,7 @@ class _Aggregation(ABC):
         self.end_condition_per_group = end_condition_per_group
         self.boundary_tick_bucket = boundary_tick_bucket
         self.large_ints = False
-        if isinstance(group_by, _Operation) or isinstance(group_by, str):
+        if isinstance(group_by, (_Operation, str)):
             group_by = [group_by]
         self.group_by = group_by or []
         self.groups_to_display = groups_to_display
@@ -327,7 +330,7 @@ class _Aggregation(ABC):
     def _attr2str(value) -> str:
         if isinstance(value, bool):
             return 'true' if value else 'false'
-        if type(value) is list:
+        if isinstance(value, list):
             return ','.join(value)
         return str(value)
 
@@ -436,7 +439,7 @@ class _Aggregation(ABC):
     @staticmethod
     def validate_output_name(schema: Dict, name: Union[List, str]):
         """checks that aggregation won't output columns with same names"""
-        if type(name) is not list:
+        if not isinstance(name, list):
             name = [name]
 
         same_fields = []

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/aggregations/_docs.py

@@ -902,7 +902,7 @@ def copy_method(obj, mimic=True, drop_examples=False):
     return _decorator
 
 
-def copy_signature(obj, add_self=False, drop_parameters=[], return_annotation='Source'):
+def copy_signature(obj, add_self=False, drop_parameters=None, return_annotation='Source'):
     """
     Decorator that copies signature of the callable ``obj`` to the decorated function.
     """

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/aggregations/other.py

@@ -227,7 +227,7 @@ class Distinct(_AggregationTSSelection):
                  keys: Union[str, List[str], _Column, List[_Column]],
                  key_attrs_only: bool = True,
                  *args, **kwargs):
-        keys = keys if type(keys) is list else [keys]   # type: ignore
+        keys = keys if isinstance(keys, list) else [keys]   # type: ignore
         super().__init__(column=keys, *args, **kwargs)  # type: ignore
         self.key_attrs_only = key_attrs_only
 

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/cache.py

@@ -26,6 +26,7 @@ def _convert_dt_to_str(dt: Union[str, datetime, otp_datetime]):
         return dt
     elif isinstance(dt, (datetime, otp_datetime)):
         return dt.strftime('%Y%m%d%H%M%S.%f')
+    raise ValueError(f"Unsupported value for 'dt' parameter: {type(dt)}")
 
 
 def _convert_time_intervals(

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/callback/callback.py

@@ -29,6 +29,7 @@ class CallbackBase(otq.CallbackBase):
     3
     """
 
+    # pylint: disable-next=useless-parent-delegation
     def __init__(self):
         """
         Method ``__init__()`` can be used for callback initialization.

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/core/_internal/_proxy_node.py

@@ -85,7 +85,7 @@ class _ProxyNode:
             else:
                 self._hist.node_name(self._key, name)
                 self._name = name
-
+            return None
         else:
             return self._name
 

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/core/_internal/_state_objects.py

@@ -383,7 +383,7 @@ class _TickSequence(_StateBase):
         return isinstance(self._owner, _EmulateInputObject)
 
     def _default_schema(self):
-        return {field: type for field, type in self._owner.schema.items()}
+        return dict(self._owner.schema.items())
 
     @property
     def schema(self) -> dict:
@@ -391,7 +391,7 @@ class _TickSequence(_StateBase):
         Get schema of the tick sequence.
         """
         fields = None
-        if type(self._schema) is list:
+        if isinstance(self._schema, list):
             fields = self._schema
             self._schema = None
         if not self._schema:

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/core/_source/source_methods/aggregations.py

@@ -1,6 +1,5 @@
 import warnings
-from inspect import Parameter
-from typing import TYPE_CHECKING, Optional, Tuple, Union
+from typing import TYPE_CHECKING, Tuple, Union
 
 from onetick import py as otp
 from onetick.py import aggregations
@@ -397,8 +396,8 @@ def distinct(self: 'Source', *args, **kwargs):
     """
     if 'bucket_interval_units' in kwargs:
         kwargs['bucket_units'] = kwargs.pop('bucket_interval_units')
-    agg = aggregations.functions.distinct(*args, **kwargs)
-    return agg.apply(self)
+    aggr = aggregations.functions.distinct(*args, **kwargs)
+    return aggr.apply(self)
 
 
 # mimic=False for backward compatibility
@@ -421,8 +420,8 @@ def high_time(self: 'Source', *args, **kwargs):
         FutureWarning,
         stacklevel=2,
     )
-    agg = aggregations.functions.high_time(*args, **kwargs)
-    return agg.apply(self, 'VALUE')
+    aggr = aggregations.functions.high_time(*args, **kwargs)
+    return aggr.apply(self, 'VALUE')
 
 
 # mimic=False for backward compatibility
@@ -445,8 +444,8 @@ def low_time(self: 'Source', *args, **kwargs):
         FutureWarning,
         stacklevel=2,
     )
-    agg = aggregations.functions.low_time(*args, **kwargs)
-    return agg.apply(self, 'VALUE')
+    aggr = aggregations.functions.low_time(*args, **kwargs)
+    return aggr.apply(self, 'VALUE')
 
 
 @copy_method(aggregations.functions.ob_snapshot)
@@ -800,7 +799,7 @@ def process_by_group(
             output_schema[field] = input_schema[field]
         for field, field_type in output_schema.items():
             output_source.schema[field] = field_type
-        output_source = output_source[[field for field in output_schema]]
+        output_source = output_source[list(output_schema)]
         output_source._merge_tmp_otq(main_source)
         output_sources.append(output_source)
 

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/core/_source/source_methods/applyers.py

@@ -174,7 +174,7 @@ def apply(self: 'Source', obj) -> Union['otp.Column', 'Source']:
     return apply_lambda(obj, _EmulateObject(self))
 
 
-def _extract_columns_from_script(script):
+def _extract_columns_from_script(script_text):
     result = {}
     supported_types = {
         'byte',
@@ -199,7 +199,7 @@ def _extract_columns_from_script(script):
     length = r"(\[(?P<length>\d+)\])?"
     name = r"\s+(?P<name>\w+)\s*=\s*"
     pattern = re.compile(types + length + name)
-    for p in re.finditer(pattern, script):
+    for p in re.finditer(pattern, script_text):
         groupdict = p.groupdict()
         type_ = ott.str2type(groupdict["type"]) if groupdict["type"] in supported_types else None
         if type_:

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/core/_source/source_methods/debugs.py

@@ -236,23 +236,25 @@ def dump(
     if label:
         self_c['_OUT_LABEL_'] = label
 
-    self_c.sink(
-        otq.WriteText(
-            formats_of_fields='TIMESTAMP=%|' + configuration.config.tz + '|%d-%m-%Y %H:%M:%S.%J',
-            prepend_timestamp=False,
-            prepend_symbol_name=False,
-            propagate_ticks=True,
-        )
+    self_c.write_text(
+        formats_of_fields={'TIMESTAMP': f'%|{configuration.config.tz}|%d-%m-%Y %H:%M:%S.%J'},
+        prepend_timestamp=True,
+        prepend_symbol_name=False,
+        propagate_ticks=True,
+        inplace=True,
     )
 
     # print <no data> in case there are 0 ticks
-    self_c = self_c.agg({'COUNT': otp.agg.count()})
-    self_c, _ = self_c[self_c['COUNT'] == 0]
-    self_c['NO_DATA'] = '<no data>'
-    self_c = self_c[['NO_DATA']]
-    self_c.sink(
-        otq.WriteText(output_headers=False, prepend_timestamp=False, prepend_symbol_name=False, propagate_ticks=True)
-    )
+    if hasattr(otq, 'InsertAtEnd'):
+        self_c.sink(otq.InsertAtEnd(delimiter_name='AT_END'))
+        self_c.schema['AT_END'] = int
+        self_c.state_vars['COUNT'] = otp.state.var(0, scope='branch')
+        self_c.state_vars['COUNT'] += 1
+        self_c, _ = self_c[(self_c['AT_END'] == 1) & (self_c.state_vars['COUNT'] == 1)]
+        self_c['NO_DATA'] = '<no data>'
+        self_c = self_c[['NO_DATA']]
+        self_c.write_text(output_headers=False, prepend_timestamp=False, prepend_symbol_name=False,
+                          propagate_ticks=False, inplace=True)
 
     # Do not propagate ticks then, because we want just to write them into
     # the std::out. We have to do that, because otherwise these ticks would

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/core/_source/source_methods/drops.py

@@ -111,7 +111,7 @@ def drop(self: 'Source', columns: List[Any], inplace=False) -> Optional['Source'
 
 
 def __delitem__(self: 'Source', obj):
-    if isinstance(obj, list) or isinstance(obj, tuple):
+    if isinstance(obj, (list, tuple)):
         objs = obj
     else:
         objs = (obj,)

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/core/_source/source_methods/fields.py

@@ -127,11 +127,12 @@ def table(self: 'Source', inplace=False, strict: bool = True, **schema) -> Optio
 
 
 def __add_field_parse_value(value):
-    if type(value) is tuple:
+    if isinstance(value, tuple):
         value, dtype = value
     else:
         dtype = ott.get_object_type(value)
 
+        # pylint: disable-next=unidiomatic-typecheck
         if type(value) is str and len(value) > ott.string.DEFAULT_LENGTH:
             dtype = ott.string[len(value)]
 
@@ -213,6 +214,7 @@ def _replace_positive_lag_operator_with_tmp_column(value):
                 )
             name = f"__{name}_{operation.index}_NEW__"
             return _Column(name, column.dtype, column.obj_ref, precision=getattr(column, "_precision", None))
+        return None
 
     op, replace_tuples = value._replace_parameters(fun, return_replace_tuples=True)
     return op, {str(new): old for old, new in replace_tuples}
@@ -228,7 +230,7 @@ def _update_field(self: 'Source', field, value):
     if names_mapping:
         self.add_fields(names_mapping, inplace=True)
 
-    if type(value) is tuple:
+    if isinstance(value, tuple):
         # support to be compatible with adding fields to get rid of some strange problems
         # but really we do not use passed type, because update field does not support it
         value, _ = value
@@ -327,9 +329,7 @@ def _validate_before_setting(key, value):
         value = value.item()
     if not (
         ott.is_type_supported(ott.get_object_type(value))
-        or isinstance(value, _Operation)
-        or type(value) is tuple
-        or isinstance(value, _ColumnAggregation)
+        or isinstance(value, (_Operation, tuple, _ColumnAggregation))
     ):
         raise TypeError(f'It is not allowed to set objects of "{type(value)}" type')
     return value

{onetick_py-1.163.0 → onetick_py-1.164.0}/src/onetick/py/core/_source/source_methods/filters.py

@@ -161,16 +161,16 @@ def where_clause(
         condition = condition._make_python_way_bool_expression()
     if isinstance(condition, _QueryEvalWrapper):
         condition = condition.to_eval_string(self._tmp_otq)
-    where = self.copy(
+    where_branch = self.copy(
         ep=otq.WhereClause(
             where=str(condition), discard_on_match=discard_on_match, stop_on_first_mismatch=stop_on_first_mismatch
         )
     )
 
-    if_source = where.copy()
+    if_source = where_branch.copy()
     if_source.node().out_pin("IF")
 
-    else_source = where.copy()
+    else_source = where_branch.copy()
     else_source.node().out_pin("ELSE")
     # TODO: add ability to remove then this ep, because it is required only for right output
     else_source.sink(otq.Passthrough())
@@ -263,6 +263,7 @@ def _get_integer_slice(self: 'Source', item: slice) -> Optional['Source']:
         raise ValueError("step value can't be negative or zero")
     if stop is not None and stop == 0:
         raise ValueError("stop value can't be zero")
+    # pylint: disable=chained-comparison
     if start and stop and start > 0 and stop > 0 and start >= stop:
         raise ValueError("stop value can't be less than start")
     if start and start < 0 and stop and stop > 0: