omnata-plugin-runtime 0.9.4a217__tar.gz → 0.9.5__tar.gz

{omnata_plugin_runtime-0.9.4a217 → omnata_plugin_runtime-0.9.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: omnata-plugin-runtime
-Version: 0.9.4a217
+Version: 0.9.5
 Summary: Classes and common runtime components for building and running Omnata Plugins
 Author: James Weakley
 Author-email: james.weakley@omnata.com

{omnata_plugin_runtime-0.9.4a217 → omnata_plugin_runtime-0.9.5}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "omnata-plugin-runtime"
-version = "0.9.4-a217"
+version = "0.9.5"
 description = "Classes and common runtime components for building and running Omnata Plugins"
 authors = ["James Weakley <james.weakley@omnata.com>"]
 readme = "README.md"

{omnata_plugin_runtime-0.9.4a217 → omnata_plugin_runtime-0.9.5}/src/omnata_plugin_runtime/json_schema.py

@@ -166,16 +166,18 @@ class SnowflakeViewColumn(BaseModel):
     def definition(self) -> str:
         return f'{self.expression} as "{self.name}"'
 
-    def name_with_comment(self) -> str:
+    def name_with_comment(self,binding_list:Optional[List[Any]] = None) -> str:
         """
         Returns the column name (quoted), along with any comment.
         The resulting text can be used in a CREATE VIEW statement.
-        """
-        return (
-            f'"{self.name}"'
-            if self.comment is None
-            else f'"{self.name}" COMMENT $${self.comment}$$'
-        )
+        If binding_list is provided, the comment will be added to the list, and a placeholder '?' will be used in the SQL.
+        """
+        if self.comment is None:
+            return f'"{self.name}"'
+        if binding_list is not None:
+            binding_list.append(self.comment)
+            return f'"{self.name}" COMMENT ?'
+        return f'"{self.name}" COMMENT $${self.comment}$$'
     
     @classmethod
     def from_json_schema_property(cls,
@@ -357,11 +359,17 @@ class SnowflakeViewPart(BaseModel):
         """
         return f"COMMENT = $${self.comment}$$ " if self.comment is not None else ""
 
-    def column_names_with_comments(self) -> List[str]:
+    def column_names_with_comments(self,binding_list:Optional[List[Any]] = None) -> List[str]:
+        """
+        Returns a list of column names with comments, suitable for use in a CREATE VIEW statement.
+        This includes direct columns first, followed by join columns.
+        If binding_list is provided, the comments will be added to the list, and a placeholder '?' will be used in the SQL.
+        Otherwise, the comments will be included in the SQL inside of a '$$' delimiter.
+        """
         # the outer view definition has all of the column names and comments, but with the direct columns
         # first and the join columns last, same as they are ordered in the inner query
         return [
-            c.name_with_comment() for c in (self.direct_columns() + self.join_columns())
+            c.name_with_comment(binding_list) for c in (self.direct_columns() + self.join_columns())
         ]
     
     def cte_text(self) -> str:
@@ -594,7 +602,7 @@ def normalized_view_part(
             column_name_expression=column_name_expression
         )
         if json_schema.joins:
-            joins = json_schema
+            joins = json_schema.joins
         comment = json_schema.description
 
     return SnowflakeViewPart(