oarepo-runtime 1.4.4__tar.gz → 1.4.6__tar.gz

{oarepo-runtime-1.4.4/oarepo_runtime.egg-info → oarepo-runtime-1.4.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: oarepo-runtime
-Version: 1.4.4
+Version: 1.4.6
 Summary: A set of runtime extensions of Invenio repository
 Description-Content-Type: text/markdown
 License-File: LICENSE

{oarepo-runtime-1.4.4 → oarepo-runtime-1.4.6}/oarepo_runtime/cli/index.py

@@ -1,3 +1,4 @@
+import itertools
 import sys
 
 import click
@@ -85,6 +86,18 @@ def record_or_service(model):
     return record
 
 
+def model_records_generator(model_class):
+    try:
+        for x in db.session.query(model_class.model_cls.id).filter(
+            model_class.model_cls.is_deleted.is_(False)
+        ):
+            rec_id = x[0]
+            yield model_class.get_record(rec_id)
+    except Exception as e:
+        if "Column expression or FROM clause expected" not in str(e):
+            raise
+
+
 @index.command()
 @with_appcontext
 @click.argument("model", required=False)
@@ -99,30 +112,38 @@ def reindex(model):
         service = current_service_registry.get(service_id)
         record_class = getattr(service.config, "record_cls", None)
 
-        if not record_class or not hasattr(service, "indexer"):
-            continue
+        id_generators = []
 
-        try:
-            id_generator = (
-                x[0]
-                for x in db.session.query(record_class.model_cls.id).filter(
-                    record_class.model_cls.is_deleted.is_(False)
+        if record_class and hasattr(service, "indexer"):
+            try:
+                id_generators.append(model_records_generator(record_class))
+            except Exception as e:
+                click.secho(
+                    f"Could not get record ids for {service_id}, exception {e}",
+                    file=sys.stderr,
+                )
+
+        draft_class = getattr(service.config, "draft_cls", None)
+
+        if draft_class and hasattr(service, "indexer"):
+            try:
+                id_generators.append(model_records_generator(draft_class))
+            except Exception as e:
+                click.secho(
+                    f"Could not get draft record ids for {service_id}, exception {e}",
+                    file=sys.stderr,
                 )
-            )
-        except Exception as e:
-            click.secho(
-                f"Could not get record ids for {service_id}, exception {e}",
-                file=sys.stderr,
-            )
-            continue
 
         click.secho(f"Indexing {service_id}", file=sys.stderr)
-        ids = list(id_generator)
-        for rec_id in ids:
-            record = record_class.get_record(rec_id)
-            service.indexer.index(record)
-        service.indexer.refresh()
+        count = 0
+        for gen in id_generators:
+            for record in gen:
+                service.indexer.index(record)
+                count += 1
+        if count:
+            service.indexer.refresh()
+
         click.secho(
-            f"Indexing {service_id} finished, indexed {len(ids)} records",
+            f"Indexing {service_id} finished, indexed {count} records",
             file=sys.stderr,
         )

{oarepo-runtime-1.4.4 → oarepo-runtime-1.4.6}/oarepo_runtime/cli/validate.py

@@ -22,6 +22,12 @@ class CheckOk(Exception):
     pass
 
 
+def dump_data(d):
+    io = StringIO()
+    yaml.safe_dump(d, io, allow_unicode=True)
+    return io.getvalue()
+
+
 @oarepo.command(
     help="Validate a record. Takes one or two parameters - service name as "
     "the first one, file name or stdin with record data as the second"
@@ -51,12 +57,22 @@ def validate(service_name, record_file, verbose):
     if file_content.startswith("{"):
         data = json.loads(file_content)
     else:
-        data = yaml.safe_load(StringIO(file_content))
+        data = list(yaml.safe_load_all(StringIO(file_content)))
 
     if not isinstance(data, list):
         data = [data]
     for idx, d in enumerate(data):
-        loaded = schema().load(d)
+        try:
+            loaded = schema().load(d)
+        except Exception as e:
+            click.secho(
+                f"Marshmallow validation of record idx {idx + 1} failed",
+                fg="red",
+            )
+            click.secho(dump_data(d))
+            click.secho(e)
+            continue
+
         click.secho(
             f"Marshmallow validation of record idx {idx+1} has been successful",
             fg="green",
@@ -74,6 +90,14 @@ def validate(service_name, record_file, verbose):
             click.secho(
                 f"Pre-commit hook of record idx {idx+1} has been successful", fg="green"
             )
+        except Exception as e:
+            click.secho(
+                f"Pre-commit validation of record idx {idx + 1} failed",
+                fg="red",
+            )
+            click.secho(dump_data(d))
+            click.secho(e)
+            continue
 
         if verbose:
             yaml.safe_dump(loaded, sys.stdout, allow_unicode=True)

oarepo-runtime-1.4.6/oarepo_runtime/relations/errors.py

@@ -0,0 +1,5 @@
+class InvalidRelationError(KeyError):
+    def __init__(self, message, related_id, location):
+        self.related_id = related_id
+        self.location = location
+        super().__init__(message)

{oarepo-runtime-1.4.4 → oarepo-runtime-1.4.6}/oarepo_runtime/relations/pid_relation.py

@@ -1,6 +1,7 @@
 from invenio_db import db
 
 from .base import Relation, RelationResult
+from .errors import InvalidRelationError
 from .lookup import LookupResult
 
 
@@ -8,19 +9,23 @@ class PIDRelationResult(RelationResult):
     def resolve(self, id_):
         """Resolve the value using the record class."""
         # TODO: handle permissions here !!!!!!
-        pid_field = self.field.pid_field.field
-        cache_key = (
-            pid_field._provider.pid_type
-            if pid_field._provider
-            else pid_field._pid_type,
-            id_,
-        )
+        pid_field_context = self.field.pid_field
+        if hasattr(pid_field_context, "pid_type"):
+            pid_type = pid_field_context.pid_type
+        else:
+            pid_field = pid_field_context.field
+            pid_type = (
+                pid_field._provider.pid_type
+                if pid_field._provider
+                else pid_field._pid_type
+            )
+        cache_key = (pid_type, id_)
         if cache_key in self.cache:
             obj = self.cache[cache_key]
             return obj
 
         try:
-            obj = self.field.pid_field.resolve(id_)
+            obj = pid_field_context.resolve(id_)
             # We detach the related record model from the database session when
             # we add it in the cache. Otherwise, accessing the cached record
             # model, will execute a new select query after a db.session.commit.
@@ -28,8 +33,10 @@ class PIDRelationResult(RelationResult):
             self.cache[cache_key] = obj
             return obj
         except Exception as e:
-            raise KeyError(
-                f"Repository object {cache_key} has not been found or there was an exception accessing it"
+            raise InvalidRelationError(
+                f"Repository object {cache_key} has not been found or there was an exception accessing it. Referenced from {self.field.key}.",
+                related_id=id_,
+                location=self.field.key,
             ) from e
 
     def _needs_update_relation_value(self, relation: LookupResult):

{oarepo-runtime-1.4.4 → oarepo-runtime-1.4.6/oarepo_runtime.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: oarepo-runtime
-Version: 1.4.4
+Version: 1.4.6
 Summary: A set of runtime extensions of Invenio repository
 Description-Content-Type: text/markdown
 License-File: LICENSE

{oarepo-runtime-1.4.4 → oarepo-runtime-1.4.6}/oarepo_runtime.egg-info/SOURCES.txt

@@ -72,6 +72,7 @@ oarepo_runtime/i18n/validation.py
 oarepo_runtime/relations/__init__.py
 oarepo_runtime/relations/base.py
 oarepo_runtime/relations/components.py
+oarepo_runtime/relations/errors.py
 oarepo_runtime/relations/internal.py
 oarepo_runtime/relations/lookup.py
 oarepo_runtime/relations/mapping.py

{oarepo-runtime-1.4.4 → oarepo-runtime-1.4.6}/setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = oarepo-runtime
-version = 1.4.4
+version = 1.4.6
 description = A set of runtime extensions of Invenio repository
 authors = Alzbeta Pokorna
 readme = README.md