oai-statsig-python-core 0.34.0rc2__tar.gz → 0.34.0rc4__tar.gz

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/Cargo.lock

@@ -1853,7 +1853,7 @@ dependencies = [
 
 [[package]]
 name = "oai-statsig-grpc"
-version = "0.34.0-rc.2"
+version = "0.34.0-rc.4"
 dependencies = [
  "async-trait",
  "chrono",
@@ -1869,7 +1869,7 @@ dependencies = [
 
 [[package]]
 name = "oai-statsig-rust"
-version = "0.34.0-rc.2"
+version = "0.34.0-rc.4"
 dependencies = [
  "ahash",
  "arc-swap",
@@ -3102,7 +3102,7 @@ checksum = "a2eb9349b6444b326872e140eb1cf5e7c522154d69e7a0ffb0fb81c06b37543f"
 
 [[package]]
 name = "statsig-node"
-version = "0.34.0-rc.2"
+version = "0.34.0-rc.4"
 dependencies = [
  "async-trait",
  "napi",
@@ -3117,7 +3117,7 @@ dependencies = [
 
 [[package]]
 name = "statsig-pyo3"
-version = "0.34.0-rc.2"
+version = "0.34.0-rc.4"
 dependencies = [
  "async-trait",
  "lazy_static",
@@ -3132,7 +3132,7 @@ dependencies = [
 
 [[package]]
 name = "statsig_ffi"
-version = "0.34.0-rc.2"
+version = "0.34.0-rc.4"
 dependencies = [
  "async-trait",
  "cbindgen",

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/Cargo.toml

@@ -26,7 +26,7 @@ exclude = [
 [workspace.package]
 edition = "2021"
 license = "ISC"
-version = "0.34.0-rc.2"
+version = "0.34.0-rc.4"
 homepage = "https://statsig.com/"
 authors = ["Statsig", "Daniel Loomb <daniel@statsig.com>"]
 readme = "README.md"

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: oai_statsig_python_core
-Version: 0.34.0rc2
+Version: 0.34.0rc4
 Classifier: Programming Language :: Rust
 Classifier: Programming Language :: Python :: Implementation :: CPython
 Classifier: Programming Language :: Python :: Implementation :: PyPy
@@ -67,9 +67,14 @@ explicit `:443`. Fallback sends no request or SDK credentials to other manifest
 origins; the original request error is returned. Fallback does not follow redirects.
 Custom network providers must implement `send_without_redirects`; otherwise the
 fallback returns an error without sending a request. Fallback preserves the URL's
-path and query, the file identity, and the byte offset for incremental updates.
-Each destination uses its own range protocol: a `range` query for the OpenAI CDN, or `Range` and
-`statsig-id-list-file-size` headers for other hosts.
+path and query except for legacy `range` parameters. It sends `Range`,
+`statsig-id-list-file-size`, and `Accept-Encoding: identity` headers, preserving
+the file identity and byte offset for incremental updates. A `206` response must
+have a valid `Content-Range` matching the requested offset and cover the advertised
+file size. If the CDN returns a full `200` response, the SDK applies only the bytes
+after that offset. Stale or inconsistent responses use the remaining retry budget
+without publishing the refresh. Direct CDN downloads that do not use fallback
+retain the existing `range` query protocol.
 
 Set `fallback_to_statsig_api` to `Some(false)` or leave it unset to keep file
 downloads strictly on the selected destination. There is no second attempt when

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/py_src/statsig_python_core/statsig_python_core.pyi

@@ -359,12 +359,12 @@ class StatsigOptions:
     @property
     def prefer_http2(self) -> typing.Optional[builtins.bool]:
         r"""
-        Prefer HTTP/2 while allowing HTTP/1.1. Unset enables it; False restores the existing transport.
+        Prefer HTTP/2 while allowing HTTP/1.1. Disabled by default; True opts in.
         """
     @prefer_http2.setter
     def prefer_http2(self, value: typing.Optional[builtins.bool]) -> None:
         r"""
-        Prefer HTTP/2 while allowing HTTP/1.1. Unset enables it; False restores the existing transport.
+        Prefer HTTP/2 while allowing HTTP/1.1. Disabled by default; True opts in.
         """
     @property
     def event_logging_flush_interval_ms(self) -> typing.Optional[builtins.int]: ...

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/py_src/statsig_python_core/typed_config.py

@@ -122,7 +122,7 @@ class _TypedConfigs:
         from google.protobuf.json_format import ParseDict
 
         try:
-            value = ParseDict(raw["value"], message_type())
+            value = ParseDict(raw["value"], message_type(), ignore_unknown_fields=True)
         except Exception as error:
             raise TypedConfigConversionError(
                 f"Failed to convert typed config {name!r}"

{oai_statsig_python_core-0.34.0rc2/statsig-pyo3 → oai_statsig_python_core-0.34.0rc4/statsig-grpc}/README.md

@@ -45,9 +45,14 @@ explicit `:443`. Fallback sends no request or SDK credentials to other manifest
 origins; the original request error is returned. Fallback does not follow redirects.
 Custom network providers must implement `send_without_redirects`; otherwise the
 fallback returns an error without sending a request. Fallback preserves the URL's
-path and query, the file identity, and the byte offset for incremental updates.
-Each destination uses its own range protocol: a `range` query for the OpenAI CDN, or `Range` and
-`statsig-id-list-file-size` headers for other hosts.
+path and query except for legacy `range` parameters. It sends `Range`,
+`statsig-id-list-file-size`, and `Accept-Encoding: identity` headers, preserving
+the file identity and byte offset for incremental updates. A `206` response must
+have a valid `Content-Range` matching the requested offset and cover the advertised
+file size. If the CDN returns a full `200` response, the SDK applies only the bytes
+after that offset. Stale or inconsistent responses use the remaining retry budget
+without publishing the refresh. Direct CDN downloads that do not use fallback
+retain the existing `range` query protocol.
 
 Set `fallback_to_statsig_api` to `Some(false)` or leave it unset to keep file
 downloads strictly on the selected destination. There is no second attempt when

{oai_statsig_python_core-0.34.0rc2/statsig-grpc → oai_statsig_python_core-0.34.0rc4/statsig-pyo3}/README.md

@@ -45,9 +45,14 @@ explicit `:443`. Fallback sends no request or SDK credentials to other manifest
 origins; the original request error is returned. Fallback does not follow redirects.
 Custom network providers must implement `send_without_redirects`; otherwise the
 fallback returns an error without sending a request. Fallback preserves the URL's
-path and query, the file identity, and the byte offset for incremental updates.
-Each destination uses its own range protocol: a `range` query for the OpenAI CDN, or `Range` and
-`statsig-id-list-file-size` headers for other hosts.
+path and query except for legacy `range` parameters. It sends `Range`,
+`statsig-id-list-file-size`, and `Accept-Encoding: identity` headers, preserving
+the file identity and byte offset for incremental updates. A `206` response must
+have a valid `Content-Range` matching the requested offset and cover the advertised
+file size. If the CDN returns a full `200` response, the SDK applies only the bytes
+after that offset. Stale or inconsistent responses use the remaining retry budget
+without publishing the refresh. Direct CDN downloads that do not use fallback
+retain the existing `range` query protocol.
 
 Set `fallback_to_statsig_api` to `Some(false)` or leave it unset to keep file
 downloads strictly on the selected destination. There is no second attempt when

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/statsig-pyo3/src/statsig_options_py.rs

@@ -128,7 +128,7 @@ pub struct StatsigOptionsPy {
     pub disable_network: Option<bool>,
     #[pyo3(get, set)]
     pub log_event_connection_reuse: Option<bool>,
-    /// Prefer HTTP/2 while allowing HTTP/1.1. Unset enables it; False restores the existing transport.
+    /// Prefer HTTP/2 while allowing HTTP/1.1. Disabled by default; True opts in.
     #[pyo3(get, set)]
     pub prefer_http2: Option<bool>,
     #[pyo3(get, set)]

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/statsig-pyo3/tests/test_typed_config.py

@@ -274,9 +274,50 @@ def test_unavailable_never_substitutes_previous_value(sdk, payload_state):
     assert sdk.get().value == {}
 
 
+def test_conversion_ignores_unknown_fields_and_enum_names(sdk):
+    sdk.raw = selected(
+        2,
+        {
+            "number": 7,
+            "type": "NEW_UNKNOWN_ENUM_VALUE",
+            "newField": {"enabled": True},
+            "options": {"deprecated": True, "newNestedField": 42},
+        },
+    )
+
+    result = sdk.get(message_type=FieldDescriptorProto)
+
+    assert result.value == FieldDescriptorProto(number=7, options={"deprecated": True})
+    assert result.details.version == 2
+
+
+def test_callback_conversion_ignores_unknown_fields(sdk):
+    callbacks = Queue()
+    sdk.raw = selected(1, {"number": 1, "newField": True})
+    sdk.register(callbacks.put, message_type=FieldDescriptorProto)
+    assert sdk._typed_configs.observers[0].revision == 1
+    assert callbacks.empty()
+
+    sdk.publish(
+        selected(
+            2,
+            {
+                "number": 2,
+                "newField": True,
+                "options": {"deprecated": True, "newNestedField": 42},
+            },
+        )
+    )
+    result = callbacks.get(timeout=5)
+    assert result.value == FieldDescriptorProto(number=2, options={"deprecated": True})
+    assert result.details.version == 2
+    sdk.wait_for_observation()
+    assert sdk._typed_configs.observers[0].error is None
+
+
 def test_conversion_failure_is_explicit_with_cause_for_each_user(sdk):
     sdk.get()
-    sdk.raw = selected(2, {"number": "invalid"})
+    sdk.raw = selected(2, {"number": "invalid", "newField": True})
     for user in (sdk.user, StatsigUser("other")):
         with pytest.raises(TypedConfigConversionError) as caught:
             sdk.get(user=user, message_type=FieldDescriptorProto)

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/statsig-rust/Cargo.toml

@@ -47,7 +47,7 @@ serde_json = { version = "1.0.151", features = [
 ] }
 serde_with = "3.23.0"
 sha2 = "0.11.0"
-oai-statsig-grpc = { path = "../statsig-grpc", version = "0.34.0-rc.2", optional = true }
+oai-statsig-grpc = { path = "../statsig-grpc", version = "0.34.0-rc.4", optional = true }
 simple_logger = { version = "5.2.0" }
 tempfile = "3.27.0"
 tokio = { version = "1.53.1", features = ["full"] }

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/statsig-rust/src/__tests__/statsig_options_tests.rs

@@ -4,8 +4,8 @@ use crate::StatsigOptions;
 fn test_prefer_http2_supported_option() {
     use crate::networking::http2::http2_enabled;
 
-    assert!(http2_enabled(None));
-    assert!(http2_enabled(Some(&StatsigOptions::default())));
+    assert!(!http2_enabled(None));
+    assert!(!http2_enabled(Some(&StatsigOptions::default())));
     for enabled in [true, false] {
         let options = StatsigOptions::builder()
             .prefer_http2(Some(enabled))
@@ -22,7 +22,7 @@ fn test_prefer_http2_supported_option() {
         experimental_flags: Some(["prefer_http2".to_string()].into()),
         ..Default::default()
     };
-    assert!(http2_enabled(Some(&old_flag_only)));
+    assert!(!http2_enabled(Some(&old_flag_only)));
     let explicit_off = StatsigOptions {
         prefer_http2: Some(false),
         ..old_flag_only

oai_statsig_python_core-0.34.0rc4/statsig-rust/src/id_lists_adapter/id_list_fallback_range_tests.rs

@@ -0,0 +1,252 @@
+#[cfg(not(feature = "custom_network_provider"))]
+use super::tests::{TestIdListsUpdateListener, with_local_cdn};
+use super::*;
+#[cfg(not(feature = "custom_network_provider"))]
+use mockito::Server;
+
+const CDN_FILE: &str =
+    "https://statsigcdn.openai.com/v1/download_id_list_file/company%2Fids?private=true";
+#[cfg(not(feature = "custom_network_provider"))]
+const PATH: &str = "/v1/download_id_list_file/company%2Fids?private=true";
+
+#[test]
+fn fallback_range_rejects_invalid_or_stale_responses() {
+    for (status, range, start, size, body) in [
+        (206, None, 3, 6, "+b\n"),
+        (206, Some("invalid"), 3, 6, "+b\n"),
+        (206, Some("bytes 0-2/6"), 3, 6, "+b\n"),
+        (206, Some("bytes 3-5/6"), 3, 6, "+b"),
+        (206, Some("bytes 3-5/5"), 3, 6, "+b\n"),
+        (206, Some("bytes 3-5/*"), 3, 6, "+b\n"),
+        (206, Some("bytes 3-5/6"), 3, 9, "+b\n"),
+        (206, Some("bytes 3-18446744073709551615/6"), 3, 6, "+b\n"),
+        (200, None, 3, 6, "+a\n"),
+        (200, None, 9, 6, "+a\n+b\n"),
+        (200, Some("bytes 3-5/6"), 3, 6, "+b\n"),
+        (200, None, 2, 4, "+é\n"),
+        (204, None, 0, 0, ""),
+    ] {
+        assert!(
+            normalize_fallback_download(Some(status), range, start, size, body.into()).is_err(),
+            "accepted {status} {range:?} at {start} for size {size}"
+        );
+    }
+}
+
+#[test]
+fn fallback_range_handles_empty_files_and_growth_past_manifest() {
+    for (status, header, start, size, body, expected, end) in [
+        (200, None, 0, 0, "", "", 0),
+        (200, None, 0, 3, "+a\n+b\n", "+a\n+b\n", 6),
+        (200, None, 3, 6, "+a\n+b\n+c\n", "+b\n+c\n", 9),
+        (206, Some("bytes 3-8/9"), 3, 6, "+b\n+c\n", "+b\n+c\n", 9),
+    ] {
+        let (delta, range) =
+            normalize_fallback_download(Some(status), header, start, size, body.into()).unwrap();
+        assert_eq!(delta, expected);
+        assert_eq!(range, start..end);
+    }
+}
+
+#[test]
+fn fallback_range_removes_legacy_query_ranges_without_losing_other_parameters() {
+    let request = StatsigHttpIdListsAdapter::id_list_file_request_args(
+        &format!("{CDN_FILE}&range=0-&token=a%2Bb&Range=10-"),
+        17,
+        42,
+        None,
+        true,
+    );
+    let url = url::Url::parse(&request.url).unwrap();
+    let params: HashMap<_, _> = url.query_pairs().collect();
+    assert_eq!(params.len(), 2);
+    assert_eq!(params["private"], "true");
+    assert_eq!(params["token"], "a+b");
+    assert_eq!(url.path(), "/v1/download_id_list_file/company%2Fids");
+    assert!(request.query_params.is_none());
+    assert_eq!(request.headers.as_ref().unwrap()["Range"], "bytes=17-");
+    assert_eq!(
+        request.headers.as_ref().unwrap()["statsig-id-list-file-size"],
+        "42"
+    );
+}
+
+#[tokio::test]
+#[cfg(not(feature = "custom_network_provider"))]
+async fn fallback_range_preserves_membership_and_offsets_across_growth_and_replacement() {
+    for partial in [false, true] {
+        let mut manifest = Server::new_async().await;
+        let mut proxy = Server::new_async().await;
+        let mut origin = Server::new_async().await;
+        let adapter = StatsigHttpIdListsAdapter::new(
+            "secret-key",
+            &StatsigOptions {
+                id_lists_url: Some(format!("{}/lists", manifest.url())),
+                download_id_list_file_api: Some(proxy.url()),
+                fallback_to_statsig_api: Some(true),
+                ..StatsigOptions::default()
+            },
+        );
+        let (adapter, _provider) = with_local_cdn(adapter, &origin);
+        let listener = Arc::new(TestIdListsUpdateListener {
+            id_lists: RwLock::new(HashMap::new()),
+        });
+        adapter.set_listener(listener.clone());
+
+        // The third update catches offset overshoot after a full-body incremental
+        // response. Replacement must discard the previous generation's members.
+        for (generation, start, body, expected) in [
+            (1, 0, "+a\n+b\n", vec!["a", "b"]),
+            (1, 6, "+a\n+b\n-a\n+c\n", vec!["b", "c"]),
+            (1, 12, "+a\n+b\n-a\n+c\n-b\n+d\n", vec!["c", "d"]),
+            (2, 0, "+replacement\n", vec!["replacement"]),
+        ] {
+            let size = body.len();
+            let manifest_request = manifest
+                .mock("POST", "/lists")
+                .with_body(
+                    serde_json::json!({"list": {
+                        "name": "list", "size": size, "url": CDN_FILE,
+                        "creationTime": generation, "fileID": format!("file-{generation}")
+                    }})
+                    .to_string(),
+                )
+                .expect(1)
+                .create_async()
+                .await;
+            let proxy_request = proxy
+                .mock("GET", PATH)
+                .match_header("range", format!("bytes={start}-").as_str())
+                .with_status(503)
+                .expect(1)
+                .create_async()
+                .await;
+            let mut fallback = origin
+                .mock("GET", PATH)
+                .match_header("range", format!("bytes={start}-").as_str())
+                .match_header("statsig-id-list-file-size", size.to_string().as_str())
+                .match_header("statsig-api-key", "secret-key")
+                .match_header("accept-encoding", "identity")
+                .with_status(if partial { 206 } else { 200 })
+                .with_body(if partial { &body[start..] } else { body })
+                .expect(1);
+            if partial {
+                fallback = fallback.with_header(
+                    "content-range",
+                    &format!("bytes {start}-{}/{size}", size - 1),
+                );
+            }
+            let fallback = fallback.create_async().await;
+            adapter.sync_id_lists().await.unwrap();
+            manifest_request.assert_async().await;
+            proxy_request.assert_async().await;
+            fallback.assert_async().await;
+            let lists = listener.id_lists.read();
+            let list = &lists["list"];
+            assert_eq!(list.metadata.size, size as u64);
+            assert_eq!(
+                *list.ids,
+                expected
+                    .into_iter()
+                    .map(str::to_string)
+                    .collect::<crate::id_lists_adapter::IdListIds>()
+            );
+        }
+    }
+}
+
+#[tokio::test]
+#[cfg(not(feature = "custom_network_provider"))]
+async fn fallback_range_retries_invalid_data_without_publishing_or_advancing() {
+    for (status, header, body) in [
+        (200, None, "+a\n"),
+        (206, Some("bytes 0-2/6"), "+b\n"),
+        (206, Some("bytes 3-5/6"), "+b"),
+        (416, None, ""),
+    ] {
+        let mut manifest = Server::new_async().await;
+        let mut proxy = Server::new_async().await;
+        let mut origin = Server::new_async().await;
+        let metadata = IdListMetadata {
+            name: "list".into(),
+            url: CDN_FILE.into(),
+            size: 6,
+            file_id: Some("file-1".into()),
+            creation_time: 1,
+        };
+        let mut list = crate::id_lists_adapter::IdList::new(metadata.clone());
+        list.apply_update(IdListUpdate {
+            raw_changeset: Some("+a\n".into()),
+            new_metadata: metadata,
+        });
+        let listener = Arc::new(TestIdListsUpdateListener {
+            id_lists: RwLock::new(HashMap::from([("list".into(), list)])),
+        });
+        let manifest_request = manifest
+            .mock("POST", "/lists")
+            .with_body(
+                serde_json::json!({"list": {
+                    "name": "list", "size": 6, "url": CDN_FILE,
+                    "creationTime": 1, "fileID": "file-1"
+                }})
+                .to_string(),
+            )
+            .expect(2)
+            .create_async()
+            .await;
+        let proxy_request = proxy
+            .mock("GET", PATH)
+            .match_header("range", "bytes=3-")
+            .with_status(503)
+            .expect(2)
+            .create_async()
+            .await;
+        let mut invalid = origin
+            .mock("GET", PATH)
+            .match_header("range", "bytes=3-")
+            .with_status(status)
+            .with_body(body)
+            .expect(2);
+        if let Some(header) = header {
+            invalid = invalid.with_header("content-range", header);
+        }
+        let invalid = invalid.create_async().await;
+        let adapter = StatsigHttpIdListsAdapter::new(
+            "secret-key",
+            &StatsigOptions {
+                id_lists_url: Some(format!("{}/lists", manifest.url())),
+                download_id_list_file_api: Some(proxy.url()),
+                fallback_to_statsig_api: Some(true),
+                ..StatsigOptions::default()
+            },
+        );
+        let (adapter, _provider) = with_local_cdn(adapter, &origin);
+        adapter.set_listener(listener.clone());
+        let error = adapter.sync_id_lists().await.unwrap_err();
+        assert!(matches!(
+            error,
+            StatsigErr::NetworkError(NetworkError::RetriesExhausted(_, _, 3, _))
+        ));
+        invalid.assert_async().await;
+        assert_eq!(listener.id_lists.read()["list"].metadata.size, 3);
+        assert_eq!(
+            *listener.id_lists.read()["list"].ids,
+            crate::id_lists_adapter::IdListIds::from([String::from("a")])
+        );
+        invalid.remove_async().await;
+        let recovered = origin
+            .mock("GET", PATH)
+            .match_header("range", "bytes=3-")
+            .with_status(200)
+            .with_body("+a\n+b\n")
+            .expect(1)
+            .create_async()
+            .await;
+        adapter.sync_id_lists().await.unwrap();
+        assert_eq!(listener.id_lists.read()["list"].metadata.size, 6);
+        assert!(listener.id_lists.read()["list"].ids.contains("b"));
+        recovered.assert_async().await;
+        proxy_request.assert_async().await;
+        manifest_request.assert_async().await;
+    }
+}

{oai_statsig_python_core-0.34.0rc2 → oai_statsig_python_core-0.34.0rc4}/statsig-rust/src/id_lists_adapter/id_list_propagation.rs

@@ -103,7 +103,8 @@ impl IdListPropagationState {
     }
 }
 
-// This proof is only for telemetry. An absent/invalid range never fails a download.
+// Legacy downloads use this proof only for telemetry. Header-based CDN fallback
+// also validates the interval before applying the bytes as an incremental update.
 pub(super) fn downloaded_range(
     status: Option<u16>,
     content_range: Option<&str>,