novelWriter 2.4.3__tar.gz → 2.4.4__tar.gz

{novelwriter-2.4.3 → novelwriter-2.4.4}/CHANGELOG.md

@@ -1,5 +1,31 @@
 # novelWriter Changelog
 
+## Version 2.4.4 [2024-06-12]
+
+### Release Notes
+
+This is a patch release that fixes a usage issue when setting document label from an unsaved
+document, fixes a rare chance of a crash when closing the Manuscript tool, and updates the
+Portuguese translation.
+
+### Detailed Changelog
+
+**Bugfixes**
+
+* Backported some memory improvements from the upcoming 2.5 release. This also fixes a potential,
+  but low probability crash in the Manuscript tool. If the tool is closed during the milliseconds
+  long window when the clock on the yellow label is updated, the app can crash with a segmentation
+  fault. PRs #1903 and #1905.
+* Fixed an issue where changing a document's label to match the document heading would suggest the
+  wrong title if the document was open in the editor, but in an unsaved state. An easy condition to
+  encounter when creating a new document and setting the heading first. Issue #1914. PR #1923.
+
+**Internationalisation**
+
+* Portuguese translation updated by Oli Maia. PR #1904.
+
+----
+
 ## Version 2.4.3 [2024-05-20]
 
 ### Release Notes
@@ -12,14 +38,14 @@ the spell check dictionary install tool.
 
 **Bugfixes**
 
-* Fix a crash in the dictionaries install tool on Windows if the config folder reported by the
+* Fixed a crash in the dictionaries install tool on Windows if the config folder reported by the
   third party Enchant spell checker tool didn't already exist prior to adding new dictionaries.
   The folder is now created when the tool is opened if it doesn't exist. Issue #1874. PR #1876.
-* Fix issues setting a different text font for the editor and viewer, and related issues with the
-  preview in the Manuscript Build tool, on certain platforms. Changing the font and setting
-  non-standard font sizes produced unexpected results when reloading. The issue seems to be related
-  to Qt 5.15.3, but that is not fully confirmed. However, the only place so far where the issue is
-  observed is on Mint 21.3. Issues #1862 and #1875. PR #1877.
+* Fixed issues when setting a different text font for the editor and viewer, and related issues
+  with the preview in the Manuscript Build tool, on certain platforms. Changing the font and
+  setting non-standard font sizes produced unexpected results when reloading. The issue seems to be
+  related to Qt 5.15.3, but that is not fully confirmed. However, the only place so far where the
+  issue is observed is on Mint 21.3. Issues #1862 and #1875. PR #1877.
 
 ----
 

{novelwriter-2.4.3 → novelwriter-2.4.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: novelWriter
-Version: 2.4.3
+Version: 2.4.4
 Summary: A markdown-like text editor for planning and writing novels
 Author-email: Veronica Berglyd Olsen <code@vkbo.net>
 License: GNU General Public License v3

{novelwriter-2.4.3 → novelwriter-2.4.4}/novelWriter.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: novelWriter
-Version: 2.4.3
+Version: 2.4.4
 Summary: A markdown-like text editor for planning and writing novels
 Author-email: Veronica Berglyd Olsen <code@vkbo.net>
 License: GNU General Public License v3

{novelwriter-2.4.3 → novelwriter-2.4.4}/novelwriter/__init__.py

@@ -47,9 +47,9 @@ __license__    = "GPLv3"
 __author__     = "Veronica Berglyd Olsen"
 __maintainer__ = "Veronica Berglyd Olsen"
 __email__      = "code@vkbo.net"
-__version__    = "2.4.3"
-__hexversion__ = "0x020403f0"
-__date__       = "2024-05-20"
+__version__    = "2.4.4"
+__hexversion__ = "0x020404f0"
+__date__       = "2024-06-12"
 __status__     = "Stable"
 __domain__     = "novelwriter.io"
 

novelwriter-2.4.4/novelwriter/assets/i18n/project_pt_BR.json

@@ -0,0 +1,116 @@
+{
+  "Synopsis": "Sinopse",
+  "Short Description": "Descrição breve",
+  "Comment": "Comentário",
+  "Notes": "Notas",
+  "Tag": "Etiqueta",
+  "Point of View": "Ponto de vista",
+  "Focus": "Foco",
+  "Characters": "Personagens",
+  "Plot": "Trama",
+  "Timeline": "Linha do tempo",
+  "Locations": "Lugares",
+  "Objects": "Objetos",
+  "Entities": "Entidades",
+  "Custom": "Outros",
+  "0": "Zero",
+  "1": "Um",
+  "2": "Dois",
+  "3": "Três",
+  "4": "Quatro",
+  "5": "Cinco",
+  "6": "Seis",
+  "7": "Sete",
+  "8": "Oito",
+  "9": "Nove",
+  "10": "Dez",
+  "11": "Onze",
+  "12": "Doze",
+  "13": "Treze",
+  "14": "Quatorze",
+  "15": "Quinze",
+  "16": "Dezesseis",
+  "17": "Dezessete",
+  "18": "Dezoito",
+  "19": "Dezenove",
+  "20": "Vinte",
+  "21": "Vinte e um",
+  "22": "Vinte e dois",
+  "23": "Vinte e três",
+  "24": "Vinte e quatro",
+  "25": "Vinte e cinco",
+  "26": "Vinte e seis",
+  "27": "Vinte e sete",
+  "28": "Vinte e oito",
+  "29": "Vinte e nove",
+  "30": "Trinta",
+  "31": "Trinta e um",
+  "32": "Trinta e dois",
+  "33": "Trinta e três",
+  "34": "Trinta e quatro",
+  "35": "Trinta e cinco",
+  "36": "Trinta e seis",
+  "37": "Trinta e sete",
+  "38": "Trinta e oito",
+  "39": "Trinta e nove",
+  "40": "Quarenta",
+  "41": "Quarenta e um",
+  "42": "Quarenta e dois",
+  "43": "Quarenta e três",
+  "44": "Quarenta e quatro",
+  "45": "Quarenta e cinco",
+  "46": "Quarenta e seis",
+  "47": "Quarenta e sete",
+  "48": "Quarenta e oito",
+  "49": "Quarenta e nove",
+  "50": "Cinquenta",
+  "51": "Cinquenta e um",
+  "52": "Cinquenta e dois",
+  "53": "Cinquenta e três",
+  "54": "Cinquenta e quatro",
+  "55": "Cinquenta e cinco",
+  "56": "Cinquenta e seis",
+  "57": "Cinquenta e sete",
+  "58": "Cinquenta e oito",
+  "59": "Cinquenta e nove",
+  "60": "Sessenta",
+  "61": "Sessenta e um",
+  "62": "Sessenta e dois",
+  "63": "Sessenta e três",
+  "64": "Sessenta e quatro",
+  "65": "Sessenta e cinco",
+  "66": "Sessenta e seis",
+  "67": "Sessenta e sete",
+  "68": "Sessenta e oito",
+  "69": "Sessenta e nove",
+  "70": "Setenta",
+  "71": "Setenta e um",
+  "72": "Setenta e dois",
+  "73": "Setenta e três",
+  "74": "Setenta e quatro",
+  "75": "Setenta e cinco",
+  "76": "Setenta e seis",
+  "77": "Setenta e sete",
+  "78": "Setenta e oito",
+  "79": "Setenta e nove",
+  "80": "Oitenta",
+  "81": "Oitenta e um",
+  "82": "Oitenta e dois",
+  "83": "Oitenta e três",
+  "84": "Oitenta e quatro",
+  "85": "Oitenta e cinco",
+  "86": "Oitenta e seis",
+  "87": "Oitenta e sete",
+  "88": "Oitenta e oito",
+  "89": "Oitenta e nove",
+  "90": "Noventa",
+  "91": "Noventa e um",
+  "92": "Noventa e dois",
+  "93": "Noventa e três",
+  "94": "Noventa e quatro",
+  "95": "Noventa e cinco",
+  "96": "Noventa e seis",
+  "97": "Noventa e sete",
+  "98": "Noventa e oito",
+  "99": "Noventa e nove"
+}

{novelwriter-2.4.3 → novelwriter-2.4.4}/novelwriter/extensions/modified.py

@@ -27,11 +27,23 @@ from __future__ import annotations
 
 from PyQt5.QtCore import QSize, Qt
 from PyQt5.QtGui import QWheelEvent
-from PyQt5.QtWidgets import QComboBox, QDoubleSpinBox, QSpinBox, QToolButton, QWidget
+from PyQt5.QtWidgets import QComboBox, QDialog, QDoubleSpinBox, QSpinBox, QToolButton, QWidget
 
 from novelwriter import SHARED
 
 
+class NDialog(QDialog):
+
+    def softDelete(self) -> None:
+        """Since calling deleteLater is sometimes not safe from Python,
+        as the C++ object can be deleted before the Python process is
+        done with the object, we instead set the dialog's parent to None
+        so that it gets garbage collected when it runs out of scope.
+        """
+        self.setParent(None)  # type: ignore
+        return
+
+
 class NComboBox(QComboBox):
 
     def __init__(self, parent: QWidget | None = None) -> None:

{novelwriter-2.4.3 → novelwriter-2.4.4}/novelwriter/gui/projtree.py

@@ -32,10 +32,8 @@ from enum import Enum
 from time import time
 from typing import TYPE_CHECKING
 
-from PyQt5.QtCore import QPoint, QTimer, Qt, pyqtSignal, pyqtSlot
-from PyQt5.QtGui import (
-    QDragEnterEvent, QDragMoveEvent, QDropEvent, QIcon, QMouseEvent, QPalette
-)
+from PyQt5.QtCore import QPoint, Qt, QTimer, pyqtSignal, pyqtSlot
+from PyQt5.QtGui import QDragEnterEvent, QDragMoveEvent, QDropEvent, QIcon, QMouseEvent, QPalette
 from PyQt5.QtWidgets import (
     QAbstractItemView, QAction, QDialog, QFrame, QHBoxLayout, QHeaderView,
     QLabel, QMenu, QShortcut, QSizePolicy, QTreeWidget, QTreeWidgetItem,
@@ -44,14 +42,14 @@ from PyQt5.QtWidgets import (
 
 from novelwriter import CONFIG, SHARED
 from novelwriter.common import minmax
-from novelwriter.constants import nwHeaders, nwUnicode, trConst, nwLabels
+from novelwriter.constants import nwHeaders, nwLabels, nwUnicode, trConst
 from novelwriter.core.coretools import DocDuplicator, DocMerger, DocSplitter
 from novelwriter.core.item import NWItem
 from novelwriter.dialogs.docmerge import GuiDocMerge
 from novelwriter.dialogs.docsplit import GuiDocSplit
 from novelwriter.dialogs.editlabel import GuiEditLabel
 from novelwriter.dialogs.projectsettings import GuiProjectSettings
-from novelwriter.enum import nwDocMode, nwItemType, nwItemClass, nwItemLayout
+from novelwriter.enum import nwDocMode, nwItemClass, nwItemLayout, nwItemType
 from novelwriter.extensions.modified import NIconToolButton
 from novelwriter.gui.theme import STYLES_MIN_TOOLBUTTON
 from novelwriter.types import QtAlignLeft, QtAlignRight, QtMouseLeft, QtMouseMiddle, QtUserRole
@@ -1830,6 +1828,7 @@ class _TreeContextMenu(QMenu):
 
     def _itemHeader(self) -> None:
         """Check if there is a header that can be used for rename."""
+        SHARED.ensureEditorSaved(self._handle)
         if hItem := SHARED.project.index.getItemHeading(self._handle, "T0001"):
             action = self.addAction(self.tr("Rename to Heading"))
             action.triggered.connect(

{novelwriter-2.4.3 → novelwriter-2.4.4}/novelwriter/shared.py

@@ -204,6 +204,19 @@ class SharedData(QObject):
         self._resetIdleTimer()
         return
 
+    def ensureEditorSaved(self, tHandle: str | None) -> None:
+        """Ensure that the editor content is saved. Optionally, only if
+        it is a specific handle.
+        """
+        docEditor = self.mainGui.docEditor
+        if (
+            self.hasProject and docEditor.docHandle
+            and (tHandle is None or tHandle == docEditor.docHandle)
+        ):
+            logger.debug("Saving editor document before action")
+            docEditor.saveText()
+        return
+
     def updateSpellCheckLanguage(self, reload: bool = False) -> None:
         """Update the active spell check language from settings."""
         from novelwriter import CONFIG

{novelwriter-2.4.3 → novelwriter-2.4.4}/novelwriter/tools/manuscript.py

@@ -34,10 +34,10 @@ from PyQt5.QtCore import Qt, QTimer, QUrl, pyqtSignal, pyqtSlot
 from PyQt5.QtGui import QCloseEvent, QColor, QCursor, QPalette, QResizeEvent
 from PyQt5.QtPrintSupport import QPrinter, QPrintPreviewDialog
 from PyQt5.QtWidgets import (
-    QAbstractItemView, QApplication, QDialog, QFormLayout, QGridLayout,
-    QHBoxLayout, QLabel, QListWidget, QListWidgetItem, QPushButton,
-    QSizePolicy, QSplitter, QStackedWidget, QTabWidget, QTextBrowser,
-    QTreeWidget, QTreeWidgetItem, QVBoxLayout, QWidget
+    QAbstractItemView, QApplication, QFormLayout, QGridLayout, QHBoxLayout,
+    QLabel, QListWidget, QListWidgetItem, QPushButton, QSizePolicy, QSplitter,
+    QStackedWidget, QTabWidget, QTextBrowser, QTreeWidget, QTreeWidgetItem,
+    QVBoxLayout, QWidget
 )
 
 from novelwriter import CONFIG, SHARED
@@ -48,7 +48,7 @@ from novelwriter.core.tohtml import ToHtml
 from novelwriter.core.tokenizer import HeadingFormatter
 from novelwriter.error import logException
 from novelwriter.extensions.circularprogress import NProgressCircle
-from novelwriter.extensions.modified import NIconToggleButton, NIconToolButton
+from novelwriter.extensions.modified import NDialog, NIconToggleButton, NIconToolButton
 from novelwriter.gui.theme import STYLES_FLAT_TABS, STYLES_MIN_TOOLBUTTON
 from novelwriter.tools.manusbuild import GuiManuscriptBuild
 from novelwriter.tools.manussettings import GuiBuildSettings
@@ -63,7 +63,7 @@ if TYPE_CHECKING:  # pragma: no cover
 logger = logging.getLogger(__name__)
 
 
-class GuiManuscript(QDialog):
+class GuiManuscript(NDialog):
     """GUI Tools: Manuscript Tool
 
     The dialog displays all the users build definitions, a preview panel
@@ -285,7 +285,7 @@ class GuiManuscript(QDialog):
             if isinstance(obj, GuiBuildSettings) and obj.isVisible():
                 obj.close()
         event.accept()
-        self.deleteLater()
+        self.softDelete()
         return
 
     ##
@@ -343,7 +343,7 @@ class GuiManuscript(QDialog):
             return
 
         # Make sure editor content is saved before we start
-        SHARED.mainGui.saveDocument()
+        SHARED.ensureEditorSaved(None)
 
         docBuild = NWBuildDocument(SHARED.project, build)
         docBuild.setPreviewMode(True)

{novelwriter-2.4.3 → novelwriter-2.4.4}/novelwriter/tools/manussettings.py

@@ -30,8 +30,8 @@ from typing import TYPE_CHECKING
 from PyQt5.QtCore import QEvent, Qt, pyqtSignal, pyqtSlot
 from PyQt5.QtGui import QFont, QIcon, QSyntaxHighlighter, QTextCharFormat, QTextDocument
 from PyQt5.QtWidgets import (
-    QAbstractButton, QAbstractItemView, QDialog, QDialogButtonBox, QFontDialog,
-    QFrame, QGridLayout, QHBoxLayout, QHeaderView, QLabel, QLineEdit, QMenu,
+    QAbstractButton, QAbstractItemView, QDialogButtonBox, QFontDialog, QFrame,
+    QGridLayout, QHBoxLayout, QHeaderView, QLabel, QLineEdit, QMenu,
     QPlainTextEdit, QPushButton, QSplitter, QStackedWidget, QTreeWidget,
     QTreeWidgetItem, QVBoxLayout, QWidget
 )
@@ -42,7 +42,9 @@ from novelwriter.core.buildsettings import BuildSettings, FilterMode
 from novelwriter.extensions.configlayout import (
     NColourLabel, NFixedPage, NScrollableForm, NScrollablePage
 )
-from novelwriter.extensions.modified import NComboBox, NDoubleSpinBox, NIconToolButton, NSpinBox
+from novelwriter.extensions.modified import (
+    NComboBox, NDialog, NDoubleSpinBox, NIconToolButton, NSpinBox
+)
 from novelwriter.extensions.pagedsidebar import NPagedSideBar
 from novelwriter.extensions.switch import NSwitch
 from novelwriter.extensions.switchbox import NSwitchBox
@@ -57,7 +59,7 @@ if TYPE_CHECKING:  # pragma: no cover
 logger = logging.getLogger(__name__)
 
 
-class GuiBuildSettings(QDialog):
+class GuiBuildSettings(NDialog):
     """GUI Tools: Manuscript Build Settings Dialog
 
     The main tool for configuring manuscript builds. It's a GUI tool for
@@ -199,7 +201,7 @@ class GuiBuildSettings(QDialog):
         self._askToSaveBuild()
         self._saveSettings()
         event.accept()
-        self.deleteLater()
+        self.softDelete()
         return
 
     ##

novelwriter-2.4.3/novelwriter/assets/i18n/project_pt_BR.json

@@ -1,116 +0,0 @@
-{
-  "Synopsis": "Sinopse",
-  "Short Description": "Descrição breve",
-  "Comment": "Comentários",
-  "Notes": "Notas",
-  "Tag": "Etiqueta",
-  "Point of View": "Ponto de vista",
-  "Focus": "Foco",
-  "Characters": "Personagens",
-  "Plot": "Trama",
-  "Timeline": "Linha do tempo",
-  "Locations": "Lugares",
-  "Objects": "Objetos",
-  "Entities": "Entidades",
-  "Custom": "Outros",
-  "0": "Zero",
-  "1": "Um",
-  "2": "Dois",
-  "3": "Três",
-  "4": "Quatro",
-  "5": "Cinco",
-  "6": "Seis",
-  "7": "Sete",
-  "8": "Oito",
-  "9": "Nove",
-  "10": "Dez",
-  "11": "Onze",
-  "12": "Doze",
-  "13": "Treze",
-  "14": "Quatorze",
-  "15": "Quinze",
-  "16": "Dezesseis",
-  "17": "Dezesete",
-  "18": "Dezoito",
-  "19": "Dezenove",
-  "20": "Vinte",
-  "21": "Vinte e Um",
-  "22": "Vinte e Dois",
-  "23": "Vinte e Três",
-  "24": "Vinte e Quatro",
-  "25": "Vinte e Cinco",
-  "26": "Vinte e Seis",
-  "27": "Vinte e Sete",
-  "28": "Vinte e Oito",
-  "29": "Vinte e Nove",
-  "30": "Trinta",
-  "31": "Trinta e Um",
-  "32": "Trinta e Dois",
-  "33": "Trinta e Três",
-  "34": "Trinta e Quatro",
-  "35": "Trinta e Cinco",
-  "36": "Trinta e Seis",
-  "37": "Trinta e Sete",
-  "38": "Trinta e Oito",
-  "39": "Trinta e Nove",
-  "40": "Quarenta",
-  "41": "Quarenta e Um",
-  "42": "Quarenta e Dois",
-  "43": "Quarenta e Três",
-  "44": "Quarenta e Quatro",
-  "45": "Quarenta e Cinco",
-  "46": "Quarenta e Seis",
-  "47": "Quarenta e Sete",
-  "48": "Quarenta e Oito",
-  "49": "Quarenta e Nove",
-  "50": "Cinquenta",
-  "51": "Cinquenta e Um",
-  "52": "Cinquenta e Dois",
-  "53": "Cinquenta e Três",
-  "54": "Cinquenta e Quatro",
-  "55": "Cinquenta e Cinco",
-  "56": "Cinquenta e Seis",
-  "57": "Cinquenta e Sete",
-  "58": "Cinquenta e Oito",
-  "59": "Cinquenta e Nove",
-  "60": "Sessenta",
-  "61": "Sessenta e Um",
-  "62": "Sessenta e Dois",
-  "63": "Sessenta e Três",
-  "64": "Sessenta e Quatro",
-  "65": "Sessenta e Cinco",
-  "66": "Sessenta e Seis",
-  "67": "Sessenta e Sete",
-  "68": "Sessenta e Oito",
-  "69": "Sessenta e Nove",
-  "70": "Setenta",
-  "71": "Setenta e Um",
-  "72": "Setenta e Dois",
-  "73": "Setenta e Três",
-  "74": "Setenta e Quatro",
-  "75": "Setenta e Cinco",
-  "76": "Setenta e Seis",
-  "77": "Setenta e Sete",
-  "78": "Setenta e Oito",
-  "79": "Setenta e Nove",
-  "80": "Oitenta",
-  "81": "Oitenta e Um",
-  "82": "Oitenta e Dois",
-  "83": "Oitenta e Três",
-  "84": "Oitenta e Quatro",
-  "85": "Oitenta e Cinco",
-  "86": "Oitenta e Seis",
-  "87": "Oitenta e Sete",
-  "88": "Oitenta e Oito",
-  "89": "Oitenta e Nove",
-  "90": "Noventa",
-  "91": "Noventa e Um",
-  "92": "Noventa e Dois",
-  "93": "Noventa e Três",
-  "94": "Noventa e Quatro",
-  "95": "Noventa e Cinco",
-  "96": "Noventa e Seis",
-  "97": "Noventa e Sete",
-  "98": "Noventa e Oito",
-  "99": "Noventa e Nove"
-}