notebook-intelligence 4.7.0__tar.gz → 4.8.0__tar.gz

{notebook_intelligence-4.7.0 → notebook_intelligence-4.8.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: notebook_intelligence
-Version: 4.7.0
+Version: 4.8.0
 Summary: AI coding assistant for JupyterLab
 Project-URL: Homepage, https://github.com/notebook-intelligence/notebook-intelligence
 Project-URL: Bug Tracker, https://github.com/notebook-intelligence/notebook-intelligence/issues

{notebook_intelligence-4.7.0 → notebook_intelligence-4.8.0}/docs/admin-guide.md

@@ -75,28 +75,32 @@ If users share a home directory across nodes (NFS-backed shared HPC, classroom l
 
 The full surface, in one table.
 
-| Name                                | Type | Default                     | Source                             | Purpose                                                                                                                                                             |
-| ----------------------------------- | ---- | --------------------------- | ---------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `disabled_providers`                | List | `[]`                        | traitlet on `NotebookIntelligence` | Hide providers from the user dropdown. Values: `github-copilot`, `ollama`, `litellm-compatible`, `openai-compatible`.                                               |
-| `allow_enabling_providers_with_env` | Bool | `False`                     | traitlet                           | If true, `NBI_ENABLED_PROVIDERS` re-enables hidden providers per pod.                                                                                               |
-| `NBI_ENABLED_PROVIDERS`             | csv  | unset                       | env                                | Comma-separated provider IDs to re-enable. Effective only when `allow_enabling_providers_with_env=True`.                                                            |
-| `disabled_tools`                    | List | `[]`                        | traitlet                           | Hide built-in tools from agent mode. Values listed in [Restricting features](#restricting-features-for-managed-deployments).                                        |
-| `allow_enabling_tools_with_env`     | Bool | `False`                     | traitlet                           | If true, `NBI_ENABLED_BUILTIN_TOOLS` re-enables hidden tools per pod.                                                                                               |
-| `NBI_ENABLED_BUILTIN_TOOLS`         | csv  | unset                       | env                                | Comma-separated tool IDs to re-enable. Effective only when `allow_enabling_tools_with_env=True`.                                                                    |
-| `enable_chat_feedback`              | Bool | `False`                     | traitlet                           | Enables thumbs-up/down UI in chat and emits in-process `telemetry` events.                                                                                          |
-| `skills_manifest`                   | str  | `""`                        | traitlet                           | URL or filesystem path to a managed-skills manifest. See [`docs/skills.md`](skills.md#managed-skills-via-an-org-manifest).                                          |
-| `NBI_SKILLS_MANIFEST`               | str  | unset                       | env (overrides traitlet)           | Same as above; env takes precedence.                                                                                                                                |
-| `skills_manifest_interval`          | int  | `86400`                     | traitlet                           | Seconds between reconciles.                                                                                                                                         |
-| `NBI_SKILLS_MANIFEST_INTERVAL`      | int  | unset                       | env (overrides traitlet)           | Same as above; env takes precedence.                                                                                                                                |
-| `managed_skills_token`              | str  | `""`                        | traitlet                           | Bearer token for managed-skills GitHub fetches.                                                                                                                     |
-| `NBI_MANAGED_SKILLS_TOKEN`          | str  | unset                       | env (overrides traitlet)           | Same as above; env takes precedence.                                                                                                                                |
-| `NBI_GH_ACCESS_TOKEN_PASSWORD`      | str  | `nbi-access-token-password` | env                                | Password used to encrypt the stored Copilot token in `user-data.json`. **Change in multi-tenant deployments.**                                                      |
-| `NBI_RULES_AUTO_RELOAD`             | bool | `true`                      | env                                | When `false`, ruleset edits require a JupyterLab restart to take effect.                                                                                            |
-| `NBI_CLAUDE_CLI_PATH`               | str  | unset                       | env                                | Absolute path to the Claude Code CLI binary. When unset, NBI looks up `claude` on `PATH`.                                                                           |
-| `NBI_GHE_SUBDOMAIN`                 | str  | `""`                        | env                                | GitHub Enterprise subdomain for GitHub Copilot users on a GHE tenant. Empty selects github.com.                                                                     |
-| `NBI_LOG_LEVEL`                     | str  | `INFO`                      | env                                | Python logging level for the `notebook_intelligence` logger.                                                                                                        |
-| `GITHUB_TOKEN`, `GH_TOKEN`          | str  | unset                       | env                                | Used (in that order) by user-initiated skill imports for GitHub auth. Falls back to `gh` CLI auth.                                                                  |
-| `NBI_*_POLICY`                      | str  | `user-choice`               | env                                | Lock individual Settings panel toggles. See [README → Admin policies](../README.md#admin-policies) for the full list of `*_POLICY` env vars and matching traitlets. |
+| Name                                           | Type | Default                     | Source                             | Purpose                                                                                                                                                                                             |
+| ---------------------------------------------- | ---- | --------------------------- | ---------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| `disabled_providers`                           | List | `[]`                        | traitlet on `NotebookIntelligence` | Hide providers from the user dropdown. Values: `github-copilot`, `ollama`, `litellm-compatible`, `openai-compatible`.                                                                               |
+| `allow_enabling_providers_with_env`            | Bool | `False`                     | traitlet                           | If true, `NBI_ENABLED_PROVIDERS` re-enables hidden providers per pod.                                                                                                                               |
+| `NBI_ENABLED_PROVIDERS`                        | csv  | unset                       | env                                | Comma-separated provider IDs to re-enable. Effective only when `allow_enabling_providers_with_env=True`.                                                                                            |
+| `disabled_tools`                               | List | `[]`                        | traitlet                           | Hide built-in tools from agent mode. Values listed in [Restricting features](#restricting-features-for-managed-deployments).                                                                        |
+| `allow_enabling_tools_with_env`                | Bool | `False`                     | traitlet                           | If true, `NBI_ENABLED_BUILTIN_TOOLS` re-enables hidden tools per pod.                                                                                                                               |
+| `NBI_ENABLED_BUILTIN_TOOLS`                    | csv  | unset                       | env                                | Comma-separated tool IDs to re-enable. Effective only when `allow_enabling_tools_with_env=True`.                                                                                                    |
+| `enable_chat_feedback`                         | Bool | `False`                     | traitlet                           | Enables thumbs-up/down UI in chat and emits in-process `telemetry` events.                                                                                                                          |
+| `additional_skipped_workspace_directories`     | List | `[]`                        | traitlet                           | Extra directory names to skip in the chat-sidebar @-mention workspace file picker. Merged with the built-in skips (`__pycache__`, `node_modules`). Match is by directory name only, case-sensitive. |
+| `NBI_ADDITIONAL_SKIPPED_WORKSPACE_DIRECTORIES` | csv  | unset                       | env (appends to traitlet)          | Comma-separated extra directory names. Resolved at server startup and concatenated with the traitlet value, so a spawn profile can add to (rather than replace) the org-wide list.                  |
+| `allow_github_skill_import`                    | Bool | `True`                      | traitlet                           | When `False`, hides the **Import from GitHub** button in the Skills panel and rejects `/skills/import` POSTs with 403. Does not affect the managed-skills reconciler.                               |
+| `NBI_ALLOW_GITHUB_SKILL_IMPORT`                | bool | unset                       | env (overrides traitlet)           | Per-pod override for `allow_github_skill_import`. Accepts `true`/`false`/`1`/`0`/`yes`/`no`/`on`/`off` (case-insensitive). Useful for varying the policy across spawn profiles.                     |
+| `skills_manifest`                              | str  | `""`                        | traitlet                           | URL or filesystem path to a managed-skills manifest. See [`docs/skills.md`](skills.md#managed-skills-via-an-org-manifest).                                                                          |
+| `NBI_SKILLS_MANIFEST`                          | str  | unset                       | env (overrides traitlet)           | Same as above; env takes precedence.                                                                                                                                                                |
+| `skills_manifest_interval`                     | int  | `86400`                     | traitlet                           | Seconds between reconciles.                                                                                                                                                                         |
+| `NBI_SKILLS_MANIFEST_INTERVAL`                 | int  | unset                       | env (overrides traitlet)           | Same as above; env takes precedence.                                                                                                                                                                |
+| `managed_skills_token`                         | str  | `""`                        | traitlet                           | Bearer token for managed-skills GitHub fetches.                                                                                                                                                     |
+| `NBI_MANAGED_SKILLS_TOKEN`                     | str  | unset                       | env (overrides traitlet)           | Same as above; env takes precedence.                                                                                                                                                                |
+| `NBI_GH_ACCESS_TOKEN_PASSWORD`                 | str  | `nbi-access-token-password` | env                                | Password used to encrypt the stored Copilot token in `user-data.json`. **Change in multi-tenant deployments.**                                                                                      |
+| `NBI_RULES_AUTO_RELOAD`                        | bool | `true`                      | env                                | When `false`, ruleset edits require a JupyterLab restart to take effect.                                                                                                                            |
+| `NBI_CLAUDE_CLI_PATH`                          | str  | unset                       | env                                | Absolute path to the Claude Code CLI binary. When unset, NBI looks up `claude` on `PATH`.                                                                                                           |
+| `NBI_GHE_SUBDOMAIN`                            | str  | `""`                        | env                                | GitHub Enterprise subdomain for GitHub Copilot users on a GHE tenant. Empty selects github.com.                                                                                                     |
+| `NBI_LOG_LEVEL`                                | str  | `INFO`                      | env                                | Python logging level for the `notebook_intelligence` logger.                                                                                                                                        |
+| `GITHUB_TOKEN`, `GH_TOKEN`                     | str  | unset                       | env                                | Used (in that order) by user-initiated skill imports for GitHub auth. Falls back to `gh` CLI auth.                                                                                                  |
+| `NBI_*_POLICY`                                 | str  | `user-choice`               | env                                | Lock individual Settings panel toggles. See [README → Admin policies](../README.md#admin-policies) for the full list of `*_POLICY` env vars and matching traitlets.                                 |
 
 Configure traitlets in `jupyter_server_config.py`:
 
@@ -315,6 +319,44 @@ NBI_ENABLED_BUILTIN_TOOLS=nbi-notebook-execute,nbi-python-file-edit
 
 NBI does not currently support an explicit allowlist mode (`allowed_providers`, `allowed_tools`). A new built-in provider added in a minor release would auto-enable for users with `disabled_providers=[]`. If this matters for your compliance posture, pin to specific NBI versions and review changelog entries before upgrading. Tracked as a feature request.
 
+### Disabling user-initiated GitHub Skill imports
+
+```python
+c.NotebookIntelligence.allow_github_skill_import = False
+```
+
+Hides the **Import from GitHub** button in the Skills panel and rejects POSTs to `/notebook-intelligence/skills/import` and `/notebook-intelligence/skills/import/preview` with HTTP 403. This does **not** disable the [managed-skills reconciler](#managed-claude-skills-token); admin-curated skills delivered via `NBI_SKILLS_MANIFEST` continue to install. Use this when you want to allow only org-vetted skills.
+
+To vary the policy per spawn profile, override at pod startup:
+
+```bash
+NBI_ALLOW_GITHUB_SKILL_IMPORT=false
+```
+
+The env var wins over the traitlet and is resolved at server startup. Recognized values: `true`/`false`/`1`/`0`/`yes`/`no`/`on`/`off`, case-insensitive. Unrecognized values raise at startup so a typo can't silently flip the policy.
+
+### Tuning the chat-sidebar workspace file picker
+
+**Audience:** server admins. End users can't override this — ask your admin to add or remove entries.
+
+The @-mention picker in the chat sidebar enumerates files from the JupyterLab working directory and skips a built-in set of directories (`__pycache__`, `node_modules`) plus any dotfiles/dot-directories. Because dot-prefixed names are filtered separately, entries starting with `.` in the list below are no-ops; list non-dot names only.
+
+To extend the directory skip set without editing the codebase:
+
+```python
+c.NotebookIntelligence.additional_skipped_workspace_directories = ["build", "dist", "target"]
+```
+
+Match is by directory name only (not path), case-sensitive. Use this when a project has standard build outputs the picker shouldn't surface.
+
+To vary the list per spawn profile, append entries via env at pod startup:
+
+```bash
+NBI_ADDITIONAL_SKIPPED_WORKSPACE_DIRECTORIES=tmp,artifacts
+```
+
+The env var **appends** to the traitlet value at server startup (in contrast to `NBI_ALLOW_GITHUB_SKILL_IMPORT` and the `NBI_*_POLICY` env vars, which override). Duplicates are collapsed; both lists are then merged with the built-in skip set on the frontend.
+
 ---
 
 ## Multi-tenancy and per-team scoping

{notebook_intelligence-4.7.0 → notebook_intelligence-4.8.0}/notebook_intelligence/_version.py

@@ -1,4 +1,4 @@
 # This file is auto-generated by Hatchling. As such, do not:
 #   - modify
 #   - track in version control e.g. be sure to add to .gitignore
-__version__ = VERSION = '4.7.0'
+__version__ = VERSION = '4.8.0'

{notebook_intelligence-4.7.0 → notebook_intelligence-4.8.0}/notebook_intelligence/config.py

@@ -3,7 +3,9 @@
 import json
 import logging
 import os
+import stat
 import sys
+import tempfile
 from typing import Optional
 
 from notebook_intelligence.feature_flags import (
@@ -94,11 +96,8 @@ class NBIConfig:
         # TODO: save only diff
         os.makedirs(self.nbi_user_dir, exist_ok=True)
 
-        with open(self.user_config_file, 'w') as file:
-            json.dump(self.user_config, file, indent=2)
-
-        with open(self.user_mcp_file, 'w') as file:
-            json.dump(self.user_mcp, file, indent=2)
+        _atomic_write_json(self.user_config_file, self.user_config)
+        _atomic_write_json(self.user_mcp_file, self.user_mcp)
 
     def get(self, key, default=None):
         return self.user_config.get(key, self.env_config.get(key, default))
@@ -211,3 +210,71 @@ class NBIConfig:
         active_rules = self.active_rules.copy()
         active_rules[filename] = active
         self.set('active_rules', active_rules)
+
+
+def _atomic_write_json(target: str, payload: dict) -> None:
+    """Crash-safe replacement for ``open(target, 'w') + json.dump``.
+
+    Plain truncating writes leave the destination empty (or partial)
+    if the process is killed mid-write — the next launch then chokes on
+    a corrupt config. Write to a sibling tempfile, ``fsync``, and
+    ``os.replace`` so the swap is atomic on POSIX and atomic-ish on
+    Windows.
+
+    Symlink-preserving: a user who symlinks ``~/.jupyter/nbi/config.json``
+    to a shared config file expects ``save()`` to update the link's
+    target, not replace the link itself. Resolve via ``realpath`` first.
+
+    Mode-preserving: ``mkstemp`` returns a 0o600 file; if the existing
+    config has different permissions (e.g. 0o644 for a shared install),
+    re-apply them after the swap so the user's chmod isn't silently
+    undone.
+
+    Durability: ``fsync`` the tempfile, then ``fsync`` the target's
+    parent directory on POSIX so the rename itself survives a crash.
+    """
+    real_target = os.path.realpath(target)
+    target_dir = os.path.dirname(real_target) or '.'
+    existing_mode = None
+    try:
+        existing_mode = stat.S_IMODE(os.stat(real_target).st_mode)
+    except FileNotFoundError:
+        pass
+    fd, tmp_path = tempfile.mkstemp(
+        prefix='.' + os.path.basename(real_target) + '.',
+        suffix='.tmp',
+        dir=target_dir,
+    )
+    try:
+        with os.fdopen(fd, 'w', encoding='utf-8') as fh:
+            json.dump(payload, fh, indent=2)
+            fh.flush()
+            os.fsync(fh.fileno())
+        if existing_mode is not None:
+            try:
+                os.chmod(tmp_path, existing_mode)
+            except OSError:
+                # Some filesystems (FAT, certain network mounts) reject chmod;
+                # the swap itself is still safe, just lose the mode bits.
+                pass
+        os.replace(tmp_path, real_target)
+    except Exception:
+        # Best-effort cleanup — if replace failed the tempfile is dangling.
+        try:
+            os.unlink(tmp_path)
+        except OSError:
+            pass
+        raise
+    # ``os.replace`` makes the new inode visible, but until the directory
+    # entry is fsynced a power-loss can still leave the rename unrecorded
+    # on POSIX. Windows has no ``O_RDONLY`` directory descriptor, so skip
+    # there and rely on its rename semantics.
+    if hasattr(os, 'O_DIRECTORY'):
+        try:
+            dir_fd = os.open(target_dir, os.O_RDONLY)
+            try:
+                os.fsync(dir_fd)
+            finally:
+                os.close(dir_fd)
+        except OSError:
+            pass

{notebook_intelligence-4.7.0 → notebook_intelligence-4.8.0}/notebook_intelligence/extension.py

@@ -155,6 +155,45 @@ def _resolve_policy_with_env(env_var_name: str, traitlet_value: str) -> str:
     return traitlet_value
 
 
+_TRUE_VALUES = frozenset({"true", "1", "yes", "on"})
+_FALSE_VALUES = frozenset({"false", "0", "no", "off"})
+_BOOL_ENV_VOCAB = "true, false, 1, 0, yes, no, on, off"
+
+
+def _resolve_csv_appended(env_var_name: str, traitlet_value):
+    """Merge a traitlet List with the comma-separated env-var value (append).
+
+    Env *adds to* the traitlet list rather than replacing it — the use case
+    is per-pod profiles layering on an org-wide baseline. Whitespace around
+    each token is stripped, empty segments are dropped, and exact duplicates
+    are collapsed while preserving first-seen order.
+    """
+    base = list(traitlet_value or [])
+    raw = os.environ.get(env_var_name, "")
+    extras = [name.strip() for name in raw.split(",") if name.strip()]
+    return list(dict.fromkeys(base + extras))
+
+
+def _resolve_bool_with_env(env_var_name: str, fallback: bool | None) -> bool:
+    """Resolve a boolean admin gate: env var wins if recognized, else fallback.
+
+    Raises ValueError when the env var is set but unrecognized — silent
+    fall-back can flip a security gate either direction depending on the
+    fallback polarity, so a typo must surface at startup. ``None`` fallback
+    is coerced to ``False``.
+    """
+    env_value = os.environ.get(env_var_name, "").strip().lower()
+    if not env_value:
+        return bool(fallback)
+    if env_value in _TRUE_VALUES:
+        return True
+    if env_value in _FALSE_VALUES:
+        return False
+    raise ValueError(
+        f"Invalid {env_var_name}={env_value!r}: must be one of {_BOOL_ENV_VOCAB}"
+    )
+
+
 # Single source of truth for the boolean policies. Each entry is
 # ``(policy_name, env_var, traitlet_attr)``. Drives env-var resolution, the
 # capabilities response, and the lock-rejection set in ConfigHandler.
@@ -279,6 +318,8 @@ class GetCapabilitiesHandler(APIHandler):
     disabled_providers = []
     allow_enabling_providers_with_env = False
     enable_chat_feedback = False
+    allow_github_skill_import = True
+    additional_skipped_workspace_directories = []
     feature_policies = {}
     string_overrides = {}
 
@@ -365,6 +406,8 @@ class GetCapabilitiesHandler(APIHandler):
             "claude_cli_available": shutil.which("claude") is not None,
             "default_chat_mode": nbi_config.default_chat_mode,
             "chat_feedback_enabled": self.enable_chat_feedback,
+            "allow_github_skill_import": self.allow_github_skill_import,
+            "additional_skipped_workspace_directories": self.additional_skipped_workspace_directories,
             "cell_output_features": _build_cell_output_features_response(
                 self.feature_policies.get("explain_error", POLICY_USER_CHOICE),
                 self.feature_policies.get("output_followup", POLICY_USER_CHOICE),
@@ -654,10 +697,19 @@ class RulesReloadHandler(APIHandler):
 class SkillsBaseHandler(APIHandler):
     """Shared helpers for skills endpoints."""
 
+    allow_github_skill_import = True
+
     @property
     def skill_manager(self):
         return ai_service_manager.get_skill_manager()
 
+    def _reject_if_github_import_disabled(self) -> bool:
+        if self.allow_github_skill_import:
+            return False
+        self.set_status(403)
+        self.finish(json.dumps({"error": "GitHub Skill import is disabled by configuration"}))
+        return True
+
     def _error(self, exc):
         if isinstance(exc, FileExistsError):
             self.set_status(409)
@@ -765,6 +817,8 @@ class SkillDetailHandler(SkillsBaseHandler):
 class SkillsImportPreviewHandler(SkillsBaseHandler):
     @tornado.web.authenticated
     def post(self):
+        if self._reject_if_github_import_disabled():
+            return
         data = self._parse_json_body()
         if data is None:
             return
@@ -783,6 +837,8 @@ class SkillsImportPreviewHandler(SkillsBaseHandler):
 class SkillsImportHandler(SkillsBaseHandler):
     @tornado.web.authenticated
     def post(self):
+        if self._reject_if_github_import_disabled():
+            return
         data = self._parse_json_body()
         if data is None:
             return
@@ -1653,6 +1709,38 @@ class NotebookIntelligence(ExtensionApp):
         config=True,
     )
 
+    allow_github_skill_import = Bool(
+        default_value=True,
+        help="""
+        Allow importing Skills from GitHub via the Skills panel. Set to False
+        to hide the "Import from GitHub" affordance and reject backend imports.
+        Overridden by the NBI_ALLOW_GITHUB_SKILL_IMPORT env var.
+        """,
+        allow_none=True,
+        config=True,
+    )
+
+    additional_skipped_workspace_directories = List(
+        trait=Unicode(),
+        default_value=None,
+        help="""
+        Extra directory names to skip when enumerating workspace files for
+        the chat-sidebar @-mention picker. Merged with the built-in skip set
+        (`__pycache__`, `node_modules`); dotfiles and dot-directories are
+        already filtered separately, so entries starting with `.` are no-ops.
+
+        The NBI_ADDITIONAL_SKIPPED_WORKSPACE_DIRECTORIES env var (csv)
+        appends to this list at server startup so spawn profiles can vary
+        the policy without forking config.
+
+        Match is by directory name only (not path), case-sensitive.
+
+        Example: ['build', 'dist', 'target']
+        """,
+        allow_none=True,
+        config=True,
+    )
+
     explain_error_policy = TraitletEnum(
         list(VALID_POLICIES),
         default_value=POLICY_USER_CHOICE,
@@ -1903,6 +1991,17 @@ class NotebookIntelligence(ExtensionApp):
         GetCapabilitiesHandler.disabled_providers = self.disabled_providers
         GetCapabilitiesHandler.allow_enabling_providers_with_env = self.allow_enabling_providers_with_env
         GetCapabilitiesHandler.enable_chat_feedback = self.enable_chat_feedback
+        allow_github_skill_import = _resolve_bool_with_env(
+            "NBI_ALLOW_GITHUB_SKILL_IMPORT", self.allow_github_skill_import
+        )
+        GetCapabilitiesHandler.allow_github_skill_import = allow_github_skill_import
+        SkillsBaseHandler.allow_github_skill_import = allow_github_skill_import
+        GetCapabilitiesHandler.additional_skipped_workspace_directories = (
+            _resolve_csv_appended(
+                "NBI_ADDITIONAL_SKIPPED_WORKSPACE_DIRECTORIES",
+                self.additional_skipped_workspace_directories,
+            )
+        )
         self._publish_policies(feature_policies, string_overrides)
         NotebookIntelligence.handlers = [
             (route_pattern_capabilities, GetCapabilitiesHandler),

{notebook_intelligence-4.7.0 → notebook_intelligence-4.8.0}/notebook_intelligence/labextension/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@notebook-intelligence/notebook-intelligence",
-  "version": "4.7.0",
+  "version": "4.8.0",
   "description": "AI coding assistant for JupyterLab",
   "keywords": [
     "AI",
@@ -142,7 +142,7 @@
       }
     },
     "_build": {
-      "load": "static/remoteEntry.556389fd0da7df9338c0.js",
+      "load": "static/remoteEntry.64319537c5af580d82c4.js",
       "extension": "./extension",
       "style": "./style"
     }

{notebook_intelligence-4.7.0 → notebook_intelligence-4.8.0}/notebook_intelligence/labextension/schemas/@notebook-intelligence/notebook-intelligence/package.json.orig

@@ -1,6 +1,6 @@
 {
     "name": "@notebook-intelligence/notebook-intelligence",
-    "version": "4.7.0",
+    "version": "4.8.0",
     "description": "AI coding assistant for JupyterLab",
     "keywords": [
         "AI",