nominal 1.104.0__tar.gz → 1.104.2__tar.gz

{nominal-1.104.0 → nominal-1.104.2}/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [1.104.2](https://github.com/nominal-io/nominal-client/compare/v1.104.1...v1.104.2) (2026-01-08)
+
+
+### Bug Fixes
+
+* explicitly pin version of urllib to fix CVE ([#571](https://github.com/nominal-io/nominal-client/issues/571)) ([2014e51](https://github.com/nominal-io/nominal-client/commit/2014e51d95e8cf804b1dce269402b2671f5153f8))
+
+## [1.104.1](https://github.com/nominal-io/nominal-client/compare/v1.104.0...v1.104.1) (2026-01-08)
+
+
+### Bug Fixes
+
+* add asset_rid to data_review request ([#508](https://github.com/nominal-io/nominal-client/issues/508)) ([b1baf4f](https://github.com/nominal-io/nominal-client/commit/b1baf4f3745ee8a485ff0407a53ad9ee1ee9b0fc))
+
 ## [1.104.0](https://github.com/nominal-io/nominal-client/compare/v1.103.0...v1.104.0) (2026-01-08)
 
 

{nominal-1.104.0 → nominal-1.104.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: nominal
-Version: 1.104.0
+Version: 1.104.2
 Summary: Automate Nominal workflows in Python
 Project-URL: Homepage, https://nominal.io
 Project-URL: Documentation, https://docs.nominal.io
@@ -33,6 +33,7 @@ Requires-Dist: tabulate<0.10,>=0.9.0
 Requires-Dist: truststore>=0.10.4
 Requires-Dist: types-cachetools>=6.0.0.20250525
 Requires-Dist: typing-extensions<5,>=4
+Requires-Dist: urllib3==2.6.3
 Provides-Extra: protos
 Requires-Dist: nominal-api-protos>=0.949.2; extra == 'protos'
 Provides-Extra: tdms

{nominal-1.104.0 → nominal-1.104.2}/nominal/core/data_review.py

@@ -20,8 +20,10 @@ from typing_extensions import Self, deprecated
 
 from nominal.core import checklist, event
 from nominal.core._clientsbunch import HasScoutParams
-from nominal.core._utils.api_tools import HasRid
+from nominal.core._utils.api_tools import HasRid, rid_from_instance_or_string
+from nominal.core.asset import Asset
 from nominal.core.exceptions import NominalMethodRemovedError
+from nominal.core.run import Run
 from nominal.ts import IntegralNanosecondsUTC, _SecondsNanos
 
 
@@ -162,8 +164,81 @@ class DataReviewBuilder:
         self._integration_rids.append(integration_rid)
         return self
 
-    def add_request(self, run_rid: str, checklist_rid: str, commit: str) -> DataReviewBuilder:
-        self._requests.append(scout_datareview_api.CreateDataReviewRequest(checklist_rid, run_rid, commit))
+    @deprecated(
+        "`DataReviewBuilder.add_request` is deprecated and will be removed in a future release of the Nominal SDK. "
+        "Please use `DataReviewBuilder.execute_checklist` instead."
+    )
+    def add_request(
+        self,
+        run_rid: str,
+        checklist_rid: str,
+        commit: str | None = None,
+        *,
+        asset_rid: str | None = None,
+    ) -> DataReviewBuilder:
+        """Add a request to create a data review for the given checklist and run.
+
+        Args:
+            run_rid: RID of the Run to run the Checklist on
+            checklist_rid: RID of the checklist to execute on the Run
+            commit: Commit hash of the version of the checklist to run, or the latest version if None is provided
+            asset_rid: RID of the asset to run the checklist on within the Run (only required for multi-asset runs)
+
+        Returns:
+            DataReviewBuilder instance to continue building a data review with
+        """
+        return self.execute_checklist(run_rid, checklist_rid, commit=commit, asset=asset_rid)
+
+    def execute_checklist(
+        self,
+        run: str | Run,
+        checklist: str | checklist.Checklist,
+        *,
+        commit: str | None = None,
+        asset: str | Asset | None = None,
+    ) -> Self:
+        """Add a request to create a data review for the given checklist and run.
+
+        Args:
+            run: Instance or rid of the Run to run the Checklist on
+            checklist: Instance or rid of the checklist to execute on the Run
+            commit: Commit hash of the version of the checklist to run, or the latest version if None is provided
+            asset: Instance or rid of the asset to run the checklist on within the Run
+                NOTE: only required for multi-asset runs
+
+        Returns:
+            DataReviewBuilder instance to continue building a data review with
+
+        Raises:
+            ValueError: If the given run has multiple associated assets and no asset was specified, or
+                if the run has an asset that differs from the provided asset.
+        """
+        checklist_rid = rid_from_instance_or_string(checklist)
+        run_rid = rid_from_instance_or_string(run)
+        asset_rid = None if asset is None else rid_from_instance_or_string(asset)
+
+        raw_run = self._clients.run.get_run(self._clients.auth_header, run_rid)
+        if len(raw_run.assets) > 1 and asset is None:
+            raise ValueError(
+                f"Cannot run data review on checklist {checklist_rid} and {run_rid} without specifying `asset_rid`: "
+                f"run has {len(raw_run.assets)} assets!"
+            )
+        elif len(raw_run.assets) == 1 and asset_rid is not None:
+            raw_asset_rid = raw_run.assets[0]
+            if raw_asset_rid != asset_rid:
+                raise ValueError(
+                    f"Cannot run data review on checklist {checklist_rid} and {run_rid} with asset {asset_rid}: "
+                    f"run has a different asset {raw_asset_rid}!"
+                )
+
+        self._requests.append(
+            scout_datareview_api.CreateDataReviewRequest(
+                checklist_rid=checklist_rid,
+                run_rid=run_rid,
+                asset_rid=asset_rid,
+                commit=commit,
+            )
+        )
         return self
 
     def add_tags(self, tags: list[str]) -> DataReviewBuilder:
@@ -174,8 +249,7 @@ class DataReviewBuilder:
         """Initiates a batch data review process.
 
         Args:
-            wait_for_completion (bool): If True, waits for the data review process to complete before returning.
-                                        Default is True.
+            wait_for_completion: If True, waits for the data review process to complete before returning.
         """
         request = scout_datareview_api.BatchInitiateDataReviewRequest(
             notification_configurations=[

{nominal-1.104.0 → nominal-1.104.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "nominal"
-version = "1.104.0"
+version = "1.104.2"
 description = "Automate Nominal workflows in Python"
 authors = [
     { name = "Alexander Reynolds", email = "alex.reynolds@nominal.io" },
@@ -49,6 +49,8 @@ dependencies = [
     # list only the exact platforms supported
     # TODO(drake): support more architectures and clean up dependency markers.
     "nominal-streaming==0.5.8; platform_python_implementation=='CPython' and python_version>='3.10' and ((sys_platform=='win32' and platform_machine=='AMD64') or (sys_platform=='darwin' and platform_machine=='arm64') or (sys_platform=='linux' and (platform_machine=='x86_64' or platform_machine=='armv7l')))",
+    # Explicitly specifying urllib3 version to handle CVE present in earlier versions
+    "urllib3==2.6.3",
 ]
 
 
@@ -173,10 +175,6 @@ disable_error_code = ["no-untyped-def"]
 [tool.pytest.ini_options]
 filterwarnings = [
     "error", # transform all warnings into errors, except ignore: ones.
-    # DeprecationWarning: The 'strict' parameter is no longer needed on Python 3+. This will raise an error in urllib3 v2.1.0.
-    # from conjure-python-client, in conjure_python_client/_http/requests_client.py,
-    # TransportAdapter.init_poolmanager() uses urllib3.poolmanager.PoolManager(..., strict=True) which is deprecated.
-    "ignore:The 'strict' parameter is no longer needed on Python 3+.",
 ]
 testpaths = ["tests"]
 # make tests/e2e opt-in (they require a Nominal instance)