nomad-schema-plugin-simulation-workflow 1.0.8__tar.gz → 1.0.10__tar.gz

{nomad_schema_plugin_simulation_workflow-1.0.8/nomad_schema_plugin_simulation_workflow.egg-info → nomad_schema_plugin_simulation_workflow-1.0.10}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.2
+Metadata-Version: 2.4
 Name: nomad-schema-plugin-simulation-workflow
-Version: 1.0.8
+Version: 1.0.10
 Summary: Simulation workflow schema plugin for NOMAD.
 Author: The NOMAD Authors
 License: Apache-2.0
@@ -8,12 +8,13 @@ Project-URL: homepage, https://github.com/nomad-coe/nomad-schema-plugin-simulati
 Requires-Python: >=3.9
 Description-Content-Type: text/markdown
 License-File: LICENSE
-Requires-Dist: nomad-lab>=1.3.6.dev1
+Requires-Dist: nomad-lab>=1.3.13
 Requires-Dist: nomad-schema-plugin-run>=1.0.1
 Requires-Dist: mdanalysis<3.0.0,>=2.8.0; python_full_version >= "3.10"
 Requires-Dist: mdanalysis<2.8; python_full_version < "3.10"
 Requires-Dist: scipy>=1.7.1
 Requires-Dist: networkx>=2.6.3
+Dynamic: license-file
 
 [![DOI](https://zenodo.org/badge/744481756.svg)](https://zenodo.org/badge/latestdoi/744481756)
 

{nomad_schema_plugin_simulation_workflow-1.0.8 → nomad_schema_plugin_simulation_workflow-1.0.10/nomad_schema_plugin_simulation_workflow.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.2
+Metadata-Version: 2.4
 Name: nomad-schema-plugin-simulation-workflow
-Version: 1.0.8
+Version: 1.0.10
 Summary: Simulation workflow schema plugin for NOMAD.
 Author: The NOMAD Authors
 License: Apache-2.0
@@ -8,12 +8,13 @@ Project-URL: homepage, https://github.com/nomad-coe/nomad-schema-plugin-simulati
 Requires-Python: >=3.9
 Description-Content-Type: text/markdown
 License-File: LICENSE
-Requires-Dist: nomad-lab>=1.3.6.dev1
+Requires-Dist: nomad-lab>=1.3.13
 Requires-Dist: nomad-schema-plugin-run>=1.0.1
 Requires-Dist: mdanalysis<3.0.0,>=2.8.0; python_full_version >= "3.10"
 Requires-Dist: mdanalysis<2.8; python_full_version < "3.10"
 Requires-Dist: scipy>=1.7.1
 Requires-Dist: networkx>=2.6.3
+Dynamic: license-file
 
 [![DOI](https://zenodo.org/badge/744481756.svg)](https://zenodo.org/badge/latestdoi/744481756)
 

{nomad_schema_plugin_simulation_workflow-1.0.8 → nomad_schema_plugin_simulation_workflow-1.0.10}/nomad_schema_plugin_simulation_workflow.egg-info/requires.txt

@@ -1,4 +1,4 @@
-nomad-lab>=1.3.6.dev1
+nomad-lab>=1.3.13
 nomad-schema-plugin-run>=1.0.1
 scipy>=1.7.1
 networkx>=2.6.3

{nomad_schema_plugin_simulation_workflow-1.0.8 → nomad_schema_plugin_simulation_workflow-1.0.10}/pyproject.toml

@@ -10,7 +10,7 @@ readme = "README.md"
 authors = [{ name = "The NOMAD Authors" }]
 license = { text = "Apache-2.0" }
 dependencies = [
-    "nomad-lab>=1.3.6.dev1",
+    "nomad-lab>=1.3.13",
     "nomad-schema-plugin-run>=1.0.1",
     "mdanalysis>=2.8.0,<3.0.0 ; python_full_version >= '3.10'",
     "mdanalysis<2.8 ; python_full_version < '3.10'",
@@ -24,9 +24,9 @@ homepage = "https://github.com/nomad-coe/nomad-schema-plugin-simulation-workflow
 
 [tool.uv]
 dev-dependencies = [
-    "nomad-normalizer-plugin-bandstructure",
-    "nomad-normalizer-plugin-system",
-    'mypy==1.0.1',
+    "nomad-normalizer-plugin-bandstructure>=1.0.3",
+    "nomad-normalizer-plugin-system>=1.0.3",
+    'mypy>=1.15',
     'pytest>= 5.3.0, <8',
     'pytest-timeout>=1.4.2',
     'pytest-cov>=2.7.1',

{nomad_schema_plugin_simulation_workflow-1.0.8 → nomad_schema_plugin_simulation_workflow-1.0.10}/simulationworkflowschema/general.py

@@ -15,7 +15,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-from typing import List
 import numpy as np
 
 from nomad.datamodel.data import ArchiveSection
@@ -129,9 +128,9 @@ class SimulationWorkflow(Workflow):
     def normalize(self, archive, logger):
         super().normalize(archive, logger)
 
-        self._calculations: List[Calculation] = []
-        self._systems: List[System] = []
-        self._methods: List[Method] = []
+        self._calculations: list[ArchiveSection] = []  # noqa
+        self._systems: list[ArchiveSection] = []  # noqa
+        self._methods: list[ArchiveSection] = []  # noqa
         try:
             self._calculations = archive.run[-1].calculation
             self._systems = archive.run[-1].system

{nomad_schema_plugin_simulation_workflow-1.0.8 → nomad_schema_plugin_simulation_workflow-1.0.10}/simulationworkflowschema/molecular_dynamics.py

@@ -15,15 +15,15 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-from typing import List, Dict, Any, Callable
+from typing import Any, Callable, Optional
 from itertools import chain
 from collections import namedtuple
 import numpy as np
 from array import array
-from nptyping import Int, NDArray
 from scipy import sparse
 from scipy.stats import linregress
 import networkx
+import numpy as np
 import MDAnalysis
 from MDAnalysis.core.topology import Topology
 from MDAnalysis.core.universe import Universe
@@ -105,7 +105,7 @@ class BeadGroup(object):
 
 def get_bond_list_from_model_contributions(
     sec_run: MSection, method_index: int = -1, model_index: int = -1
-) -> List[tuple]:
+) -> list[tuple]:
     """
     Generates bond list of tuples using the list of bonded force field interactions stored under run[].method[].force_field.model[].
 
@@ -139,12 +139,12 @@ def create_empty_universe(
     n_frames: int = 1,
     n_residues: int = 1,
     n_segments: int = 1,
-    atom_resindex: NDArray[Int] = None,
-    residue_segindex: NDArray[Int] = None,
+    atom_resindex: Optional[np.ndarray] = None,
+    residue_segindex: Optional[np.ndarray] = None,
     flag_trajectory: bool = False,
     flag_velocities: bool = False,
     flag_forces: bool = False,
-    timestep: float = None,
+    timestep: Optional[float] = None,
 ) -> MDAnalysis.Universe:
     """Create a blank Universe
 
@@ -208,13 +208,13 @@ def create_empty_universe(
         n_segments = 0
 
     if atom_resindex is None:
-        LOGGER.warn(
+        LOGGER.warning(
             'Residues specified but no atom_resindex given.  '
             'All atoms will be placed in first Residue.',
         )
 
     if residue_segindex is None:
-        LOGGER.warn(
+        LOGGER.warning(
             'Segments specified but no segment_resindex given.  '
             'All residues will be placed in first Segment',
         )
@@ -314,7 +314,7 @@ def archive_to_universe(
         sec_atoms_group = sec_system_top.atoms_group
         sec_calculation = sec_run.calculation
         sec_method = (
-            sec_run.method[method_index] if sec_run.get('method') is not None else None
+            sec_run.method[method_index] if sec_run.get('method') is not None else {}
         )
     except IndexError:
         LOGGER.warning(
@@ -327,7 +327,7 @@ def archive_to_universe(
         LOGGER.warning('No atoms found in the archive. Cannot build the MDA universe.')
         return None
 
-    n_frames = len(sec_system) if sec_system is not None else None
+    n_frames = len(sec_system) if sec_system is not None else 1
     atom_names = sec_atoms.get('labels')
     model_atom_parameters = sec_method.get('atom_parameters')
     atom_types = (
@@ -514,8 +514,8 @@ def archive_to_universe(
         n_frames=n_frames,
         n_residues=n_residues,
         n_segments=n_segments,
-        atom_resindex=atom_resindex,
-        residue_segindex=residue_segindex,
+        atom_resindex=np.array(atom_resindex),
+        residue_segindex=np.array(residue_segindex),
         flag_trajectory=True,
         flag_velocities=True,
         timestep=system_timestep.magnitude,
@@ -556,12 +556,17 @@ def archive_to_universe(
 
 
 def _get_molecular_bead_groups(
-    universe: MDAnalysis.Universe, moltypes: List[str] = None
-) -> Dict[str, BeadGroup]:
+    universe: MDAnalysis.Universe, moltypes: list[str] = []
+) -> dict[str, BeadGroup]:
     """
     Creates bead groups based on the molecular types as defined by the MDAnalysis universe.
     """
-    if moltypes is None:
+    # Input validation
+    if universe is None:
+        LOGGER.warning('Universe required to create beads.')
+        return {}
+
+    if not moltypes:
         atoms_moltypes = getattr(universe.atoms, 'moltypes', [])
         moltypes = np.unique(atoms_moltypes)
     bead_groups = {}
@@ -581,24 +586,42 @@ def _get_molecular_bead_groups(
 
 def calc_molecular_rdf(
     universe: MDAnalysis.Universe,
+    bead_groups: dict[str, BeadGroup],
     n_traj_split: int = 10,
     n_prune: int = 1,
     interval_indices=None,
     max_mols: int = 5000,
-) -> Dict:
+) -> dict[str, Any]:
     """
     Calculates the radial distribution functions between for each unique pair of
     molecule types as a function of their center of mass distance.
 
-    interval_indices: 2D array specifying the groups of the n_traj_split intervals to be averaged
-    max_mols: the maximum number of molecules per bead group for calculating the rdf, for efficiency purposes.
+    Parameters
+    ----------
+    universe : MDAnalysis.Universe
+        The MDAnalysis universe object.
+    bead_groups : dict[str, BeadGroup]
+        Precomputed bead groups for the universe.
+    n_traj_split : int
+        Number of intervals to split trajectory into for averaging.
+    n_prune : int
+        Pruning parameter for frames.
+    interval_indices : list or None
+        2D array specifying the groups of the n_traj_split intervals to be averaged.
+    max_mols : int
+        Maximum number of molecules per bead group for calculating the rdf, for efficiency purposes.
     """
     # TODO 5k default for max_mols was set after > 50k was giving problems. Should do further testing to see where the appropriate limit should be set.
+    if bead_groups is None or not bead_groups:
+        LOGGER.warning('bead_groups required to calculate RDF.')
+        return {}
+
     if (
         not universe
         or not universe.trajectory
         or universe.trajectory[0].dimensions is None
     ):
+        LOGGER.warning('universe required to calculate RDF.')
         return {}
 
     n_frames = universe.trajectory.n_frames
@@ -623,10 +646,9 @@ def calc_molecular_rdf(
         if not interval_indices:
             interval_indices = [[i] for i in range(n_traj_split)]
 
-    bead_groups = _get_molecular_bead_groups(universe)
     if not bead_groups:
         return bead_groups
-    moltypes = [moltype for moltype in bead_groups.keys()]
+    moltypes = list(bead_groups.keys())
     del_list = [
         i_moltype
         for i_moltype, moltype in enumerate(moltypes)
@@ -639,7 +661,7 @@ def calc_molecular_rdf(
     n_bins = 200
     n_smooth = 2
 
-    rdf_results: Dict[str, Any] = {}
+    rdf_results: dict[str, Any] = {}
     rdf_results['n_smooth'] = n_smooth
     rdf_results['n_prune'] = n_prune
     rdf_results['type'] = 'molecular'
@@ -663,7 +685,7 @@ def calc_molecular_rdf(
             else:
                 exclusion_block = None
             pair_type = f'{moltype_i}-{moltype_j}'
-            rdf_results_interval: Dict[str, Any] = {}
+            rdf_results_interval: dict[str, Any] = {}
             rdf_results_interval['types'] = []
             rdf_results_interval['variables_name'] = []
             rdf_results_interval['bins'] = []
@@ -756,14 +778,14 @@ def __log_indices(first: int, last: int, num: int = 100):
     return np.unique(np.int_(ls) - 1 + first)
 
 
-def __correlation(function, positions: List[float]):
+def __correlation(function, positions: list[float]):
     iterator = iter(positions)
     start_frame = next(iterator)
     return map(lambda f: function(start_frame, f), chain([start_frame], iterator))
 
 
 def _calc_diffusion_constant(
-    times: NDArray, values: NDArray, dim: int = 3
+    times: np.ndarray, values: np.ndarray, dim: int = 3
 ) -> tuple[float, float]:
     """
     Determines the diffusion constant from a fit of the mean squared displacement
@@ -777,14 +799,14 @@ def _calc_diffusion_constant(
 
 def shifted_correlation_average(
     function: Callable,
-    times: NDArray,
-    positions: NDArray,
+    times: np.ndarray,
+    positions: np.ndarray,
     index_distribution: Callable = __log_indices,
     correlation: Callable = __correlation,
     segments: int = 10,
     window: float = 0.5,
     skip: int = 0,
-) -> tuple[NDArray, NDArray]:
+) -> tuple[np.ndarray, np.ndarray]:
     """
     Code adapted from MDevaluate module: https://github.com/mdevaluate/mdevaluate.git
 
@@ -830,8 +852,8 @@ def shifted_correlation_average(
         >>> indices, data = shifted_correlation(msd, coords)
     """
     if window + skip >= 1:
-        LOGGER.warn(
-            'Invalid parameters for shifted_correlation(), ' 'resetting to defaults.',
+        LOGGER.warning(
+            'Invalid parameters for shifted_correlation(), resetting to defaults.',
         )
         window = 0.5
         skip = 0
@@ -855,7 +877,7 @@ def shifted_correlation_average(
 
     correlation_times = np.array([times[i] for i in idx]) - times[0]
 
-    result: NDArray
+    result: np.ndarray
     for i_start_frame, start_frame in enumerate(start_frames):
         if i_start_frame == 0:
             result = np.array(list(correlate(start_frame)))
@@ -868,14 +890,22 @@ def shifted_correlation_average(
 
 
 def calc_molecular_mean_squared_displacements(
-    universe: MDAnalysis.Universe, max_mols: int = 5000
-) -> Dict:
+    universe: MDAnalysis.Universe,
+    bead_groups: dict[str, BeadGroup],
+    max_mols: int = 5000,
+) -> dict[str, Any]:
     """
     Calculates the mean squared displacement for the center of mass of each
     molecule type.
 
-    max_mols: the maximum number of molecules per bead group for calculating the msd, for efficiency purposes.
-    50k was tested and is very fast and does not seem to have any memory issues.
+    Parameters
+    ----------
+    universe : MDAnalysis.Universe
+        The MDAnalysis universe object.
+    bead_groups : dict[str, BeadGroup]
+        Precomputed bead groups for the universe.
+    max_mols : int
+        Maximum number of molecules per bead group for calculating the msd, for efficiency purposes.
     """
 
     def parse_jumps(
@@ -926,7 +956,7 @@ def calc_molecular_mean_squared_displacements(
 
     def get_nojump_positions(
         universe: MDAnalysis.Universe, selection: MDAnalysis.AtomGroup
-    ) -> NDArray:
+    ) -> np.ndarray:
         """
         Unwraps the positions to create a continuous trajectory without jumps across periodic boundaries.
         """
@@ -945,23 +975,28 @@ def calc_molecular_mean_squared_displacements(
 
         return np.array(nojump_positions)
 
-    def mean_squared_displacement(start: NDArray, current: NDArray):
+    def mean_squared_displacement(start: np.ndarray, current: np.ndarray):
         """
         Calculates mean square displacement between current and initial (start) coordinates.
         """
         vec = start - current
         return (vec**2).sum(axis=1).mean()
 
+    if bead_groups is None or not bead_groups:
+        LOGGER.warning('bead_groups required to calculate MSD.')
+        return {}
+
     if (
         not universe
         or not universe.trajectory
         or universe.trajectory[0].dimensions is None
     ):
+        LOGGER.warning('universe required to calculate MSD.')
         return {}
 
     n_frames = universe.trajectory.n_frames
     if n_frames < 50:
-        LOGGER.warn(
+        LOGGER.warning(
             'At least 50 frames required to calculate molecular'
             ' mean squared displacements, skipping.',
         )
@@ -969,14 +1004,13 @@ def calc_molecular_mean_squared_displacements(
 
     dt = getattr(universe.trajectory, 'dt')
     if dt is None:
-        LOGGER.warn(
+        LOGGER.warning(
             'Universe is missing time step, cannot calculate molecular'
             ' mean squared displacements, skipping.',
         )
         return {}
     times = np.arange(n_frames) * dt
 
-    bead_groups = _get_molecular_bead_groups(universe)
     if bead_groups is {}:
         return bead_groups
 
@@ -985,7 +1019,7 @@ def calc_molecular_mean_squared_displacements(
     for i_moltype, moltype in enumerate(moltypes):
         if len(bead_groups[moltype].positions) > max_mols:
             if max_mols > 50000:
-                LOGGER.warn(
+                LOGGER.warning(
                     'Calculating mean squared displacements for more than 50k molecules.'
                     ' Expect long processing times!',
                 )
@@ -1000,18 +1034,18 @@ def calc_molecular_mean_squared_displacements(
                     np.random.choice(molnum_types, size=max_mols)
                 )
                 atom_indices_rnd = np.concatenate(
-                    [np.where(molnums == molnum)[0] for molnum in molnum_types_rnd]
+                    [moltype_indices[molnums == molnum] for molnum in molnum_types_rnd]
                 )
                 selection = ' '.join([str(i) for i in atom_indices_rnd])
                 selection = f'index {selection}'
                 ags_moltype_rnd = universe.select_atoms(selection)
                 bead_groups[moltype] = BeadGroup(ags_moltype_rnd, compound='fragments')
-                LOGGER.warn(
+                LOGGER.warning(
                     'Maximum number of molecules for calculating the msd has been reached.'
                     ' Will make a random selection for calculation.'
                 )
             except Exception:
-                LOGGER.warn(
+                LOGGER.warning(
                     'Error in selecting random molecules for large group when calculating msd. Skipping this molecule type.'
                 )
                 del_list.append(i_moltype)
@@ -1019,7 +1053,7 @@ def calc_molecular_mean_squared_displacements(
     for index in sorted(del_list, reverse=True):
         del moltypes[index]
 
-    msd_results: Dict[str, Any] = {}
+    msd_results: dict[str, Any] = {}
     msd_results['type'] = 'molecular'
     msd_results['direction'] = 'xyz'
     msd_results['value'] = []
@@ -1052,21 +1086,31 @@ def calc_molecular_mean_squared_displacements(
 
 
 def calc_radius_of_gyration(
-    universe: MDAnalysis.Universe, molecule_atom_indices: NDArray
-) -> Dict:
+    universe: MDAnalysis.Universe, molecule_atom_indices: np.ndarray
+) -> dict[str, Any]:
     """
     Calculates the radius of gyration as a function of time for the atoms 'molecule_atom_indices'.
+
+    molecule_atom_indices : np.ndarray
+        The indices of the atoms corresponding to a single molecule for which the Rg will be calculated.
     """
+    if molecule_atom_indices is None or len(molecule_atom_indices) == 0:
+        LOGGER.warning(
+            'molecule_atom_indices is required to calculate radius of gyration'
+        )
+        return {}
+
     if (
         not universe
         or not universe.trajectory
         or universe.trajectory[0].dimensions is None
     ):
+        LOGGER.warning('universe is None. Cannot calculate radius of gyration.')
         return {}
     selection = ' '.join([str(i) for i in molecule_atom_indices])
     selection = f'index {selection}'
     molecule = universe.select_atoms(selection)
-    rg_results: Dict[str, Any] = {}
+    rg_results: dict[str, Any] = {}
     rg_results['type'] = 'molecular'
     rg_results['times'] = []
     rg_results['value'] = []
@@ -1091,11 +1135,17 @@ def calc_radius_of_gyration(
 
 def calc_molecular_radius_of_gyration(
     universe: MDAnalysis.Universe, system_topology: MSection
-) -> List[Dict]:
+) -> list[dict[str, Any]]:
     """
     Calculates the radius of gyration as a function of time for each polymer in the system.
     """
-    if not system_topology:
+    if universe is None:
+        LOGGER.warning('universe required to calculate molecular radius of gyration')
+        return []
+    if system_topology is None or not system_topology:
+        LOGGER.warning(
+            'system_topology require to calculate molecular radius of gyration.'
+        )
         return []
 
     rg_results = []
@@ -1115,10 +1165,10 @@ def calc_molecular_radius_of_gyration(
 
 def get_molecules_from_bond_list(
     n_particles: int,
-    bond_list: List[tuple],
-    particle_types: List[str] = None,
-    particles_typeid: array = None,
-) -> List[Dict]:
+    bond_list: list[tuple],
+    particle_types: list[str] = [],
+    particles_typeid: Optional[array] = None,
+) -> list[dict[str, Any]]:
     """
     Returns a list of dictionaries with molecule info from each instance in the list of bonds.
     """
@@ -1128,8 +1178,8 @@ def get_molecules_from_bond_list(
         system_graph.subgraph(c).copy()
         for c in networkx.connected_components(system_graph)
     ]
-    molecule_info: List[Dict] = []
-    molecule_dict: Dict = {}
+    molecule_info: list[dict[str, Any]] = []
+    molecule_dict: dict[str, Any] = {}
     for mol in molecules:
         molecule_dict = {}
         molecule_dict['indices'] = np.array(mol.nodes())
@@ -1183,7 +1233,7 @@ def is_same_molecule(mol_1: dict, mol_2: dict) -> bool:
     return False
 
 
-def get_composition(children_names: List[str]) -> str:
+def get_composition(children_names: list[str]) -> str:
     """
     Generates a generalized "chemical formula" based on the provided list `children_names`,
     with the format X(m)Y(n) for children_names X and Y of quantities m and n, respectively.
@@ -2536,10 +2586,6 @@ class MolecularDynamicsResults(ThermodynamicsResults):
         sub_section=CorrelationFunction.m_def, repeats=True
     )
 
-    radial_distribution_functions = SubSection(
-        sub_section=RadialDistributionFunction.m_def, repeats=True
-    )
-
     radius_of_gyration = SubSection(sub_section=RadiusOfGyration, repeats=True)
 
     mean_squared_displacements = SubSection(
@@ -2564,6 +2610,8 @@ class MolecularDynamicsResults(ThermodynamicsResults):
         if universe is None:
             return
 
+        bead_groups = _get_molecular_bead_groups(universe)
+
         # calculate molecular radial distribution functions
         if not self.radial_distribution_functions:
             n_traj_split = (
@@ -2586,6 +2634,7 @@ class MolecularDynamicsResults(ThermodynamicsResults):
             n_prune = int(universe.trajectory.n_frames / len(archive.run[-1].system))
             rdf_results = calc_molecular_rdf(
                 universe,
+                bead_groups,
                 n_traj_split=n_traj_split,
                 n_prune=n_prune,
                 interval_indices=interval_indices,
@@ -2598,7 +2647,9 @@ class MolecularDynamicsResults(ThermodynamicsResults):
 
         # calculate the molecular mean squared displacements
         if not self.mean_squared_displacements:
-            msd_results = calc_molecular_mean_squared_displacements(universe)
+            msd_results = calc_molecular_mean_squared_displacements(
+                universe, bead_groups
+            )
             if msd_results:
                 sec_msds = MeanSquaredDisplacement()
                 sec_msds._msd_results = msd_results
@@ -2627,7 +2678,7 @@ class MolecularDynamicsResults(ThermodynamicsResults):
             for rg in rg_results:
                 n_frames = rg.get('n_frames')
                 if len(sec_systems) != n_frames:
-                    self.logger.warning(
+                    logger.warning(
                         'Mismatch in length of system references in calculation and calculated Rg values.'
                         'Will not store Rg values under calculation section'
                     )

{nomad_schema_plugin_simulation_workflow-1.0.8 → nomad_schema_plugin_simulation_workflow-1.0.10}/simulationworkflowschema/thermodynamics.py

@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 import numpy as np
-from nptyping import NDArray
+from typing import Optional
 
 from nomad.datamodel.data import ArchiveSection
 from nomad.metainfo import SubSection, Section, Quantity, Reference, derived
@@ -189,7 +189,7 @@ class ThermodynamicsResults(SimulationWorkflowResults):
         """,
         cached=True,
     )
-    def heat_capacity_c_v_specific(self) -> NDArray:
+    def heat_capacity_c_v_specific(self) -> Optional[np.ndarray]:
         """Returns the specific heat capacity by dividing the heat capacity per
         cell with the mass of the atoms in the cell.
         """
@@ -197,7 +197,7 @@ class ThermodynamicsResults(SimulationWorkflowResults):
 
         workflow = self.m_parent
         if not workflow._systems or not workflow._systems[0].atoms:
-            return
+            return None
         atomic_numbers = workflow._systems[0].atoms.species
         mass_per_unit_cell = nomad.atomutils.get_summed_atomic_mass(atomic_numbers)
         heat_capacity = self.heat_capacity_c_v
@@ -223,12 +223,14 @@ class ThermodynamicsResults(SimulationWorkflowResults):
         """,
         cached=True,
     )
-    def vibrational_free_energy_at_constant_volume_specific(self) -> NDArray:
+    def vibrational_free_energy_at_constant_volume_specific(
+        self,
+    ) -> Optional[np.ndarray]:
         import nomad.atomutils
 
         workflow = self.m_parent
         if not workflow._systems or not workflow._systems[0].atoms:
-            return
+            return None
         atomic_numbers = workflow._systems[0].atoms.species
         mass_per_unit_cell = nomad.atomutils.get_summed_atomic_mass(atomic_numbers)
         free_energy = self.vibrational_free_energy_at_constant_volume

{nomad_schema_plugin_simulation_workflow-1.0.8 → nomad_schema_plugin_simulation_workflow-1.0.10}/tests/test_simulationworkflowschema.py

@@ -82,6 +82,8 @@ def test_single_point_workflow():
     assert sec_workflow.results.is_converged
 
 
+# TODO do not skip nomad-lab>=3.15
+@pytest.mark.skip
 def test_gw_workflow(gw_workflow):
     """Testing GW workflow (DFT+GW) entry"""
     workflow = gw_workflow.workflow2
@@ -106,6 +108,8 @@ def test_gw_workflow(gw_workflow):
     assert results.properties.electronic.dos_electronic_new[1].label == 'GW'
 
 
+# TODO do not skip nomad-lab>=3.15
+@pytest.mark.skip
 def test_dmft_workflow(dmft_workflow):
     """Testing DMFT workflow entry"""
     workflow = dmft_workflow.workflow2
@@ -136,6 +140,8 @@ def test_dmft_workflow(dmft_workflow):
     # assert results.m_xpath('properties.electronic.greens_function_electronic')
 
 
+# TODO do not skip nomad-lab>=3.15
+@pytest.mark.skip
 def test_maxent_workflow(maxent_workflow):
     """Testing MaxEnt workflow entry"""
     workflow = maxent_workflow.workflow2
@@ -201,6 +207,8 @@ def test_bse_workflow(bse_workflow):
     assert spectra[0].provenance != spectra[1].provenance
 
 
+# TODO do not skip nomad-lab>=3.15
+@pytest.mark.skip
 def test_xs_workflow(xs_workflow):
     """Testing XS workflow (DFT+BSEworkflow) entry"""
     workflow = xs_workflow.workflow2