nmcli 1.7.0__tar.gz → 1.8.0__tar.gz

{nmcli-1.7.0 → nmcli-1.8.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: nmcli
-Version: 1.7.0
+Version: 1.8.0
 Summary: A python wrapper library for the network-manager cli client
 Author: ushiboy
 License-Expression: MIT
@@ -307,9 +307,11 @@ Connect to a Wi-Fi network specified by SSID or BSSID.
 
 The `wait` argument applies the same effect to the command as the `--wait` option. If it is omitted, the default behavior is followed.
 
+If `password` is `None`, the password option is omitted from the command. This allows connecting to open networks or known networks that already have credentials stored.
+
 ```
 nmcli.device.wifi_connect(ssid: str,
-                          password: str,
+                          password: Optional[str] = None,
                           ifname: str = None,
                           wait: int = None) -> None
 ```
@@ -523,6 +525,10 @@ nmcli.set_lang(lang: str) -> None
 
 ## Change Log
 
+### 1.8.0
+
+- Allow `nmcli.device.wifi_connect` to accept `None` as password to connect to open or known networks without specifying a password.
+
 ### 1.7.0
 
 - Added `nmcli.connection.show_all` method with active filtering support

{nmcli-1.7.0 → nmcli-1.8.0}/README.md

@@ -293,9 +293,11 @@ Connect to a Wi-Fi network specified by SSID or BSSID.
 
 The `wait` argument applies the same effect to the command as the `--wait` option. If it is omitted, the default behavior is followed.
 
+If `password` is `None`, the password option is omitted from the command. This allows connecting to open networks or known networks that already have credentials stored.
+
 ```
 nmcli.device.wifi_connect(ssid: str,
-                          password: str,
+                          password: Optional[str] = None,
                           ifname: str = None,
                           wait: int = None) -> None
 ```
@@ -509,6 +511,10 @@ nmcli.set_lang(lang: str) -> None
 
 ## Change Log
 
+### 1.8.0
+
+- Allow `nmcli.device.wifi_connect` to accept `None` as password to connect to open or known networks without specifying a password.
+
 ### 1.7.0
 
 - Added `nmcli.connection.show_all` method with active filtering support

{nmcli-1.7.0 → nmcli-1.8.0}/nmcli/_device.py

@@ -1,5 +1,5 @@
 import re
-from typing import List, Tuple
+from typing import List, Optional, Tuple
 
 from ._exception import ConnectionActivateFailedException
 from ._helper import add_fields_option_if_needed, add_wait_option_if_needed
@@ -75,7 +75,7 @@ class DeviceControlInterface:
 
     def wifi_connect(self,
                      ssid: str,
-                     password: str,
+                     password: Optional[str] = None,
                      ifname: str = None,
                      wait: int = None) -> None:
         raise NotImplementedError
@@ -182,11 +182,13 @@ class DeviceControl(DeviceControlInterface):
 
     def wifi_connect(self,
                      ssid: str,
-                     password: str,
+                     password: Optional[str] = None,
                      ifname: str = None,
                      wait: int = None) -> None:
         cmd = add_wait_option_if_needed(
-            wait) + ['device', 'wifi', 'connect', ssid, 'password', password]
+            wait) + ['device', 'wifi', 'connect', ssid]
+        if password is not None:
+            cmd += ['password', password]
         if ifname is not None:
             cmd += ['ifname', ifname]
         r = self._syscmd.nmcli(cmd)

{nmcli-1.7.0 → nmcli-1.8.0}/nmcli/dummy/_device.py

@@ -1,4 +1,4 @@
-from typing import List, Tuple
+from typing import List, Optional, Tuple
 
 from .._device import DeviceControlInterface, DeviceDetails
 from ..data.device import Device, DeviceWifi
@@ -126,7 +126,7 @@ class DummyDeviceControl(DeviceControlInterface):  # pylint: disable=too-many-pu
 
     def wifi_connect(self,
                      ssid: str,
-                     password: str,
+                     password: Optional[str] = None,
                      ifname: str = None,
                      wait: int = None) -> None:
         self._raise_error_if_needed()

{nmcli-1.7.0 → nmcli-1.8.0}/nmcli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: nmcli
-Version: 1.7.0
+Version: 1.8.0
 Summary: A python wrapper library for the network-manager cli client
 Author: ushiboy
 License-Expression: MIT
@@ -307,9 +307,11 @@ Connect to a Wi-Fi network specified by SSID or BSSID.
 
 The `wait` argument applies the same effect to the command as the `--wait` option. If it is omitted, the default behavior is followed.
 
+If `password` is `None`, the password option is omitted from the command. This allows connecting to open networks or known networks that already have credentials stored.
+
 ```
 nmcli.device.wifi_connect(ssid: str,
-                          password: str,
+                          password: Optional[str] = None,
                           ifname: str = None,
                           wait: int = None) -> None
 ```
@@ -523,6 +525,10 @@ nmcli.set_lang(lang: str) -> None
 
 ## Change Log
 
+### 1.8.0
+
+- Allow `nmcli.device.wifi_connect` to accept `None` as password to connect to open or known networks without specifying a password.
+
 ### 1.7.0
 
 - Added `nmcli.connection.show_all` method with active filtering support

{nmcli-1.7.0 → nmcli-1.8.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "nmcli"
-version = "1.7.0"
+version = "1.8.0"
 description = "A python wrapper library for the network-manager cli client"
 readme = "README.md"
 authors = [{name = "ushiboy"}]

{nmcli-1.7.0 → nmcli-1.8.0}/tests/test_device.py

@@ -309,6 +309,27 @@ def test_wifi_connect():
         '--wait', '10', 'device', 'wifi', 'connect', ssid, 'password', password]
 
 
+def test_wifi_connect_without_password():
+    s = DummySystemCommand()
+    device = DeviceControl(s)
+    ssid = 'Open AP'
+    ifname = 'wlan0'
+
+    device.wifi_connect(ssid, None)
+    assert s.passed_parameters == ['device', 'wifi', 'connect', ssid]
+
+    device.wifi_connect(ssid, None, ifname)
+    assert s.passed_parameters == [
+        'device', 'wifi', 'connect', ssid, 'ifname', ifname]
+
+    device.wifi_connect(ssid, None, wait=10)
+    assert s.passed_parameters == [
+        '--wait', '10', 'device', 'wifi', 'connect', ssid]
+
+    device.wifi_connect(ssid)
+    assert s.passed_parameters == ['device', 'wifi', 'connect', ssid]
+
+
 def test_wifi_connect_when_connection_activate_failed():
     s = DummySystemCommand(
         '''Error: Connection activation failed: (7) Secrets were required, but not provided.

{nmcli-1.7.0 → nmcli-1.8.0}/tests/test_general.py

@@ -59,7 +59,8 @@ def test_reload_with_all_valid_flags():
     s = DummySystemCommand()
     general = GeneralControl(s)
     general.reload(['conf', 'dns-rc', 'dns-full'])
-    assert s.passed_parameters == ['general', 'reload', 'conf', 'dns-rc', 'dns-full']
+    assert s.passed_parameters == ['general',
+                                   'reload', 'conf', 'dns-rc', 'dns-full']
 
 
 def test_reload_with_invalid_flag():