nit-cli 0.4.0__tar.gz → 0.4.1__tar.gz

{nit_cli-0.4.0 → nit_cli-0.4.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: nit-cli
-Version: 0.4.0
+Version: 0.4.1
 Summary: Terminal diff viewer with inline review comments
 Author: Joshua Zink-Duda
 License-Expression: GPL-3.0-only

{nit_cli-0.4.0 → nit_cli-0.4.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "nit-cli"
-version = "0.4.0"
+version = "0.4.1"
 description = "Terminal diff viewer with inline review comments"
 readme = "README.md"
 license = "GPL-3.0-only"

{nit_cli-0.4.0 → nit_cli-0.4.1}/src/nit/app.py

@@ -2,6 +2,7 @@ from __future__ import annotations
 
 import logging
 import os
+import shutil
 import subprocess
 from collections import Counter
 from pathlib import Path
@@ -360,9 +361,7 @@ class DiffView(VerticalScroll):
                 self.diff_lines.append(primary)
 
                 # Build Rich Text for the row
-                text = self._format_sbs_row(
-                    row, half, lang if row.row_type == "context" else None
-                )
+                text = self._format_sbs_row(row, half, lang if row.row_type == "context" else None)
                 w = DiffLineWidget(text)
 
                 w.add_class("sbs")
@@ -383,9 +382,7 @@ class DiffView(VerticalScroll):
                         block = CommentBlock(f"-- {c.comment}")
                         self.mount(block)
 
-    def _format_sbs_row(
-        self, row: SideBySideRow, half: int, language: str | None = None
-    ) -> Text:
+    def _format_sbs_row(self, row: SideBySideRow, half: int, language: str | None = None) -> Text:
         """Format a side-by-side row as Rich Text with per-side coloring."""
         if row.row_type == "hunk_header":
             left = row.left
@@ -729,7 +726,7 @@ class NitApp(App):
         try:
             self.branch = git.get_current_branch(self.repo_root)
         except Exception:
-            self.branch = ""
+            self.branch = "(detached HEAD)"
         self.base = git.get_main_branch(self.repo_root)
         if self._cli_args.mode:
             self.diff_mode = self._cli_args.mode
@@ -934,7 +931,7 @@ class NitApp(App):
                 action()
                 event.prevent_default()
                 event.stop()
-            return
+                return
         if event.key == "g":
             self._pending_g = True
             event.prevent_default()
@@ -1016,7 +1013,12 @@ class NitApp(App):
                     diff_mode=self.diff_mode,
                 )
                 self.comments.append(comment)
-                comments_mod.save_comments(self.repo_root, self.comments, self.branch, self.base)
+                try:
+                    comments_mod.save_comments(
+                        self.repo_root, self.comments, self.branch, self.base
+                    )
+                except Exception as e:
+                    self.notify(f"Failed to save comment: {e}", severity="error")
         saved_cursor = diff_view.cursor_index
         diff_view.hide_comment_input()
         if self.current_file:
@@ -1159,8 +1161,16 @@ class NitApp(App):
             self.notify("No comments to export", severity="warning")
             return
         text = comments_mod.export_comments_markdown(self.comments)
+        clip_cmd = None
+        for cmd in ("pbcopy", "xclip", "xsel"):
+            if shutil.which(cmd):
+                clip_cmd = [cmd] if cmd == "pbcopy" else [cmd, "-selection", "clipboard"]
+                break
+        if clip_cmd is None:
+            self.notify("No clipboard command found (pbcopy/xclip/xsel)", severity="error")
+            return
         try:
-            subprocess.run(["pbcopy"], input=text, text=True, check=True, timeout=5)
+            subprocess.run(clip_cmd, input=text, text=True, check=True, timeout=5)
             self.notify(f"Copied {len(self.comments)} comments to clipboard")
         except (subprocess.CalledProcessError, FileNotFoundError, subprocess.TimeoutExpired):
             self.notify("Clipboard copy failed", severity="error")

{nit_cli-0.4.0 → nit_cli-0.4.1}/src/nit_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: nit-cli
-Version: 0.4.0
+Version: 0.4.1
 Summary: Terminal diff viewer with inline review comments
 Author: Joshua Zink-Duda
 License-Expression: GPL-3.0-only

{nit_cli-0.4.0 → nit_cli-0.4.1}/src/nit_cli.egg-info/SOURCES.txt

@@ -19,4 +19,5 @@ tests/test_app.py
 tests/test_cli.py
 tests/test_comments.py
 tests/test_diff_parser.py
-tests/test_git.py
+tests/test_git.py
+tests/test_syntax.py

{nit_cli-0.4.0 → nit_cli-0.4.1}/tests/test_app.py

@@ -92,4 +92,19 @@ async def test_app_detached_head(mock_git, mock_comments):
     mock_git.get_current_branch.side_effect = Exception("not on branch")
     app = NitApp()
     async with app.run_test():
-        assert app.branch == ""
+        assert app.branch == "(detached HEAD)"
+
+
+async def test_g_chord_unrecognized_key_not_swallowed(mock_git, mock_comments):
+    app = NitApp()
+    async with app.run_test() as pilot:
+        # Press g — sets pending flag
+        await pilot.press("g")
+        assert app._pending_g is True
+        # Press unrecognized key — flag resets, key not swallowed
+        await pilot.press("z")
+        assert app._pending_g is False
+        # Valid chord still works after: gg = cursor to start
+        await pilot.press("g", "g")
+        dv = app.query_one("#diff-view")
+        assert dv.cursor_index == 0

{nit_cli-0.4.0 → nit_cli-0.4.1}/tests/test_comments.py

@@ -2,6 +2,8 @@ import json
 
 from nit.comments import (
     comment_matches_line,
+    export_comments_json,
+    export_comments_markdown,
     load_comments,
     make_comment,
     save_comments,
@@ -114,3 +116,53 @@ def test_load_missing_comment_fields(tmp_path):
     loaded = load_comments(tmp_path)
     assert len(loaded) == 1
     assert loaded[0].file_path == "x.py"
+
+
+def _make_review_comment(**overrides):
+    defaults = dict(
+        file_path="src/app.py",
+        new_line_no=10,
+        old_line_no=None,
+        line_content="return result",
+        comment="Fix this",
+        hunk_context=["line1", "return result"],
+        timestamp="2025-01-15T10:00:00+00:00",
+        diff_mode="branch",
+    )
+    defaults.update(overrides)
+    return ReviewComment(**defaults)
+
+
+def test_export_comments_markdown_empty():
+    assert export_comments_markdown([]) == ""
+
+
+def test_export_comments_markdown():
+    comments = [
+        _make_review_comment(file_path="b.py", new_line_no=5, comment="second file"),
+        _make_review_comment(file_path="a.py", new_line_no=10, comment="note here"),
+        _make_review_comment(
+            file_path="a.py", new_line_no=None, old_line_no=3, comment="old line comment"
+        ),
+    ]
+    md = export_comments_markdown(comments)
+    assert md.startswith("# Code Review Comments")
+    # Files sorted alphabetically
+    assert md.index("## a.py") < md.index("## b.py")
+    assert "**L10**: note here" in md
+    assert "**old L3**: old line comment" in md
+    assert "**L5**: second file" in md
+    assert "```" in md  # code fence for line_content
+
+
+def test_export_comments_json():
+    comments = [
+        _make_review_comment(comment="test comment"),
+    ]
+    result = export_comments_json(comments)
+    parsed = json.loads(result)
+    assert isinstance(parsed, list)
+    assert len(parsed) == 1
+    assert parsed[0]["comment"] == "test comment"
+    assert parsed[0]["file"] == "src/app.py"
+    assert parsed[0]["line"] == 10

nit_cli-0.4.1/tests/test_syntax.py

@@ -0,0 +1,26 @@
+from rich.text import Text
+
+from nit.syntax import detect_language, highlight_line
+
+
+def test_detect_language_python():
+    assert detect_language("app.py") == "python"
+
+
+def test_detect_language_javascript():
+    assert detect_language("index.js") == "javascript"
+
+
+def test_detect_language_unknown():
+    assert detect_language("file.xyzunknown") is None
+
+
+def test_highlight_line_returns_text():
+    result = highlight_line("x = 1", "python")
+    assert isinstance(result, Text)
+    assert str(result).strip() == "x = 1"
+
+
+def test_highlight_line_empty():
+    result = highlight_line("", "python")
+    assert isinstance(result, Text)