ngstrefftz 0.3.2504.dev2__tar.gz → 0.3.2505.dev1__tar.gz

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/.gitmodules

@@ -1,3 +1,3 @@
 [submodule "external_dependencies/ngstents"]
 	path = external_dependencies/ngstents
-	url = https://github.com/PaulSt/ngstents.git
+	url = https://github.com/jayggg/ngstents.git

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/CMakeLists.txt

@@ -18,7 +18,7 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_BINARY_DIR}/cmake_modules)
 
 set(addon_name ngstrefftz)
 project(ngstrefftz)
-include_directories(${CMAKE_SOURCE_DIR}/external_dependencies/ngstents/src)
+include_directories(SYSTEM ${CMAKE_SOURCE_DIR}/external_dependencies/ngstents/src) # SYSTEM to suppress warnings from headers
 include(${CMAKE_BINARY_DIR}/cmake_modules/ngsolve_addon.cmake)
 add_ngsolve_addon(ngstrefftz
     ${CMAKE_SOURCE_DIR}/external_dependencies/ngstents/src/tents.cpp
@@ -50,6 +50,10 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
         -Wpedantic
         -Wno-vla # ngsolve uses VLAs anyway
     )
+    set_source_files_properties( 
+        ${CMAKE_SOURCE_DIR}/external_dependencies/ngstents/src/tents.cpp 
+        PROPERTIES COMPILE_FLAGS "-w" #suppress all warnings
+    )
 elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
     target_compile_options(ngstrefftz PRIVATE
         -Wall
@@ -58,6 +62,10 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
         -Wtype-limits
         -Wuninitialized
     )
+    set_source_files_properties( 
+        ${CMAKE_SOURCE_DIR}/external_dependencies/ngstents/src/tents.cpp 
+        PROPERTIES COMPILE_FLAGS "-w" #suppress all warnings
+    )
 endif()
 
 ### user options

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/PKG-INFO

@@ -1,13 +1,13 @@
 Metadata-Version: 2.2
 Name: ngstrefftz
-Version: 0.3.2504.dev2
+Version: 0.3.2505.dev1
 Summary: NGSTrefftz is an add-on to NGSolve for Trefftz methods.
 Author-Email: Paul Stocker <paul.stocker@univie.ac.at>
 Classifier: License :: OSI Approved :: GNU Lesser General Public License v3 (LGPLv3)
 Project-URL: Documentation, https://paulst.github.io/NGSTrefftz
 Project-URL: Repository, https://github.com/PaulSt/ngstrefftz
 Requires-Python: >=3.9
-Requires-Dist: ngsolve==6.2.2503
+Requires-Dist: ngsolve==6.2.2504
 Description-Content-Type: text/markdown
 
 # NGSTrefftz

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/_version.py

@@ -17,5 +17,5 @@ __version__: str
 __version_tuple__: VERSION_TUPLE
 version_tuple: VERSION_TUPLE
 
-__version__ = version = '0.3.2504.dev2'
-__version_tuple__ = version_tuple = (0, 3, 2504, 'dev2')
+__version__ = version = '0.3.2505.dev1'
+__version_tuple__ = version_tuple = (0, 3, 2505, 'dev1')

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/docs/requirements.txt

@@ -21,6 +21,6 @@ myst_parser>=3.0.1
 numpy>=2.0.0
 scipy>=1.13.1
 webgui-jupyter-widgets>=0.2.35
-#ngstrefftz==0.3.2503
+#ngstrefftz==0.3.2504
 #ngsolve==6.2.2404.post22.dev0
-xfem==2.1.2503
+xfem==2.1.2504

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/external_dependencies/ngstents/.github/workflows/build.yml

@@ -15,9 +15,9 @@ jobs:
       matrix:
         os: [ubuntu-latest, macos-13]
         include:
-          - os: windows-2019
+          - os: windows-2022
             cibw-arch: AMD64
-            cmake-generator: "Visual Studio 16 2019"
+            cmake-generator: "Visual Studio 17 2022"
             cmake_generator_platform: "x64"
 
     steps:
@@ -81,7 +81,7 @@ jobs:
       pages: write
       id-token: write
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0 # otherwise, you will failed to push refs to dest repo
           submodules: 'False'
@@ -100,10 +100,10 @@ jobs:
           python3 -m pip install --break-system-packages jupyter-book
           jupyter-book build .
       - name: Upload artifact
-        uses: actions/upload-pages-artifact@v2
+        uses: actions/upload-pages-artifact@v3
         with:
           path: "docs/_build/html"
       - name: Deploy to GitHub Pages
         if: github.ref == 'refs/heads/master'
         id: deployment
-        uses: actions/deploy-pages@v2
+        uses: actions/deploy-pages@v4

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/external_dependencies/ngstents/pyproject.toml

@@ -1,18 +1,18 @@
 [project]
 name = "ngstents"
-dynamic = ["version", "dependencies"]
+dynamic = ["dependencies", "version"]
 authors = [{name="Jay Gopalakrishnan", email= "gjay@pdx.edu"}]
 description = "Spacetime tent facilities for solving hyperbolic equations"
 urls = {github="https://github.com/jayggg/ngstents"}
 readme = "README.md"
-requires-python = ">=3.8"
-dependencies = ["matplotlib"]
+requires-python = ">=3.9"
+# dependencies = ["matplotlib"]
 classifiers = [
   "License :: OSI Approved :: GNU Lesser General Public License v2 or later (LGPLv2+)"
 ]
 
 [build-system]
-requires = ["ngsolve>=6.2.2404.post16", "matplotlib", "setuptools>=45", "setuptools_scm[toml]>=8", "toml", "scikit-build-core>=0.3.3", "pybind11_stubgen", "cmake>=3.26.1"]
+requires = ["ngsolve>=6.2.2503", "matplotlib", "cmake", "setuptools>=45", "setuptools_scm[toml]>=8", "toml", "scikit-build-core>=0.3.3", "pybind11_stubgen", "cmake>=3.26.1"]
 build-backend = "scikit_build_core.build"
 
 ##########################################################################
@@ -31,6 +31,7 @@ metadata.dependencies.provider="ngsolve._scikit_build_core_dependencies"
 local_scheme = "no-local-version"
 
 [tool.cibuildwheel]
+manylinux-x86_64-image = "cerbsim/manylinux_2_28_x86_64_cuda_12.8"
 skip = """
   pp*
   *_i686
@@ -39,7 +40,7 @@ skip = """
 """
 
 [tool.cibuildwheel.linux]
-repair-wheel-command = "mv {wheel} {dest_dir} && rename linux_x86_64 manylinux_2_17_x86_64.manylinux2014_x86_64 {dest_dir}/*-linux_x86_64*.whl"
+repair-wheel-command = "mv {wheel} {dest_dir} && rename linux_x86_64 manylinux_2_28_x86_64.manylinux2014_x86_64 {dest_dir}/*-linux_x86_64*.whl"
 
 [tool.cibuildwheel.macos]
 environment = {MACOSX_DEPLOYMENT_TARGET="10.15"}

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/external_dependencies/ngstents/src/CMakeLists.txt

@@ -42,4 +42,4 @@ install(FILES
   ../py/conslaw/__init__.py
   DESTINATION ${install_dir}/conslaw)
 
-ngsolve_generate_stub_files(ngstents)
+# ngsolve_generate_stub_files(ngstents)

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/external_dependencies/ngstents/src/paralleldepend.hpp

@@ -5,10 +5,14 @@
 using namespace ngsolve;
 #include "concurrentqueue.h"
 
+
+namespace ngstents {
+
 typedef moodycamel::ConcurrentQueue<int> TQueue;
 typedef moodycamel::ProducerToken TPToken;
 typedef moodycamel::ConsumerToken TCToken;
 
+
 static TQueue queue;
 
 using namespace ngstd;
@@ -68,7 +72,7 @@ void RunParallelDependency (const Table<int> & dag, TFUNC func)
 
 
   task_manager -> CreateJob
-    ([&] (const TaskInfo &)
+    ([&] (const TaskInfo & ti)
      {
        TPToken ptoken(queue);
        TCToken ctoken(queue);
@@ -126,5 +130,5 @@ void RunParallelDependency (const Table<int> & dag, TFUNC func)
   */
 }
 
-
+}
 #endif

ngstrefftz-0.3.2505.dev1/external_dependencies/ngstents/src/python_tents.cpp

@@ -0,0 +1,139 @@
+#include "tents.hpp"
+#include <python_ngstd.hpp>
+
+typedef CoefficientFunction CF;
+
+// python export of tent mesh
+auto ExportTimeSlab(py::module &m)
+{
+  auto pyname = "TentSlab";
+  auto pydocu = "Tent pitched slab in D + 1 time dimensions";
+  py::class_<TentPitchedSlab, shared_ptr<TentPitchedSlab>>
+    (m, pyname, pydocu)
+    .def(py::init([](shared_ptr<MeshAccess> ma, string method_name, int heapsize)
+		  {
+		    ngstents::PitchingMethod method = [method_name]{
+		      if(method_name == "edge") return ngstents::EEdgeGrad;
+		      else if(method_name == "vol") return ngstents::EVolGrad;
+		      else//just for static analyzers. the code should not reach this case
+			{
+			  cout << "Invalid method! Setting edge algorithm as default..." << endl;
+			  return ngstents::EEdgeGrad;
+			}
+		    }();
+		    auto tps = TentPitchedSlab(ma,  heapsize);
+		    tps.SetPitchingMethod(method);
+		    return tps;
+		  }),
+	 py::arg("mesh"), py::arg("method") = "edge", py::arg("heapsize") = 1000000
+	 )
+    .def_readonly("mesh", &TentPitchedSlab::ma)
+    .def_property_readonly("gradphi",[](shared_ptr<TentPitchedSlab> self) -> shared_ptr<CF>
+			   {
+			     return self->cfgradphi;
+			   })
+    .def("SetMaxWavespeed", [](shared_ptr<TentPitchedSlab> self, py::object wavespeed)
+	 {
+	   if (auto ws = py::extract<double> (wavespeed); ws.check())
+	     self->SetMaxWavespeed(ws());
+           else if (auto ws = py::extract<shared_ptr<CF>>(wavespeed); ws.check())
+             self->SetMaxWavespeed(ws());
+           else
+             throw Exception("wrong argument type in SetMaxWavespeed");
+         })
+    .def("PitchTents",[](shared_ptr<TentPitchedSlab> self,
+			 const double dt,
+			 const bool local_ct, const double global_ct)
+	 {
+	   int dim = self->ma->GetDimension();
+	   bool success = false;
+	   switch(dim){
+	   case 1:
+	     success = self->PitchTents<1>(dt,local_ct,global_ct);
+	     break;
+	   case 2:
+	     success = self->PitchTents<2>(dt,local_ct,global_ct);
+	     break;
+	   case 3:
+	     success = self->PitchTents<3>(dt,local_ct,global_ct);
+	     break;
+	   default:
+	     throw Exception("TentPitchedSlab not available for dimension "+ToString(dim));
+	   }
+	   return success;
+	 },
+	 py::arg("dt"), py::arg("local_ct")=false, py::arg("global_ct")=1.0,
+	 R"(
+         Parameters:--
+           dt: spacetime slab's height in time.
+           local_ct: if True, constrain tent slope by scaling 1/wavespeed
+             with a further local mesh-dependent factor.
+           global_ct: an additional factor to constrain tent slope, which
+             gives flatter tents for smaller values.
+
+         Returns True upon successful tent meshing.
+         -------------)"
+	 )
+    .def("GetNTents", &TentPitchedSlab::GetNTents)
+    .def("GetNLayers", &TentPitchedSlab::GetNLayers)
+    .def("GetSlabHeight", &TentPitchedSlab::GetSlabHeight)
+    .def("MaxSlope", &TentPitchedSlab::MaxSlope)
+    .def("GetTent", &TentPitchedSlab::GetTent, pybind11::return_value_policy::reference_internal)
+    ////////////////////////////
+    // visualization functions
+    ////////////////////////////
+    .def("TentData1D", [](shared_ptr<TentPitchedSlab> self)
+	 {
+	   py::list ret;
+	   for(int i = 0; i < self->GetNTents(); i++)
+	     {
+	       const Tent & tent = self->GetTent(i);
+	       py::list reti;
+	       reti.append(py::make_tuple(tent.vertex, tent.ttop,
+					  tent.tbot, tent.level));
+	       for(int j = 0; j< tent.nbv.Size(); j++)
+		 reti.append(py::make_tuple(tent.nbv[j],tent.nbtime[j]));
+	       ret.append(reti);
+	     }
+	   return ret;
+	 })
+    .def("DrawPitchedTentsVTK", [](shared_ptr<TentPitchedSlab> self,
+				   string vtkfilename)
+	 {
+	   if(self->ma->GetDimension() != 2)
+	     throw Exception("VTK export is only supported for 2D spatial meshes");
+	   else
+	     self->DrawPitchedTentsVTK(vtkfilename);
+	 },
+	 py::arg("vtkfilename")="vtkoutput",
+	 R"(
+         Export the mesh of tents and intermediate advancing fronts
+         to VTK file format for visualization in Paraview.)"
+      )
+    ;
+}
+
+
+void ExportTents(py::module & m) {
+
+  py::class_<Tent, shared_ptr<Tent>>(m, "Tent", "Tent structure")
+    .def_readonly("vertex", &Tent::vertex)
+    .def_readonly("ttop", &Tent::ttop)
+    .def_readonly("tbot", &Tent::tbot)
+    .def_readonly("nbv", &Tent::nbv)
+    .def_readonly("nbtime", &Tent::nbtime)
+    .def_readonly("els", &Tent::els)
+    .def_readonly("level", &Tent::level)
+    .def_readonly("internal_facets", &Tent::internal_facets)
+    .def("MaxSlope", &Tent::MaxSlope);
+
+  ExportTimeSlab(m);
+}
+
+
+PYBIND11_MODULE(_pytents, m) {
+  py::module_::import("ngsolve");
+  m.attr("__name__") = "ngstents";
+  m.attr("__package__") = "ngstents";
+  ExportTents(m);
+}

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/external_dependencies/ngstents/src/tconservationlaw_tp_impl.hpp

@@ -5,6 +5,9 @@
 #include "paralleldepend.hpp"
 #include "tentsolver_impl.hpp"
 
+using namespace ngstents;
+
+
 template <typename EQUATION, int DIM, int COMP, int ECOMP, bool SYMBOLIC>
 void T_ConservationLaw<EQUATION, DIM, COMP, ECOMP, SYMBOLIC>::
 CalcFluxTent(const Tent & tent, const FlatMatrixFixWidth<COMP> u,

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/external_dependencies/ngstents/src/tents.cpp

@@ -6,8 +6,10 @@
 
 ///////////////////// GradPhiCoefficientFunction ///////////////////////////
 
-void GradPhiCoefficientFunction::GenerateCode(Code &code, FlatArray<int>, int index) const
+void GradPhiCoefficientFunction::GenerateCode(Code &code, FlatArray<int> inputs, int index) const
 {
+  auto dims = Dimensions();
+
   string header = "\n\
     {flatmatrix} {values};\n\
     ProxyUserData * {ud} = (ProxyUserData*)mir.GetTransformation().userdata;\n\
@@ -27,7 +29,7 @@ void GradPhiCoefficientFunction::GenerateCode(Code &code, FlatArray<int>, int in
 
   string body = "";
 
-  for (size_t i = 0; i < this->Dimension(); i++) {
+  for (int i = 0; i < this->Dimension(); i++) {
     body += Var(index, i, this->Dimensions()).Declare("{scal_type}", 0.0);
     string values = "{values}";
     if(code.is_simd)
@@ -250,8 +252,8 @@ bool TentPitchedSlab::PitchTents(const double dt, const bool calc_local_ct, cons
         }
       //check if slab is complete
       slab_complete = true;
-      for(size_t i = 0; i < ma->GetNV(); i++)
-        if(vmap[i] == int(i))
+      for(int i = 0; i < ma->GetNV(); i++)
+        if(vmap[i] == i)
           if(complete_vertices[i] == false)
             {
               slab_complete = false;
@@ -264,9 +266,9 @@ bool TentPitchedSlab::PitchTents(const double dt, const bool calc_local_ct, cons
     {
       const auto &vrefdt = slabpitcher->GetVerticesReferenceHeight();
       cout << "Error: the algorithm could not pitch the whole slab" << endl;
-      size_t iv;
+      int iv;
       for(iv = 0; iv < ma->GetNV(); iv++)
-        if(vmap[iv] == int(iv) && !complete_vertices[iv]) break;
+        if(vmap[iv] == iv && !complete_vertices[iv]) break;
       if(iv == ma->GetNV())//just as a precaution, let us check that it really didnt pitch.
         {
           cout << "Inconsistent data structure. Aborting..." << endl;
@@ -274,7 +276,7 @@ bool TentPitchedSlab::PitchTents(const double dt, const bool calc_local_ct, cons
         }
       for(iv = 0; iv < ma->GetNV(); iv++)
         {
-          if(vmap[iv] == int(iv) && !complete_vertices[iv])
+          if(vmap[iv] == iv && !complete_vertices[iv])
             {
               const auto relkt = ktilde[iv] / vrefdt[iv];
               if(relkt < 1e-10) {continue;}
@@ -391,8 +393,8 @@ bool TentSlabPitcher::GetReadyVertices(double &adv_factor, bool reset_adv_factor
   const double initial_adv_factor = adv_factor;
   for(auto ia = 0; ia < n_attempts; ia++)
     {
-      for (size_t iv = 0; iv < ma->GetNV(); iv++)
-        if(vmap[iv] == int(iv) && !complete_vertices[iv])
+      for (auto iv = 0; iv < ma->GetNV(); iv++)
+        if(vmap[iv] == iv && !complete_vertices[iv])
           {
             if (ktilde[iv] > adv_factor * vertex_refdt[iv])
               if (!vertex_ready[iv])
@@ -418,8 +420,8 @@ bool TentSlabPitcher::GetReadyVertices(double &adv_factor, bool reset_adv_factor
 void TentSlabPitcher::ComputeVerticesReferenceHeight(const Table<int> &v2v, const Table<int> &v2e, const FlatArray<double> &tau, LocalHeap &lh)
 {
   this->vertex_refdt = std::numeric_limits<double>::max();
-  for (size_t i = 0; i < this->ma->GetNV(); i++)
-    if(vmap[i]==int(i)) // non-periodic
+  for (auto i = 0; i < this->ma->GetNV(); i++)
+    if(vmap[i]==i) // non-periodic
       {
         this->vertex_refdt[i] = this->GetPoleHeight(i, tau, v2v[i],v2e[i],lh);
       }
@@ -427,11 +429,11 @@ void TentSlabPitcher::ComputeVerticesReferenceHeight(const Table<int> &v2v, cons
 }
 
 std::tuple<int,int> TentSlabPitcher::PickNextVertexForPitching(const FlatArray<int> &ready_vertices,
-                                                               const FlatArray<double> &,
+                                                               const FlatArray<double> &ktilde,
                                                                const FlatArray<int> &vertices_level){  
   int minlevel = std::numeric_limits<int>::max();
   int posmin = -1;
-  for(size_t i = 0; i < ready_vertices.Size(); i++)
+  for(auto i = 0; i < ready_vertices.Size(); i++)
     if(vertices_level[ready_vertices[i]] < minlevel)
       {
         minlevel = vertices_level[ready_vertices[i]];
@@ -541,7 +543,7 @@ std::tuple<Table<int>,Table<int>> TentSlabPitcher::InitializeMeshData(LocalHeap
   for ( ; !create_per_verts.Done(); create_per_verts++)
     {
       for(auto i : Range(vmap))
-        if(vmap[i]!=int(i))
+        if(vmap[i]!=i)
           create_per_verts.Add(vmap[i],i);
     }
 
@@ -555,7 +557,7 @@ std::tuple<Table<int>,Table<int>> TentSlabPitcher::InitializeMeshData(LocalHeap
     }
   else
     {
-      this->local_ctau = [](const int, const int){return 1;};
+      this->local_ctau = [](const int v, const int el_or_edge){return 1;};
     }
   return std::make_tuple(v2v, v2e);
 }
@@ -622,7 +624,7 @@ void TentSlabPitcher::RemovePeriodicEdges(BitArray &fine_edges)
 
 
 
-template <int DIM> double VolumeGradientPitcher<DIM>::GetPoleHeight(const int vi, const FlatArray<double> & tau,  FlatArray<int>, FlatArray<int>, LocalHeap & lh) const{
+template <int DIM> double VolumeGradientPitcher<DIM>::GetPoleHeight(const int vi, const FlatArray<double> & tau,  FlatArray<int> nbv, FlatArray<int> nbe, LocalHeap & lh) const{
   HeapReset hr(lh);
   constexpr auto el_type = EL_TYPE(DIM);
   //number of vertices of the current element (always the simplex associated to DIM)
@@ -645,7 +647,7 @@ template <int DIM> double VolumeGradientPitcher<DIM>::GetPoleHeight(const int vi
   //numerical tolerance (NOT YET SCALED)
   constexpr double num_tol = std::numeric_limits<double>::epsilon();
   const auto nels = els.Size();
-  for (size_t iel = 0; iel < nels; iel++)
+  for (int iel = 0; iel < nels; iel++)
     {
       const auto el = els[iel];
       ElementId ei(VOL,el);
@@ -715,7 +717,9 @@ template <int DIM> double VolumeGradientPitcher<DIM>::GetPoleHeight(const int vi
  }
 
 template <int DIM>
-Table<double> VolumeGradientPitcher<DIM>::CalcLocalCTau(LocalHeap &lh, const Table<int> &){
+Table<double> VolumeGradientPitcher<DIM>::CalcLocalCTau(LocalHeap &lh, const Table<int> &v2e){
+  constexpr auto el_type = EL_TYPE(DIM);//simplex of dimension dim
+  constexpr auto n_el_vertices = DIM + 1;//number of vertices of that simplex
   
   const auto n_mesh_vertices = ma->GetNV();
   //this table will contain the local mesh-dependent constant
@@ -726,10 +730,10 @@ Table<double> VolumeGradientPitcher<DIM>::CalcLocalCTau(LocalHeap &lh, const Tab
   //just calculating the size of the table
   for(auto vi : IntRange(0, n_mesh_vertices))
     {
-      if(vi != size_t(vmap[vi])) {continue;}
+      if(vi != vmap[vi]) {continue;}
       this->GetVertexElements(vi,vertex_els);
       const auto n_vert_els = vertex_els.Size();
-      for(auto _ : IntRange(0, n_vert_els))
+      for(auto el : IntRange(0, n_vert_els))
         {create_local_ctau.Add(vi,0);}
     }
   create_local_ctau++;// it is in insert mode
@@ -739,7 +743,7 @@ Table<double> VolumeGradientPitcher<DIM>::CalcLocalCTau(LocalHeap &lh, const Tab
   //therefore it must be ensured that ctau <=1
   for(auto vi : IntRange(0,n_mesh_vertices))
     {
-      if(vi != size_t(vmap[vi])){continue;}
+      if(vi != vmap[vi]){continue;}
       this->GetVertexElements(vi,vertex_els);
       for(auto iel : IntRange(0,vertex_els.Size()))
         {
@@ -769,7 +773,7 @@ Table<double> VolumeGradientPitcher<DIM>::CalcLocalCTau(LocalHeap &lh, const Tab
               for(auto edge : face_edges)
                 {
                   auto pnts = ma->GetEdgePNums(edge);
-                  if(size_t(vmap[pnts[0]]) != vi && size_t(vmap[pnts[1]]) != vi)
+                  if(vmap[pnts[0]] != vi && vmap[pnts[1]] != vi)
                     {
                       opposite_edge = edge_len[edge];
                     }
@@ -790,7 +794,7 @@ Table<double> VolumeGradientPitcher<DIM>::CalcLocalCTau(LocalHeap &lh, const Tab
 }
 
 template <int DIM>
-double EdgeGradientPitcher<DIM>::GetPoleHeight(const int vi, const FlatArray<double> & tau, FlatArray<int> nbv, FlatArray<int> nbe, LocalHeap &) const{
+double EdgeGradientPitcher<DIM>::GetPoleHeight(const int vi, const FlatArray<double> & tau, FlatArray<int> nbv, FlatArray<int> nbe, LocalHeap & lh) const{
   double kt = std::numeric_limits<double>::max();
   for (int nb_index : nbv.Range())
     {
@@ -821,9 +825,9 @@ Table<double> EdgeGradientPitcher<DIM>::CalcLocalCTau(LocalHeap &lh, const Table
   //just calculating the size of the table
   for(auto vi : IntRange(0, n_mesh_vertices))
     {
-      if(vi != size_t(vmap[vi])) {continue;}
+      if(vi != vmap[vi]) {continue;}
       const auto n_edges_vert = v2e[vi].Size();
-      for(auto _ : IntRange(0, n_edges_vert))
+      for(auto el : IntRange(0, n_edges_vert))
         {create_local_ctau.Add(vi,0);}
     }
   create_local_ctau++;// it is in insert mode
@@ -844,7 +848,7 @@ Table<double> EdgeGradientPitcher<DIM>::CalcLocalCTau(LocalHeap &lh, const Table
   //projection of the gradient over the respective face
   for(auto vi : IntRange(0, n_mesh_vertices))
     {
-      if(vi != size_t(vmap[vi])){continue;}
+      if(vi != vmap[vi]){continue;}
       for(auto edge : v2e[vi])
         {
           //gets the elements that have this edge as a side
@@ -1034,7 +1038,7 @@ void TentPitchedSlab::DrawPitchedTentsVTK(string filename)
 
 
   out << "CELL_TYPES " << cells.Size() << endl;
-  for (auto _ : cells)
+  for (auto c : cells)
     out << "10 " << endl;
 
   out << "CELL_DATA " << cells.Size() << endl;

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/external_dependencies/ngstents/src/tents.hpp

@@ -141,7 +141,7 @@ public:
     : CoefficientFunction(adim)
   { }
 
-  double Evaluate(const BaseMappedIntegrationPoint &) const
+  double Evaluate(const BaseMappedIntegrationPoint & ip) const
   {
     throw Exception ("Evaluate not implemented for BaseMappedIntegrationPoint!");
   }
@@ -199,8 +199,8 @@ public:
 
   // Constructor and initializers
   TentPitchedSlab(shared_ptr<MeshAccess> ama, int heapsize) :
-    dt(0), cmax(nullptr), has_been_pitched(false), nlayers(0),
-    lh(heapsize, "Tents heap"), ma(ama)
+    dt(0), ma(ama), cmax(nullptr), nlayers(0),
+    has_been_pitched(false), lh(heapsize, "Tents heap")
   {
     cfgradphi = make_shared<GradPhiCoefficientFunction>(ma->GetDimension());
   };

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/pyproject.toml

@@ -9,7 +9,7 @@ classifiers = [
   "License :: OSI Approved :: GNU Lesser General Public License v3 (LGPLv3)",
 ]
 dependencies = [
-  "ngsolve==6.2.2503",
+  "ngsolve==6.2.2504",
 ]
 
 
@@ -18,7 +18,7 @@ Documentation = "https://paulst.github.io/NGSTrefftz"
 Repository = "https://github.com/PaulSt/ngstrefftz"
 
 [build-system]
-requires = ["ngsolve==6.2.2503",
+requires = ["ngsolve==6.2.2504",
             "scikit-build-core>=0.9.0",
             "pybind11_stubgen",
             "setuptools>=45",

{ngstrefftz-0.3.2504.dev2 → ngstrefftz-0.3.2505.dev1}/src/twavetents.cpp

@@ -63,7 +63,7 @@ namespace ngcomp
 
     CSR basismat = TWaveBasis<D + 1>::Basis (order, 0, fosystem);
 
-    RunParallelDependency (tps->tent_dependency, [&] (int tentnr) {
+    ngstents::RunParallelDependency (tps->tent_dependency, [&] (int tentnr) {
       LocalHeap slh = lh.Split (); // split to threads
       const Tent *tent = &tps->GetTent (tentnr);
 
@@ -880,7 +880,7 @@ namespace ngcomp
   template <int D> double TWaveTents<D>::MaxAdiam ()
   {
     double h = 0.0;
-    RunParallelDependency (tps->tent_dependency, [&] (int tentnr) {
+    ngstents::RunParallelDependency (tps->tent_dependency, [&] (int tentnr) {
       const Tent *tent = &tps->GetTent (tentnr);
       h = max (h, TentAdiam (tent));
     });
@@ -948,7 +948,7 @@ namespace ngcomp
     // cout << "solving qt " << (this->tps)->GetNTents() << " tents in " << D
     // << "+1 dimensions..." << endl;
 
-    RunParallelDependency ((this->tps)->tent_dependency, [&] (int tentnr) {
+    ngstents::RunParallelDependency ((this->tps)->tent_dependency, [&] (int tentnr) {
       LocalHeap slh = lh.Split (); // split to threads
       const Tent *tent = &(this->tps)->GetTent (tentnr);