neuroglia-python 0.6.18__tar.gz → 0.6.20__tar.gz

{neuroglia_python-0.6.18 → neuroglia_python-0.6.20}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: neuroglia-python
-Version: 0.6.18
+Version: 0.6.20
 Summary: Port from .NET to Python of the Neuroglia Framework
 License: Apache
 License-File: LICENSE

{neuroglia_python-0.6.18 → neuroglia_python-0.6.20}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "neuroglia-python"
-version = "0.6.18"
+version = "0.6.20"
 description = "Port from .NET to Python of the Neuroglia Framework"
 authors = ["Charles d'Avernas <charles.davernas@neuroglia.io>", "Bruno van de Werve <bvandewe@gmail.com>"]
 license = "Apache"

{neuroglia_python-0.6.18 → neuroglia_python-0.6.20}/src/neuroglia/data/infrastructure/event_sourcing/__init__.py

@@ -4,14 +4,16 @@ Event sourcing infrastructure for Neuroglia.
 Provides event store implementations and aggregate root support.
 """
 
+# Apply runtime patches for third-party library bugs
+from . import patches  # noqa: F401
 from .abstractions import (
-    EventStore,
-    EventRecord,
+    Aggregator,
     EventDescriptor,
+    EventRecord,
+    EventStore,
+    EventStoreOptions,
     StreamDescriptor,
     StreamReadDirection,
-    EventStoreOptions,
-    Aggregator
 )
 from .event_sourcing_repository import EventSourcingRepository
 
@@ -19,9 +21,9 @@ __all__ = [
     "EventStore",
     "EventSourcingRepository",
     "EventRecord",
-    "EventDescriptor", 
+    "EventDescriptor",
     "StreamDescriptor",
     "StreamReadDirection",
     "EventStoreOptions",
     "Aggregator",
-]
+]

{neuroglia_python-0.6.18 → neuroglia_python-0.6.20}/src/neuroglia/data/infrastructure/event_sourcing/event_sourcing_repository.py

@@ -127,7 +127,8 @@ class EventSourcingRepository(Generic[TAggregate, TKey], Repository[TAggregate,
         encoded_events = [self._encode_event(e) for e in events]
         await self._eventstore.append_async(stream_id, encoded_events)
         aggregate.state.state_version = events[-1].aggregate_version
-        aggregate.clear_pending_events()
+        # DON'T clear pending events here - let base class do it after publishing!
+        # aggregate.clear_pending_events()
         return aggregate
 
     async def _do_update_async(self, aggregate: TAggregate) -> TAggregate:
@@ -139,7 +140,8 @@ class EventSourcingRepository(Generic[TAggregate, TKey], Repository[TAggregate,
         encoded_events = [self._encode_event(e) for e in events]
         await self._eventstore.append_async(stream_id, encoded_events, aggregate.state.state_version)
         aggregate.state.state_version = events[-1].aggregate_version
-        aggregate.clear_pending_events()
+        # DON'T clear pending events here - let base class do it after publishing!
+        # aggregate.clear_pending_events()
         return aggregate
 
     async def _do_remove_async(self, id: TKey) -> None:

{neuroglia_python-0.6.18 → neuroglia_python-0.6.20}/src/neuroglia/data/infrastructure/event_sourcing/event_store/event_store.py

@@ -253,7 +253,9 @@ class ESEventStore(EventStore):
                     logging.debug(f"Skipping tombstone event from stream: {e.stream_name}")
                     # Acknowledge tombstone to continue processing
                     if is_persistent:
-                        await subscription.ack(e.id)
+                        # Use ack_id for resolved link events, fall back to id
+                        ack_id = getattr(e, "ack_id", e.id)
+                        await subscription.ack(ack_id)
                     continue
 
                 # Skip system event types (prefixed with $)
@@ -262,7 +264,9 @@ class ESEventStore(EventStore):
                     logging.debug(f"Skipping system event type '{e.type}' from stream: {e.stream_name}")
                     # Acknowledge system event to continue processing
                     if is_persistent:
-                        await subscription.ack(e.id)
+                        # Use ack_id for resolved link events, fall back to id
+                        ack_id = getattr(e, "ack_id", e.id)
+                        await subscription.ack(ack_id)
                     continue
 
                 try:
@@ -271,12 +275,16 @@ class ESEventStore(EventStore):
                     logging.warning(f"Could not decode event with offset '{e.stream_position}' from stream '{e.stream_name}': {ex}")
                     # Acknowledge failed decode to continue processing (don't park/retry invalid events)
                     if is_persistent:
-                        await subscription.ack(e.id)
+                        # Use ack_id for resolved link events, fall back to id
+                        ack_id = getattr(e, "ack_id", e.id)
+                        await subscription.ack(ack_id)
                     continue
 
                 # Convert to AckableEventRecord if subscription supports ack/nack
                 if is_persistent:
-                    event_id = e.id
+                    # Use ack_id for resolved link events (resolveLinktos=true), fall back to id
+                    # This is critical for persistent subscriptions to category streams ($ce-*)
+                    event_id = getattr(e, "ack_id", e.id)
 
                     async def ack_delegate(eid=event_id, sub=subscription):
                         """

neuroglia_python-0.6.20/src/neuroglia/data/infrastructure/event_sourcing/patches.py

@@ -0,0 +1,74 @@
+"""
+Runtime patches for third-party library bugs affecting Neuroglia event sourcing.
+
+This module contains monkey-patches that fix critical bugs in dependencies.
+Patches are applied automatically when this module is imported.
+"""
+
+import logging
+
+log = logging.getLogger(__name__)
+
+
+def patch_esdbclient_async_subscription_id():
+    """
+    Fix esdbclient bug: AsyncPersistentSubscription.init() doesn't propagate
+    subscription_id to _read_reqs, causing ACKs to be sent with empty subscription ID.
+
+    **Bug Description**:
+    The sync version (PersistentSubscription.__init__) has this line:
+        self._read_reqs.subscription_id = subscription_id.encode()
+
+    But the async version (AsyncPersistentSubscription.init) is missing it!
+    This causes ACKs to fail silently because EventStoreDB doesn't know which
+    subscription the ACK is for.
+
+    **Symptoms**:
+    - Events are redelivered every message_timeout seconds despite being processed
+    - Checkpoint never advances in EventStoreDB
+    - Events eventually get parked after maxRetryCount attempts
+    - Read models may process the same event multiple times
+
+    **Root Cause**:
+    BaseSubscriptionReadReqs.__init__() initializes subscription_id = b"" (empty bytes).
+    The sync version overwrites this with the correct value in __init__, but the async
+    version only sets self._subscription_id without propagating it to _read_reqs.
+
+    **Affected Versions**:
+    - esdbclient: 1.1.7 (and likely all earlier versions with async support)
+    - kurrentdbclient: Likely affected (same codebase, rebranded)
+
+    **Upstream Issue**:
+    Bug report to be filed with esdbclient/kurrentdbclient maintainers.
+
+    **Verification**:
+    After applying this patch, check EventStoreDB admin UI:
+    - Navigate to Persistent Subscriptions → your subscription
+    - lastCheckpointedEventPosition should advance after processing events
+    - totalInFlightMessages should decrease after successful ACKs
+    """
+    try:
+        from esdbclient.persistent import (
+            AsyncPersistentSubscription,  # type: ignore[import-not-found]
+        )
+
+        original_init = AsyncPersistentSubscription.init
+
+        async def patched_init(self) -> None:
+            await original_init(self)
+            # Propagate subscription_id to _read_reqs (missing in esdbclient async version)
+            if hasattr(self, "_subscription_id") and hasattr(self, "_read_reqs"):
+                self._read_reqs.subscription_id = self._subscription_id.encode()
+                log.debug(f"🔧 Patched: propagated subscription_id to _read_reqs: {self._subscription_id}")
+
+        AsyncPersistentSubscription.init = patched_init
+        log.info("🔧 Patched esdbclient AsyncPersistentSubscription.init() to propagate subscription_id")
+
+    except ImportError:
+        log.debug("esdbclient not installed, skipping AsyncPersistentSubscription patch")
+    except Exception as e:
+        log.warning(f"Failed to apply esdbclient AsyncPersistentSubscription patch: {e}")
+
+
+# Auto-apply patches when this module is imported
+patch_esdbclient_async_subscription_id()