netbox-super-cli 1.0.6__tar.gz → 1.0.7__tar.gz

{netbox_super_cli-1.0.6 → netbox_super_cli-1.0.7}/CHANGELOG.md

@@ -2,6 +2,24 @@
 
 All notable changes to netbox-super-cli are tracked here. Format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) loosely. From v1.0.0 onward, releases follow [Semantic Versioning](https://semver.org/) and the version in `pyproject.toml` matches the git tag. Pre-1.0 milestones (Phase 1-5) were pinned by tag while `pyproject.toml` stayed at `0.0.1`.
 
+## v1.0.7 — 2026-06-09
+
+Patch release. Fixes a hard crash on fresh installs caused by an undeclared
+`click` dependency (issue #81).
+
+### Fixed
+
+- **`nsc` no longer crashes with `ModuleNotFoundError: No module named 'click'`
+  on fresh installs** (issue #81). `nsc` imports the standalone `click` package
+  directly, but it was never declared as a dependency — it was only pulled in
+  transitively by `typer`. typer 0.26 vendored click (as `typer._click`) and
+  dropped its public `click` dependency, so a fresh `uv tool install` / `pip
+  install` resolving `typer>=0.12` got typer 0.26.x with no `click`, and the
+  first `import click` aborted every command. `click>=8.1` is now an explicit
+  dependency, and `typer` is pinned `>=0.12,<0.26` — the last line that uses the
+  standalone `click` that nsc's `TyperGroup` overrides are written against.
+  Adopting typer 0.26's vendored click is tracked in #82.
+
 ## v1.0.6 — 2026-06-09
 
 Patch release. Fixes table/CSV column rendering for fields that are nested

{netbox_super_cli-1.0.6 → netbox_super_cli-1.0.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: netbox-super-cli
-Version: 1.0.6
+Version: 1.0.7
 Summary: Dynamic NetBox CLI generated from the live OpenAPI schema.
 Project-URL: Homepage, https://github.com/thomaschristory/netbox-super-cli
 Project-URL: Issues, https://github.com/thomaschristory/netbox-super-cli/issues
@@ -16,13 +16,14 @@ Classifier: Programming Language :: Python :: 3.12
 Classifier: Programming Language :: Python :: 3.13
 Classifier: Topic :: System :: Networking
 Requires-Python: >=3.12
+Requires-Dist: click>=8.1
 Requires-Dist: httpx>=0.27
 Requires-Dist: platformdirs>=4.2
 Requires-Dist: pydantic>=2.7
 Requires-Dist: rich>=13.7
 Requires-Dist: ruamel-yaml>=0.18
 Requires-Dist: structlog>=24.1
-Requires-Dist: typer>=0.12
+Requires-Dist: typer<0.26,>=0.12
 Description-Content-Type: text/markdown
 
 # netbox-super-cli (`nsc`)

{netbox_super_cli-1.0.6 → netbox_super_cli-1.0.7}/nsc/_version.py

@@ -1,3 +1,3 @@
 """Single source of truth for the package version."""
 
-__version__ = "1.0.6"
+__version__ = "1.0.7"

{netbox_super_cli-1.0.6 → netbox_super_cli-1.0.7}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "netbox-super-cli"
-version = "1.0.6"
+version = "1.0.7"
 description = "Dynamic NetBox CLI generated from the live OpenAPI schema."
 readme = "README.md"
 requires-python = ">=3.12"
@@ -18,7 +18,12 @@ classifiers = [
     "Topic :: System :: Networking",
 ]
 dependencies = [
-    "typer>=0.12",
+    # typer 0.26 vendored click as typer._click and dropped its public `click`
+    # dependency; nsc imports the standalone `click` directly and subclasses
+    # TyperGroup, so it stays on the <0.26 line (which uses standalone click)
+    # until that interop is migrated. See issue #82.
+    "typer>=0.12,<0.26",
+    "click>=8.1",
     "rich>=13.7",
     "httpx>=0.27",
     "pydantic>=2.7",

netbox_super_cli-1.0.7/tests/test_packaging.py

@@ -0,0 +1,71 @@
+"""Packaging-metadata guards.
+
+Protects against importing a third-party package directly while relying on
+another dependency to supply it transitively. That is exactly how `click`
+broke on fresh installs (issue #81): `nsc` imports `click` directly, but it
+was only ever pulled in via `typer` — and typer 0.26 vendored click as
+`typer._click` and dropped its public `click` dependency, so fresh
+resolutions had no `click` and `import click` crashed.
+"""
+
+from __future__ import annotations
+
+import ast
+import pathlib
+import re
+import sys
+import tomllib
+from importlib.metadata import packages_distributions
+
+_REPO_ROOT = pathlib.Path(__file__).resolve().parents[1]
+_NSC = _REPO_ROOT / "nsc"
+
+
+def _canonical(name: str) -> str:
+    return re.sub(r"[-_.]+", "-", name).strip().lower()
+
+
+def _declared_dependencies() -> set[str]:
+    data = tomllib.loads((_REPO_ROOT / "pyproject.toml").read_text(encoding="utf-8"))
+    deps: list[str] = data["project"]["dependencies"]
+    return {_canonical(re.split(r"[<>=!~\[; ]", dep, maxsplit=1)[0]) for dep in deps}
+
+
+def _top_level_imports(tree: ast.AST) -> set[str]:
+    names: set[str] = set()
+    for node in ast.walk(tree):
+        if isinstance(node, ast.Import):
+            names.update(alias.name.split(".")[0] for alias in node.names)
+        elif isinstance(node, ast.ImportFrom) and node.level == 0 and node.module:
+            names.add(node.module.split(".")[0])
+    return names
+
+
+def _directly_imported_modules() -> set[str]:
+    names: set[str] = set()
+    for path in _NSC.rglob("*.py"):
+        names |= _top_level_imports(ast.parse(path.read_text(encoding="utf-8")))
+    return names
+
+
+def test_click_is_a_declared_dependency() -> None:
+    # The concrete regression guard for issue #81: nsc imports click directly.
+    assert "click" in _directly_imported_modules()
+    assert _canonical("click") in _declared_dependencies()
+
+
+def test_every_direct_third_party_import_is_declared() -> None:
+    # Generalizes the guard: any top-level third-party module imported anywhere
+    # in nsc/ must resolve to a declared dependency — never a transitive freebie.
+    declared = _declared_dependencies()
+    dist_map = packages_distributions()
+    undeclared: dict[str, set[str]] = {}
+    for module in _directly_imported_modules():
+        if module == "nsc" or module in sys.stdlib_module_names:
+            continue
+        dists = dist_map.get(module)
+        if dists is None:
+            continue  # not an installed distribution (e.g. a namespace shim)
+        if not any(_canonical(dist) in declared for dist in dists):
+            undeclared[module] = set(dists)
+    assert not undeclared, f"third-party imports missing from dependencies: {undeclared}"

{netbox_super_cli-1.0.6 → netbox_super_cli-1.0.7}/uv.lock

@@ -646,9 +646,10 @@ wheels = [
 
 [[package]]
 name = "netbox-super-cli"
-version = "1.0.6"
+version = "1.0.7"
 source = { editable = "." }
 dependencies = [
+    { name = "click" },
     { name = "httpx" },
     { name = "platformdirs" },
     { name = "pydantic" },
@@ -676,13 +677,14 @@ docs = [
 
 [package.metadata]
 requires-dist = [
+    { name = "click", specifier = ">=8.1" },
     { name = "httpx", specifier = ">=0.27" },
     { name = "platformdirs", specifier = ">=4.2" },
     { name = "pydantic", specifier = ">=2.7" },
     { name = "rich", specifier = ">=13.7" },
     { name = "ruamel-yaml", specifier = ">=0.18" },
     { name = "structlog", specifier = ">=24.1" },
-    { name = "typer", specifier = ">=0.12" },
+    { name = "typer", specifier = ">=0.12,<0.26" },
 ]
 
 [package.metadata.requires-dev]