netbox-plugin-dns 1.3b2__tar.gz → 1.3.2__tar.gz

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: netbox-plugin-dns
-Version: 1.3b2
+Version: 1.3.2
 Summary: NetBox DNS is a NetBox plugin for managing DNS data.
 Author-email: Peter Eckel <pete@netbox-dns.org>
 Project-URL: Homepage, https://github.com/peteeckel/netbox-plugin-dns
@@ -8,7 +8,7 @@ Project-URL: Documentation, https://github.com/peteeckel/netbox-plugin-dns/blob/
 Project-URL: Repository, https://github.com/peteeckel/netbox-plugin-dns
 Project-URL: Issues, https://github.com/peteeckel/netbox-plugin-dns/issues
 Keywords: netbox,netbox-plugin,dns
-Classifier: Development Status :: 4 - Beta
+Classifier: Development Status :: 5 - Production/Stable
 Requires-Python: >=3.10
 Description-Content-Type: text/markdown
 License-File: LICENSE
@@ -52,6 +52,7 @@ The main focus of the plugin is to ensure the quality of the data stored in it.
 * Support for [RFC 2317](https://datatracker.ietf.org/doc/html/rfc2317) delegation of PTR zones for IPv4 subnets longer than 24 bits
 * Templating for zones and records enables faster creations of zones with given boilerplate object relations, such as name servers, tags, tenants or registration information, or records like standard SPF or MX records that are the same for a subset of zones
 * IPAM DNSsync can be used to automatically create address and pointer records for IP addresses by assigning prefixes to DNS views. When an IP address has a DNS name assigned and there are zones with matching names in the DNS views linked to the IP address' prefix, a matching DNS record will be created in these zones
+* DNSSEC support for storing configuration data relevant to DNSSEC operation in NetBox DNS
 
 Other main features include:
 

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/README.md

@@ -35,6 +35,7 @@ The main focus of the plugin is to ensure the quality of the data stored in it.
 * Support for [RFC 2317](https://datatracker.ietf.org/doc/html/rfc2317) delegation of PTR zones for IPv4 subnets longer than 24 bits
 * Templating for zones and records enables faster creations of zones with given boilerplate object relations, such as name servers, tags, tenants or registration information, or records like standard SPF or MX records that are the same for a subset of zones
 * IPAM DNSsync can be used to automatically create address and pointer records for IP addresses by assigning prefixes to DNS views. When an IP address has a DNS name assigned and there are zones with matching names in the DNS views linked to the IP address' prefix, a matching DNS record will be created in these zones
+* DNSSEC support for storing configuration data relevant to DNSSEC operation in NetBox DNS
 
 Other main features include:
 

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/__init__.py

@@ -4,7 +4,7 @@ from django.core.exceptions import ImproperlyConfigured
 from netbox.plugins import PluginConfig
 from netbox.plugins.utils import get_plugin_config
 
-__version__ = "1.3-beta2"
+__version__ = "1.3.2"
 
 
 def _check_list(setting):
@@ -16,7 +16,7 @@ class DNSConfig(PluginConfig):
     name = "netbox_dns"
     verbose_name = _("NetBox DNS")
     description = _("NetBox plugin for DNS data")
-    min_version = "4.2.0"
+    min_version = "4.3.0"
     version = __version__
     author = "Peter Eckel"
     author_email = "pete@netbox-dns.org"

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/api/serializers_/dnssec_key_template.py

@@ -62,6 +62,7 @@ class DNSSECKeyTemplateSerializer(NetBoxModelSerializer):
         help_text=_("Policies using this Key Template"),
     )
     tenant = TenantSerializer(
+        nested=True,
         required=False,
         allow_null=True,
     )

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/api/serializers_/dnssec_policy.py

@@ -136,6 +136,7 @@ class DNSSECPolicySerializer(NetBoxModelSerializer):
         help_text=_("Zone templates this policy is assigned to"),
     )
     tenant = TenantSerializer(
+        nested=True,
         required=False,
         allow_null=True,
     )

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/api/serializers_/nameserver.py

@@ -48,4 +48,8 @@ class NameServerSerializer(NetBoxModelSerializer):
         default=None,
         help_text=_("Zones served by the authoritative nameserver"),
     )
-    tenant = TenantSerializer(required=False, allow_null=True)
+    tenant = TenantSerializer(
+        nested=True,
+        required=False,
+        allow_null=True,
+    )

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/api/serializers_/record.py

@@ -35,7 +35,7 @@ class RecordSerializer(NetBoxModelSerializer):
             "managed",
             "disable_ptr",
             "ptr_record",
-            "address_record",
+            "address_records",
             "active",
             "custom_fields",
             "tenant",
@@ -71,14 +71,14 @@ class RecordSerializer(NetBoxModelSerializer):
         read_only=True,
         required=False,
         allow_null=True,
-        help_text=_("PTR record generated from an address"),
+        help_text=_("PTR record related to an address"),
     )
-    address_record = NestedRecordSerializer(
-        many=False,
+    address_records = NestedRecordSerializer(
+        many=True,
         read_only=True,
         required=False,
         allow_null=True,
-        help_text=_("Address record defining the PTR"),
+        help_text=_("Address records related to the PTR"),
     )
     zone = NestedZoneSerializer(
         many=False,

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/filtersets/record.py

@@ -63,10 +63,10 @@ class RecordFilterSet(TenancyFilterSet, NetBoxModelFilterSet):
         label=_("View the Parent Zone belongs to"),
     )
     address_record_id = django_filters.ModelMultipleChoiceFilter(
-        field_name="address_record",
+        field_name="address_records",
         queryset=Record.objects.all(),
         to_field_name="id",
-        label=_("Address Record"),
+        label=_("Address Records"),
     )
     ptr_record_id = django_filters.ModelMultipleChoiceFilter(
         field_name="ptr_record",

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/forms/zone.py

@@ -534,7 +534,7 @@ class ZoneFilterForm(TenancyFilterForm, NetBoxModelFilterSetForm):
     )
     parental_agents = forms.GenericIPAddressField(
         required=False,
-        label=_("Parental Agent"),
+        label=_("Parental Agents"),
     )
     registrar_id = DynamicModelMultipleChoiceField(
         queryset=Registrar.objects.all(),

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/dnssec_key_template.py

@@ -23,7 +23,7 @@ from netbox_dns.models import DNSSECKeyTemplate
 __all__ = ("NetBoxDNSDNSSECKeyTemplateFilter",)
 
 
-@strawberry_django.filter(DNSSECKeyTemplate, lookups=True)
+@strawberry_django.filter_type(DNSSECKeyTemplate, lookups=True)
 class NetBoxDNSDNSSECKeyTemplateFilter(
     ContactFilterMixin, TenancyFilterMixin, NetBoxModelFilterMixin
 ):

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/dnssec_policy.py

@@ -21,7 +21,7 @@ from netbox_dns.graphql.filter_lookups import PolicyDigestArrayLookup
 __all__ = ("NetBoxDNSDNSSECPolicyFilter", "PolicyDigestArrayLookup")
 
 
-@strawberry_django.filter(DNSSECPolicy, lookups=True)
+@strawberry_django.filter_type(DNSSECPolicy, lookups=True)
 class NetBoxDNSDNSSECPolicyFilter(
     ContactFilterMixin, TenancyFilterMixin, NetBoxModelFilterMixin
 ):

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/nameserver.py

@@ -16,7 +16,7 @@ from netbox_dns.models import NameServer
 __all__ = ("NetBoxDNSNameServerFilter",)
 
 
-@strawberry_django.filter(NameServer, lookups=True)
+@strawberry_django.filter_type(NameServer, lookups=True)
 class NetBoxDNSNameServerFilter(
     ContactFilterMixin, TenancyFilterMixin, NetBoxModelFilterMixin
 ):

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/record.py

@@ -24,7 +24,7 @@ from netbox_dns.models import Record
 __all__ = ("NetBoxDNSRecordFilter",)
 
 
-@strawberry_django.filter(Record, lookups=True)
+@strawberry_django.filter_type(Record, lookups=True)
 class NetBoxDNSRecordFilter(
     ContactFilterMixin, TenancyFilterMixin, NetBoxModelFilterMixin
 ):

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/record_template.py

@@ -20,7 +20,7 @@ from netbox_dns.models import RecordTemplate
 __all__ = ("NetBoxDNSRecordTemplateFilter",)
 
 
-@strawberry_django.filter(RecordTemplate, lookups=True)
+@strawberry_django.filter_type(RecordTemplate, lookups=True)
 class NetBoxDNSRecordTemplateFilter(
     ContactFilterMixin, TenancyFilterMixin, NetBoxModelFilterMixin
 ):

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/registrar.py

@@ -15,7 +15,7 @@ from netbox_dns.models import Registrar
 __all__ = ("NetBoxDNSRegistrarFilter",)
 
 
-@strawberry_django.filter(Registrar, lookups=True)
+@strawberry_django.filter_type(Registrar, lookups=True)
 class NetBoxDNSRegistrarFilter(NetBoxModelFilterMixin):
     name: FilterLookup[str] | None = strawberry_django.filter_field()
     description: FilterLookup[str] | None = strawberry_django.filter_field()

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/registration_contact.py

@@ -9,7 +9,7 @@ from netbox_dns.models import RegistrationContact
 __all__ = ("NetBoxDNSRegistrationContactFilter",)
 
 
-@strawberry_django.filter(RegistrationContact, lookups=True)
+@strawberry_django.filter_type(RegistrationContact, lookups=True)
 class NetBoxDNSRegistrationContactFilter(NetBoxModelFilterMixin):
     name: FilterLookup[str] | None = strawberry_django.filter_field()
     description: FilterLookup[str] | None = strawberry_django.filter_field()

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/view.py

@@ -16,7 +16,7 @@ from netbox_dns.models import View
 __all__ = ("NetBoxDNSViewFilter",)
 
 
-@strawberry_django.filter(View, lookups=True)
+@strawberry_django.filter_type(View, lookups=True)
 class NetBoxDNSViewFilter(
     ContactFilterMixin, TenancyFilterMixin, NetBoxModelFilterMixin
 ):

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/zone.py

@@ -23,7 +23,7 @@ from netbox_dns.models import Zone
 __all__ = ("NetBoxDNSZoneFilter",)
 
 
-@strawberry_django.filter(Zone, lookups=True)
+@strawberry_django.filter_type(Zone, lookups=True)
 class NetBoxDNSZoneFilter(
     ContactFilterMixin, TenancyFilterMixin, NetBoxModelFilterMixin
 ):

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/filters/zone_template.py

@@ -21,7 +21,7 @@ from netbox_dns.models import ZoneTemplate
 __all__ = ("NetBoxDNSZoneTemplateFilter",)
 
 
-@strawberry_django.filter(ZoneTemplate, lookups=True)
+@strawberry_django.filter_type(ZoneTemplate, lookups=True)
 class NetBoxDNSZoneTemplateFilter(
     ContactFilterMixin, TenancyFilterMixin, NetBoxModelFilterMixin
 ):

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/graphql/types.py

@@ -165,10 +165,9 @@ class NetBoxDNSRecordType(NetBoxObjectType):
         Annotated["NetBoxDNSRecordType", strawberry.lazy("netbox_dns.graphql.types")]
         | None
     )
-    address_record: (
+    address_records: List[
         Annotated["NetBoxDNSRecordType", strawberry.lazy("netbox_dns.graphql.types")]
-        | None
-    )
+    ]
     rfc2317_ptr_records: List[
         Annotated["NetBoxDNSRecordType", strawberry.lazy("netbox_dns.graphql.types")]
     ]

netbox_plugin_dns-1.3.2/netbox_dns/management/commands/remove_orphaned_ptr_records.py

@@ -0,0 +1,35 @@
+from django.core.management.base import BaseCommand
+
+from netbox_dns.models import Record
+from netbox_dns.choices import RecordTypeChoices
+
+
+class Command(BaseCommand):
+    help = "Remove managed PTR records without an address record"
+
+    def handle(self, *model_names, **options):
+        orphaned_ptr_records = Record.objects.filter(
+            type=RecordTypeChoices.PTR,
+            address_records__isnull=True,
+            managed=True,
+        )
+
+        if not orphaned_ptr_records.exists():
+            if options.get("verbosity") >= 1:
+                self.stdout.write("No orphaned PTR records found")
+            return
+
+        if options.get("verbosity") >= 1:
+            self.stdout.write(
+                f"Removing {orphaned_ptr_records.count()} orphaned PTR record(s) ..."
+            )
+
+        for record in orphaned_ptr_records:
+            if options.get("verbosity") >= 2:
+                self.stdout.write(
+                    f"removing PTR record {record} from zone {record.zone}"
+                )
+            record.delete()
+
+        if options.get("verbosity") >= 1:
+            self.stdout.write("... done.")

netbox_plugin_dns-1.3.2/netbox_dns/migrations/0021_alter_record_ptr_record.py

@@ -0,0 +1,25 @@
+# Generated by Django 5.2 on 2025-05-13 09:16
+
+import django.db.models.deletion
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("netbox_dns", "0020_remove_dnssecpolicy_parental_agents_and_more"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="record",
+            name="ptr_record",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="address_records",
+                to="netbox_dns.record",
+            ),
+        ),
+    ]

netbox_plugin_dns-1.3.2/netbox_dns/migrations/0022_alter_record_ipam_ip_address.py

@@ -0,0 +1,26 @@
+# Generated by Django 5.2.1 on 2025-05-19 19:34
+
+import django.db.models.deletion
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("ipam", "0081_remove_service_device_virtual_machine_add_parent_gfk_index"),
+        ("netbox_dns", "0021_alter_record_ptr_record"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="record",
+            name="ipam_ip_address",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="netbox_dns_records",
+                to="ipam.ipaddress",
+            ),
+        ),
+    ]

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/models/record.py

@@ -6,7 +6,7 @@ from dns import name as dns_name
 from dns import rdata
 
 from django.core.exceptions import ValidationError
-from django.db import transaction, models
+from django.db import models
 from django.db.models import Q, ExpressionWrapper, BooleanField, Min
 from django.conf import settings
 from django.utils.translation import gettext_lazy as _
@@ -28,7 +28,6 @@ from netbox_dns.choices import (
     RecordClassChoices,
 )
 
-
 __all__ = (
     "Record",
     "RecordIndex",
@@ -143,6 +142,11 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
         "tenant",
     )
 
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+
+        self._cleanup_ptr_record = None
+
     def __str__(self):
         try:
             fqdn = dns_name.from_text(
@@ -206,11 +210,11 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
         null=False,
         default=False,
     )
-    ptr_record = models.OneToOneField(
+    ptr_record = models.ForeignKey(
         verbose_name=_("PTR Record"),
         to="self",
         on_delete=models.SET_NULL,
-        related_name="address_record",
+        related_name="address_records",
         null=True,
         blank=True,
     )
@@ -241,7 +245,7 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
     ipam_ip_address = models.ForeignKey(
         verbose_name=_("IPAM IP Address"),
         to="ipam.IPAddress",
-        on_delete=models.CASCADE,
+        on_delete=models.SET_NULL,
         related_name="netbox_dns_records",
         blank=True,
         null=True,
@@ -255,6 +259,14 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
         blank=True,
     )
 
+    @property
+    def cleanup_ptr_record(self):
+        return self._cleanup_ptr_record
+
+    @cleanup_ptr_record.setter
+    def cleanup_ptr_record(self, ptr_record):
+        self._cleanup_ptr_record = ptr_record
+
     @property
     def display_name(self):
         return name_to_unicode(self.name)
@@ -348,21 +360,42 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
     def is_delegation_record(self):
         return self in self.zone.delegation_records
 
+    def refresh_ptr_record(
+        self, ptr_record=None, update_rfc2317_cname=True, save_zone_serial=True
+    ):
+        if ptr_record is None:
+            return
+
+        if not ptr_record.address_records.exists():
+            if ptr_record.rfc2317_cname_record is not None:
+                ptr_record.remove_from_rfc2317_cname_record()
+
+            ptr_record.delete(save_zone_serial=save_zone_serial)
+
+        elif update_rfc2317_cname:
+            ptr_record.update_rfc2317_cname_record(save_zone_serial=save_zone_serial)
+
     def update_ptr_record(self, update_rfc2317_cname=True, save_zone_serial=True):
         ptr_zone = self.ptr_zone
 
+        # +
+        # Check whether a PTR record is optioned for and return if that is not the
+        # case.
+        # -
         if (
             ptr_zone is None
             or self.disable_ptr
             or not self.is_active
             or self.name.startswith("*")
         ):
-            if self.ptr_record is not None:
-                with transaction.atomic():
-                    self.ptr_record.delete()
-                    self.ptr_record = None
+            self.cleanup_ptr_record = self.ptr_record
+            self.ptr_record = None
             return
 
+        # +
+        # Determine the ptr_name and ptr_value related to the ptr_zone. RFC2317
+        # PTR names and zones need to be handled differently.
+        # -
         if ptr_zone.is_rfc2317_zone:
             ptr_name = self.rfc2317_ptr_name
         else:
@@ -371,51 +404,76 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
                 .relativize(dns_name.from_text(ptr_zone.name))
                 .to_text()
             )
-
         ptr_value = self.fqdn
-        ptr_record = self.ptr_record
 
-        if ptr_record is not None:
+        # +
+        # If there is an existing and matching PTR record there is nothing to be done.
+        # -
+        if (ptr_record := self.ptr_record) is not None:
             if (
-                not ptr_record.zone.is_rfc2317_zone
-                and ptr_record.rfc2317_cname_record is not None
+                ptr_record.zone == ptr_zone
+                and ptr_record.name == ptr_name
+                and ptr_record.value == ptr_value
+                and ptr_record.ttl == self.ttl
             ):
+                return
+
+            # +
+            # If there is an RFC2317 CNAME for the PTR record and it is either
+            # not required or needs to be changed, remove it.
+            # -
+            if (
+                ptr_record.zone.pk != ptr_zone.pk or not ptr_record.zone.is_rfc2317_zone
+            ) and ptr_record.rfc2317_cname_record is not None:
                 ptr_record.rfc2317_cname_record.delete(
                     save_zone_serial=save_zone_serial
                 )
-
-        with transaction.atomic():
-            if ptr_record is not None:
-                if ptr_record.zone.pk != ptr_zone.pk:
-                    if ptr_record.rfc2317_cname_record is not None:
-                        ptr_record.rfc2317_cname_record.delete()
-                    ptr_record.delete(save_zone_serial=save_zone_serial)
-                    ptr_record = None
-
-                else:
-                    if (
-                        ptr_record.name != ptr_name
-                        or ptr_record.value != ptr_value
-                        or ptr_record.ttl != self.ttl
-                    ):
-                        ptr_record.name = ptr_name
-                        ptr_record.value = ptr_value
-                        ptr_record.ttl = self.ttl
-                        ptr_record.save(save_zone_serial=save_zone_serial)
-
-            if ptr_record is None:
-                ptr_record = Record(
-                    zone_id=ptr_zone.pk,
-                    type=RecordTypeChoices.PTR,
-                    name=ptr_name,
-                    ttl=self.ttl,
-                    value=ptr_value,
-                    managed=True,
-                )
+                ptr_record.rfc2317_cname_record = None
+
+            # +
+            # If the PTR record is used exclusively by the address record it can be
+            # modified to match the new name, zone, value and TTL.
+            # -
+            if ptr_record.address_records.count() == 1:
+                ptr_record.zone = ptr_zone
+                ptr_record.name = ptr_name
+                ptr_record.value = ptr_value
+                ptr_record.ttl = self.ttl
                 ptr_record.save(
                     update_rfc2317_cname=update_rfc2317_cname,
                     save_zone_serial=save_zone_serial,
                 )
+                return
+
+        # +
+        # Either there was no PTR record or the existing PTR record could not be re-used,
+        # so we need to either get find a matching PTR record or create a new one.
+        # -
+        try:
+            ptr_record = Record.objects.get(
+                name=ptr_name,
+                zone=ptr_zone,
+                type=RecordTypeChoices.PTR,
+                value=ptr_value,
+            )
+
+        # +
+        # If no existing PTR record could be found in the database, create a new
+        # one from scratch.
+        # -
+        except Record.DoesNotExist:
+            ptr_record = Record(
+                zone_id=ptr_zone.pk,
+                type=RecordTypeChoices.PTR,
+                name=ptr_name,
+                ttl=self.ttl,
+                value=ptr_value,
+                managed=True,
+            )
+            ptr_record.save(
+                update_rfc2317_cname=update_rfc2317_cname,
+                save_zone_serial=save_zone_serial,
+            )
 
         self.ptr_record = ptr_record
 
@@ -905,13 +963,19 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
                 save_zone_serial=save_zone_serial,
             )
         elif self.ptr_record is not None:
-            self.ptr_record.delete()
+            self.cleanup_ptr_record = self.ptr_record
             self.ptr_record = None
 
         changed_fields = self.changed_fields
         if changed_fields is None or changed_fields:
             super().save(*args, **kwargs)
 
+            self.refresh_ptr_record(
+                self.cleanup_ptr_record,
+                update_rfc2317_cname=update_rfc2317_cname,
+                save_zone_serial=save_zone_serial,
+            )
+
             if self.type != RecordTypeChoices.SOA and self.zone.soa_serial_auto:
                 self.zone.update_serial(save_zone_serial=save_zone_serial)
 
@@ -919,11 +983,16 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
         if self.rfc2317_cname_record:
             self.remove_from_rfc2317_cname_record(save_zone_serial=save_zone_serial)
 
-        if self.ptr_record:
-            self.ptr_record.delete()
+        ptr_record = self.ptr_record
 
         super().delete(*args, **kwargs)
 
+        self.refresh_ptr_record(
+            ptr_record,
+            update_rfc2317_cname=True,
+            save_zone_serial=save_zone_serial,
+        )
+
         _zone = self.zone
         if _zone.soa_serial_auto:
             _zone.update_serial(save_zone_serial=save_zone_serial)

{netbox_plugin_dns-1.3b2 → netbox_plugin_dns-1.3.2}/netbox_dns/models/zone.py

@@ -1036,7 +1036,7 @@ class Zone(ObjectModificationMixin, ContactsMixin, NetBoxModel):
             for address_record in address_records:
                 address_record.ptr_record.delete()
 
-            ptr_records = self.records.filter(address_record__isnull=False)
+            ptr_records = self.records.filter(address_records__isnull=False)
             update_records = list(
                 Record.objects.filter(ptr_record__in=ptr_records).values_list(
                     "pk", flat=True