mx-bluesky 1.5.6__tar.gz → 1.5.7__tar.gz

mx_bluesky-1.5.7/.devcontainer/devcontainer.json

@@ -0,0 +1,75 @@
+// For format details, see https://containers.dev/implementors/json_reference/
+{
+    "name": "Python 3 Developer Container",
+    "build": {
+        "dockerfile": "../Dockerfile",
+        "target": "developer"
+    },
+    "remoteEnv": {
+        // Allow X11 apps to run inside the container
+        "DISPLAY": "${localEnv:DISPLAY}"
+    },
+    "customizations": {
+        "vscode": {
+            // Set *default* container specific settings.json values on container create.
+            "settings": {
+                "python.defaultInterpreterPath": "/venv/bin/python"
+            },
+            // Add the IDs of extensions you want installed when the container is created.
+            "extensions": [
+                "ms-python.python",
+                "github.vscode-github-actions",
+                "tamasfe.even-better-toml",
+                "redhat.vscode-yaml",
+                "ryanluker.vscode-coverage-gutters",
+                "charliermarsh.ruff",
+                "ms-azuretools.vscode-docker"
+            ],
+            "python.testing.pytestArgs": [
+                "--cov=mx_bluesky",
+                "--cov-report",
+                "xml:cov.xml"
+            ],
+            "python.testing.unittestEnabled": false,
+            "python.testing.pytestEnabled": true,
+            "python.defaultInterpreterPath": "/venv/bin/python",
+            "editor.formatOnSave": true,
+            "editor.codeActionsOnSave": {
+                "source.organizeImports": "explicit"
+            },
+            "files.insertFinalNewline": true,
+            "[python]": {
+                "editor.rulers": [
+                    88
+                ],
+                "editor.codeActionsOnSave": {
+                    "source.fixAll.ruff": "explicit",
+                    "source.organizeImports.ruff": "explicit"
+                },
+                "editor.defaultFormatter": "charliermarsh.ruff"
+            },
+            "terminal.integrated.gpuAcceleration": "off",
+            "python.analysis.typeCheckingMode": "basic"
+        }
+    },
+    "features": {
+        // Some default things like git config
+        // add in eternal history and other bash features
+        "ghcr.io/diamondlightsource/devcontainer-features/bash-config:1": {}
+    },
+    // Create the config folder for the bash-config feature
+    "initializeCommand": "mkdir -p ${localEnv:HOME}/.config/bash-config",
+    "runArgs": [
+        // Allow the container to access the host X11 display and EPICS CA
+        "--net=host",
+        // Make sure SELinux does not disable with access to host filesystems like tmp
+        "--security-opt=label=disable"
+    ],
+    // Mount the parent as /workspaces so we can pip install peers as editable
+    "workspaceMount": "source=${localWorkspaceFolder}/..,target=/workspaces,type=bind",
+    "mounts": [
+        "source=/dls_sw/apps/dials/latest/latest/modules/dlstbx/src/dlstbx/,target=/dls_sw/apps/dials/latest/latest/modules/dlstbx/src/dlstbx/,type=bind,consistency=cached"
+    ],
+    // After the container is created, install the python project in editable form
+    "postCreateCommand": "pip install $([ -f dev-requirements.txt ] && echo '-c dev-requirements.txt') -e '.[dev]' && pip install -e /workspaces/dodal[dev] && pre-commit install && ln -s /dls_sw/apps/dials/latest/latest/modules/dlstbx/src/dlstbx/ /venv/lib/python3.12/site-packages/dlstbx"
+}

mx_bluesky-1.5.7/.vscode/mx-bluesky-dev-container.code-workspace

@@ -0,0 +1,23 @@
+{
+    "folders": [
+        {
+            "path": ".."
+        },
+        {
+            "path": "../../dodal"
+        },
+    ],
+    "settings": {
+        "python.languageServer": "Pylance",
+        "[python]": {
+            "editor.defaultFormatter": "ms-python.black-formatter"
+        },
+        "python.defaultInterpreterPath": "venv/bin/python",
+        "python.analysis.extraPaths": [
+            "../dodal"
+        ],
+        "python.analysis.autoImportCompletions": true,
+        "terminal.integrated.gpuAcceleration": "off",
+        "esbonio.sphinx.confDir": ""
+    }
+}

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/.vscode/mx-bluesky.code-workspace

@@ -13,7 +13,9 @@
             "editor.defaultFormatter": "ms-python.black-formatter"
         },
         "python.defaultInterpreterPath": ".venv/bin/python",
-        "python.analysis.extraPaths": ["../dodal"],
+        "python.analysis.extraPaths": [
+            "../dodal"
+        ],
         "python.analysis.autoImportCompletions": true,
         "terminal.integrated.gpuAcceleration": "off",
         "esbonio.sphinx.confDir": ""

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: mx-bluesky
-Version: 1.5.6
+Version: 1.5.7
 Summary: Bluesky tools for MX Beamlines at DLS
 Author-email: Dominic Oram <dominic.oram@diamond.ac.uk>
 License:                                  Apache License
@@ -241,7 +241,7 @@ Requires-Dist: blueapi>=0.15.0
 Requires-Dist: ophyd>=1.10.5
 Requires-Dist: ophyd-async>=0.10.0a2
 Requires-Dist: bluesky>=1.13.1
-Requires-Dist: dls-dodal==1.58.0
+Requires-Dist: dls-dodal==1.59.1
 Provides-Extra: dev
 Requires-Dist: black; extra == "dev"
 Requires-Dist: build; extra == "dev"

mx_bluesky-1.5.7/docs/developer/general/how-to/get-started.md

@@ -0,0 +1,33 @@
+# Get Started with mx-bluesky
+
+## Development Environment
+
+We recommend using devcontainers with vscode as the IDE when developing using a DLS machine. Here's how you can set this up:
+
+- Clone this repo using SSH: `git clone git@github.com:DiamondLightSource/mx-bluesky.git`.
+- At the same directory level as you were in for step 1, clone dodal using SSH: `git clone git@github.com:DiamondLightSource/dodal.git`.
+You should now have a directory structure looking like`/some_path/mx-bluesky` and `/some_path/dodal`.
+- In a terminal, move to the mx-bluesky directory and open vscode:
+
+```
+cd /some_path/mx-bluesky  
+module load vscode  
+code .
+```
+
+- Make sure you have the [devcontainers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) installed in vscode.
+- In vscode, press `shift+ctrl+p`, and type "Dev Containers: Open Folder in Container", then select the mx-bluesky folder.
+- Once this has built, in vscode at the top right, click `File -> Open workspace from file`, then select `mx-bluesky/.vscode/mx-bluesky-dev-container.code-workspace`.
+- This should get dodal and mx-bluesky opened up in your workspace with all the correct settings. To prove to yourself that the environment is correct, type `tox -e tests` in a terminal in your devcontainer while inside the dodal and inside the mx-bluesky directory.
+
+### Notes
+- The devcontainer initially takes quite a long time to build. It will be much faster every other time, and only needs to be rebuild if we change the container environment.
+- The first time you make a commit after building, you will need to follow some git prompts to set your git name and email.
+- The old `dls_dev_env.sh` script creates a virtual environment in `mx-bluesky/.venv`, while the devcontainer creates one in `mx-bluesky/venv`. This is the only reason why we need separate code-workspace files.
+
+## Supported Python versions
+
+
+As a standard for the python versions to support, we are using the [numpy deprecation policy](https://numpy.org/neps/nep-0029-deprecation_policy.html)
+
+Currently supported versions are: 3.11, 3.12.

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/docs/developer/hyperion/index.rst

@@ -13,6 +13,7 @@ Documentation specific for the Hyperion module within MX-Bluesky
             :maxdepth: 1
 
             reference/readme
+            reference/baton
             reference/param-hierarchy
             reference/coordinate-systems
             deploying-hyperion

mx_bluesky-1.5.7/docs/developer/hyperion/reference/baton.rst

@@ -0,0 +1,22 @@
+Hyperion Baton
+==============
+
+The Hyperion baton is controlled by two PVs; these are described under `Special PVs`_
+
+An approximate outline of how the various baton workflows operates is outlined in the flowcharts below:
+
+.. image:: ../../../images/417717258-afbd813c-8941-445c-9fdf-255c167453cf.png
+
+.. _Special PVs: ../../../user/hyperion/pvs.html
+
+
+GDA-side Baton Integration
+--------------------------
+
+Below is a diagram showing how baton-handling in GDA integrates the GDA baton with the Hyperion Baton PV, using the 
+``HyperionUDCRunner``.
+
+The diagram represents an interim stage; at some point ``GDAUDCRunner`` can be eliminated and the baton management 
+simplified.
+
+.. uml:: gda-baton.puml

mx_bluesky-1.5.7/docs/developer/hyperion/reference/gda-baton.puml

@@ -0,0 +1,192 @@
+@startuml
+title GDA Baton Management
+
+package Server {
+    class Thread
+    class JythonServerThread extends Thread {
+        authorisationLevel: int
+        int getAuthorisationLevel()
+    }
+        
+    interface IBatonManager {
+        ClientDetails getClientInformation((myJSFIdentifier)
+        boolean requestBaton(uniqueIdentifier)
+        void returnBaton((uniqueIdentifier)
+        void assignBaton(myJSFIdentifier, indexOfReceiver, indexOfPasser)
+        boolean isBatonHeld()
+        boolean amIBatonHolder(myJSFIdentifier)
+        int effectiveAuthorisationLevelOf(uniqueId)
+        void addFacade(uniqueId, info: ClientDetails)
+        void removeFacade(uniqueId)
+    }
+    
+    class BatonManager implements IBatonManager {
+        useBaton = true
+        useRBAC = true
+        firstClientTakesBaton = true
+        batonHolder: String
+        facadeNames: Map<String, ClientInfo>
+        leaseHolders: Map<String, Long>
+    }
+    
+    note "Each client has a facade name aka uniqueId aka jsfIdentifier\n\
+There is a LeaseRefresher that periodically sends a BatonLeaseRenewRequest\n\
+to all clients, any interaction with the BatonManager extends the lease.\n\n\
+On first client registration, if firstClientTakesBaton is true then it will\n\
+assume the baton if it is not the server or an automated client." as batonManagerNote
+
+    BatonManager .. batonManagerNote
+
+
+    interface IJythonServerNotifier {
+        void notifyServer(source, data)    
+    }
+    interface LocalJython
+    class JythonServer implements LocalJython {
+        batonManager: BatonManager
+    }
+
+    note "JythonServer registers a client with the BatonManager via forwarding of addFacade()\n\
+The authorisationLevel is determined by asking the Authoriser" as jythonServerNote
+
+    JythonServer .. jythonServerNote
+        
+    interface Authoriser {
+        int getAuthorisationLevel(username)
+        int getDefaultPermissions(username)
+        isLocalStaff(username)    
+    }
+    
+    class FileAuthoriser implements Authoriser
+    note "Gets the permissions from user_permissions.xml" as fileAuthoriserNote
+    FileAuthoriser .. fileAuthoriserNote
+    class LdapAuthoriser extends FileAuthoriser
+    class SingleFileAuthoriser implements Authoriser
+    note "Authorisation method is determined by gda.gui.AcquisitionGUI.authorisationMethod" as authoriserNote
+    
+    Authoriser .. authoriserNote    
+
+    together {
+        class UDCBatonHandler {
+            runner: IUDCRunner
+        }
+        interface IUDCRunner
+        class GDAUDCRunner implements IUDCRunner
+        class HyperionUDCRunner implements IUDCRunner
+    }
+
+    note "\
+Creates the UDC Client by calling getUnattendedClientFacade() during configuration.\n\
+Creates the UDC Runner according to the gda.mx.udc.hyperion.enable property.\
+" as udcBatonHandlerNote
+    UDCBatonHandler .. udcBatonHandlerNote
+
+    class Device {
+        protectionLevel: int
+    }
+    class DeviceInterceptor
+    note "DeviceInterceptor is an interceptor on specific methods of Device, if the current thread\n\
+has an authorisationLevel below the protectionLevel of the device, and\n\
+the call is made from Jython the method call throws AccessDeniedException." as deviceNote
+    Device .. deviceNote
+    
+    
+    
+    class UDCCompleteEvent
+    
+}
+
+package Common {
+    together {
+        class BatonChanged
+        class BatonRequested
+        class BatonLeaseRenewRequest
+    }
+
+    interface Jython {
+        boolean amIBatonHolder(myJSFIdentifier)
+        int addFacade(jsfIdentifier, hostname, username, fullName, visitId)
+        boolean isBatonHeld()
+    }
+
+    class ClientInfo {
+        index: int
+        userId: String
+        fullName: String
+        hostname: String
+        authorisationLevel: int
+        visitID: String
+        
+        boolean isServer()
+        boolean isAutomatedUser()
+    }
+    note "isServer and isAutomatedUser are determined by the authorisationLevel" as clientInfoNote
+    ClientInfo .. clientInfoNote
+    
+    class ClientDetails extends ClientInfo {
+     hasBaton: boolean
+    }
+
+    interface IAuthorisationHolder {
+        int getAuthorisationLevel()
+        int getAuthorisationLevelAtRegistration()
+    }
+    
+    interface IBatonStateProvider {
+        boolean amIBatonHolder()
+        boolean isBatonHeld()
+        void addBatonChangedObserver(observer)
+        void deleteBatonChangedObserver(observer)
+    }
+    note "Access is enforced in the client via calls to amIBatonHolder()" as iBatonStateProviderNote
+
+    class JythonServerFacade implements IBatonStateProvider, IAuthorisationHolder {
+        commandServer: Jython
+        visitID: String
+        {static} JythonServerFacade getUnattendedClientFacade()
+    }
+}
+
+package Client {
+  class ApplicationWorkbenchAdvisor
+    note "ApplicationWorkbenchAdvisor receives the BatonLeaseRenewRequest and uses IBatonStateProvider\n\
+to renew the lease by calling amIBatonHolder()" as applicationWorkbenchAdvisorNote
+}
+
+'Server -up-> Common
+'Common -up[hidden]-> Client
+ApplicationWorkbenchAdvisor ..[norank] applicationWorkbenchAdvisorNote
+   
+ApplicationWorkbenchAdvisor --down> IBatonStateProvider
+
+IBatonStateProvider .. iBatonStateProviderNote
+LocalJython -up-|> Jython
+LocalJython --|> IJythonServerNotifier
+
+JythonServerFacade o-> Jython
+JythonServer o->BatonManager
+JythonServer --> Authoriser
+
+JythonServer --> JythonServerThread
+
+BatonChanged --> UDCBatonHandler : handles
+BatonRequested --> UDCBatonHandler : handles
+UDCCompleteEvent --> UDCBatonHandler : handles
+
+UDCBatonHandler -[norank]-> JythonServerFacade
+UDCBatonHandler o-> IUDCRunner
+BatonManager -up-> BatonChanged : fires
+BatonManager -up-> BatonRequested : fires
+BatonManager -up-> BatonLeaseRenewRequest : fires
+GDAUDCRunner -[norank]-> UDCCompleteEvent : fires
+BatonManager *-[norank]-> ClientInfo
+
+UDCCompleteEvent --> GDAUDCRunner : handles
+HyperionUDCRunner --> UDCCompleteEvent : fires
+
+DeviceInterceptor --> Device
+DeviceInterceptor --> JythonServerThread
+
+BatonManager -up-> IJythonServerNotifier
+
+@enduml

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/docs/developer/hyperion/reference/gridscan.puml

@@ -97,13 +97,13 @@ class GridScanParamsCommon {
     z2_start_mm
 }
 class PandAGridScanParams
-class ZebraGridScanParams
+class ZebraGridScanParamsThreeD
 
 AbstractExperimentBase <|-- AbstractExperimentWithBeamParams
 AbstractExperimentWithBeamParams <|-- GridScanParamsCommon
 GridScanParamsCommon <|-- PandAGridScanParams
-GridScanParamsCommon <|-- ZebraGridScanParams
+GridScanParamsCommon <|-- ZebraGridScanParamsThreeD
 
-HyperionThreeDGridScan --> ZebraGridScanParams : generates
+HyperionThreeDGridScan --> ZebraGridScanParamsThreeD : generates
 HyperionThreeDGridScan --> PandAGridScanParams : generates
 @enduml

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/docs/user/hyperion/index.rst

@@ -2,7 +2,7 @@ Hyperion User Guide
 ===================
 
 The Hyperion User Guide describes how to run, configure and troubleshoot Hyperion. For installation instructions, see
-the Developer Guide.
+the `Developer Guide`_.
 
 What is Hyperion?
 -----------------
@@ -16,25 +16,38 @@ The software supports two modes of operation:
 * GDA mode (where GDA fetches and decodes the Agamemnon
   instructions). GDA mode will be removed in a future release.
 
-The mode of operation is determined by configuration using the ``gda.mx.udc.hyperion.enable`` parameter
+The mode of operation is determined by configuration using the ``gda.mx.udc.hyperion.enable`` parameter inside 
+GDA properties. See `configuration`_ for other properties that control Hyperions behavior. 
 
 Once Hyperion has received a request, either from GDA or directly from Agamemnon, it will do the following tasks:
 
-- Robot Load (if necessary)
-- Pin tip detection using the OAV
-- Xray Centring
+- Robot Load (if the requested sample has not yet been loaded)
+- Pin tip centring using the OAV
+- Xray Centring using 2 2D gridscans 
 - A number of data collections, depending on the number of centres returned from Zocalo and the applied selection criteria
 
 During this it will generate the following outputs:
 
 - Snapshots on robot load, XRC and rotations
 - Data collections in ISPyB for the gridscans and rotations as well as entries for robot load/unload
-- Nexus files for each data collection
+- NeXus files for each data collection
 - Alert notifications on loading a new container and on beamline error conditions when intervention is required.  
 
+To increase throughput, the behavior of Hyperion differs in many ways from UDC under GDA. The main ways this manifests 
+to a user is:
+
+- Xray Centring is 2 2D gridscans (rather than the one gridscan and one line scan in GDA). For speed, the eiger is only
+  armed once for both of these and the data is split up after the fact. This means on the filesystem there is one set of 
+  hdf files for both gridscans but two NeXus files. The two grid scans are stored in ISPyB under one data collection 
+  group so at first glance it may look like one gridscan in synchweb but you can click through to see both scans.
+- If an xray centre cannot be done on a pin (because it is too long/short or bent), or if no diffraction is found in the 
+  xray centring data, the sample will be immediately unloaded without a rotation scan being done and the next sample loaded.
+
 For a more detailed breakdown of the operation, it may be helpful to browse the  `Code Map`_
 
 .. _Code Map: ../../developer/code-map 
+.. _Developer Guide: ../../developer/hyperion/deploying-hyperion
+.. _configuration: ./configuration
 
 .. toctree::
     :caption: Topics

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/docs/user/hyperion/troubleshooting.rst

@@ -15,6 +15,12 @@ Graylog
 Graylog is the recommended way to view logs. It is used for more centralised logging which is also more easily 
 searched and archived. Log messages are sent to the `Hyperion graylog stream <https://graylog.diamond.ac.uk/streams/66264f5519ccca6d1c9e4e03/search>`_.
 
+To find different severity of message you can search for ``level: X``. Where X is:
+
+* ``3``: Errors messages - usually causing Hyperion to have stopped. Note that no diffraction is currently logged as an error but this doesn't stop Hyperion, only skip the sample. This will be improved by https://github.com/DiamondLightSource/mx-bluesky/issues/427.
+* ``4``: Warnings - usually not a major problem
+* ``6``: Info - Just telling you what Hyperion is doing
+
 
 Startup Log
 ~~~~~~~~~~~

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/pyproject.toml

@@ -48,7 +48,7 @@ dependencies = [
     "ophyd >= 1.10.5",
     "ophyd-async >= 0.10.0a2",
     "bluesky >= 1.13.1",
-    "dls-dodal == 1.58.0",
+    "dls-dodal == 1.59.1",
 ]
 
 

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/src/mx_bluesky/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '1.5.6'
-__version_tuple__ = version_tuple = (1, 5, 6)
+__version__ = version = '1.5.7'
+__version_tuple__ = version_tuple = (1, 5, 7)
 
-__commit_id__ = commit_id = 'g6a9297fcb'
+__commit_id__ = commit_id = 'ge1f29265f'

mx_bluesky-1.5.7/src/mx_bluesky/beamlines/i02_1/parameters/gridscan.py

@@ -0,0 +1,35 @@
+from dodal.devices.i02_1.fast_grid_scan import ZebraGridScanParamsTwoD
+from scanspec.specs import Product
+
+from mx_bluesky.common.parameters.components import SplitScan, WithOptionalEnergyChange
+from mx_bluesky.common.parameters.gridscan import SpecifiedGrid
+
+
+class SpecifiedTwoDGridScan(
+    SpecifiedGrid[ZebraGridScanParamsTwoD],
+    SplitScan,
+    WithOptionalEnergyChange,
+):
+    """Parameters representing a so-called 2D grid scan, which consists of doing a
+    gridscan in X and Y."""
+
+    @property
+    def scan_spec(self) -> Product[str]:
+        """A fully specified ScanSpec object representing the grid, with x, y, z and
+        omega positions."""
+        return self.grid_1_spec
+
+    @property
+    def FGS_params(self) -> ZebraGridScanParamsTwoD:
+        return ZebraGridScanParamsTwoD(
+            x_steps=self.x_steps,
+            y_steps=self.y_steps,
+            x_step_size_mm=self.x_step_size_um / 1000,
+            y_step_size_mm=self.y_step_size_um / 1000,
+            x_start_mm=self.x_start_um / 1000,
+            y1_start_mm=self.y_start_um / 1000,
+            z1_start_mm=self.z_start_um / 1000,
+            set_stub_offsets=self._set_stub_offsets,
+            transmission_fraction=0.5,
+            dwell_time_ms=self.exposure_time_s,
+        )

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/src/mx_bluesky/beamlines/i04/experiment_plans/i04_grid_detect_then_xray_centre_plan.py

@@ -13,7 +13,7 @@ from dodal.devices.common_dcm import BaseDCM
 from dodal.devices.detector.detector_motion import DetectorMotion
 from dodal.devices.eiger import EigerDetector
 from dodal.devices.fast_grid_scan import (
-    ZebraFastGridScan,
+    ZebraFastGridScanThreeD,
     set_fast_grid_scan_params,
 )
 from dodal.devices.flux import Flux
@@ -48,6 +48,7 @@ from mx_bluesky.common.external_interaction.callbacks.common.zocalo_callback imp
 )
 from mx_bluesky.common.external_interaction.callbacks.xray_centre.ispyb_callback import (
     GridscanISPyBCallback,
+    generate_start_info_from_omega_map,
 )
 from mx_bluesky.common.external_interaction.callbacks.xray_centre.nexus_callback import (
     GridscanNexusFileCallback,
@@ -80,7 +81,7 @@ def i04_grid_detect_then_xray_centre(
     backlight: Backlight = inject("backlight"),
     beamstop: Beamstop = inject("beamstop"),
     dcm: BaseDCM = inject("dcm"),
-    zebra_fast_grid_scan: ZebraFastGridScan = inject("zebra_fast_grid_scan"),
+    zebra_fast_grid_scan: ZebraFastGridScanThreeD = inject("zebra_fast_grid_scan"),
     flux: Flux = inject("flux"),
     oav: OAV = inject("oav"),
     pin_tip_detection: PinTipDetection = inject("pin_tip_detection"),
@@ -198,7 +199,9 @@ def create_gridscan_callbacks() -> tuple[
         GridscanISPyBCallback(
             param_type=GridCommon,
             emit=ZocaloCallback(
-                PlanNameConstants.DO_FGS, EnvironmentConstants.ZOCALO_ENV
+                PlanNameConstants.DO_FGS,
+                EnvironmentConstants.ZOCALO_ENV,
+                generate_start_info_from_omega_map,
             ),
         ),
     )

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/src/mx_bluesky/beamlines/i04/redis_to_murko_forwarder.py

@@ -7,7 +7,7 @@ from typing import TypedDict
 import numpy as np
 import zmq
 from dodal.devices.i04.constants import RedisConstants
-from dodal.devices.i04.murko_results import FullMurkoResults, MurkoResult
+from dodal.devices.i04.murko_results import MurkoResult
 from numpy.typing import NDArray
 from PIL import Image
 from redis import StrictRedis
@@ -16,6 +16,8 @@ from mx_bluesky.common.utils.log import LOGGER
 
 MURKO_ADDRESS = "tcp://i04-murko-prod.diamond.ac.uk:8008"
 
+FullMurkoResults = dict[str, list[MurkoResult]]
+
 
 class MurkoRequest(TypedDict):
     """See https://github.com/MartinSavko/murko#usage for more information."""

{mx_bluesky-1.5.6 → mx_bluesky-1.5.7}/src/mx_bluesky/beamlines/i04/thawing_plan.py

@@ -1,8 +1,9 @@
 from collections.abc import Callable
+from functools import partial
 
 import bluesky.plan_stubs as bps
 import bluesky.preprocessors as bpp
-from bluesky.preprocessors import run_decorator, stage_wrapper, subs_decorator
+from bluesky.preprocessors import run_decorator, subs_decorator
 from bluesky.utils import MsgGenerator
 from dodal.common import inject
 from dodal.devices.i04.constants import RedisConstants
@@ -42,7 +43,7 @@ def thaw_and_stream_to_redis(
     robot: BartRobot = inject("robot"),
     thawer: Thawer = inject("thawer"),
     smargon: Smargon = inject("smargon"),
-    oav: OAV = inject("oav"),
+    oav: OAV = inject("oav_full_screen"),
     oav_to_redis_forwarder: OAVToRedisForwarder = inject("oav_to_redis_forwarder"),
 ) -> MsgGenerator:
     """Turns on the thawer and rotates the sample by {rotation} degrees to thaw it, then
@@ -84,7 +85,7 @@ def thaw_and_murko_centre(
     robot: BartRobot = inject("robot"),
     thawer: Thawer = inject("thawer"),
     smargon: Smargon = inject("smargon"),
-    oav: OAV = inject("oav"),
+    oav: OAV = inject("oav_full_screen"),
     murko_results: MurkoResultsDevice = inject("murko_results"),
     oav_to_redis_forwarder: OAVToRedisForwarder = inject("oav_to_redis_forwarder"),
 ) -> MsgGenerator:
@@ -109,14 +110,14 @@ def thaw_and_murko_centre(
                      defaults are always correct
     """
 
+    MURKO_RESULTS_GROUP = "get_results"
+
     def centre_then_switch_forwarder_to_ROI() -> MsgGenerator:
         yield from bps.complete(oav_to_redis_forwarder, wait=True)
 
-        yield from bps.trigger(murko_results, group="get_results")
-
         yield from bps.mv(oav_to_redis_forwarder.selected_source, Source.ROI.value)
 
-        yield from bps.wait("get_results")
+        yield from bps.wait(MURKO_RESULTS_GROUP)
         x_predict = yield from bps.rd(murko_results.x_mm)
         y_predict = yield from bps.rd(murko_results.y_mm)
         z_predict = yield from bps.rd(murko_results.z_mm)
@@ -127,7 +128,13 @@ def thaw_and_murko_centre(
 
         yield from bps.kickoff(oav_to_redis_forwarder, wait=True)
 
-    yield from stage_wrapper(
+    sample_id = yield from bps.rd(robot.sample_id)
+    yield from bps.abs_set(murko_results.sample_id, int(sample_id))
+
+    yield from bps.stage(murko_results)
+    yield from bps.trigger(murko_results, group=MURKO_RESULTS_GROUP)
+
+    yield from bpp.contingency_wrapper(
         _thaw_and_stream_to_redis(
             time_to_thaw,
             rotation,
@@ -138,7 +145,7 @@ def thaw_and_murko_centre(
             oav_to_redis_forwarder,
             centre_then_switch_forwarder_to_ROI,
         ),
-        [murko_results],
+        final_plan=partial(bps.unstage, murko_results),
     )