muxplex-deck 0.7.0__tar.gz → 0.8.0__tar.gz

{muxplex_deck-0.7.0 → muxplex_deck-0.8.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: muxplex-deck
-Version: 0.7.0
+Version: 0.8.0
 Summary: Hardware probe/diagnostic app for the Elgato Stream Deck+ (seed of the muxplex sidecar)
 Author: Amplifier
 Author-email: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>

{muxplex_deck-0.7.0 → muxplex_deck-0.8.0}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "muxplex-deck"
-version = "0.7.0"
+version = "0.8.0"
 description = "Hardware probe/diagnostic app for the Elgato Stream Deck+ (seed of the muxplex sidecar)"
 readme = "README.md"
 authors = [

{muxplex_deck-0.7.0 → muxplex_deck-0.8.0}/src/muxplex_deck/cli.py

@@ -60,6 +60,15 @@ def _add_run_flags(parser: argparse.ArgumentParser) -> None:
         default=8484,
         help="Port for the emulator's web UI (default: 8484). Ignored without --emulator.",
     )
+    parser.add_argument(
+        "--log-file",
+        default=None,
+        help="Write logs to this file instead of stderr (default: stderr, unchanged "
+        "behavior). All platforms -- required in practice under Windows Task "
+        "Scheduler, since pythonw.exe has no console for stderr to go to "
+        "(see WINDOWS_NATIVE_SPEC.md section 1.5); `muxplex-deck service install` "
+        "passes this automatically on Windows.",
+    )
 
 
 def run(
@@ -67,6 +76,7 @@ def run(
     *,
     emulator: bool = False,
     emulator_port: int = 8484,
+    log_file: str | None = None,
 ) -> int:
     """Load config, build the device backend, and run the sidecar's main loop.
 
@@ -90,7 +100,8 @@ def run(
         print(str(exc), file=sys.stderr)
         return 1
 
-    return main_mod.run(cfg, manager)
+    log_path = Path(log_file).expanduser() if log_file else None
+    return main_mod.run(cfg, manager, log_file=log_path)
 
 
 # ---------------------------------------------------------------------------
@@ -758,19 +769,15 @@ def check_service_status() -> tuple[str, str]:
     if sys.platform == "darwin":
         manager, tool = "launchd", "launchctl"
     elif sys.platform == "win32":
-        # Accurate-but-misleading is still misleading: "systemctl not
-        # found" frames this as a missing Linux tool, when the real story
-        # is that background-service support (Task Scheduler) is a
-        # not-yet-built increment on this platform -- not something the
-        # user is missing or can install their way out of.
-        return "warn", (
-            "Service: background-service install isn't supported on "
-            "Windows yet -- run: muxplex-deck"
-        )
+        # Task Scheduler has no single "is the tool present" probe the way
+        # `shutil.which("systemctl")` does -- `schtasks.exe` ships with
+        # every Windows install, so there's nothing to gate on here; skip
+        # straight to the installed/active checks below.
+        manager, tool = "Task Scheduler", None
     else:
         manager, tool = "systemd", "systemctl"
 
-    if shutil.which(tool) is None:
+    if tool is not None and shutil.which(tool) is None:
         return "warn", f"Service: {tool} not found -- run muxplex-deck directly"
 
     if not service_is_installed():
@@ -1378,19 +1385,19 @@ def update(*, force: bool = False) -> None:
     was_active = _service_is_active()
     if was_active:
         print("  Stopping service...")
-        if sys.platform == "darwin":
-            uid = os.getuid()
-            subprocess.run(
-                ["launchctl", "bootout", f"gui/{uid}/com.muxplex-deck"],
-                capture_output=True,
-                check=False,
-            )
-        else:
-            subprocess.run(
-                ["systemctl", "--user", "stop", "muxplex-deck"],
-                capture_output=True,
-                check=False,
-            )
+        # Was a hardcoded launchctl/systemctl-only block -- the `else`
+        # branch ran `systemctl` unconditionally, which raises
+        # `FileNotFoundError` on Windows (`check=False` only suppresses a
+        # nonzero *exit*, not a failed *exec*). This was latent only
+        # because `service_is_active()` returned False on Windows before
+        # Task Scheduler support existed -- now that it can return True
+        # there, this must dispatch per platform. `service.service_stop()`
+        # already does exactly that (darwin/windows/systemd), so this is
+        # strictly less code, one dispatch site, not a duplicated stop
+        # implementation.
+        from .service import service_stop
+
+        service_stop()
     else:
         print("  No active service found (skipping stop)")
 

{muxplex_deck-0.7.0 → muxplex_deck-0.8.0}/src/muxplex_deck/main.py

@@ -50,9 +50,11 @@ from __future__ import annotations
 
 import logging
 import signal
+import sys
 import threading
 import time
 from collections.abc import Callable
+from pathlib import Path
 from urllib.parse import urlparse
 
 from muxplex_client import (
@@ -94,7 +96,38 @@ FULL_BRIGHTNESS_PERCENT = 100
 _MAX_VIEW_LABEL_CHARS = 20
 
 
-def _configure_logging() -> None:
+def _configure_logging(log_file: Path | None = None) -> None:
+    """Configure logging, optionally to a rotating file instead of stderr.
+
+    `log_file` is required in practice on Windows under Task Scheduler:
+    `pythonw.exe` (the GUI-subsystem interpreter `service._resolve_pythonw()`
+    resolves to -- see WINDOWS_NATIVE_SPEC.md section 1.5) leaves
+    `sys.stdout`/`sys.stderr` as `None`, and `logging.StreamHandler()` around
+    a `None` stream would fail. `cli.py`'s `--log-file` flag (all platforms,
+    default `None`) is what plumbs a path down to here; on macOS/Linux this
+    stays `None` and behavior is byte-for-byte unchanged from before this
+    parameter existed.
+    """
+    if log_file is not None:
+        from logging.handlers import RotatingFileHandler
+
+        log_file.parent.mkdir(parents=True, exist_ok=True)
+        handler = RotatingFileHandler(
+            log_file, maxBytes=2_000_000, backupCount=3, encoding="utf-8"
+        )
+        handler.setFormatter(
+            logging.Formatter(
+                fmt="%(asctime)s.%(msecs)03d %(levelname)s %(message)s",
+                datefmt="%H:%M:%S",
+            )
+        )
+        logging.basicConfig(level=logging.INFO, handlers=[handler])
+        return
+    if sys.stderr is None:
+        # Defensive: a console-less launch with no --log-file must not
+        # crash trying to build a StreamHandler around a None stream.
+        logging.basicConfig(level=logging.INFO, handlers=[logging.NullHandler()])
+        return
     logging.basicConfig(
         level=logging.INFO,
         format="%(asctime)s.%(msecs)03d %(levelname)s %(message)s",
@@ -1035,8 +1068,8 @@ def _install_signal_handler() -> threading.Event:
     return shutting_down
 
 
-def run(config: Config, manager: DeviceManager) -> int:
-    _configure_logging()
+def run(config: Config, manager: DeviceManager, *, log_file: Path | None = None) -> int:
+    _configure_logging(log_file)
 
     shutting_down = _install_signal_handler()
     hostname = urlparse(config.server_url).hostname or config.server_url