multi_notifier 0.6.2__tar.gz → 0.6.3__tar.gz

multi_notifier-0.6.3/CLAUDE.md

@@ -0,0 +1,83 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Commands
+
+All commands use `uv` as the package manager.
+
+```bash
+# Install dependencies
+uv sync --frozen --all-groups
+
+# Lint (with autofix)
+uv run ruff check --fix multi_notifier
+
+# Format
+uv run ruff format multi_notifier
+
+# Type checking
+uv run mypy multi_notifier
+
+# Run tests with coverage
+uv run pytest --cov=multi_notifier --cov-report=html --cov-report=term
+
+# Run a single test file
+uv run pytest tests/connectors/test_connector_mail.py
+
+# Run all pre-commit hooks
+uv run prek run --all-files
+```
+
+## Architecture
+
+`multi_notifier` is a Python library for sending notifications over multiple protocols. The two implemented connectors are **Mail** (SMTP) and **Telegram** (via `aiogram`).
+
+### Key abstractions
+
+- **`multi_notifier/connectors/interface.py`** — Abstract base class all connectors must implement:
+
+  - `send_message(recipient, message, subject=None, images=None)` — accepts a single recipient or a list
+  - `is_valid_recipient(recipient)` — static method for format validation
+
+- **Config models** — each connector defines a Pydantic v2 `<Protocol>Config` model that is validated at init time. The Telegram connector also calls `_test_config()` (an async call wrapped in `asyncio.run()`) during `__init__` to verify the bot token against the API.
+
+- **Exceptions** — `multi_notifier/connectors/exceptions.py` contains `ConnectorError`, `ConnectorConfigurationError`, and `ConnectorTimeoutError`; the top-level `multi_notifier/exceptions.py` holds `NotificationError` and `ConfigurationError`.
+
+### Email MIME details
+
+The Mail connector builds MIME structure dynamically based on content:
+
+| Content | MIME type |
+|---|---|
+| Plain text only | `multipart/alternative` |
+| Plain text + images | `multipart/mixed` |
+| HTML only | `multipart/alternative` |
+| HTML + images | `multipart/related` |
+
+Images are embedded via Content-ID for HTML and sent as attachments for plain text.
+
+### Telegram HTML
+
+The Telegram connector uses `sulguk.transform_html()` to convert HTML into Telegram message entities. Images are sent as a media group (photos).
+
+### Adding a new connector
+
+1. Create `multi_notifier/connectors/connector_<protocol>.py`
+1. Define a `<Protocol>Config` Pydantic model
+1. Subclass `Interface` and implement `send_message` and `is_valid_recipient`
+1. Raise exceptions from `multi_notifier.connectors.exceptions`
+1. Add `tests/connectors/test_connector_<protocol>.py` with async-compatible tests
+
+## Changelog
+
+Every change must be documented in `changelog.md` under a new version heading using the format `# Version X.Y.Z - DD.MM.YYYY`, and the version in `multi_notifier/__init__.py` must be bumped to match.
+
+## Code quality standards
+
+- **Python** ≥ 3.11
+- **Line length** 150 characters (ruff)
+- **Docstrings** Google style
+- **Coverage** 100% required (`fail_under = 100`)
+- **Ruff** runs with `select = ["ALL"]` — check `pyproject.toml` for the explicit ignores list before adding new code
+- Async tests use `pytest-asyncio`; mocking via `pytest-mock`

{multi_notifier-0.6.2 → multi_notifier-0.6.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: multi_notifier
-Version: 0.6.2
+Version: 0.6.3
 Summary: notify multiple recipients on multiple protocols
 Author: Seuling N.
 License-Expression: Apache-2.0

{multi_notifier-0.6.2 → multi_notifier-0.6.3}/changelog.md

@@ -1,3 +1,7 @@
+# Version 0.6.3 - 17.05.2026
+
+- fixed missing file suffix on image attachments in HTML mails on Android (added `Content-Disposition: inline; filename=...` to embedded images)
+
 # Version 0.6.2 - 12.05.2026
 
 - bumped requests (and other packages) to avoid security vulnerabilities

{multi_notifier-0.6.2 → multi_notifier-0.6.3}/multi_notifier/__init__.py

@@ -1,3 +1,3 @@
 """Init file of send_handler."""
 
-__version__ = "0.6.2"
+__version__ = "0.6.3"

{multi_notifier-0.6.2 → multi_notifier-0.6.3}/multi_notifier/connectors/connector_mail.py

@@ -148,8 +148,8 @@ class Mail(multi_notifier.connectors.interface.Interface):
                 try:
                     img_data = image_path.read_bytes()
                     img = MIMEImage(img_data)
-                    # Set Content-ID header: allows HTML to reference this image via src="cid:..."
                     img.add_header("Content-ID", f"<{cid}>")
+                    img.add_header("Content-Disposition", f'inline; filename="{image_path.name}"')
                     msg.attach(img)
                 except FileNotFoundError:
                     LOGGER.warning(f"Image file not found: {image_path}")

{multi_notifier-0.6.2 → multi_notifier-0.6.3}/tests/connectors/test_connector_mail.py

@@ -100,6 +100,10 @@ def test_create_msg_structure(
             # HTML messages should have Content-ID for embedding
             assert "Content-ID" in image_part
             assert "<img1>" in image_part.get("Content-ID")
+            # Must also carry a filename so Android clients know the extension
+            assert "Content-Disposition" in image_part
+            assert "inline" in image_part.get("Content-Disposition")
+            assert "filename=" in image_part.get("Content-Disposition")
         else:
             # Plain text messages should have Content-Disposition for attachment
             assert "Content-Disposition" in image_part