mtg-ssm 2.6.9.dev1__tar.gz → 2.6.9.dev3__tar.gz

{mtg_ssm-2.6.9.dev1 → mtg_ssm-2.6.9.dev3}/.github/workflows/run-tests.yml

@@ -71,7 +71,7 @@ jobs:
         run: coverage lcov
 
       - name: Coveralls Parallel
-        uses: coverallsapp/github-action@v2.2.3
+        uses: coverallsapp/github-action@v2.3.0
         with:
           github-token: ${{ secrets.github_token }}
           flag-name: python-${{ matrix.python-version }}
@@ -84,7 +84,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Coveralls Finished
-        uses: coverallsapp/github-action@v2.2.3
+        uses: coverallsapp/github-action@v2.3.0
         with:
           github-token: ${{ secrets.github_token }}
           path-to-lcov: coverage.lcov

{mtg_ssm-2.6.9.dev1 → mtg_ssm-2.6.9.dev3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: mtg_ssm
-Version: 2.6.9.dev1
+Version: 2.6.9.dev3
 Summary: A tool to manage Magic: the Gathering collection spreadsheets
 Author-email: George Leslie-Waksman <waksman@gmail.com>
 License: MIT
@@ -94,7 +94,8 @@ anywhere.
 Mana Pool
 =========
 
-Please also check out my other major Magic: the Gathering project, `Mana Pool`_; buying your cards there helps support the morale of the developer.
+Please also check out my other major Magic: the Gathering project,
+`Mana Pool`_; buying your cards there helps support my morale.
 
 .. _Mana Pool: https://manapool.com
 
@@ -239,6 +240,11 @@ Development
 
 -   ...
 
+2.6.9
+-----
+
+-   Fix sorting of cards with collector number prefixes (primarily PLST).
+
 2.6.1
 -----
 

{mtg_ssm-2.6.9.dev1 → mtg_ssm-2.6.9.dev3}/README.rst

@@ -33,7 +33,8 @@ anywhere.
 Mana Pool
 =========
 
-Please also check out my other major Magic: the Gathering project, `Mana Pool`_; buying your cards there helps support the morale of the developer.
+Please also check out my other major Magic: the Gathering project,
+`Mana Pool`_; buying your cards there helps support my morale.
 
 .. _Mana Pool: https://manapool.com
 
@@ -178,6 +179,11 @@ Development
 
 -   ...
 
+2.6.9
+-----
+
+-   Fix sorting of cards with collector number prefixes (primarily PLST).
+
 2.6.1
 -----
 

{mtg_ssm-2.6.9.dev1 → mtg_ssm-2.6.9.dev3}/mtg_ssm/_version.py

@@ -12,5 +12,5 @@ __version__: str
 __version_tuple__: VERSION_TUPLE
 version_tuple: VERSION_TUPLE
 
-__version__ = version = '2.6.9.dev1'
-__version_tuple__ = version_tuple = (2, 6, 9, 'dev1')
+__version__ = version = '2.6.9.dev3'
+__version_tuple__ = version_tuple = (2, 6, 9, 'dev3')

{mtg_ssm-2.6.9.dev1 → mtg_ssm-2.6.9.dev3}/mtg_ssm/containers/indexes.py

@@ -10,16 +10,14 @@ from mtg_ssm.mtg import util
 from mtg_ssm.scryfall.models import ScryCard, ScryMigrationStrategy, ScrySet
 
 
-def name_card_sort_key(card: ScryCard) -> Tuple[str, int, str]:
+def name_card_sort_key(card: ScryCard) -> Tuple[str, str, int, str]:
     """Key function for sorting cards in a by-name list."""
-    card_num, card_var = util.collector_int_var(card)
-    return (card.set, card_num or 0, card_var or "")  # TODO: sort by set release date
+    return (card.set, *util.collector_number_parts(card.collector_number))
 
 
-def set_card_sort_key(card: ScryCard) -> Tuple[int, str]:
+def set_card_sort_key(card: ScryCard) -> Tuple[str, int, str]:
     """Key function for sorting cards in a by-set list."""
-    card_num, card_var = util.collector_int_var(card)
-    return (card_num or 0, card_var or "")
+    return util.collector_number_parts(card.collector_number)
 
 
 def build_snnmas(

mtg_ssm-2.6.9.dev3/mtg_ssm/mtg/util.py

@@ -0,0 +1,26 @@
+"""Utility functions for working with card data."""
+
+import functools
+import re
+from typing import Tuple
+
+STRICT_BASICS = frozenset({"Plains", "Island", "Swamp", "Mountain", "Forest"})
+
+COLLECTOR_NUMBER_RE = re.compile(r"(?P<prefix>.*-|\D+)?(?P<number>\d+)?(?P<suffix>\D.*)?")
+
+
+@functools.lru_cache(maxsize=None)
+def collector_number_parts(collector_number: str) -> Tuple[str, int, str]:
+    """Split a collector number into its parts."""
+    match = COLLECTOR_NUMBER_RE.match(collector_number)
+    if not match:
+        return ("", 0, "")
+    prefix: str = match.group("prefix") or ""
+    number: int = int(match.group("number")) if match.group("number") else 0
+    suffix: str = match.group("suffix") or ""
+    return (prefix, number, suffix)
+
+
+def is_strict_basic(card_name: str) -> bool:
+    """Is the card on of the five basic lands (not Snow or Wastes)."""
+    return card_name in STRICT_BASICS

{mtg_ssm-2.6.9.dev1 → mtg_ssm-2.6.9.dev3}/mtg_ssm.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: mtg_ssm
-Version: 2.6.9.dev1
+Version: 2.6.9.dev3
 Summary: A tool to manage Magic: the Gathering collection spreadsheets
 Author-email: George Leslie-Waksman <waksman@gmail.com>
 License: MIT
@@ -94,7 +94,8 @@ anywhere.
 Mana Pool
 =========
 
-Please also check out my other major Magic: the Gathering project, `Mana Pool`_; buying your cards there helps support the morale of the developer.
+Please also check out my other major Magic: the Gathering project,
+`Mana Pool`_; buying your cards there helps support my morale.
 
 .. _Mana Pool: https://manapool.com
 
@@ -239,6 +240,11 @@ Development
 
 -   ...
 
+2.6.9
+-----
+
+-   Fix sorting of cards with collector number prefixes (primarily PLST).
+
 2.6.1
 -----
 

{mtg_ssm-2.6.9.dev1 → mtg_ssm-2.6.9.dev3}/tests/containers/test_indexes.py

@@ -67,6 +67,15 @@ def test_setcode_to_cards(scryfall_data: ScryfallDataSet) -> None:
         "74d",
     ]
 
+    # The List Sorting
+    assert [(c.collector_number, c.name) for c in index.setcode_to_cards["plst"]] == [
+        ("10E-20", "High Ground"),
+        ("10E-182", "Terror"),
+        ("AKH-2", "Anointed Procession"),
+        ("AKH-3", "Anointer Priest"),
+        ("ARB-1", "Ardent Plea"),
+    ]
+
 
 def test_id_to_setindex(scryfall_data: ScryfallDataSet) -> None:
     index = ScryfallDataIndex()

{mtg_ssm-2.6.9.dev1 → mtg_ssm-2.6.9.dev3}/tests/data/bulk_data.json

@@ -8,8 +8,8 @@
       "type": "default_cards",
       "name": "Default Cards",
       "description": "A JSON file containing every card object on Scryfall in English or the printed language if the card is only available in one language.",
-      "download_uri": "https://data.scryfall.io/default-cards/default-cards-20240510210636.json",
-      "updated_at": "2024-05-10T21:06:36.150000Z",
+      "download_uri": "https://data.scryfall.io/default-cards/default-cards-20240826212052.json",
+      "updated_at": "2024-08-26T21:20:52.469000Z",
       "content_type": "application/json",
       "content_encoding": "gzip"
     }