mt5api 0.3.0__tar.gz → 1.0.1__tar.gz

mt5api-1.0.1/.agents/skills/pr-feedback-triage/SKILL.md

@@ -0,0 +1,211 @@
+---
+name: pr-feedback-triage
+description: Triage pull request review comments into fixes, replies, clarification requests, or open follow-ups while respecting safe execution modes.
+allowed-tools: Bash(git:*), Bash(gh:*), mcp__github__*, Read, Grep, Glob, Edit, MultiEdit, Write
+---
+
+# PR Feedback Triage
+
+Triage pull request review feedback, decide what action each thread needs, make focused fixes when allowed, and report or resolve only what is actually handled.
+
+## When to Use
+
+- A PR has review comments, requested changes, unresolved review threads, or bot review findings.
+- The user asks to address, respond to, or resolve PR feedback.
+- The user provides a PR URL/number, a branch with an associated PR, or copied comments.
+
+Do not use this skill for a first-pass code review with no existing feedback; use a code review skill instead.
+
+## Inputs
+
+- Pull request URL or number, or a current branch that has an associated pull request.
+- Repository checkout or platform access sufficient to inspect the PR diff and review feedback.
+- Optional reviewer priorities from the user, such as "only address blocking comments" or "do not reply on the PR platform".
+- Optional operating mode flags: `dry_run`, `no_push`, and `no_reply`.
+
+If no PR or review comments are identifiable, ask for the target PR or the copied comments before proceeding.
+
+## Modes
+
+- `dry_run`: inspect review feedback and report the triage only. Do not edit files, run write-mode formatters, commit, push, post replies, or resolve review threads.
+- `no_push`: local edits and verification are allowed, but do not push commits or otherwise update the remote branch. Report the local diff or local commits that still need to be pushed. Do not resolve threads whose resolution depends on unpushed local edits.
+- `no_reply`: do not post replies, submit reviews, or resolve review threads. Provide suggested replies and resolution actions in the final report instead.
+
+When a mode disables an action, skip that destructive or externally visible action even if normal workflow text would otherwise allow it.
+
+## Preflight
+
+1. Identify the current branch and target PR.
+2. Check tracked local changes with `git diff --name-only` and `git diff --cached --name-only`. Ignore untracked files unless the review feedback explicitly concerns them.
+3. Check unpushed commits before relying on remote review feedback.
+4. If tracked local changes or unpushed commits exist, warn that existing PR comments may not cover the latest local state. In `normal` mode, push only when the user request or repository workflow allows it; otherwise continue with a clearly reported limitation.
+
+## Feedback Collection
+
+Gather the complete feedback set before editing:
+
+- Fetch unresolved review threads, requested-change reviews, inline comments, copied comments, and PR-level summary comments.
+- Use whichever authenticated GitHub-capable interface is available and reliable. This skill explicitly permits both `gh` and GitHub MCP tools; paginate results and do not inspect only the first page of threads or comments.
+- For bot reviewers that post both summary comments and inline comments, prefer inline comments for actionable triage. Incorporate summary findings only when they contain distinct severity, rationale, or fix instructions not already captured from inline comments.
+- Summary comments may be excluded from triage when they do not add distinct actionable context.
+- Preserve every thread/comment identifier needed to reply or resolve later.
+- Compare each comment with the current diff and file contents because review lines can become outdated.
+
+## Deduplication and Ordering
+
+Build one triage record per distinct finding:
+
+- Prefer exact review-thread identity when available.
+- For duplicate bot findings appearing in both summary and inline comments, merge by exact issue title first, then by file path plus line range as a fallback.
+- Prefer inline comments for location and current code context.
+- Use summary comments only for distinct severity, category, rationale, or detailed agent prompts that are not already available from inline comments.
+- Preserve the reviewer’s exact issue title and original wording where practical. Do not rename findings in a way that would make replies hard to map back to comments.
+- Preserve the reviewer’s original ordering unless the user asks for priority reordering. Many review bots already order findings by severity.
+
+Each triage record should track: original title, reviewer, source IDs, location, current applicability, severity/priority if available, disposition, planned action, verification, reply text if any, resolution decision, platform action attempted, and final platform state.
+
+## Resolution Policy
+
+In normal mode, `Resolve conversation` is the default action for any review thread that has been fully handled. A thread is handled when the requested change is implemented and verified, the current code already satisfies the comment, the comment is outdated and no longer applies, or a deliberate deferral/won't-fix response has been posted with a clear reason.
+
+Keep a thread open only when it still needs reviewer, maintainer, or product input, the fix is local-only and not pushed, verification is missing for a material change, or the user explicitly requested `dry_run`, `no_push`, or `no_reply` behavior that prevents resolution.
+
+When resolving a thread, add a concise reply first only if it provides useful context, such as what changed, why no code change was needed, why a finding was intentionally deferred, or why the original comment is now outdated. Do not add noisy replies for self-evident fixes unless project norms require them.
+
+## Platform Comment Style
+
+- Keep every posted reply or comment brief: one sentence by default, two short sentences only when necessary.
+- Do not post PR-level summary or status comments by default. Omit them when they only restate completed fixes, resolved threads, or verification already visible in commits/checks.
+- Avoid templates, long bullet lists, exhaustive status logs, and duplicated explanations in platform comments.
+- For simple fixes, already-addressed findings, or outdated findings, prefer `resolve_only` over adding a reply.
+
+## Platform Action Contract
+
+Do not treat triage as complete until every incorporated source ID reaches an explicit terminal state:
+
+- `resolved`: a platform resolve action succeeded, or a re-check shows the thread is already resolved.
+- `replied_left_open`: a reply or question was posted and the thread is intentionally left unresolved.
+- `not_resolvable`: the source is a PR-level summary comment or copied comment that has no platform-level resolve action; post a brief reply only when useful.
+- `skipped_by_mode`: `dry_run`, `no_push`, or `no_reply` prevented the external action.
+- `failed_action`: a reply or resolve action was attempted and failed; include the attempted action and failure in the final summary.
+
+In normal mode, build and execute a platform action queue after fixes are verified and pushed when needed:
+
+- `reply_then_resolve`: use for handled threads where the reviewer needs context before resolution.
+- `resolve_only`: use for self-evident fixes and already-addressed or outdated threads where an extra reply would add noise.
+- `reply_leave_open`: use only for clarification requests, blocked work, or intentionally open follow-ups.
+- `reply_only`: use for PR-level comments or summaries that cannot be resolved, only when a short reply adds value.
+
+For duplicate findings, execute the terminal action for every source thread ID, not only the primary triage record. If one finding is represented by three unresolved inline threads, all three must be resolved or explicitly left open.
+
+## GitHub Action Guidance
+
+Use whichever authenticated GitHub-capable interface is available and reliable, preferably `gh` or GitHub MCP. Prefer interfaces that expose review-thread resolution state. For GitHub inline review threads, use the thread node ID and the GraphQL `resolveReviewThread` mutation, or an equivalent GitHub MCP resolve-thread tool, rather than assuming that a reply resolves the conversation.
+
+A reliable pattern is:
+
+1. Re-fetch review threads and comments immediately before acting.
+2. Reply to the thread when the action queue says a reply is needed.
+3. Resolve the review thread by node ID when the terminal state should be `resolved`.
+4. Re-fetch unresolved review threads after the action queue completes.
+5. Retry any expected-to-be-resolved thread that is still unresolved once; if it still remains unresolved, mark it `failed_action` instead of claiming completion.
+
+Example GraphQL mutation shape:
+
+```graphql
+mutation ($threadId: ID!) {
+  resolveReviewThread(input: { threadId: $threadId }) {
+    thread {
+      id
+      isResolved
+    }
+  }
+}
+```
+
+A posted reply alone is sufficient only for `reply_leave_open`, `reply_only`, or `not_resolvable` sources. For handled inline review threads, reply and resolve are separate actions.
+
+## Flow
+
+```mermaid
+flowchart TD
+  A[Identify PR and branch state] --> B[Collect all review feedback]
+  B --> C[Deduplicate and preserve source IDs]
+  C --> D[Inspect current diff and code]
+  D --> E{Classify each triage record}
+  E -->|Fix| F[Implement minimal change]
+  E -->|Answer| G[Prepare concise reply]
+  E -->|Clarify| H[Prepare question and leave open]
+  E -->|Already addressed or Outdated| I[Prepare evidence]
+  E -->|Defer or Won't fix| J[Document reason]
+  F --> K[Verify]
+  G --> L{Mode}
+  H --> L
+  I --> L
+  J --> L
+  K --> L
+  L -->|dry_run| M[Report triage only]
+  L -->|no_push| N[Report local diff or commits]
+  L -->|no_reply| O[Report suggested replies/actions]
+  L -->|normal| P[Commit/push if changed]
+  P --> R[Execute reply/resolve action queue]
+  R --> S[Re-fetch threads and retry unresolved handled threads once]
+  M --> Q[Final summary]
+  N --> Q
+  O --> Q
+  S --> Q
+```
+
+## Compact Workflow
+
+1. **Collect all relevant feedback**
+   - Identify the PR and gather unresolved review threads, requested-change reviews, inline comments, copied comments, and PR-level summaries.
+   - Paginate all platform calls and keep comment/thread IDs for later replies and resolution.
+   - For bot reviews, prioritize inline comments and incorporate summary findings only when they add distinct actionable context.
+
+2. **Classify each triage record**
+   - **Fix**: Valid requested change; make the smallest focused edit when not in `dry_run`.
+   - **Answer**: No code change needed; prepare a concise explanation.
+   - **Clarify**: Ambiguous, conflicting, or missing context; reply with the question and leave unresolved.
+   - **Already addressed**: Current code already satisfies it; prepare evidence.
+   - **Outdated**: Commented code or issue no longer exists; prepare evidence.
+   - **Defer / Won't fix**: Valid concern intentionally not changed now; document a specific reason.
+
+3. **Act according to the classification and mode**
+   - Keep edits scoped to the review feedback.
+   - Follow reviewer-provided fix instructions literally when they are still applicable; deviate only when the current code proves the instruction is stale or unsafe.
+   - In `dry_run`, stop at triage, proposed fixes, suggested replies, and verification plan.
+   - In `no_push`, local edits are allowed, but do not push or resolve threads whose fix is only local. Reply or resolve non-code, already-addressed, or outdated threads only when the action does not depend on unpushed work and `no_reply` is not set.
+   - In `no_reply`, do not post replies or resolve threads; report suggested replies/actions instead.
+   - In normal mode, commit and push changed code when appropriate, then execute the platform action queue for every incorporated source ID.
+
+4. **Verify before claiming completion**
+   - For fixes, run appropriate checks or explain why they could not run.
+   - Re-inspect the updated diff and comment context to confirm the concern is resolved.
+   - Re-fetch review threads after reply/resolve actions and confirm all expected-to-be-resolved thread IDs are resolved.
+   - Do not mark a thread resolved if it still needs reviewer, maintainer, or product input.
+   - If a resolve or reply operation fails, retry once when safe; then report `failed_action` with the affected source ID and reason.
+
+5. **Finish**
+   - Normal mode: commit/push changes when appropriate, post only useful short replies/comments, omit PR-level summaries when they add no value, resolve all handled threads by default, and reconcile the final unresolved set.
+   - Safe modes: report the local state and the exact replies/resolution actions a human could take.
+
+## Reply Guidance
+
+- Keep inline replies short: one sentence by default, two short sentences only when needed.
+- For fixed findings, mention the concrete change or commit only if it helps the reviewer.
+- For already-addressed or outdated findings, cite the current code path or behavior only as briefly as needed.
+- For deferred or won't-fix findings, provide the reason and any follow-up issue or owner if known.
+- Avoid posting PR-level summary comments unless they communicate a decision, blocker, or requested reviewer action.
+- If a reply or resolve operation fails, continue with the remaining threads and report the failure in the final summary.
+
+## Final Summary Checklist
+
+- Mode used: `normal`, `dry_run`, `no_push`, or `no_reply`
+- Counts by disposition: fixed, answered, clarified/left open, already addressed, outdated, deferred/won't-fix
+- Counts by platform terminal state: resolved, replied-left-open, not-resolvable, skipped-by-mode, failed-action
+- Threads resolved, intentionally left open, already resolved, or resolution actions skipped by mode
+- Any expected-to-be-resolved thread that remained unresolved after retry
+- Verification run or planned
+- Commits pushed, local diff/commits, or "none"
+- Remaining open items and who needs to respond

{mt5api-0.3.0 → mt5api-1.0.1}/.github/workflows/ci.yml

@@ -62,6 +62,19 @@ jobs:
       runs-on: ubuntu-slim
     secrets:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  github-codeql-analysis:
+    if: >
+      github.event_name == 'push'
+      || github.event_name == 'pull_request'
+      || (github.event_name == 'workflow_dispatch' && inputs.workflow == 'lint-and-test')
+    permissions:
+      contents: read
+      security-events: write
+      actions: read
+    uses: dceoy/gh-actions-for-devops/.github/workflows/github-codeql-analysis.yml@main  # zizmor: ignore[unpinned-uses]
+    with:
+      language: >
+        ["python"]
   dependabot-auto-merge:
     if: >
       github.event_name == 'pull_request' && github.actor == 'dependabot[bot]'
@@ -73,5 +86,7 @@ jobs:
       contents: write
       pull-requests: write
       actions: read
+      checks: read
+      statuses: read
     with:
       unconditional: true

mt5api-1.0.1/AGENTS.md

@@ -0,0 +1,70 @@
+# Repository Guidelines
+
+## Project Structure & Module Organization
+
+`mt5api/` contains the FastAPI application. Core app setup lives in `main.py`,
+configuration and security in `config.py` and `auth.py`, shared request
+dependencies in `dependencies.py`, middleware in `middleware.py`, response
+serialization in `formatters.py`, and Pydantic/data models in `models.py`.
+Endpoint modules are grouped under `mt5api/routers/` by domain, such as
+`market.py`, `symbols.py`, `account.py`, and `trading.py`. Tests live in
+`tests/` and mirror the package domains with `test_*.py` files. Documentation is
+in `docs/`, with MkDocs configured by `mkdocs.yml`; local agent skills are under
+`skills/`.
+
+## Build, Test, and Development Commands
+
+- `uv sync --group dev`: install runtime and development dependencies.
+- `uv run python -m mt5api`: start the API using environment configuration.
+- `uv run uvicorn mt5api.main:app --host 0.0.0.0 --port 8000`: run the app
+  directly for local API testing.
+- `uv run pytest`: run the full test suite with coverage settings from
+  `pyproject.toml`.
+- `uv run ruff check .` and `uv run ruff format --check .`: lint and verify
+  formatting.
+- `uv run pyright`: run strict static type checking.
+- `uv run mkdocs serve`: preview documentation locally.
+- `.agents/skills/local-qa/scripts/qa.sh`: run the repository QA workflow after
+  any file update. This wraps formatting, linting, type checks, tests, Markdown
+  formatting, and workflow/security checks.
+
+The API server runtime requires Windows with MetaTrader 5 installed and logged
+in. Non-Windows systems are suitable for editing docs and most mocked tests.
+
+## Coding Style & Naming Conventions
+
+Target Python 3.11+. Use Ruff formatting with an 88-character line length and
+Google-style docstrings. Keep type annotations complete; Pyright runs in strict
+mode. Use `snake_case` for functions, variables, and modules; `PascalCase` for
+classes and Pydantic models; and uppercase names for constants.
+
+## Testing Guidelines
+
+Pytest discovers `tests/test_*.py`, `*_test.py`, `Test*` classes, and `test_*`
+functions. Coverage is branch-aware and configured to fail below 100%, so add or
+adjust focused tests with each behavior change. Prefer mocked MT5/pdmt5
+interactions unless a test explicitly requires a Windows MT5 terminal.
+
+## Design Principles
+
+Apply KISS, DRY, and YAGNI when changing code. Prefer the simplest direct
+implementation that satisfies the current requirement. Remove duplication when
+it improves clarity or prevents drift, but avoid abstractions that do not serve
+an immediate need. Keep changes small, focused, and easy to review.
+
+## Commit & Pull Request Guidelines
+
+History uses short imperative subjects and occasional Conventional Commit
+prefixes, for example `refactor: delegate MT5 constant parsing...` or
+`Add checks and statuses read permissions...`. Keep commits scoped to one
+logical change. Before committing or opening a PR, run
+`.agents/skills/local-qa/scripts/qa.sh`. Pull requests should describe the
+behavior change, list verification commands, link related issues when
+applicable, and call out any runtime impact for Windows/MT5 users.
+
+## Security & Configuration Tips
+
+Do not commit credentials, terminal account details, or real API keys. Configure
+runtime values through environment variables such as `MT5API_SECRET_KEY`,
+`MT5API_ROUTER_PREFIX`, `MT5API_HOST`, `MT5API_PORT`, and
+`MT5API_LOG_LEVEL`.

{mt5api-0.3.0 → mt5api-1.0.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: mt5api
-Version: 0.3.0
+Version: 1.0.1
 Summary: MetaTrader 5 REST API
 Project-URL: Repository, https://github.com/dceoy/mt5api.git
 Author-email: dceoy <dceoy@users.noreply.github.com>
@@ -18,9 +18,9 @@ Classifier: Topic :: Office/Business :: Financial :: Investment
 Requires-Python: <3.14,>=3.11
 Requires-Dist: fastapi>=0.115.0
 Requires-Dist: httpx>=0.27.0
-Requires-Dist: pdmt5>=0.3.0
+Requires-Dist: pdmt5>=1.1.1
 Requires-Dist: pyarrow>=18.0.0
-Requires-Dist: python-multipart>=0.0.9
+Requires-Dist: python-multipart>=0.0.31
 Requires-Dist: uvicorn[standard]>=0.32.0
 Description-Content-Type: text/markdown
 
@@ -30,14 +30,18 @@ MetaTrader 5 REST API
 
 [![CI/CD](https://github.com/dceoy/mt5api/actions/workflows/ci.yml/badge.svg)](https://github.com/dceoy/mt5api/actions/workflows/ci.yml)
 
-mt5api exposes MT5 market data, account info, trading history, and trading
-operations over HTTP. It is a FastAPI/HTTP adapter over
-[`pdmt5`](https://github.com/dceoy/pdmt5), which provides the core MT5 client,
-dataframe/trading primitives, and canonical MT5 constant parsing. mt5api adds
-optional API-key auth and JSON/Parquet response formatting.
+mt5api exposes MT5 market data, account info, trading history, trading state,
+order validation, and operational terminal endpoints over HTTP. It is a
+FastAPI/HTTP adapter over [`pdmt5`](https://github.com/dceoy/pdmt5), which
+provides the core MT5 client, dataframe/order primitives, and canonical MT5
+constant parsing. mt5api adds optional API-key auth and JSON/Parquet response
+formatting.
 
-[`mt5cli`](https://github.com/dceoy/mt5cli) is a sibling CLI/batch adapter for
-the same pdmt5 stack; it is not a dependency of mt5api.
+The exposed operational surface is deliberately narrow: mt5api validates trade
+requests, manages terminal-side subscriptions and MarketWatch visibility, and
+supports reconnecting the terminal to a different MT5 account via
+`POST /connection/login`, but it does not expose live order-send endpoints or
+implement strategy orchestration.
 
 The API server must run on Windows. pdmt5 connects through the MetaTrader 5
 Python API, which is supported only on Windows, so you must host `mt5api` on a
@@ -72,8 +76,8 @@ graph TB
 
 ## Features
 
-- REST endpoints for symbols, market data, account info, orders, history,
-  calculations, and trading operations
+- REST endpoints for symbols, market data, account info, orders, positions,
+  history, margin/profit calculations, order validation, and terminal operations
 - JSON and Apache Parquet responses (content negotiation)
 - Optional API key authentication
 - Structured JSON logging

{mt5api-0.3.0 → mt5api-1.0.1}/README.md

@@ -4,14 +4,18 @@ MetaTrader 5 REST API
 
 [![CI/CD](https://github.com/dceoy/mt5api/actions/workflows/ci.yml/badge.svg)](https://github.com/dceoy/mt5api/actions/workflows/ci.yml)
 
-mt5api exposes MT5 market data, account info, trading history, and trading
-operations over HTTP. It is a FastAPI/HTTP adapter over
-[`pdmt5`](https://github.com/dceoy/pdmt5), which provides the core MT5 client,
-dataframe/trading primitives, and canonical MT5 constant parsing. mt5api adds
-optional API-key auth and JSON/Parquet response formatting.
-
-[`mt5cli`](https://github.com/dceoy/mt5cli) is a sibling CLI/batch adapter for
-the same pdmt5 stack; it is not a dependency of mt5api.
+mt5api exposes MT5 market data, account info, trading history, trading state,
+order validation, and operational terminal endpoints over HTTP. It is a
+FastAPI/HTTP adapter over [`pdmt5`](https://github.com/dceoy/pdmt5), which
+provides the core MT5 client, dataframe/order primitives, and canonical MT5
+constant parsing. mt5api adds optional API-key auth and JSON/Parquet response
+formatting.
+
+The exposed operational surface is deliberately narrow: mt5api validates trade
+requests, manages terminal-side subscriptions and MarketWatch visibility, and
+supports reconnecting the terminal to a different MT5 account via
+`POST /connection/login`, but it does not expose live order-send endpoints or
+implement strategy orchestration.
 
 The API server must run on Windows. pdmt5 connects through the MetaTrader 5
 Python API, which is supported only on Windows, so you must host `mt5api` on a
@@ -46,8 +50,8 @@ graph TB
 
 ## Features
 
-- REST endpoints for symbols, market data, account info, orders, history,
-  calculations, and trading operations
+- REST endpoints for symbols, market data, account info, orders, positions,
+  history, margin/profit calculations, order validation, and terminal operations
 - JSON and Apache Parquet responses (content negotiation)
 - Optional API key authentication
 - Structured JSON logging

{mt5api-0.3.0 → mt5api-1.0.1}/docs/api/rest-api.md

@@ -316,8 +316,8 @@ Errors follow RFC 7807 Problem Details:
 {
   "type": "/errors/validation-error",
   "title": "Request Validation Failed",
-  "status": 400,
-  "detail": "count must be positive (got: -10)",
+  "status": 422,
+  "detail": "Request validation error details",
   "instance": "/rates/from"
 }
 ```

{mt5api-0.3.0 → mt5api-1.0.1}/docs/index.md

@@ -10,9 +10,6 @@ mt5api is a FastAPI/HTTP adapter over
 dataframe/trading primitives, and canonical MT5 constant parsing. mt5api adds
 optional authentication, response formatting, and OpenAPI documentation.
 
-[`mt5cli`](https://github.com/dceoy/mt5cli) is a sibling CLI/batch adapter for
-the same pdmt5 stack; it is not a dependency of mt5api.
-
 The API server must run on Windows because pdmt5 connects through the MetaTrader
 5 Python API, which is Windows-only. Run `mt5api` on a Windows host with
 MetaTrader 5 installed and logged in. API clients can connect from any operating

{mt5api-0.3.0 → mt5api-1.0.1}/mt5api/__main__.py

@@ -11,11 +11,7 @@ from .config import (
     get_configured_api_log_level,
     get_configured_api_port,
 )
-from .constants import (
-    API_APP_IMPORT,
-    DEFAULT_API_PORT,
-    MAX_API_PORT,
-)
+from .constants import API_APP_IMPORT
 
 
 def _get_host() -> str:
@@ -33,19 +29,7 @@ def _get_port() -> int:
     Returns:
         Port number for the API server.
     """
-    raw_port = get_configured_api_port()
-    if raw_port is None:
-        return DEFAULT_API_PORT
-
-    try:
-        port_value = int(raw_port)
-    except ValueError:
-        return DEFAULT_API_PORT
-
-    if not 1 <= port_value <= MAX_API_PORT:
-        return DEFAULT_API_PORT
-
-    return port_value
+    return get_configured_api_port()
 
 
 def _get_log_level() -> str:
@@ -54,7 +38,7 @@ def _get_log_level() -> str:
     Returns:
         Log level string for uvicorn.
     """
-    return get_configured_api_log_level().lower()
+    return get_configured_api_log_level()
 
 
 def main() -> None:

{mt5api-0.3.0 → mt5api-1.0.1}/mt5api/config.py

@@ -8,6 +8,7 @@ import re
 from .constants import (
     DEFAULT_API_HOST,
     DEFAULT_API_LOG_LEVEL,
+    DEFAULT_API_PORT,
     DEFAULT_API_ROUTER_PREFIX,
     DEFAULT_MAX_MARKET_BOOK_SUBSCRIPTIONS,
     ENV_MT5API_HOST,
@@ -16,9 +17,21 @@ from .constants import (
     ENV_MT5API_PORT,
     ENV_MT5API_ROUTER_PREFIX,
     ENV_MT5API_SECRET_KEY,
+    MAX_API_PORT,
 )
 
 _VALID_API_ROUTER_PREFIX_PATTERN = re.compile(r"^[A-Za-z0-9_-]+(?:/[A-Za-z0-9_-]+)*$")
+_VALID_UVICORN_LOG_LEVELS = {"critical", "error", "warning", "info", "debug", "trace"}
+_LOGGING_LOG_LEVEL_BY_API_LEVEL = {
+    "critical": "CRITICAL",
+    "error": "ERROR",
+    "warning": "WARNING",
+    "info": "INFO",
+    "debug": "DEBUG",
+    "trace": "DEBUG",
+}
+_INVALID_MT5API_PORT_ERROR = "Invalid MT5API_PORT"
+_INVALID_MT5API_LOG_LEVEL_ERROR = "Invalid MT5API_LOG_LEVEL"
 _INVALID_MT5API_ROUTER_PREFIX_ERROR = "Invalid MT5API_ROUTER_PREFIX"
 _INVALID_MT5API_MAX_MARKET_BOOK_SUBSCRIPTIONS_ERROR = (
     "Invalid MT5API_MAX_MARKET_BOOK_SUBSCRIPTIONS"
@@ -59,22 +72,52 @@ def get_configured_api_host() -> str:
     return os.getenv(ENV_MT5API_HOST, DEFAULT_API_HOST)
 
 
-def get_configured_api_port() -> str | None:
-    """Get the configured API port string.
+def get_configured_api_port() -> int:
+    """Get the configured API port.
 
     Returns:
-        Raw port string from the environment, or ``None`` if unset.
+        Port number for the API server.
+
+    Raises:
+        ValueError: If the configured port is not an integer in the TCP port range.
     """
-    return os.getenv(ENV_MT5API_PORT)
+    raw_port = os.getenv(ENV_MT5API_PORT)
+    if raw_port is None:
+        return DEFAULT_API_PORT
+
+    try:
+        port = int(raw_port)
+    except ValueError as error:
+        raise ValueError(_INVALID_MT5API_PORT_ERROR) from error
+
+    if not 1 <= port <= MAX_API_PORT:
+        raise ValueError(_INVALID_MT5API_PORT_ERROR)
+
+    return port
 
 
 def get_configured_api_log_level() -> str:
     """Get the configured API log level.
 
     Returns:
-        Log level string from configuration.
+        Valid uvicorn log level string from configuration.
+
+    Raises:
+        ValueError: If the configured log level is unsupported.
+    """
+    log_level = os.getenv(ENV_MT5API_LOG_LEVEL, DEFAULT_API_LOG_LEVEL).strip().lower()
+    if log_level not in _VALID_UVICORN_LOG_LEVELS:
+        raise ValueError(_INVALID_MT5API_LOG_LEVEL_ERROR)
+    return log_level
+
+
+def get_configured_python_log_level() -> str:
+    """Get a stdlib logging-compatible log level for the API logger.
+
+    Returns:
+        Python logging level name derived from the configured API log level.
     """
-    return os.getenv(ENV_MT5API_LOG_LEVEL, DEFAULT_API_LOG_LEVEL)
+    return _LOGGING_LOG_LEVEL_BY_API_LEVEL[get_configured_api_log_level()]
 
 
 def get_configured_api_router_prefix() -> str:

{mt5api-0.3.0 → mt5api-1.0.1}/mt5api/constants.py

@@ -6,7 +6,7 @@ API_DESCRIPTION = (
     "Provides market data, account information, trading history, calculations, "
     "and safe operational endpoints via HTTP."
 )
-API_VERSION = "1.0.0"
+API_VERSION = "1.0.1"
 API_DOCS_URL = "/docs"
 API_REDOC_URL = "/redoc"
 API_OPENAPI_URL = "/openapi.json"

{mt5api-0.3.0 → mt5api-1.0.1}/mt5api/dependencies.py

@@ -80,12 +80,12 @@ def shutdown_mt5_client() -> None:
 async def replace_mt5_client(config: Mt5Config) -> Mt5DataClient:
     """Swap the MT5 client singleton with a new connection.
 
-    Constructs and initializes the new ``Mt5DataClient`` BEFORE touching the
-    singleton so a failed reconnect leaves the existing client in place
-    instead of disconnecting the operator from a working terminal. The new
-    client is installed atomically; the old client (if any) is shut down on
-    a best-effort basis after the swap. Callers MUST hold
-    ``get_mt5_client_lock`` so concurrent reconnect requests do not race.
+    Constructs and initializes the new ``Mt5DataClient`` before replacing the
+    singleton reference. The MetaTrader5 Python module has process-global
+    connection state, so the previous client object must not be shut down after
+    successful reconnect because that would close the connection just opened by
+    the new client. Callers MUST hold ``get_mt5_client_lock`` so concurrent
+    reconnect requests do not race.
 
     The raised ``RuntimeError`` deliberately omits the underlying exception
     text from its message because third-party ``pdmt5``/MetaTrader5
@@ -101,7 +101,7 @@ async def replace_mt5_client(config: Mt5Config) -> Mt5DataClient:
 
     Raises:
         RuntimeError: If the new MT5 client cannot be constructed or
-            initialized. The previously installed client is preserved.
+            initialized.
     """
     global _mt5_client  # noqa: PLW0603
 
@@ -113,15 +113,8 @@ async def replace_mt5_client(config: Mt5Config) -> Mt5DataClient:
         error_message = "Failed to initialize MT5 client"
         raise RuntimeError(error_message) from e
 
-    old_client = _mt5_client
     _mt5_client = new_client
 
-    if old_client is not None:
-        try:
-            await asyncio.to_thread(old_client.shutdown)
-        except Exception:
-            logger.exception("Failed to shutdown previous MT5 client")
-
     return new_client