msad 0.4.0__tar.gz → 0.4.1__tar.gz

{msad-0.4.0 → msad-0.4.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: msad
-Version: 0.4.0
+Version: 0.4.1
 Summary: msad is a commandline for interacting with Active Directory
 Project-URL: Homepage, https://github.com/matteoredaelli/msad
 Project-URL: Issues, https://github.com/matteoredaelli/msad/issues
@@ -9,7 +9,7 @@ License-Expression: GPL-3.0-or-later
 License-File: LICENSE
 Classifier: Operating System :: OS Independent
 Classifier: Programming Language :: Python :: 3
-Requires-Python: >=3.9
+Requires-Python: >=3.11
 Requires-Dist: cryptography
 Requires-Dist: gssapi
 Requires-Dist: ldap3
@@ -24,21 +24,22 @@ It supports authentication with user/pwd and kerberos
 
 It supports paginations: it can retreive more than 2000 objects (a limit of AD)
 
-It can be used for:
-- search objects (users, groups, computers,..)
-- search (recursively) group memberships and all user's groups
-- add/remove members to/from AD groups using DN or sAMaccoutName
-- change AD passwords
-- check if a user is disabled or locked, group membership
+Features:
+
+- [X] search objects (users, groups, computers,..)
+- [X] search (recursively) group memberships and all user's groups
+- [X] add/remove members to/from AD groups using DN or sAMaccoutName
+- [X] change AD passwords
+- [ ] check if a user is disabled or locked
 
 ## Prerequisites
 
-python >= 3.9
+python >= 3.11
 
 For kerboros auth
 
   - krb5 lib and tools (like kinit, ...)
-  - a keytab file or 
+  - a keytab file or krb5.conf configured 
   
 ## Installation
 
@@ -46,7 +47,7 @@ For kerboros auth
 pipx install msad
 ```
 
-## COnfiguration
+## Configuration
 
 Create a configuration file in $HOME/.msad.toml as suggested by
 
@@ -54,7 +55,6 @@ Create a configuration file in $HOME/.msad.toml as suggested by
 msad get-sample-config
 ```
 
-
 ## Usage
 
 
@@ -65,19 +65,16 @@ python -m msad --help
 
 ```
 
-
 For kerberos authentication, first you need to login to AD / get a ticket kerberos with
 
 ```bash
-kinit youraduser
+kinit # or kinit myaduser 
 ```
 
-
-
 ```text
-msad search "(samaccountname=matteo)"  --out-format=json
+msad search "(samaccountname=matteo)"  --out-format=json # show all attributes
 
-msad search "(cn=redaelli*)" --attribute mail --attribute samaccountname --out-format=json
+msad search "(cn=redaelli*)" --attributes mail --attributes samaccountname --out-format=json
 
 msad group-members qlik_analyzer_users --nested
 
@@ -89,10 +86,6 @@ msad user-groups matteo --nested
 
 ```
 
-## Sample
-
-
-
 ## License
 
 Copyright © 2021 - 2025 Matteo Redaelli

{msad-0.4.0 → msad-0.4.1}/README.md

@@ -6,21 +6,22 @@ It supports authentication with user/pwd and kerberos
 
 It supports paginations: it can retreive more than 2000 objects (a limit of AD)
 
-It can be used for:
-- search objects (users, groups, computers,..)
-- search (recursively) group memberships and all user's groups
-- add/remove members to/from AD groups using DN or sAMaccoutName
-- change AD passwords
-- check if a user is disabled or locked, group membership
+Features:
+
+- [X] search objects (users, groups, computers,..)
+- [X] search (recursively) group memberships and all user's groups
+- [X] add/remove members to/from AD groups using DN or sAMaccoutName
+- [X] change AD passwords
+- [ ] check if a user is disabled or locked
 
 ## Prerequisites
 
-python >= 3.9
+python >= 3.11
 
 For kerboros auth
 
   - krb5 lib and tools (like kinit, ...)
-  - a keytab file or 
+  - a keytab file or krb5.conf configured 
   
 ## Installation
 
@@ -28,7 +29,7 @@ For kerboros auth
 pipx install msad
 ```
 
-## COnfiguration
+## Configuration
 
 Create a configuration file in $HOME/.msad.toml as suggested by
 
@@ -36,7 +37,6 @@ Create a configuration file in $HOME/.msad.toml as suggested by
 msad get-sample-config
 ```
 
-
 ## Usage
 
 
@@ -47,19 +47,16 @@ python -m msad --help
 
 ```
 
-
 For kerberos authentication, first you need to login to AD / get a ticket kerberos with
 
 ```bash
-kinit youraduser
+kinit # or kinit myaduser 
 ```
 
-
-
 ```text
-msad search "(samaccountname=matteo)"  --out-format=json
+msad search "(samaccountname=matteo)"  --out-format=json # show all attributes
 
-msad search "(cn=redaelli*)" --attribute mail --attribute samaccountname --out-format=json
+msad search "(cn=redaelli*)" --attributes mail --attributes samaccountname --out-format=json
 
 msad group-members qlik_analyzer_users --nested
 
@@ -71,10 +68,6 @@ msad user-groups matteo --nested
 
 ```
 
-## Sample
-
-
-
 ## License
 
 Copyright © 2021 - 2025 Matteo Redaelli

msad-0.4.1/build.sh

@@ -0,0 +1 @@
+python3 -m build && python3 -m twine upload dist/*

{msad-0.4.0 → msad-0.4.1}/pyproject.toml

@@ -1,12 +1,12 @@
 [project]
 name = "msad"
-version = "0.4.0"
+version = "0.4.1"
 authors = [
   { name="Matteo Redaelli", email="matteo.redaelli@gmail.com" },
 ]
 description = "msad is a commandline for interacting with Active Directory"
 readme = "README.md"
-requires-python = ">=3.9"
+requires-python = ">=3.11"
 
 dependencies = [
     "ldap3",

{msad-0.4.0 → msad-0.4.1}/src/msad/user.py

@@ -20,11 +20,11 @@ import logging
 import getpass
 import ldap3
 import datetime
-from .search import get_dn, search
-from .group import *
+from .search import disabled_users, get_dn, search, locked_users, never_expires_password
+from .group import group_member
 
 
-def _enter_password(text):
+def _enter_password(text: str):
     try:
         p = getpass.getpass(text)
     except Exception as error:
@@ -34,7 +34,7 @@ def _enter_password(text):
         return p
 
 
-def change_password(conn, search_base, user):
+def change_password(conn, search_base: str, user: str):
     user_dn = get_dn(conn, search_base, user)
 
     if not user_dn:
@@ -47,7 +47,7 @@ def change_password(conn, search_base, user):
         conn.extend.microsoft.modify_password(user_dn, newpwd, oldpwd)
 
 
-def is_disabled(conn, search_base, user):
+def is_disabled(conn, search_base: str, user: str):
     result = disabled_users(
         conn, search_base, f"(samaccountname={user})", limit=1, attributes=None
     )
@@ -55,37 +55,21 @@ def is_disabled(conn, search_base, user):
     return True if len(result) == 1 else None
 
 
-def is_locked(conn, search_base, user):
+def is_locked(conn, search_base: str, user: str):
     result = locked_users(
         conn, search_base, f"(samaccountname={user})", limit=1, attributes=None
     )
     return True if len(result) == 1 else None
 
 
-def has_never_expires_password(conn, search_base, user):
+def has_never_expires_password(conn, search_base: str, user: str):
     result = never_expires_password(
         conn, search_base, f"(samaccountname={user})", limit=1, attributes=None
     )
     return True if len(result) == 1 else None
 
 
-def password_changed_in_days(conn, search_base, user, limit=1000):
-    search_filter = f"(samaccountname={user})"
-    result = search(
-        conn, search_base, search_filter, limit=limit, attributes=["sAMAccountName","pwdLastSet"]
-    )
-
-    if len(result) == 0:
-        return None
-
-    now = datetime.datetime.now()
-    result = [ {"sAMAccountName": u["sAMAccountName"],
-                "days": (now - u["pwdLastSet"].replace(tzinfo=None)).days} for u in result]
-
-    return result
-
-
-def has_expired_password(conn, search_base, user, max_age):
+def password_changed_in_days(conn, search_base: str, user: str, limit: int = 2000, max_age: int):
     #    return search(conn, search_base, search_filter, attributes=attributes)
     search_filter = f"(samaccountname={user})"
     result = search(
@@ -106,7 +90,7 @@ def has_expired_password(conn, search_base, user, max_age):
         return True if days > max_age else False
 
 
-def check_user(conn, search_base, user, max_age, groups=[]):
+def check_user(conn, search_base:str, user:str, max_age:int, groups=[]):
     # result = {}
     yield ({"is_disabled": is_disabled(conn, search_base, user)})
     yield ({"is_locked": is_locked(conn, search_base, user)})
@@ -127,13 +111,13 @@ def check_user(conn, search_base, user, max_age, groups=[]):
         yield (
             {
                 f"membership_{group}": group_member(
-                    conn, search_base, group_name=group, user_name=user
+                    conn, search_base, group=group, user=user
                 )
             }
         )
 
 
-def user_groups(conn, search_base, limit, user, nested=True):
+def user_groups(conn, search_base:str , limit: int, user: str, nested: bool =True):
     """retrieve all groups (also nested) of a user"""
 
     user_dn = get_dn(conn, search_base, user)