mpf 0.57.1.dev2__tar.gz → 0.57.1.dev3__tar.gz

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/.prospector.yaml

@@ -1,4 +1,4 @@
-strictness: verylow
+strictness: high
 max-line-length: 120
 
 mccabe:

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: mpf
-Version: 0.57.1.dev2
+Version: 0.57.1.dev3
 Summary: The Mission Pinball Framework (MPF)
 Author-email: The Mission Pinball Framework Team <brian@missionpinball.org>
 License: MIT

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/_version.py

@@ -10,7 +10,7 @@ PyPI.
 
 """
 
-__version__ = '0.57.1.dev2'  # Also consider whether MPF-MC pyproject.toml should be updated
+__version__ = '0.57.1.dev3'  # Also consider whether MPF-MC pyproject.toml should be updated
 '''The full version of MPF.'''
 
 __short_version__ = '0.57'

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/commands/test.py

@@ -1,23 +1,24 @@
+"""Base module for running tests."""
 import os
 
 import argparse
+import logging
 import re
 import unittest
 import sys
 
+from kivy.logger import Logger  # pylint: disable=import-error
 from mpf.commands import MpfCommandLineParser
 from mpf.tests.MpfDocTestCase import MpfDocTestCase, MpfDocTestCaseNoFakeGame
 from mpf.tests.MpfIntegrationDocTestCase import MpfIntegrationDocTestCase
 
 # some hacks to unbreak logging after loading the kivy logger
-import logging
 root = logging.root
 os.environ['KIVY_NO_FILELOG'] = '1'
 os.environ['KIVY_NO_CONSOLELOG'] = '1'
 os.environ["KIVY_NO_ARGS"] = "1"
 
 # pylint: disable-msg=import-error,wrong-import-position
-from kivy.logger import Logger
 for handler in Logger.handlers:
     Logger.removeHandler(handler)
 sys.stdout = sys.__stdout__
@@ -31,7 +32,7 @@ class Command(MpfCommandLineParser):
 
     """Run a text unit test from cli."""
 
-    def __init__(self, args, path):
+    def __init__(self, args, path):  # pylint: disable=too-many-locals
         """Parse args."""
         super().__init__(args, path)
         test_file = self.argv.pop(1)

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/config_players/event_player.py

@@ -54,7 +54,7 @@ class EventPlayer(FlatConfigPlayer):
 
                 if s["number"] is not None:
                     self.delay.add(callback=self._post_event, ms=s["number"],
-                                event=event, priority=s["priority"], params=s["params"])
+                                   event=event, priority=s["priority"], params=s["params"])
                 else:
                     self._post_event(event, s["priority"], s["params"])
 

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/config_players/variable_player.py

@@ -144,7 +144,7 @@ class VariablePlayer(ConfigPlayer):
 
     def clear_context(self, context: str) -> None:
         """Clear context."""
-        for var, block in self.blocks.items():
+        for _, block in self.blocks.items():  # Unused variable "var"
             for entry, s in enumerate(block):
                 if s.context == context:
                     del block[entry]

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/assets.py

@@ -634,6 +634,7 @@ class AsyncioSyncAssetManager(BaseAssetManager):
         task.add_done_callback(Util.raise_exceptions)
 
 
+# pylint: disable-msg=invalid-name
 TUnconditionalAssetEntry = Tuple[AssetClass, int]
 TConditionalAssetEntry = Tuple[AssetClass, int, BoolTemplate]
 TMaybeConditionalAssetEntry = Union[TUnconditionalAssetEntry, TConditionalAssetEntry]

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/ball_search.py

@@ -279,7 +279,7 @@ class BallSearch(MpfController):
 
             # if a callback returns True we wait for the next one
             self.debug_log("Ball search: %s (phase: %s  iteration: %s)",
-                element.name, self.phase, self.iteration)
+                           element.name, self.phase, self.iteration)
             if element.callback(self.phase, self.iteration):
                 self.delay.add(name='run', callback=self._run, ms=timeout)
                 return

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/bcp/bcp.py

@@ -57,7 +57,9 @@ class Bcp(MpfController):
     def _setup_bcp_connections(self, queue: QueuedEvent, **kwargs):
         """Connect to BCP servers from MPF config."""
         del kwargs
-        if 'connections' not in self.machine.config['bcp'] or not self.machine.config['bcp']['connections'] or self.machine.config['bcp']['connections'] == 'None':
+        if 'connections' not in self.machine.config['bcp'] or \
+                not self.machine.config['bcp']['connections'] or \
+                self.machine.config['bcp']['connections'] == 'None':
             return
 
         client_connect_futures = []

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/bcp/bcp_server.py

@@ -1,5 +1,4 @@
 """Bcp server for clients which connect and disconnect randomly."""
-import asyncio
 
 from mpf.exceptions.runtime_error import MpfRuntimeError
 

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/config_validator.py

@@ -179,9 +179,8 @@ class ConfigValidator:
         processed_config = source
 
         if not isinstance(source, dict):
-            raise self.validation_error(source, validation_failure_info, "Config attribute should be dict but is {}".format(
-                source.__class__
-            ))
+            raise self.validation_error(source, validation_failure_info,
+                                        "Config attribute should be dict but is {}".format(source.__class__))
 
         for k in list(this_spec.keys()):
             if this_spec[k] == 'ignore' or k[0] == '_':
@@ -234,9 +233,10 @@ class ConfigValidator:
         if item == 'item not in config!@#':
             if default == 'default required!@#':
                 section = self._build_error_path(validation_failure_info.parent)
-                raise self.validation_error("None", validation_failure_info,
-                                      'Required setting "{}:" is missing from section "{}:" in your config.'.format(
-                                          validation_failure_info.item, section), 9)
+                raise self.validation_error(
+                    "None", validation_failure_info,
+                    f'Required setting "{validation_failure_info.item}:" is missing '
+                    f'from section "{section}:" in your config.', 9)
             item = default
 
         if item_type == 'single':
@@ -374,9 +374,9 @@ class ConfigValidator:
         if item is True and 'yes' in enum_values:
             return 'yes'
 
-        raise self.validation_error(item, validation_failure_info,
-                                     "Entry \"{}\" is not valid for enum. Valid values are: {}".format(
-                                         item, str(param)))
+        raise self.validation_error(
+            item, validation_failure_info,
+            f'Entry "{item}" is not valid for enum. Valid values are: {str(param)}')
 
     def _validate_type_machine(self, item, param, validation_failure_info):
         if item is None:
@@ -386,20 +386,20 @@ class ConfigValidator:
 
         if not isinstance(item, str):
             raise self.validation_error(item, validation_failure_info,
-                                         'Expected "{}" in "{}" to be string'.format(item, param),
-                                         10)
+                                        'Expected "{}" in "{}" to be string'.format(item, param),
+                                        10)
 
         if not item:
             raise self.validation_error(item, validation_failure_info,
-                                         'Setting "{}" is empty'.format(param),
-                                         14)
+                                        'Setting "{}" is empty'.format(param),
+                                        14)
 
         if item in section:
             return section[item]
 
         raise self.validation_error(item, validation_failure_info,
-                                     'Device "{}" not found in "{}:" section in your config.'.format(item, param),
-                                     6)
+                                    'Device "{}" not found in "{}:" section in your config.'.format(item, param),
+                                    6)
 
     @classmethod
     def _validate_type_list(cls, item, validation_failure_info):
@@ -448,6 +448,7 @@ class ConfigValidator:
         return self.machine.placeholder_manager.build_quoted_string_template(item)
 
     def _validate_type_template_float(self, item, validation_failure_info, param=None):
+        del param
         if item is None:
             return None
         if not isinstance(item, (str, float, int)):
@@ -506,9 +507,11 @@ class ConfigValidator:
         if param:
             param = param.split(",")
             if param[0] != "NONE" and value < float(param[0]):
-                raise self.validation_error(item, validation_failure_info, "{} is smaller then {}".format(value, param[0]))
+                raise self.validation_error(item, validation_failure_info,
+                                            "{} is smaller then {}".format(value, param[0]))
             if param[1] != "NONE" and value > float(param[1]):
-                raise self.validation_error(item, validation_failure_info, "{} is larger then {}".format(value, param[1]))
+                raise self.validation_error(item, validation_failure_info,
+                                            "{} is larger then {}".format(value, param[1]))
 
     def _validate_type_float(self, item, validation_failure_info, param=None):
         if item is None:
@@ -625,7 +628,8 @@ class ConfigValidator:
             try:
                 color[i] = int(x) / 255
             except ValueError:
-                raise self.validation_error(item, validation_failure_info, "Color could not be converted to int for kivy.")
+                raise self.validation_error(item, validation_failure_info,
+                                            "Color could not be converted to int for kivy.")
 
         if len(color) == 3:
             color.append(1)

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/data_manager.py

@@ -129,7 +129,7 @@ class DataManager(MpfController):
             # save data
             try:
                 FileManager.save(self.filename, data)
-            except Exception as e:
+            except Exception as e:  # pylint: disable=broad-exception-caught
                 # If the file writer has an exception handle it here. Otherwise
                 # this thread will die and all subsequent write attempts will no-op.
                 self.info_log("ERROR writing file %s: %s", self.filename, e)

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/delays.py

@@ -2,7 +2,7 @@
 
 import uuid
 from functools import partial
-from typing import Any, Callable, Dict, Tuple, Union
+from typing import Any, Callable, Dict, Tuple
 from mpf.core.mpf_controller import MpfController
 
 MYPY = False

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/device_manager.py

@@ -299,7 +299,7 @@ class DeviceCollection(dict):
         This method is DEPRECATED and will be removed soon. Use .values() instead.
         """
         self.machine.log.warning("Iterating device collections directly is deprecated and will be removed. "
-                                 "Access by value() instead: device_collections[%s] -> device_collections['%s'].values()",
+                                 "Access by value(): device_collections[%s] -> device_collections['%s'].values()",
                                  self.name, self.name)
         for item in self.values():
             yield item

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/events.py

@@ -168,16 +168,19 @@ class EventManager(MpfController):
         ``events.remove_handler(my_handler)``
 
 
-        A fully working example to get some initial working code might look like explained below. In your modes config file have the section
+        A fully working example to get some initial working code might look like
+        explained below. In your modes config file have the section
 
         .. code::
 
             mode:
                 start_events: ball_started
                 priority: 100
-                code: base.My_Base  #base is the name of my code file (base.py), My_Base is the name of the class to be used from that source file
+                code: base.My_Base  #base is the name of my code file (base.py),
+                    My_Base is the name of the class to be used from that source file
 
-        Here the mode being used is my base mode, of course it could be done for any mode. Some basic code to read and write some player variable might look like below.
+        Here the mode being used is my base mode, of course it could be done for any mode.
+        Some basic code to read and write some player variable might look like below.
 
         .. code::
 
@@ -194,7 +197,8 @@ class EventManager(MpfController):
                         return    # do something reasonable here but do not crash in the next line
 
                     # read player variable
-                    print(player["status_target_light_red_0"]) #the variable status_target_light_red_0 is defined in the player_vars section of the config.yaml file
+                    print(player["status_target_light_red_0"])
+                    #the variable status_target_light_red_0 is defined in the player_vars section of the config file
 
                     #with every fired event alternate variable value between 0 and 1
 

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/platform.py

@@ -321,7 +321,7 @@ class ServoPlatform(BasePlatform, metaclass=abc.ABCMeta):
         self.features['has_servos'] = True
 
     @abc.abstractmethod
-    async def configure_servo(self, number: str, config: dict, platform_config: dict) -> "ServoPlatformInterface":
+    async def configure_servo(self, number: str, config: dict) -> "ServoPlatformInterface":
         """Configure a servo device in platform.
 
         Args:
@@ -527,19 +527,30 @@ class SwitchPlatform(BasePlatform, metaclass=abc.ABCMeta):
 
 @dataclass
 class SwitchSettings:
+
+    """Base class for a switch configuration setting."""
+
     hw_switch: Any
     invert: Any
     debounce: Any
 
+
 @dataclass
 class DriverSettings:
+
+    """Base class for a driver configuration setting."""
+
     hw_driver: Any
     pulse_settings: Any
     hold_settings: Any
     recycle: Any
 
+
 @dataclass
 class DriverConfig:
+
+    """Base class for a driver platform configuration."""
+
     name: str
     default_pulse_ms: int
     default_pulse_power: float
@@ -550,13 +561,16 @@ class DriverConfig:
     max_pulse_power: float
     max_hold_power: float
 
+
 @dataclass
 class RepulseSettings:
+
+    """Base class for a driver repulse setting."""
+
     enable_repulse: bool
     debounce_ms: int
 
 
-
 class DriverPlatform(BasePlatform, metaclass=abc.ABCMeta):
 
     """Baseclass for platforms with drivers."""

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/plugin.py

@@ -1,11 +1,13 @@
 """Contains the MPF Plugin class."""
 
 from mpf.core.logging import LogMixin
-from mpf.core.utility_functions import Util
+
 
 class MpfPlugin(LogMixin):
 
-    __slots__ = ("machine", "name")
+    """Base class for a plugin module."""
+
+    __slots__ = ("machine", "name", "config")
 
     config_section = None
 
@@ -14,18 +16,18 @@ class MpfPlugin(LogMixin):
         super().__init__()
         self.machine = machine
         self.name = type(self).__name__
+        self.config = None
 
         if self.config_section and self.config_section not in self.machine.config:
             self.machine.log.debug('"%s:" section not found in machine '
-                    'configuration, so the %s will not be '
-                    'used.', self.config_section, self.name)
+                                   'configuration, so the %s will not be '
+                                   'used.', self.config_section, self.name)
 
     def initialize(self):
         """Called when the plugin is enabled and loaded into MPF.
 
         Override with plugin-specific init behavior.
         """
-        pass
 
     @property
     def is_plugin_enabled(self):

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/rgb_color.py

@@ -185,7 +185,8 @@ class RGBColor:
             try:
                 self._color = (color[0], color[1], color[2])
             except IndexError:
-                raise ValueError(f"Invalid RGB color value provided: {color}. Do you need to add quotes around a color that starts or ends with zeros?")
+                raise ValueError(f"Invalid RGB color value provided: {color}. Do you need to add quotes "
+                                 "around a color that starts or ends with zeros?")
         else:
             self._color = RGB_MIN
 

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/text_ui.py

@@ -80,7 +80,8 @@ class TextUi(MpfController):
         self.screen = None
 
         if not machine.options['text_ui'] or not Scene:
-            self.log.debug("Text UI is disabled. TUI option setting: %s, Asciimatics loaded: %s", machine.options['text_ui'], Scene)
+            self.log.debug("Text UI is disabled. TUI option setting: %s, Asciimatics loaded: %s",
+                           machine.options['text_ui'], Scene)
             return
 
         # hack to add themes until https://github.com/peterbrittain/asciimatics/issues/207 is implemented
@@ -169,7 +170,7 @@ class TextUi(MpfController):
 
     def _update_stats(self):
         # Runtime
-        rt = (datetime.now() - self.start_time)
+        rt = datetime.now() - self.start_time
         mins, sec = divmod(rt.seconds + rt.days * 86400, 60)
         hours, mins = divmod(mins, 60)
         self.footer_uptime.text = 'RUNNING {:d}:{:02d}:{:02d}'.format(hours, mins, sec)
@@ -460,7 +461,8 @@ class TextUi(MpfController):
     def _bcp_connected(self, **kwargs):
         del kwargs
         self.scene.remove_effect(self._pending_bcp_connection)
-        self._create_window()  # The MC will write any SDL or other messages on top of the TUI, so recreate it to get rid of that stuff
+        # The MC will write any SDL or other messages on top of the TUI, so recreate it to get rid of that stuff
+        self._create_window()
         self._schedule_draw_screen()
 
     def _asset_load_change(self, percent, **kwargs):

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/core/utility_functions.py

@@ -737,9 +737,9 @@ class Util:
             return 1.0
 
     @staticmethod
-    def snake_to_pascal(input: str) -> str:
+    def snake_to_pascal(text: str) -> str:
         """Convert a snake_case_string to a PascalCaseString."""
-        temp = input.split('_')
+        temp = text.split('_')
         return ''.join(e.title() for e in temp)
 
     @staticmethod

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/ball_device/ball_count_handler.py

@@ -94,11 +94,8 @@ class BallCountHandler(BallDeviceStateHandler):
         self._ball_count = await self.counter.count_balls()
         # on start try to reorder balls if count is unstable
         if self.counter.is_count_unreliable() or self.counter.is_jammed():
-            self.info_log("BCH: Count is unstable. Trying to reorder balls.")
-            await self.ball_device.ejector.reorder_balls()
-            self.info_log("BCH: Repulse done. Waiting for balls to settle.")
-            # recount
-            self._ball_count = await self.counter.count_balls()
+            # Platform watchdogs don't open until init phase 3/4, so wait before reordering
+            self.machine.events.add_async_handler("init_phase_5", self._reorder_balls)
 
         self.info_log("BCH: Initial count: %s", self._ball_count)
 
@@ -108,6 +105,17 @@ class BallCountHandler(BallDeviceStateHandler):
         await super().initialize()
         self._count_valid.set()
 
+    async def _reorder_balls(self, **kwargs):
+        del kwargs
+        self.machine.events.remove_handler(self._reorder_balls)
+        self.info_log("BCH: Count is unstable. Trying to reorder balls.")
+        await self.ball_device.ejector.reorder_balls()
+        self.info_log("BCH: Repulse done. Waiting for balls to settle.")
+        # recount
+        self._ball_count = await self.counter.count_balls()
+
+        self.info_log("BCH: Reordered count: %s", self._ball_count)
+
     @property
     def has_ball(self) -> bool:
         """Return true if the device has at least one ball."""

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/ball_device/outgoing_balls_handler.py

@@ -442,7 +442,7 @@ class OutgoingBallsHandler(BallDeviceStateHandler):
                             self._eject_queue.get_nowait()
                             self._eject_queue.task_done()
                     self.info_log("Necessary queue requests are cancelled. Updating ball count to %s." % new_balls)
-                    self.ball_device.ball_count_handler._set_ball_count(new_balls)
+                    self.ball_device.ball_count_handler._set_ball_count(new_balls)  # pylint: disable=protected-access
 
             return result
         except asyncio.CancelledError:

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/ball_hold.py

@@ -244,13 +244,14 @@ class BallHold(EnableDisableMixin, SystemWideDevice, ModeDevice):
 
     def _lost_ball(self, device, balls, **kwargs):
         """Handle the ball hold devices losing a ball."""
+        del kwargs
         if self.balls_held:
             self.balls_held -= balls
             self.info_log("Ball device %s lost %s balls, hold now has %s balls held", device, balls, self.balls_held)
         else:
             self.info_log("Ball device %s lost %s balls but hold is not holding. Doing nothing.", device, balls)
         # Do not claim this ball
-        return { 'balls': balls }
+        return {'balls': balls}
 
     def _hold_ball(self, device, new_balls, unclaimed_balls, **kwargs):
         """Handle result of _ball_enter event of hold_devices."""

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/drop_target.py

@@ -217,7 +217,8 @@ class DropTarget(SystemWideDevice):
         self.debug_log("Drop target %s switch %s has active value %s compared to drop complete %s",
                        self.name, self.config['switch'].name, is_complete, self.complete)
         if self._in_ball_search or self._ignore_switch_hits:
-            self.debug_log("Ignoring state change in drop target %s due to being in ball search or ignoring switch hits", self.name)
+            self.debug_log("Ignoring state change in drop target %s due to being in ball search "
+                           "or ignoring switch hits", self.name)
             return
 
         if not reconcile:

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/light.py

@@ -133,7 +133,8 @@ class Light(SystemWideDevice, DevicePositionMixin):
                 for driver in drivers:
                     key = (light.config['platform'], driver.number, type(driver))
                     if key in check_set:
-                        raise ConfigFileError(f"Duplicate light number {type(driver)} {driver.number} for light {light}", 10, "light", key, "light")
+                        raise ConfigFileError(f"Duplicate number {type(driver)} {driver.number} for light {light}",
+                                              10, "light", key, "light")
 
                     check_set.add(key)
 
@@ -343,7 +344,8 @@ class Light(SystemWideDevice, DevicePositionMixin):
                 self.default_fade_ms = (self.machine.config['light_settings']
                                         ['default_fade_ms'])
 
-            if len(self.hw_drivers) == 4 and all(channel in self.hw_drivers for channel in ['red', 'green', 'blue', 'white']):
+            if len(self.hw_drivers) == 4 and all(channel in self.hw_drivers
+                                                 for channel in ['red', 'green', 'blue', 'white']):
                 self._rbgw_style = self.machine.config['mpf']['rgbw_white_behavior']
 
             self.debug_log("Initializing Light. CC Profile: %s, "

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/light_group.py

@@ -95,20 +95,20 @@ class LightGroup(SystemWideDevice):
     def _reorder_lights(self):
         if self.config['size'] == '8digit':
             #Magic order for 8 digit NeoSeg displays from CobraPin
-            order = [95,90,93,82,85,89,86,91,88,87,81,92,83,84,94,
-                     104,76,79,96,99,103,100,77,102,101,75,78,97,98,80,
-                     110,105,108,67,70,74,71,106,73,72,66,107,68,69,109,
-                     119,61,64,111,114,118,115,62,117,116,60,63,112,113,65,
-                     5,0,3,52,55,59,56,1,58,57,51,2,53,54,4,
-                     14,46,49,6,9,13,10,47,12,11,45,48,7,8,50,
-                     20,15,18,37,40,44,41,16,43,42,36,17,38,39,19,
-                     29,31,34,21,24,28,25,32,27,26,30,33,22,23,35]
+            order = [95, 90, 93, 82, 85, 89, 86, 91, 88, 87, 81, 92, 83, 84, 94,
+                     104, 76, 79, 96, 99, 103, 100, 77, 102, 101, 75, 78, 97, 98, 80,
+                     110, 105, 108, 67, 70, 74, 71, 106, 73, 72, 66, 107, 68, 69, 109,
+                     119, 61, 64, 111, 114, 118, 115, 62, 117, 116, 60, 63, 112, 113, 65,
+                     5, 0, 3, 52, 55, 59, 56, 1, 58, 57, 51, 2, 53, 54, 4,
+                     14, 46, 49, 6, 9, 13, 10, 47, 12, 11, 45, 48, 7, 8, 50,
+                     20, 15, 18, 37, 40, 44, 41, 16, 43, 42, 36, 17, 38, 39, 19,
+                     29, 31, 34, 21, 24, 28, 25, 32, 27, 26, 30, 33, 22, 23, 35]
         elif self.config['size'] == '2digit':
             #Magic order for 2 digit NeoSeg displays from CobraPin
-            order = [5,0,3,22,25,29,26,1,28,27,21,2,23,24,4,
-                     14,16,19,6,9,13,10,17,12,11,15,18,7,8,20]
+            order = [5, 0, 3, 22, 25, 29, 26, 1, 28, 27, 21, 2, 23, 24, 4,
+                     14, 16, 19, 6, 9, 13, 10, 17, 12, 11, 15, 18, 7, 8, 20]
         else:
-            order = range(0,len(self.lights))
+            order = range(0, len(self.lights))
 
         self.lights = [self.lights[i] for i in order]
 
@@ -179,9 +179,7 @@ class NeoSegDisplay(LightGroup):
 
     __slots__ = []  # type: List[str]
 
-
     def _create_lights(self):
-        distance = 0
         if self.config['size'] == '8digit':
             count = 120
         elif self.config['size'] == '2digit':

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/multiball_lock.py

@@ -335,7 +335,7 @@ class MultiballLock(EnableDisableMixin, ModeDevice):
         del kwargs
         self.info_log("Ball device %s lost %s balls, %s has %s locked balls and action %s",
                       device.name, balls, self.name, self.locked_balls,
-                      self.config['ball_lost_action'] )
+                      self.config['ball_lost_action'])
         if self.locked_balls and self.config['ball_lost_action'] == "add_to_play":
             self.info_log("Ball device %s lost %s balls, adding to balls_in_play", device.name, balls)
             self.machine.game.balls_in_play += balls

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/score_reel_controller.py

@@ -1,9 +1,6 @@
 """Score reel controller."""
 import logging
 
-import asyncio
-from functools import partial
-
 
 class ScoreReelController:
 
@@ -155,7 +152,6 @@ class ScoreReelController:
             score_reel_group.set_value(0)
             await score_reel_group.wait_for_ready()
 
-
     def _game_ending(self, **kwargs):
         """Reset controller."""
         del kwargs

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/score_reel_group.py

@@ -1,8 +1,6 @@
 """A group of score reels."""
 from collections import deque
 
-import asyncio
-
 from mpf.core.system_wide_device import SystemWideDevice
 from mpf.devices.score_reel_controller import ScoreReelController
 

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/segment_display/segment_display_text.py

@@ -47,7 +47,7 @@ class SegmentDisplayText(metaclass=abc.ABCMeta):
         char_colors = [None] * len(text)
         return UncoloredSegmentDisplayText(
             cls._create_characters(text, display_size, collapse_dots, collapse_commas, use_dots_for_commas,
-            char_colors), collapse_dots, collapse_commas, use_dots_for_commas)
+                                   char_colors), collapse_dots, collapse_commas, use_dots_for_commas)
 
     @classmethod
     def _embed_dots_and_commas(cls, text: str, collapse_dots: bool, collapse_commas: bool, use_dots_for_commas: bool):

{mpf-0.57.1.dev2 → mpf-0.57.1.dev3}/mpf/devices/segment_display/transition_manager.py

@@ -25,8 +25,8 @@ class TransitionManager:
         if transition_config:
             config = transition_config.copy()
             config.pop('type')
-            return TRANSITIONS[transition_config['type']](output_length, collapse_dots, collapse_commas, 
-                               use_dots_for_commas, config)
+            return TRANSITIONS[transition_config['type']](output_length, collapse_dots, collapse_commas,
+                                                          use_dots_for_commas, config)
 
         return None