molcraft 0.1.0a12__tar.gz → 0.1.0a14__tar.gz

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: molcraft
-Version: 0.1.0a12
+Version: 0.1.0a14
 Summary: Graph Neural Networks for Molecular Machine Learning
 Author-email: Alexander Kensert <alexander.kensert@gmail.com>
 License: MIT License

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/molcraft/__init__.py

@@ -1,4 +1,4 @@
-__version__ = '0.1.0a12'
+__version__ = '0.1.0a14'
 
 import os
 os.environ["TF_CPP_MIN_LOG_LEVEL"] = "3"

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/molcraft/chem.py

@@ -331,20 +331,20 @@ def get_shortest_paths(
 def get_periodic_table():
     return Chem.GetPeriodicTable()
 
-def gasteiger_charges(mol: 'Mol') -> list[float]:
+def partial_charges(mol: 'Mol') -> list[float]:
     rdPartialCharges.ComputeGasteigerCharges(mol)
     return [atom.GetDoubleProp("_GasteigerCharge") for atom in mol.atoms]
 
 def logp_contributions(mol: 'Mol') -> list[float]:
     return [i[0] for i in rdMolDescriptors._CalcCrippenContribs(mol)]
 
-def molar_refractivity_contribution(mol: 'Mol') -> list[float]:
+def molar_refractivity_contributions(mol: 'Mol') -> list[float]:
     return [i[1] for i in rdMolDescriptors._CalcCrippenContribs(mol)]
 
-def tpsa_contribution(mol: 'Mol') -> list[float]:
+def total_polar_surface_area_contributions(mol: 'Mol') -> list[float]:
     return list(rdMolDescriptors._CalcTPSAContribs(mol))
 
-def asa_contribution(mol: 'Mol') -> list[float]:
+def accessible_surface_area_contributions(mol: 'Mol') -> list[float]:
     return list(rdMolDescriptors._CalcLabuteASAContribs(mol)[0])
 
 def hydrogen_acceptors(mol: 'Mol') -> list[bool]:

molcraft-0.1.0a14/molcraft/datasets.py

@@ -0,0 +1,131 @@
+import numpy as np
+import pandas as pd
+import typing
+
+
+def split(
+    data: pd.DataFrame | np.ndarray,
+    *,
+    train_size: float | None = None,
+    validation_size: float | None = None, 
+    test_size: float | None = None,
+    groups: str | np.ndarray = None,
+    shuffle: bool = False, 
+    random_state: int | None = None,
+) -> tuple[np.ndarray | pd.DataFrame, ...]:
+    """Splits the dataset into subsets.
+
+    Args:
+        data: 
+            A pd.DataFrame or np.ndarray object.
+        train_size:
+            The size of the train set.
+        validation_size:
+            The size of the validation set.
+        test_size:
+            The size of the test set.
+        groups:
+            The groups to perform the splitting on.
+        shuffle:
+            Whether the dataset should be shuffled prior to splitting.
+        random_state:
+            The random state/seed. Only applicable if shuffling.
+    """
+    if not isinstance(data, (pd.DataFrame, np.ndarray)):
+        raise ValueError(f'Unsupported `data` type ({type(data)}).')
+
+    if isinstance(groups, str):
+        groups = data[groups].values 
+    elif groups is None:
+        groups = np.arange(len(data))
+    
+    indices = np.unique(groups)
+    size = len(indices)
+
+    if not train_size and not test_size:
+        raise ValueError(
+            f'Found both `train_size` and `test_size` to be `None`, '
+            f'specify at least one of them.'
+        )
+    if isinstance(test_size, float):
+        test_size = int(size * test_size)
+    if isinstance(train_size, float):
+        train_size = int(size * train_size)
+    if isinstance(validation_size, float):
+        validation_size = int(size * validation_size)
+    elif not validation_size:
+        validation_size = 0
+
+    if not train_size:
+        train_size = (size - test_size - validation_size)
+    if not test_size:
+        test_size = (size - train_size - validation_size)
+    
+    remainder = size - (train_size + validation_size + test_size)
+    if remainder < 0:
+        raise ValueError(
+            f'subset sizes added up to more than the data size.'
+        )
+    train_size += remainder
+
+    if shuffle:
+        np.random.seed(random_state)
+        np.random.shuffle(indices)
+
+    train_mask = np.isin(groups, indices[:train_size])
+    test_mask = np.isin(groups, indices[-test_size:])
+    if not validation_size:
+        return data[train_mask], data[test_mask]
+    validation_mask = np.isin(groups, indices[train_size:-test_size])
+    return data[train_mask], data[validation_mask], data[test_mask]
+    
+def cv_split(
+    data: pd.DataFrame | np.ndarray,
+    num_splits: int = 10,
+    groups: str | np.ndarray = None,
+    shuffle: bool = False, 
+    random_state: int | None = None,
+) -> typing.Iterator[
+        tuple[np.ndarray | pd.DataFrame, np.ndarray | pd.DataFrame]
+    ]:
+    """Splits the dataset into cross-validation folds.
+
+    Args:
+        data: 
+            A pd.DataFrame or np.ndarray object.
+        num_splits:
+            The number of cross-validation folds.
+        groups:
+            The groups to perform the splitting on.
+        shuffle:
+            Whether the dataset should be shuffled prior to splitting.
+        random_state:
+            The random state/seed. Only applicable if shuffling.
+    """
+    if not isinstance(data, (pd.DataFrame, np.ndarray)):
+        raise ValueError(f'Unsupported `data` type ({type(data)}).')
+    
+    if isinstance(groups, str):
+        groups = data[groups].values
+    elif groups is None:
+        groups = np.arange(len(data))
+
+    indices = np.unique(groups)
+    size = len(indices)
+    
+    if num_splits > size:
+        raise ValueError(
+            f'`num_splits` ({num_splits}) must not be greater than'
+            f'the data size or the number of groups ({size}).'
+        )
+    if shuffle:
+        np.random.seed(random_state)
+        np.random.shuffle(indices)
+
+    indices_splits = np.array_split(indices, num_splits)
+
+    for k in range(num_splits):
+        test_indices = indices_splits[k]
+        test_mask = np.isin(groups, test_indices)
+        train_mask = ~test_mask
+        yield data[train_mask], data[test_mask]

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/molcraft/descriptors.py

@@ -37,19 +37,21 @@ class MolWeight(Descriptor):
 
 
 @keras.saving.register_keras_serializable(package='molcraft')
-class TPSA(Descriptor):
+class TotalPolarSurfaceArea(Descriptor):
     def call(self, mol: chem.Mol) -> np.ndarray:
         return rdMolDescriptors.CalcTPSA(mol)
 
 
 @keras.saving.register_keras_serializable(package='molcraft')
-class CrippenLogP(Descriptor):
+class LogP(Descriptor):
+    """Crippen logP."""
     def call(self, mol: chem.Mol) -> np.ndarray:
         return rdMolDescriptors.CalcCrippenDescriptors(mol)[0]
     
 
 @keras.saving.register_keras_serializable(package='molcraft')
-class CrippenMolarRefractivity(Descriptor):
+class MolarRefractivity(Descriptor):
+    """Crippen molar refractivity."""
     def call(self, mol: chem.Mol) -> np.ndarray:
         return rdMolDescriptors.CalcCrippenDescriptors(mol)[1]
     

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/molcraft/features.py

@@ -276,37 +276,42 @@ class IsHydrogenAcceptor(Feature):
 class IsInRing(Feature):
     def call(self, mol: chem.Mol) -> list[int, float, str]:         
         return [atom.IsInRing() for atom in mol.atoms]
-
+    
 
 @keras.saving.register_keras_serializable(package='molcraft')
-class CrippenLogPContribution(Feature):
-    def call(self, mol: chem.Mol) -> list[int, float, str]:      
-        return chem.logp_contributions(mol)
+class PartialCharge(Feature):
+    """Gasteiger partial charge."""
+    def call(self, mol: chem.Mol) -> list[int, float, str]:  
+        return chem.partial_charges(mol)
 
 
 @keras.saving.register_keras_serializable(package='molcraft')
-class CrippenMolarRefractivityContribution(Feature):
+class TotalPolarSurfaceAreaContribution(Feature):
+    """Total polar surface area (TPSA) contribution."""
     def call(self, mol: chem.Mol) -> list[int, float, str]:      
-        return chem.molar_refractivity_contribution(mol)
-    
+        return chem.total_polar_surface_area_contributions(mol)
 
-@keras.saving.register_keras_serializable(package='molcraft')
-class TPSAContribution(Feature):
-    def call(self, mol: chem.Mol) -> list[int, float, str]:      
-        return chem.tpsa_contribution(mol)
-    
 
 @keras.saving.register_keras_serializable(package='molcraft')
-class LabuteASAContribution(Feature):
+class AccessibleSurfaceAreaContribution(Feature):
+    """Labute accessible surface area (ASA) contribution."""
     def call(self, mol: chem.Mol) -> list[int, float, str]:  
-        return chem.asa_contribution(mol)
+        return chem.accessible_surface_area_contributions(mol)
 
 
 @keras.saving.register_keras_serializable(package='molcraft')
-class GasteigerCharge(Feature):
-    def call(self, mol: chem.Mol) -> list[int, float, str]:  
-        return chem.gasteiger_charges(mol)
-    
+class LogPContribution(Feature):
+    """Crippen logP contribution."""
+    def call(self, mol: chem.Mol) -> list[int, float, str]:      
+        return chem.logp_contributions(mol)
+
+
+@keras.saving.register_keras_serializable(package='molcraft')
+class MolarRefractivityContribution(Feature):
+    """Crippen molar refractivity contribution."""
+    def call(self, mol: chem.Mol) -> list[int, float, str]:      
+        return chem.molar_refractivity_contributions(mol)
+
 
 @keras.saving.register_keras_serializable(package='molcraft')
 class BondType(Feature):

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/molcraft/featurizers.py

@@ -192,9 +192,9 @@ class MolGraphFeaturizer(Featurizer):
         if default_molecule_features:
             molecule_features = [
                 descriptors.MolWeight(),
-                descriptors.TPSA(),
-                descriptors.CrippenLogP(),
-                descriptors.CrippenMolarRefractivity(),
+                descriptors.TotalPolarSurfaceArea(),
+                descriptors.LogP(),
+                descriptors.MolarRefractivity(),
                 descriptors.NumHeavyAtoms(),
                 descriptors.NumHeteroatoms(),
                 descriptors.NumHydrogenDonors(),

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/molcraft/models.py

@@ -250,7 +250,7 @@ class GraphModel(layers.GraphLayer, keras.models.Model):
                 val_size = int(val_split * x.num_subgraphs)
                 x_val = _make_dataset(x[-val_size:], batch_size)
                 x = x[:-val_size]
-            x = _make_dataset(x, batch_size)
+            x = _make_dataset(x, batch_size, shuffle=kwargs.get('shuffle', True))
         return super().fit(x, validation_data=x_val, **kwargs)
     
     def evaluate(self, x: tensors.GraphTensor | tf.data.Dataset, **kwargs):
@@ -561,9 +561,8 @@ def _functional_init_arguments(args, kwargs):
         or ("inputs" in kwargs and "outputs" in kwargs)
     )
 
-def _make_dataset(x: tensors.GraphTensor, batch_size: int):
-    return (
-        tf.data.Dataset.from_tensor_slices(x)
-        .batch(batch_size)
-        .prefetch(-1)
-    )
+def _make_dataset(x: tensors.GraphTensor, batch_size: int, shuffle: bool = False):
+    ds = tf.data.Dataset.from_tensor_slices(x)
+    if shuffle:
+        ds = ds.shuffle(buffer_size=ds.cardinality())
+    return ds.batch(batch_size).prefetch(-1)

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/molcraft/ops.py

@@ -62,6 +62,22 @@ def scatter_update(
         indices = keras.ops.expand_dims(indices, axis=-1)
     return keras.ops.scatter_update(inputs, indices, updates)
 
+def scatter_add(
+    inputs: tf.Tensor,
+    indices: tf.Tensor,
+    updates: tf.Tensor,
+) -> tf.Tensor:
+    if indices.dtype == tf.bool:
+        indices = keras.ops.stack(keras.ops.where(indices), axis=-1)
+    expected_rank = len(keras.ops.shape(inputs))
+    current_rank = len(keras.ops.shape(indices))
+    for _ in range(expected_rank - current_rank):
+        indices = keras.ops.expand_dims(indices, axis=-1)
+    if backend.backend() == 'tensorflow':
+        return tf.tensor_scatter_nd_add(inputs, indices, updates)
+    updates = scatter_update(keras.ops.zeros_like(inputs), indices, updates)
+    return inputs + updates
+
 def edge_softmax(
     score: tf.Tensor, 
     edge_target: tf.Tensor

{molcraft-0.1.0a12 → molcraft-0.1.0a14}/molcraft.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: molcraft
-Version: 0.1.0a12
+Version: 0.1.0a14
 Summary: Graph Neural Networks for Molecular Machine Learning
 Author-email: Alexander Kensert <alexander.kensert@gmail.com>
 License: MIT License

molcraft-0.1.0a12/molcraft/datasets.py

@@ -1,123 +0,0 @@
-import numpy as np
-import pandas as pd
-
-
-def split(
-    data: pd.DataFrame | np.ndarray,
-    train_size: float | None = None,
-    validation_size: float | None = None, 
-    test_size: float = 0.1,
-    shuffle: bool = False, 
-    random_state: int | None = None,
-) -> pd.DataFrame | np.ndarray:
-    """Splits dataset into subsets.
-
-    Args:
-        data: 
-            A pd.DataFrame or np.ndarray object.
-        train_size:
-            Optional train size, as a fraction (`float`) or size (`int`).
-        validation_size:
-            Optional validation size, as a fraction (`float`) or size (`int`).
-        test_size:
-            Required test size, as a fraction (`float`) or size (`int`).
-        shuffle:
-            Whether the dataset should be shuffled prior to splitting.
-        random_state:
-            The random state (or seed). Only applicable if shuffling.
-    """
-
-    if not isinstance(data, (pd.DataFrame, np.ndarray, list)):
-        raise ValueError(
-            '`data` needs to be a pd.DataFrame, np.ndarray or a list. '
-            f'Found {type(data)}.'
-        )
-    
-    size = len(data)
-    
-    if test_size is None:
-        raise ValueError('`test_size` is required.')
-    elif test_size <= 0:
-        raise ValueError(
-            f'Test size needs to be positive. Found: {test_size}. '
-            'Either specify a positive `float` (fraction) or '
-            'a positive `int` (size).'
-        )
-    if train_size is not None and train_size <= 0:
-        raise ValueError(
-            f'Train size needs to be None or positive. Found: {train_size}. '
-            'Either specify `None`, a positive `float` (fraction) or '
-            'a positive `int` (size).'
-        )
-    if validation_size is not None and validation_size <= 0:
-        raise ValueError(
-            f'Validation size needs to be None or positive. Found: {validation_size}. '
-            'Either specify `None`, a positive `float` (fraction) or '
-            'a positive `int` (size).'
-        )
-    
-    if isinstance(test_size, float):
-        test_size = int(size * test_size)
-    if validation_size and isinstance(validation_size, float):
-        validation_size = int(size * validation_size)
-    elif not validation_size:
-        validation_size = 0
-
-    if train_size and isinstance(train_size, float):
-        train_size = int(size * train_size)
-    elif not train_size:
-        train_size = 0
-
-    if not train_size:
-        train_size = size - test_size
-        if not validation_size:
-            train_size -= validation_size
-
-    remainder = size - (train_size + validation_size + test_size)
-
-    if remainder < 0:
-        raise ValueError(
-            'Sizes of data subsets add up to more than the size of the original data set: '
-            f'{size} < ({train_size} + {validation_size} + {test_size})'
-        )
-    if test_size <= 0:
-        raise ValueError(
-            f'Test size needs to be greater than 0. Found: {test_size}.'
-        )
-    if train_size <= 0:
-        raise ValueError(
-            f'Train size needs to be greater than 0. Found: {train_size}.'
-        )
-    
-    train_size += remainder
-
-    if isinstance(data, pd.DataFrame):
-        if shuffle:
-            data = data.sample(
-                frac=1.0, replace=False, random_state=random_state
-            )
-        train_data = data.iloc[:train_size]
-        test_data = data.iloc[-test_size:]
-        if not validation_size:
-            return train_data, test_data 
-        validation_data = data.iloc[train_size:-test_size]
-        return train_data, validation_data, test_data
-    
-    if not isinstance(data, np.ndarray):
-        data = np.asarray(data)
-
-    np.random.seed(random_state)
-
-    random_indices = np.arange(size)
-    np.random.shuffle(random_indices)
-    data = data[random_indices]
-
-    train_data = data[:train_size]
-    test_data = data[-test_size:]
-    if not validation_size:
-        return train_data, test_data 
-    validation_data = data[train_size:-test_size]
-    return train_data, validation_data, test_data
-    
-
-