minima-cli 0.12.2__tar.gz → 0.12.3__tar.gz

{minima_cli-0.12.2 → minima_cli-0.12.3}/.github/workflows/ci.yml

@@ -35,6 +35,9 @@ jobs:
       - name: Sync deps (dev extra)
         run: uv sync --extra dev
 
+      - name: Venv integrity (installed files match wheel RECORD)
+        run: uv run python scripts/verify_venv_integrity.py
+
       - name: Ruff
         run: uv run ruff check src client_sdk tests
 

{minima_cli-0.12.2 → minima_cli-0.12.3}/CHANGELOG.md

@@ -4,6 +4,24 @@ All notable changes to Minima are documented here. The format follows
 [Keep a Changelog](https://keepachangelog.com/), and the project aims to follow
 [Semantic Versioning](https://semver.org/).
 
+## [0.12.3] - 2026-07-21
+
+### Fixed
+- **Keyed lookup no longer depends on an unreleased SDK method** (server): every prod
+  recommend logged `keyed_lookup_degraded` because the adapter called
+  `self._client.lookup`, which does not exist in released `mubit-sdk` (0.10.0) — the
+  deterministic per-(cluster, model) evidence channel never left the process. A new
+  `_client_lookup` shim prefers a native `Client.lookup` when present and otherwise
+  drives the `core.lookup` op through the SDK's transport engine (same endpoint, key,
+  and error handling as generated methods). Verified against a pristine 0.10.0 install
+  and live against a dev Mubit instance.
+
+### Added
+- **Venv integrity check**: `scripts/verify_venv_integrity.py` re-hashes every installed
+  file against its wheel RECORD and fails on mismatch; runs first in `make test` and as
+  a CI step. Guards against hand-patched site-packages masking prod-only failures —
+  exactly how the keyed-lookup bug stayed invisible locally.
+
 ## [0.12.2] - 2026-07-20
 
 The memory spine: the SQLite ledger starts feeding decisions. Ten PRs across the

{minima_cli-0.12.2 → minima_cli-0.12.3}/CLAUDE.md

@@ -53,6 +53,7 @@ bun run build     # -> dist/minima native binary (bun build --compile)
 - **Offline tests MUST stay hermetic.** `tests/conftest.py` has an autouse fixture that neutralizes `.env` — never rely on ambient credentials in a non-`live` test.
 - For service tests: `tests/factories.py:FakeMemory` + `create_app(...)` + `TestClient` gives a full in-process app with no Mubit.
 - For TUI tests: register a faux provider/model and mock `fetch` — see existing `packages/tui/tests/*.test.ts` for the pattern. No test may hit the network or spend money.
+- **Never hand-patch site-packages.** `make test` (and CI) first runs `scripts/verify_venv_integrity.py`, which re-hashes every installed file against its wheel RECORD and fails on any mismatch — a patched venv once let the whole suite vouch for an SDK method no release has. To try an SDK change, use a local editable install or a pinned fork, then `uv sync --reinstall` to restore.
 
 ## Conventions
 

{minima_cli-0.12.2 → minima_cli-0.12.3}/Makefile

@@ -1,4 +1,4 @@
-.PHONY: install run test lint fmt live eval seed refresh-catalog tui-install tui-test tui-check tui-build tui tui-dev tui-shot
+.PHONY: install run test lint fmt live eval seed refresh-catalog verify-venv tui-install tui-test tui-check tui-build tui tui-dev tui-shot
 
 install:
 	uv sync --extra dev   # dev pulls server + reasoner extras for the full test suite
@@ -6,9 +6,12 @@ install:
 run:
 	uv run --extra server uvicorn minima.main:app --reload --host $${MINIMA_HOST:-0.0.0.0} --port $${MINIMA_PORT:-8080}
 
-test:
+test: verify-venv
 	uv run pytest -m "not live and not eval" -q
 
+verify-venv:
+	uv run python scripts/verify_venv_integrity.py
+
 lint:
 	uv run ruff check src client_sdk tests
 	uv run mypy src/minima

{minima_cli-0.12.2 → minima_cli-0.12.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: minima-cli
-Version: 0.12.2
+Version: 0.12.3
 Summary: Minima CLI: cost-aware LLM model routing — recommend cheaper models, backed by Mubit memory.
 Project-URL: Homepage, https://docs.minima.sh
 Project-URL: Documentation, https://docs.minima.sh

{minima_cli-0.12.2 → minima_cli-0.12.3}/packages/sdk/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mubit-ai/minima-sdk",
-  "version": "0.12.2",
+  "version": "0.12.3",
   "description": "TypeScript SDK for the Minima recommender service (api.minima.sh) — typed /v1/* client for the recommend → run → judge → feedback loop.",
   "type": "module",
   "license": "FSL-1.1-Apache-2.0",

{minima_cli-0.12.2 → minima_cli-0.12.3}/packages/tui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "minima-tui",
-  "version": "0.12.2",
+  "version": "0.12.3",
   "description": "Minima harness + TUI — the `minima` CLI (TypeScript/Ink; successor to the removed Python harness). Talks to the Python FastAPI recommender service over the /v1/* contract.",
   "type": "module",
   "license": "FSL-1.1-Apache-2.0",

{minima_cli-0.12.2 → minima_cli-0.12.3}/pyproject.toml

@@ -7,7 +7,7 @@ build-backend = "hatchling.build"
 # package stays `minima`. This package ships the server + client SDK only; the `minima` CLI
 # is the TypeScript binary installed via Homebrew (brew tap mubit-ai/minima).
 name = "minima-cli"
-version = "0.12.2"
+version = "0.12.3"
 description = "Minima CLI: cost-aware LLM model routing — recommend cheaper models, backed by Mubit memory."
 readme = "README.md"
 requires-python = ">=3.11"

minima_cli-0.12.3/scripts/verify_venv_integrity.py

@@ -0,0 +1,76 @@
+"""Verify installed packages against their wheel RECORD hashes.
+
+A hand-patched file in site-packages lets the whole test suite vouch for code that no
+released package contains (this is exactly how the mubit-sdk `Client.lookup` prod
+incident stayed invisible locally). This walks every installed distribution, re-hashes
+each file RECORD claims, and fails loudly on any mismatch.
+
+Usage: uv run python scripts/verify_venv_integrity.py [dist-name ...]
+With no args, every installed distribution is checked.
+"""
+
+from __future__ import annotations
+
+import base64
+import hashlib
+import sys
+from importlib.metadata import distributions
+
+
+def _file_hash(path: str, algo: str) -> str:
+    h = hashlib.new(algo)
+    with open(path, "rb") as f:
+        for chunk in iter(lambda: f.read(1 << 20), b""):
+            h.update(chunk)
+    return base64.urlsafe_b64encode(h.digest()).rstrip(b"=").decode("ascii")
+
+
+def main(argv: list[str]) -> int:
+    only = {name.lower() for name in argv}
+    mismatched: list[str] = []
+    missing: list[str] = []
+    dists = 0
+    files = 0
+    for dist in distributions():
+        name = (dist.metadata["Name"] or "").lower()
+        if only and name not in only:
+            continue
+        if not dist.files:
+            continue
+        dists += 1
+        for pf in dist.files:
+            hash_ = getattr(pf, "hash", None)
+            if hash_ is None:
+                continue  # RECORD itself, *.pyc, editable .pth stubs
+            try:
+                located = dist.locate_file(pf)
+            except Exception:
+                continue
+            path = str(located)
+            try:
+                actual = _file_hash(path, hash_.mode.replace("-", "_"))
+            except FileNotFoundError:
+                missing.append(f"{name}: {pf}")
+                continue
+            except ValueError:
+                continue  # unknown hash algo — nothing to verify against
+            files += 1
+            if actual != hash_.value:
+                mismatched.append(f"{name}: {pf}")
+    for line in mismatched:
+        print(f"TAMPERED (hash != wheel RECORD): {line}", file=sys.stderr)
+    for line in missing:
+        print(f"MISSING (listed in RECORD, not on disk): {line}", file=sys.stderr)
+    if mismatched:
+        print(
+            f"venv integrity FAILED: {len(mismatched)} tampered file(s) across {dists} dist(s). "
+            "Reinstall with `uv sync --reinstall` — never hand-patch site-packages.",
+            file=sys.stderr,
+        )
+        return 1
+    print(f"venv integrity OK: {files} files across {dists} dists match their wheel RECORD")
+    return 0
+
+
+if __name__ == "__main__":
+    raise SystemExit(main(sys.argv[1:]))

{minima_cli-0.12.2 → minima_cli-0.12.3}/src/minima/memory/adapter.py

@@ -92,6 +92,35 @@ def _parse_lookup_record(item: Mapping[str, Any]) -> RecalledEvidence | None:
     )
 
 
+_LOOKUP_OP = {
+    "key": "core.lookup",
+    "http": {"method": "POST", "path": "/v2/core/lookup"},
+    "grpc": {},
+    "run_id_field": "run_id",
+}
+
+
+def _client_lookup(client: Any, *, session_id: str, match: list[dict], limit: int) -> Any:
+    """Invoke POST /v2/core/lookup, tolerating SDKs without ``Client.lookup``.
+
+    The keyed-lookup endpoint is deliberately not part of the public SDK
+    surface, so released builds (``mubit-sdk`` <= 0.12.x) have no
+    ``Client.lookup`` — calling it raised ``AttributeError`` before any request
+    was made, silently degrading the keyed evidence channel on every recommend
+    in prod. Prefer a native method when one exists; otherwise go through the
+    SDK's transport engine, which handles endpoint/key/error mapping the same
+    way every generated client method does.
+    """
+    native = getattr(client, "lookup", None)
+    if native is not None:
+        return native(session_id=session_id, match=match, limit=limit)
+    return client._transport.invoke(  # noqa: SLF001 — released SDKs expose no public handle
+        _LOOKUP_OP,
+        {"run_id": session_id, "match": match or [], "limit": limit},
+        transport="http",
+    )
+
+
 @runtime_checkable
 class Memory(Protocol):
     async def recall(
@@ -319,7 +348,8 @@ class MubitMemory:
         try:
             with anyio.move_on_after(budget_ms / 1000.0) as scope:
                 raw = await threadpool.run_cancellable(
-                    self._client.lookup,
+                    _client_lookup,
+                    self._client,
                     session_id=lane,
                     match=match,
                     limit=limit,

minima_cli-0.12.3/tests/unit/test_lookup_parse.py

@@ -0,0 +1,110 @@
+"""Keyed-lookup evidence parsing: node-id vs fact-UUID id spaces."""
+
+from __future__ import annotations
+
+from minima.memory.adapter import _parse_lookup_record
+
+FACT_UUID = "814b0fd0-46f4-4f26-8db6-3e508b06a84c"
+
+
+def _item(metadata: dict | None) -> dict:
+    return {"id": 42137, "metadata": metadata}
+
+
+def _outcome_meta(**extra) -> dict:
+    return {
+        "kind": "outcome",
+        "model_id": "claude-haiku-4-5",
+        "task_type": "code",
+        "difficulty": "hard",
+        "task_cluster": "code:hard",
+        "quality_score": 0.9,
+        "outcome": "success",
+        "evidence_source": "judge",
+        **extra,
+    }
+
+
+def test_lookup_hit_without_fact_uuid_is_not_referenceable():
+    ev = _parse_lookup_record(_item(_outcome_meta()))
+    assert ev is not None
+    assert ev.entry_id == "42137"
+    assert ev.reference_id is None
+    assert ev.referenceable is False
+    assert ev.record is not None and ev.record.model_id == "claude-haiku-4-5"
+
+
+def test_lookup_hit_with_fact_uuid_uses_it_as_reference():
+    ev = _parse_lookup_record(_item(_outcome_meta(id=FACT_UUID)))
+    assert ev is not None
+    assert ev.entry_id == "42137"
+    assert ev.reference_id == FACT_UUID
+    assert ev.referenceable is True
+
+
+def test_lookup_hit_never_uses_node_id_as_reference():
+    ev = _parse_lookup_record(_item(_outcome_meta(id="42137")))
+    assert ev is not None
+    assert ev.reference_id is None
+    assert ev.referenceable is False
+
+
+def test_lookup_hit_without_record_is_dropped():
+    assert _parse_lookup_record(_item({"kind": "note"})) is None
+    assert _parse_lookup_record({"metadata": _outcome_meta()}) is None
+
+
+class _Transport:
+    def __init__(self):
+        self.calls: list[tuple] = []
+
+    def invoke(self, op, payload, *, transport=None):
+        self.calls.append((op, payload, transport))
+        return []
+
+
+class _ClientWithoutLookup:
+    """Released mubit-sdk (<= 0.12.x): no Client.lookup attribute."""
+
+    def __init__(self):
+        self._transport = _Transport()
+
+
+class _ClientWithLookup(_ClientWithoutLookup):
+    def __init__(self):
+        super().__init__()
+        self.native_calls: list[dict] = []
+
+    def lookup(self, *, session_id=None, match=None, limit=256):
+        self.native_calls.append({"session_id": session_id, "match": match, "limit": limit})
+        return []
+
+
+def test_client_lookup_shims_released_sdk_via_transport():
+    from minima.memory.adapter import _client_lookup
+
+    client = _ClientWithoutLookup()
+    result = _client_lookup(
+        client, session_id="minima:proj-x", match=[{"kind": "outcome"}], limit=64
+    )
+    assert result == []
+    assert len(client._transport.calls) == 1
+    op, payload, transport = client._transport.calls[0]
+    assert op["http"] == {"method": "POST", "path": "/v2/core/lookup"}
+    assert payload == {
+        "run_id": "minima:proj-x",
+        "match": [{"kind": "outcome"}],
+        "limit": 64,
+    }
+    assert transport == "http"
+
+
+def test_client_lookup_prefers_native_method_when_present():
+    from minima.memory.adapter import _client_lookup
+
+    client = _ClientWithLookup()
+    _client_lookup(client, session_id="minima:proj-x", match=[], limit=256)
+    assert client.native_calls == [
+        {"session_id": "minima:proj-x", "match": [], "limit": 256}
+    ]
+    assert client._transport.calls == []

minima_cli-0.12.2/tests/unit/test_lookup_parse.py

@@ -1,54 +0,0 @@
-"""Keyed-lookup evidence parsing: node-id vs fact-UUID id spaces."""
-
-from __future__ import annotations
-
-from minima.memory.adapter import _parse_lookup_record
-
-FACT_UUID = "814b0fd0-46f4-4f26-8db6-3e508b06a84c"
-
-
-def _item(metadata: dict | None) -> dict:
-    return {"id": 42137, "metadata": metadata}
-
-
-def _outcome_meta(**extra) -> dict:
-    return {
-        "kind": "outcome",
-        "model_id": "claude-haiku-4-5",
-        "task_type": "code",
-        "difficulty": "hard",
-        "task_cluster": "code:hard",
-        "quality_score": 0.9,
-        "outcome": "success",
-        "evidence_source": "judge",
-        **extra,
-    }
-
-
-def test_lookup_hit_without_fact_uuid_is_not_referenceable():
-    ev = _parse_lookup_record(_item(_outcome_meta()))
-    assert ev is not None
-    assert ev.entry_id == "42137"
-    assert ev.reference_id is None
-    assert ev.referenceable is False
-    assert ev.record is not None and ev.record.model_id == "claude-haiku-4-5"
-
-
-def test_lookup_hit_with_fact_uuid_uses_it_as_reference():
-    ev = _parse_lookup_record(_item(_outcome_meta(id=FACT_UUID)))
-    assert ev is not None
-    assert ev.entry_id == "42137"
-    assert ev.reference_id == FACT_UUID
-    assert ev.referenceable is True
-
-
-def test_lookup_hit_never_uses_node_id_as_reference():
-    ev = _parse_lookup_record(_item(_outcome_meta(id="42137")))
-    assert ev is not None
-    assert ev.reference_id is None
-    assert ev.referenceable is False
-
-
-def test_lookup_hit_without_record_is_dropped():
-    assert _parse_lookup_record(_item({"kind": "note"})) is None
-    assert _parse_lookup_record({"metadata": _outcome_meta()}) is None