metafold 0.12.dev3__tar.gz → 0.12.dev4__tar.gz

{metafold-0.12.dev3 → metafold-0.12.dev4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: metafold
-Version: 0.12.dev3
+Version: 0.12.dev4
 Summary: Metafold SDK for Python
 Author-email: Metafold 3D <info@metafold3d.com>
 License: Copyright 2024 Metafold 3D

{metafold-0.12.dev3 → metafold-0.12.dev4}/metafold/simulation/compression_simulation.py

@@ -589,8 +589,12 @@ class CompressionSimulation:
         cancelled = []
         for state in ("pending", "started"):
             for wf in client.workflows.list(q=f"state:{state}", project_id=project_id):
-                client.workflows.cancel(wf.id, project_id=project_id)
-                cancelled.append(wf.id)
+                try:
+                    client.workflows.cancel(wf.id, project_id=project_id)
+                    cancelled.append(wf.id)
+                except HTTPError:
+                    # Workflow already finished/uncancellable — ignore and move on.
+                    pass
         return cancelled
 
     @staticmethod
@@ -887,10 +891,10 @@ class CompressionSimulation:
             grid_min = np.minimum(grid_min, pmin)
             grid_max = np.maximum(grid_max, pmax)
 
-        # Apply margins after all parts included
+        # Apply margins after all parts are included. Note z- gets no margin
+        # since the bottom of the grid is the support boundary the stack sits on
         grid_min[:2] -= self.simulation_parameters.margin_xy
         grid_max[:2] += self.simulation_parameters.margin_xy
-        grid_min[2] -= self.simulation_parameters.margin_z
         grid_max[2] += self.simulation_parameters.margin_z
 
         grid_size = grid_max - grid_min

{metafold-0.12.dev3 → metafold-0.12.dev4}/metafold.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: metafold
-Version: 0.12.dev3
+Version: 0.12.dev4
 Summary: Metafold SDK for Python
 Author-email: Metafold 3D <info@metafold3d.com>
 License: Copyright 2024 Metafold 3D

{metafold-0.12.dev3 → metafold-0.12.dev4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "metafold"
-version = "0.12.dev3"
+version = "0.12.dev4"
 authors = [
     {name = "Metafold 3D", email = "info@metafold3d.com"},
 ]

{metafold-0.12.dev3 → metafold-0.12.dev4}/tests/test_compression_simulation.py

@@ -277,21 +277,23 @@ class TestGridBounds:
         }
         self._prepare(sim, patches)
         lower, _ = self._grid_bounds(sim)
-        mz = sim.simulation_parameters.margin_z
-        # grid bottom (metres) = outsole bottom (-50 mm = -0.05 m) minus margin.
-        assert lower[2] == pytest.approx(-0.05 - mz, abs=1e-6)
-
-    def test_bottom_margin_clearance_added(self, sim):
-        # Bottom (z-) clearance was previously missing entirely. With all parts
-        # flush at z=0, the grid bottom must sit margin_z below the lowest part.
-        flat = {"size": [0.1, 0.1, 0.05], "offset": [0.0, 0.0, 0.0], "resolution": [32, 32, 16]}
+        # grid bottom (metres) = outsole bottom (-50 mm = -0.05 m), flush — the
+        # z- face is the support boundary and gets NO margin.
+        assert lower[2] == pytest.approx(-0.05, abs=1e-6)
+
+    def test_bottom_is_flush_no_margin(self, sim):
+        # The z- face is the support boundary the stack reacts against, so it
+        # must sit flush with the lowest part — adding margin there leaves the
+        # stack unsupported and it sags under the piston before compressing.
+        flat = {"size": [100.0, 100.0, 50.0], "offset": [0.0, 0.0, 0.0], "resolution": [32, 32, 16]}
         self._prepare(sim, {n: flat for n in
                             ["piston", "upper_foam", "midsole", "outsole"]})
-        lower, _ = self._grid_bounds(sim)
+        lower, upper = self._grid_bounds(sim)
         mz = sim.simulation_parameters.margin_z
-        # Lowest part bottom is z=0 (piston cylinder sits higher), so the grid
-        # bottom is exactly -margin_z.
-        assert lower[2] == pytest.approx(-mz, abs=1e-6)
+        # Lowest part bottom is z=0 -> grid bottom is exactly 0 (no margin).
+        assert lower[2] == pytest.approx(0.0, abs=1e-6)
+        # Top (z+, above the piston) still gets clearance.
+        assert upper[2] > 0.05 + mz - 1e-6
 
 
 class TestSampleAssets: