meta-ads-mcp 0.7.8__tar.gz → 0.7.9__tar.gz

{meta_ads_mcp-0.7.8 → meta_ads_mcp-0.7.9}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: meta-ads-mcp
-Version: 0.7.8
+Version: 0.7.9
 Summary: Model Context Protocol (MCP) plugin for interacting with Meta Ads API
 Project-URL: Homepage, https://github.com/pipeboard-co/meta-ads-mcp
 Project-URL: Bug Tracker, https://github.com/pipeboard-co/meta-ads-mcp/issues

meta_ads_mcp-0.7.9/RELEASE.md

@@ -0,0 +1,166 @@
+# Release Process
+
+This repository uses GitHub Actions to automatically publish releases to PyPI. Here's the optimized release process:
+
+## 🚀 Quick Release (Recommended)
+
+### Prerequisites
+- ✅ **Trusted Publishing Configured**: Repository uses PyPI trusted publishing with OIDC tokens
+- ✅ **GitHub CLI installed**: `gh` command available for streamlined releases
+- ✅ **Clean working directory**: No uncommitted changes
+
+### Optimal Release Process
+
+1. **Update version in both files** (use consistent versioning):
+   
+   ```bash
+   # Update pyproject.toml
+   sed -i '' 's/version = "0.7.7"/version = "0.7.8"/' pyproject.toml
+   
+   # Update __init__.py  
+   sed -i '' 's/__version__ = "0.7.7"/__version__ = "0.7.8"/' meta_ads_mcp/__init__.py
+   ```
+   
+   Or manually edit:
+   - `pyproject.toml`: `version = "0.7.8"`
+   - `meta_ads_mcp/__init__.py`: `__version__ = "0.7.8"`
+
+2. **Commit and push version changes**:
+   ```bash
+   git add pyproject.toml meta_ads_mcp/__init__.py
+   git commit -m "Bump version to 0.7.8"
+   git push origin main
+   ```
+
+3. **Create GitHub release** (triggers automatic PyPI publishing):
+   ```bash
+   # Use bash wrapper if gh has issues in Cursor
+   bash -c "gh release create 0.7.8 --title '0.7.8' --generate-notes"
+   ```
+
+4. **Verify release** (optional):
+   ```bash
+   # Check GitHub release
+   curl -s "https://api.github.com/repos/pipeboard-co/meta-ads-mcp/releases/latest" | grep -E '"tag_name"|"name"'
+   
+   # Check PyPI availability (wait 2-3 minutes)
+   curl -s "https://pypi.org/pypi/meta-ads-mcp/json" | grep -E '"version"|"0.7.8"'
+   ```
+
+## 📋 Detailed Release Process
+
+### Version Management Best Practices
+
+- **Semantic Versioning**: Follow `MAJOR.MINOR.PATCH` (e.g., 0.7.8)
+- **Synchronized Files**: Always update BOTH version files
+- **Commit Convention**: Use `"Bump version to X.Y.Z"` format
+- **Release Tag**: GitHub release tag matches version (no "v" prefix)
+
+### Pre-Release Checklist
+
+```bash
+# 1. Ensure clean working directory
+git status
+
+# 2. Run tests locally (optional but recommended)
+uv run python -m pytest tests/ -v
+
+# 3. Check current version
+grep -E "version =|__version__" pyproject.toml meta_ads_mcp/__init__.py
+```
+
+### Release Commands (One-liner)
+
+```bash
+# Complete release in one sequence
+VERSION="0.7.8" && \
+sed -i '' "s/version = \"0.7.7\"/version = \"$VERSION\"/" pyproject.toml && \
+sed -i '' "s/__version__ = \"0.7.7\"/__version__ = \"$VERSION\"/" meta_ads_mcp/__init__.py && \
+git add pyproject.toml meta_ads_mcp/__init__.py && \
+git commit -m "Bump version to $VERSION" && \
+git push origin main && \
+bash -c "gh release create $VERSION --title '$VERSION' --generate-notes"
+```
+
+## 🔄 Workflows
+
+### `publish.yml` (Automatic)
+- **Trigger**: GitHub release creation
+- **Purpose**: Build and publish to PyPI
+- **Security**: OIDC tokens (no API keys)
+- **Status**: ✅ Fully automated
+
+### `test.yml` (Validation)
+- **Trigger**: Push to main/master
+- **Purpose**: Package structure validation
+- **Matrix**: Python 3.10, 3.11, 3.12
+- **Note**: Build tests only, not pytest
+
+## 🛠️ Troubleshooting
+
+### Common Issues
+
+1. **gh command issues in Cursor**:
+   ```bash
+   # Use bash wrapper
+   bash -c "gh release create 0.7.8 --title '0.7.8' --generate-notes"
+   ```
+
+2. **Version mismatch**:
+   ```bash
+   # Verify both files have same version
+   grep -E "version =|__version__" pyproject.toml meta_ads_mcp/__init__.py
+   ```
+
+3. **PyPI not updated**:
+   ```bash
+   # Check if package is available (wait 2-3 minutes)
+   curl -s "https://pypi.org/pypi/meta-ads-mcp/json" | grep '"version"'
+   ```
+
+### Manual Deployment (Fallback)
+
+```bash
+# Install build tools
+pip install build twine
+
+# Build package
+python -m build
+
+# Upload to PyPI (requires API token)
+python -m twine upload dist/*
+```
+
+## 📊 Release Verification
+
+### GitHub Release
+- ✅ Release created with correct tag
+- ✅ Auto-generated notes from commits
+- ✅ Actions tab shows successful workflow
+
+### PyPI Package
+- ✅ Package available for installation
+- ✅ Correct version displayed
+- ✅ All dependencies listed
+
+### Installation Test
+```bash
+# Test new version installation
+pip install meta-ads-mcp==0.7.8
+# or
+uvx meta-ads-mcp@0.7.8
+```
+
+## 🔒 Security Notes
+
+- **Trusted Publishing**: Uses GitHub OIDC tokens (no API keys needed)
+- **Isolated Builds**: All builds run in GitHub-hosted runners
+- **Access Control**: Only maintainers can create releases
+- **Audit Trail**: All releases tracked in GitHub Actions
+
+## 📈 Release Metrics
+
+Track successful releases:
+- **GitHub Releases**: https://github.com/pipeboard-co/meta-ads-mcp/releases
+- **PyPI Package**: https://pypi.org/project/meta-ads-mcp/
+- **Actions History**: https://github.com/pipeboard-co/meta-ads-mcp/actions 

{meta_ads_mcp-0.7.8 → meta_ads_mcp-0.7.9}/meta_ads_mcp/__init__.py

@@ -7,7 +7,7 @@ with the Claude LLM.
 
 from meta_ads_mcp.core.server import main
 
-__version__ = "0.7.8"
+__version__ = "0.7.9"
 
 __all__ = [
     'get_ad_accounts',

{meta_ads_mcp-0.7.8 → meta_ads_mcp-0.7.9}/meta_ads_mcp/core/ads.py

@@ -171,7 +171,7 @@ async def get_ad_creatives(access_token: str = None, ad_id: str = None) -> str:
         
     endpoint = f"{ad_id}/adcreatives"
     params = {
-        "fields": "id,name,status,thumbnail_url,image_url,image_hash,object_story_spec" # Added image_hash
+        "fields": "id,name,status,thumbnail_url,image_url,image_hash,object_story_spec,asset_feed_spec,image_urls_for_viewing"
     }
     
     data = await make_api_request(endpoint, access_token, params)
@@ -279,14 +279,26 @@ async def get_ad_image(access_token: str = None, ad_id: str = None) -> Image:
             if "data" in creative_data and creative_data["data"]:
                 creative = creative_data["data"][0]
                 
-                # Try image_urls_for_viewing first (usually higher quality)
+                # Prioritize higher quality image URLs in this order:
+                # 1. image_urls_for_viewing (usually highest quality)
+                # 2. image_url (direct field)
+                # 3. object_story_spec.link_data.picture (usually full size)
+                # 4. thumbnail_url (last resort - often profile thumbnail)
+                
                 if "image_urls_for_viewing" in creative and creative["image_urls_for_viewing"]:
                     image_url = creative["image_urls_for_viewing"][0]
                     print(f"Using image_urls_for_viewing: {image_url}")
-                # Fall back to thumbnail_url
+                elif "image_url" in creative and creative["image_url"]:
+                    image_url = creative["image_url"]
+                    print(f"Using image_url: {image_url}")
+                elif "object_story_spec" in creative and "link_data" in creative["object_story_spec"]:
+                    link_data = creative["object_story_spec"]["link_data"]
+                    if "picture" in link_data and link_data["picture"]:
+                        image_url = link_data["picture"]
+                        print(f"Using object_story_spec.link_data.picture: {image_url}")
                 elif "thumbnail_url" in creative and creative["thumbnail_url"]:
                     image_url = creative["thumbnail_url"]
-                    print(f"Using thumbnail_url: {image_url}")
+                    print(f"Using thumbnail_url (fallback): {image_url}")
             
             if not image_url:
                 return "Error: No image URLs found in creative"

{meta_ads_mcp-0.7.8 → meta_ads_mcp-0.7.9}/meta_ads_mcp/core/utils.py

@@ -78,23 +78,31 @@ ad_creative_images = {}
 def extract_creative_image_urls(creative: Dict[str, Any]) -> List[str]:
     """
     Extract image URLs from a creative object for direct viewing.
+    Prioritizes higher quality images over thumbnails.
     
     Args:
         creative: Meta Ads creative object
         
     Returns:
-        List of image URLs found in the creative
+        List of image URLs found in the creative, prioritized by quality
     """
     image_urls = []
     
+    # Prioritize higher quality image URLs in this order:
+    # 1. image_urls_for_viewing (usually highest quality)
+    # 2. image_url (direct field)
+    # 3. object_story_spec.link_data.picture (usually full size)
+    # 4. asset_feed_spec images (multiple high-quality images)
+    # 5. thumbnail_url (last resort - often profile thumbnail)
+    
+    # Check for image_urls_for_viewing (highest priority)
+    if "image_urls_for_viewing" in creative and creative["image_urls_for_viewing"]:
+        image_urls.extend(creative["image_urls_for_viewing"])
+    
     # Check for direct image_url field
     if "image_url" in creative and creative["image_url"]:
         image_urls.append(creative["image_url"])
     
-    # Check for thumbnail_url field
-    if "thumbnail_url" in creative and creative["thumbnail_url"]:
-        image_urls.append(creative["thumbnail_url"])
-    
     # Check object_story_spec for image URLs
     if "object_story_spec" in creative:
         story_spec = creative["object_story_spec"]
@@ -103,7 +111,7 @@ def extract_creative_image_urls(creative: Dict[str, Any]) -> List[str]:
         if "link_data" in story_spec:
             link_data = story_spec["link_data"]
             
-            # Check for picture field
+            # Check for picture field (usually full size)
             if "picture" in link_data and link_data["picture"]:
                 image_urls.append(link_data["picture"])
                 
@@ -121,6 +129,10 @@ def extract_creative_image_urls(creative: Dict[str, Any]) -> List[str]:
             if "url" in image and image["url"]:
                 image_urls.append(image["url"])
     
+    # Check for thumbnail_url field (lowest priority)
+    if "thumbnail_url" in creative and creative["thumbnail_url"]:
+        image_urls.append(creative["thumbnail_url"])
+    
     # Remove duplicates while preserving order
     seen = set()
     unique_urls = []

{meta_ads_mcp-0.7.8 → meta_ads_mcp-0.7.9}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "meta-ads-mcp"
-version = "0.7.8"
+version = "0.7.9"
 description = "Model Context Protocol (MCP) plugin for interacting with Meta Ads API"
 readme = "README.md"
 requires-python = ">=3.10"

{meta_ads_mcp-0.7.8 → meta_ads_mcp-0.7.9}/tests/test_get_ad_creatives_fix.py

@@ -90,11 +90,11 @@ class TestGetAdCreativesBugFix:
         
         urls = extract_creative_image_urls(test_creative)
         
-        # Should extract URLs in order: image_url, thumbnail_url, picture
+        # Should extract URLs in order: image_url, picture, thumbnail_url (new priority order)
         expected_urls = [
             "https://example.com/image.jpg",
-            "https://example.com/thumb.jpg", 
-            "https://example.com/picture.jpg"
+            "https://example.com/picture.jpg",
+            "https://example.com/thumb.jpg"
         ]
         
         assert urls == expected_urls

meta_ads_mcp-0.7.9/tests/test_get_ad_image_quality_improvements.py

@@ -0,0 +1,391 @@
+"""Tests for get_ad_image quality improvements.
+
+These tests verify that the get_ad_image function now correctly prioritizes
+high-quality ad creative images over profile thumbnails.
+
+Key improvements tested:
+1. Prioritizes image_urls_for_viewing over thumbnail_url
+2. Uses image_url as second priority
+3. Uses object_story_spec.link_data.picture as third priority
+4. Only uses thumbnail_url as last resort
+5. Better logging to show which image source is being used
+"""
+
+import pytest
+import json
+from unittest.mock import AsyncMock, patch, MagicMock
+from meta_ads_mcp.core.ads import get_ad_image
+from meta_ads_mcp.core.utils import extract_creative_image_urls
+
+
+class TestGetAdImageQualityImprovements:
+    """Test cases for image quality improvements in get_ad_image function."""
+    
+    @pytest.mark.asyncio
+    async def test_prioritizes_image_urls_for_viewing_over_thumbnail(self):
+        """Test that image_urls_for_viewing is prioritized over thumbnail_url."""
+        
+        # Mock responses for creative with both high-quality and thumbnail URLs
+        mock_ad_data = {
+            "account_id": "act_123456789",
+            "creative": {"id": "creative_123456789"}
+        }
+        
+        mock_creative_details = {
+            "id": "creative_123456789",
+            "name": "Test Creative"
+            # No image_hash - triggers fallback
+        }
+        
+        # Mock get_ad_creatives response with both URLs
+        mock_get_ad_creatives_response = json.dumps({
+            "data": [
+                {
+                    "id": "creative_123456789",
+                    "name": "Test Creative",
+                    "status": "ACTIVE",
+                    "thumbnail_url": "https://example.com/thumbnail_64x64.jpg",  # Low quality
+                    "image_url": "https://example.com/full_image.jpg",  # Medium quality
+                    "image_urls_for_viewing": [
+                        "https://example.com/high_quality_image.jpg",  # Highest quality
+                        "https://example.com/alt_high_quality.jpg"
+                    ],
+                    "object_story_spec": {
+                        "link_data": {
+                            "picture": "https://example.com/object_story_picture.jpg"
+                        }
+                    }
+                }
+            ]
+        })
+        
+        # Mock PIL Image processing
+        mock_pil_image = MagicMock()
+        mock_pil_image.mode = "RGB"
+        mock_pil_image.convert.return_value = mock_pil_image
+        
+        mock_byte_stream = MagicMock()
+        mock_byte_stream.getvalue.return_value = b"fake_jpeg_data"
+        
+        with patch('meta_ads_mcp.core.ads.make_api_request', new_callable=AsyncMock) as mock_api, \
+             patch('meta_ads_mcp.core.ads.get_ad_creatives', new_callable=AsyncMock) as mock_get_creatives, \
+             patch('meta_ads_mcp.core.ads.download_image', new_callable=AsyncMock) as mock_download, \
+             patch('meta_ads_mcp.core.ads.PILImage.open') as mock_pil_open, \
+             patch('meta_ads_mcp.core.ads.io.BytesIO') as mock_bytesio:
+            
+            mock_api.side_effect = [mock_ad_data, mock_creative_details]
+            mock_get_creatives.return_value = mock_get_ad_creatives_response
+            mock_download.return_value = b"fake_image_bytes"
+            mock_pil_open.return_value = mock_pil_image
+            mock_bytesio.return_value = mock_byte_stream
+            
+            # This should prioritize image_urls_for_viewing[0]
+            result = await get_ad_image(access_token="test_token", ad_id="test_ad_id")
+            
+            # Verify it used the highest quality URL
+            assert result is not None
+            mock_download.assert_called_once_with("https://example.com/high_quality_image.jpg")
+    
+    @pytest.mark.asyncio
+    async def test_falls_back_to_image_url_when_image_urls_for_viewing_unavailable(self):
+        """Test fallback to image_url when image_urls_for_viewing is not available."""
+        
+        # Mock responses for creative without image_urls_for_viewing
+        mock_ad_data = {
+            "account_id": "act_123456789",
+            "creative": {"id": "creative_123456789"}
+        }
+        
+        mock_creative_details = {
+            "id": "creative_123456789",
+            "name": "Test Creative"
+        }
+        
+        # Mock get_ad_creatives response without image_urls_for_viewing
+        mock_get_ad_creatives_response = json.dumps({
+            "data": [
+                {
+                    "id": "creative_123456789",
+                    "name": "Test Creative",
+                    "status": "ACTIVE",
+                    "thumbnail_url": "https://example.com/thumbnail.jpg",
+                    "image_url": "https://example.com/full_image.jpg",  # Should be used
+                    "object_story_spec": {
+                        "link_data": {
+                            "picture": "https://example.com/object_story_picture.jpg"
+                        }
+                    }
+                }
+            ]
+        })
+        
+        # Mock PIL Image processing
+        mock_pil_image = MagicMock()
+        mock_pil_image.mode = "RGB"
+        mock_pil_image.convert.return_value = mock_pil_image
+        
+        mock_byte_stream = MagicMock()
+        mock_byte_stream.getvalue.return_value = b"fake_jpeg_data"
+        
+        with patch('meta_ads_mcp.core.ads.make_api_request', new_callable=AsyncMock) as mock_api, \
+             patch('meta_ads_mcp.core.ads.get_ad_creatives', new_callable=AsyncMock) as mock_get_creatives, \
+             patch('meta_ads_mcp.core.ads.download_image', new_callable=AsyncMock) as mock_download, \
+             patch('meta_ads_mcp.core.ads.PILImage.open') as mock_pil_open, \
+             patch('meta_ads_mcp.core.ads.io.BytesIO') as mock_bytesio:
+            
+            mock_api.side_effect = [mock_ad_data, mock_creative_details]
+            mock_get_creatives.return_value = mock_get_ad_creatives_response
+            mock_download.return_value = b"fake_image_bytes"
+            mock_pil_open.return_value = mock_pil_image
+            mock_bytesio.return_value = mock_byte_stream
+            
+            # This should fall back to image_url
+            result = await get_ad_image(access_token="test_token", ad_id="test_ad_id")
+            
+            # Verify it used image_url
+            assert result is not None
+            mock_download.assert_called_once_with("https://example.com/full_image.jpg")
+    
+    @pytest.mark.asyncio
+    async def test_falls_back_to_object_story_spec_picture_when_image_url_unavailable(self):
+        """Test fallback to object_story_spec.link_data.picture when image_url is not available."""
+        
+        # Mock responses for creative without image_url
+        mock_ad_data = {
+            "account_id": "act_123456789",
+            "creative": {"id": "creative_123456789"}
+        }
+        
+        mock_creative_details = {
+            "id": "creative_123456789",
+            "name": "Test Creative"
+        }
+        
+        # Mock get_ad_creatives response without image_url
+        mock_get_ad_creatives_response = json.dumps({
+            "data": [
+                {
+                    "id": "creative_123456789",
+                    "name": "Test Creative",
+                    "status": "ACTIVE",
+                    "thumbnail_url": "https://example.com/thumbnail.jpg",
+                    "object_story_spec": {
+                        "link_data": {
+                            "picture": "https://example.com/object_story_picture.jpg"  # Should be used
+                        }
+                    }
+                }
+            ]
+        })
+        
+        # Mock PIL Image processing
+        mock_pil_image = MagicMock()
+        mock_pil_image.mode = "RGB"
+        mock_pil_image.convert.return_value = mock_pil_image
+        
+        mock_byte_stream = MagicMock()
+        mock_byte_stream.getvalue.return_value = b"fake_jpeg_data"
+        
+        with patch('meta_ads_mcp.core.ads.make_api_request', new_callable=AsyncMock) as mock_api, \
+             patch('meta_ads_mcp.core.ads.get_ad_creatives', new_callable=AsyncMock) as mock_get_creatives, \
+             patch('meta_ads_mcp.core.ads.download_image', new_callable=AsyncMock) as mock_download, \
+             patch('meta_ads_mcp.core.ads.PILImage.open') as mock_pil_open, \
+             patch('meta_ads_mcp.core.ads.io.BytesIO') as mock_bytesio:
+            
+            mock_api.side_effect = [mock_ad_data, mock_creative_details]
+            mock_get_creatives.return_value = mock_get_ad_creatives_response
+            mock_download.return_value = b"fake_image_bytes"
+            mock_pil_open.return_value = mock_pil_image
+            mock_bytesio.return_value = mock_byte_stream
+            
+            # This should fall back to object_story_spec.link_data.picture
+            result = await get_ad_image(access_token="test_token", ad_id="test_ad_id")
+            
+            # Verify it used object_story_spec.link_data.picture
+            assert result is not None
+            mock_download.assert_called_once_with("https://example.com/object_story_picture.jpg")
+    
+    @pytest.mark.asyncio
+    async def test_uses_thumbnail_url_only_as_last_resort(self):
+        """Test that thumbnail_url is only used when no other options are available."""
+        
+        # Mock responses for creative with only thumbnail_url
+        mock_ad_data = {
+            "account_id": "act_123456789",
+            "creative": {"id": "creative_123456789"}
+        }
+        
+        mock_creative_details = {
+            "id": "creative_123456789",
+            "name": "Test Creative"
+        }
+        
+        # Mock get_ad_creatives response with only thumbnail_url
+        mock_get_ad_creatives_response = json.dumps({
+            "data": [
+                {
+                    "id": "creative_123456789",
+                    "name": "Test Creative",
+                    "status": "ACTIVE",
+                    "thumbnail_url": "https://example.com/thumbnail_only.jpg"  # Only option
+                }
+            ]
+        })
+        
+        # Mock PIL Image processing
+        mock_pil_image = MagicMock()
+        mock_pil_image.mode = "RGB"
+        mock_pil_image.convert.return_value = mock_pil_image
+        
+        mock_byte_stream = MagicMock()
+        mock_byte_stream.getvalue.return_value = b"fake_jpeg_data"
+        
+        with patch('meta_ads_mcp.core.ads.make_api_request', new_callable=AsyncMock) as mock_api, \
+             patch('meta_ads_mcp.core.ads.get_ad_creatives', new_callable=AsyncMock) as mock_get_creatives, \
+             patch('meta_ads_mcp.core.ads.download_image', new_callable=AsyncMock) as mock_download, \
+             patch('meta_ads_mcp.core.ads.PILImage.open') as mock_pil_open, \
+             patch('meta_ads_mcp.core.ads.io.BytesIO') as mock_bytesio:
+            
+            mock_api.side_effect = [mock_ad_data, mock_creative_details]
+            mock_get_creatives.return_value = mock_get_ad_creatives_response
+            mock_download.return_value = b"fake_image_bytes"
+            mock_pil_open.return_value = mock_pil_image
+            mock_bytesio.return_value = mock_byte_stream
+            
+            # This should use thumbnail_url as last resort
+            result = await get_ad_image(access_token="test_token", ad_id="test_ad_id")
+            
+            # Verify it used thumbnail_url
+            assert result is not None
+            mock_download.assert_called_once_with("https://example.com/thumbnail_only.jpg")
+    
+    def test_extract_creative_image_urls_prioritizes_quality(self):
+        """Test that extract_creative_image_urls correctly prioritizes image quality."""
+        
+        # Test creative with multiple image URLs
+        test_creative = {
+            "id": "creative_123456789",
+            "name": "Test Creative",
+            "thumbnail_url": "https://example.com/thumbnail.jpg",  # Lowest priority
+            "image_url": "https://example.com/image.jpg",  # Medium priority
+            "image_urls_for_viewing": [
+                "https://example.com/high_quality_1.jpg",  # Highest priority
+                "https://example.com/high_quality_2.jpg"
+            ],
+            "object_story_spec": {
+                "link_data": {
+                    "picture": "https://example.com/object_story_picture.jpg"  # High priority
+                }
+            }
+        }
+        
+        # Extract URLs
+        urls = extract_creative_image_urls(test_creative)
+        
+        # Verify correct priority order
+        assert len(urls) >= 4
+        assert urls[0] == "https://example.com/high_quality_1.jpg"  # First priority
+        assert urls[1] == "https://example.com/high_quality_2.jpg"  # Second priority
+        assert "https://example.com/image.jpg" in urls  # Medium priority
+        assert "https://example.com/object_story_picture.jpg" in urls  # High priority
+        assert urls[-1] == "https://example.com/thumbnail.jpg"  # Last priority
+    
+    def test_extract_creative_image_urls_handles_missing_fields(self):
+        """Test that extract_creative_image_urls handles missing fields gracefully."""
+        
+        # Test creative with minimal fields
+        test_creative = {
+            "id": "creative_123456789",
+            "name": "Minimal Creative",
+            "thumbnail_url": "https://example.com/thumbnail.jpg"
+        }
+        
+        # Extract URLs
+        urls = extract_creative_image_urls(test_creative)
+        
+        # Should still work with only thumbnail_url
+        assert len(urls) == 1
+        assert urls[0] == "https://example.com/thumbnail.jpg"
+    
+    def test_extract_creative_image_urls_removes_duplicates(self):
+        """Test that extract_creative_image_urls removes duplicate URLs."""
+        
+        # Test creative with duplicate URLs
+        test_creative = {
+            "id": "creative_123456789",
+            "name": "Duplicate URLs Creative",
+            "thumbnail_url": "https://example.com/same_url.jpg",
+            "image_url": "https://example.com/same_url.jpg",  # Duplicate
+            "image_urls_for_viewing": [
+                "https://example.com/same_url.jpg",  # Duplicate
+                "https://example.com/unique_url.jpg"
+            ]
+        }
+        
+        # Extract URLs
+        urls = extract_creative_image_urls(test_creative)
+        
+        # Should remove duplicates while preserving order
+        assert len(urls) == 2
+        assert urls[0] == "https://example.com/same_url.jpg"  # First occurrence
+        assert urls[1] == "https://example.com/unique_url.jpg"
+    
+    @pytest.mark.asyncio
+    async def test_get_ad_image_with_real_world_example(self):
+        """Test with a real-world example that mimics the actual API response structure."""
+        
+        # Mock responses based on real API data
+        mock_ad_data = {
+            "account_id": "act_15975950",
+            "creative": {"id": "606995022142818"}
+        }
+        
+        mock_creative_details = {
+            "id": "606995022142818",
+            "name": "Test Creative"
+        }
+        
+        # Mock get_ad_creatives response based on real data
+        mock_get_ad_creatives_response = json.dumps({
+            "data": [
+                {
+                    "id": "606995022142818",
+                    "name": "Test Creative",
+                    "status": "ACTIVE",
+                    "thumbnail_url": "https://external.fbsb6-1.fna.fbcdn.net/emg1/v/t13/13476424677788553381?url=https%3A%2F%2Fwww.facebook.com%2Fads%2Fimage%2F%3Fd%3DAQLuJ5l4AROBvIUchp4g4JXxIT5uAZiAsgHQkD8Iw7BeVtkXNUUfs3leWpqQplJCJdixVIg3mq9KichJ64eRfM-r8aY4GtVQp8TvS_HBByJ8fGg_Cs7Kb8YkN4IDwJ4iQIIkMx30LycCKzuYtp9M-vOk&fb_obo=1&utld=facebook.com&stp=c0.5000x0.5000f_dst-emg0_p64x64_q75_tt6&edm=AEuWsiQEAAAA&_nc_gid=_QBCRbZxDq-i1ZiGEXxW2w&_nc_eui2=AeEbQXzmAdoqWLIXjuTDJ0xAoThZu47BlQqhOFm7jsGVCloP48Ep6Y_qIA5tcqrcSDff5f_k8xGzFIpD7PnUws8c&_nc_oc=Adn3GeYlXxbfEeY0wCBSgNdlwO80wXt5R5bgY2NozdroZ6CRSaXIaOSjVSK9S1LsqsY4GL_0dVzU80RY8QMucEkZ&ccb=13-1&oh=06_Q3-1AcBKUD0rfLGATAveIM5hMSWG9c7DsJzq2arvOl8W4Bpn&oe=688C87B2&_nc_sid=58080a",
+                    "image_url": "https://scontent.fbsb6-1.fna.fbcdn.net/v/t45.1600-4/518574136_1116014047008737_2492837958169838537_n.png?stp=dst-jpg_tt6&_nc_cat=109&ccb=1-7&_nc_sid=890911&_nc_eui2=AeHbHqoiAUgF0QeX-tvUoDjYeTyJad_QEPF5PIlp39AQ8dP8cvOlHwiJjny8AUv7xxAlYyy5BGCqFU_oVM9CI7ln&_nc_ohc=VTTYlMOAWZoQ7kNvwGjLMW5&_nc_oc=AdnYDrpNrLovWZC_RG4tvoICGPjBNfzNJimhx-4SKW4BU2i_yzL00dX0-OiYEYokq394g8xR-1a-OuVDAm4HsSJy&_nc_zt=1&_nc_ht=scontent.fbsb6-1.fna&edm=AEuWsiQEAAAA&_nc_gid=_QBCRbZxDq-i1ZiGEXxW2w&oh=00_AfTujKmF365FnGgcokkkdWnK-vmnzQK8Icvlk0kB8SKM3g&oe=68906FC4",
+                    "image_urls_for_viewing": [
+                        "https://scontent.fbsb6-1.fna.fbcdn.net/v/t45.1600-4/518574136_1116014047008737_2492837958169838537_n.png?stp=dst-jpg_tt6&_nc_cat=109&ccb=1-7&_nc_sid=890911&_nc_eui2=AeHbHqoiAUgF0QeX-tvUoDjYeTyJad_QEPF5PIlp39AQ8dP8cvOlHwiJjny8AUv7xxAlYyy5BGCqFU_oVM9CI7ln&_nc_ohc=VTTYlMOAWZoQ7kNvwGjLMW5&_nc_oc=AdnYDrpNrLovWZC_RG4tvoICGPjBNfzNJimhx-4SKW4BU2i_yzL00dX0-OiYEYokq394g8xR-1a-OuVDAm4HsSJy&_nc_zt=1&_nc_ht=scontent.fbsb6-1.fna&edm=AEuWsiQEAAAA&_nc_gid=_QBCRbZxDq-i1ZiGEXxW2w&oh=00_AfTujKmF365FnGgcokkkdWnK-vmnzQK8Icvlk0kB8SKM3g&oe=68906FC4",
+                        "https://external.fbsb6-1.fna.fbcdn.net/emg1/v/t13/13476424677788553381?url=https%3A%2F%2Fwww.facebook.com%2Fads%2Fimage%2F%3Fd%3DAQLuJ5l4AROBvIUchp4g4JXxIT5uAZiAsgHQkD8Iw7BeVtkXNUUfs3leWpqQplJCJdixVIg3mq9KichJ64eRfM-r8aY4GtVQp8TvS_HBByJ8fGg_Cs7Kb8YkN4IDwJ4iQIIkMx30LycCKzuYtp9M-vOk&fb_obo=1&utld=facebook.com&stp=c0.5000x0.5000f_dst-emg0_p64x64_q75_tt6&edm=AEuWsiQEAAAA&_nc_gid=_QBCRbZxDq-i1ZiGEXxW2w&_nc_eui2=AeEbQXzmAdoqWLIXjuTDJ0xAoThZu47BlQqhOFm7jsGVCloP48Ep6Y_qIA5tcqrcSDff5f_k8xGzFIpD7PnUws8c&_nc_oc=Adn3GeYlXxbfEeY0wCBSgNdlwO80wXt5R5bgY2NozdroZ6CRSaXIaOSjVSK9S1LsqsY4GL_0dVzU80RY8QMucEkZ&ccb=13-1&oh=06_Q3-1AcBKUD0rfLGATAveIM5hMSWG9c7DsJzq2arvOl8W4Bpn&oe=688C87B2&_nc_sid=58080a"
+                    ]
+                }
+            ]
+        })
+        
+        # Mock PIL Image processing
+        mock_pil_image = MagicMock()
+        mock_pil_image.mode = "RGB"
+        mock_pil_image.convert.return_value = mock_pil_image
+        
+        mock_byte_stream = MagicMock()
+        mock_byte_stream.getvalue.return_value = b"fake_jpeg_data"
+        
+        with patch('meta_ads_mcp.core.ads.make_api_request', new_callable=AsyncMock) as mock_api, \
+             patch('meta_ads_mcp.core.ads.get_ad_creatives', new_callable=AsyncMock) as mock_get_creatives, \
+             patch('meta_ads_mcp.core.ads.download_image', new_callable=AsyncMock) as mock_download, \
+             patch('meta_ads_mcp.core.ads.PILImage.open') as mock_pil_open, \
+             patch('meta_ads_mcp.core.ads.io.BytesIO') as mock_bytesio:
+            
+            mock_api.side_effect = [mock_ad_data, mock_creative_details]
+            mock_get_creatives.return_value = mock_get_ad_creatives_response
+            mock_download.return_value = b"fake_image_bytes"
+            mock_pil_open.return_value = mock_pil_image
+            mock_bytesio.return_value = mock_byte_stream
+            
+            # This should use the first image_urls_for_viewing URL (high quality)
+            result = await get_ad_image(access_token="test_token", ad_id="test_ad_id")
+            
+            # Verify it used the high-quality URL (not the thumbnail)
+            assert result is not None
+            expected_url = "https://scontent.fbsb6-1.fna.fbcdn.net/v/t45.1600-4/518574136_1116014047008737_2492837958169838537_n.png?stp=dst-jpg_tt6&_nc_cat=109&ccb=1-7&_nc_sid=890911&_nc_eui2=AeHbHqoiAUgF0QeX-tvUoDjYeTyJad_QEPF5PIlp39AQ8dP8cvOlHwiJjny8AUv7xxAlYyy5BGCqFU_oVM9CI7ln&_nc_ohc=VTTYlMOAWZoQ7kNvwGjLMW5&_nc_oc=AdnYDrpNrLovWZC_RG4tvoICGPjBNfzNJimhx-4SKW4BU2i_yzL00dX0-OiYEYokq394g8xR-1a-OuVDAm4HsSJy&_nc_zt=1&_nc_ht=scontent.fbsb6-1.fna&edm=AEuWsiQEAAAA&_nc_gid=_QBCRbZxDq-i1ZiGEXxW2w&oh=00_AfTujKmF365FnGgcokkkdWnK-vmnzQK8Icvlk0kB8SKM3g&oe=68906FC4"
+            mock_download.assert_called_once_with(expected_url) 

{meta_ads_mcp-0.7.8 → meta_ads_mcp-0.7.9}/tests/test_get_ad_image_regression.py

@@ -10,7 +10,12 @@ Tests for multiple issues that were fixed:
    - Many modern creatives don't have image_hash but have direct URLs
    - Fixed by adding direct URL fallback using image_urls_for_viewing and thumbnail_url
 
-The fixes enable get_ad_image to work with both traditional hash-based and modern URL-based creatives.
+3. Image Quality Issue: Function was returning profile thumbnails instead of ad creative images
+   - Fixed by prioritizing image_urls_for_viewing over thumbnail_url
+   - Added proper fallback hierarchy: image_urls_for_viewing > image_url > object_story_spec.picture > thumbnail_url
+
+The fixes enable get_ad_image to work with both traditional hash-based and modern URL-based creatives,
+and ensure high-quality images are returned instead of thumbnails.
 """
 
 import pytest
@@ -379,4 +384,71 @@ class TestGetAdImageRegressionFix:
             
             # Should get error about download failure
             assert isinstance(result, str)
-            assert "Failed to download image from direct URL" in result 
+            assert "Failed to download image from direct URL" in result
+    
+    async def test_get_ad_image_quality_improvement_prioritizes_high_quality(self):
+        """Test that the image quality improvement correctly prioritizes high-quality images over thumbnails."""
+        
+        # Mock responses for creative with both high-quality and thumbnail URLs
+        mock_ad_data = {
+            "account_id": "act_123456789",
+            "creative": {"id": "creative_123456789"}
+        }
+        
+        mock_creative_details = {
+            "id": "creative_123456789",
+            "name": "Quality Test Creative"
+        }
+        
+        # Mock get_ad_creatives response with both URLs
+        mock_get_ad_creatives_response = json.dumps({
+            "data": [
+                {
+                    "id": "creative_123456789",
+                    "name": "Quality Test Creative",
+                    "status": "ACTIVE",
+                    "thumbnail_url": "https://example.com/thumbnail_64x64.jpg",  # Low quality thumbnail
+                    "image_url": "https://example.com/full_image.jpg",  # Medium quality
+                    "image_urls_for_viewing": [
+                        "https://example.com/high_quality_image.jpg",  # Highest quality
+                        "https://example.com/alt_high_quality.jpg"
+                    ],
+                    "object_story_spec": {
+                        "link_data": {
+                            "picture": "https://example.com/object_story_picture.jpg"
+                        }
+                    }
+                }
+            ]
+        })
+        
+        # Mock PIL Image processing
+        mock_pil_image = MagicMock()
+        mock_pil_image.mode = "RGB"
+        mock_pil_image.convert.return_value = mock_pil_image
+        
+        mock_byte_stream = MagicMock()
+        mock_byte_stream.getvalue.return_value = b"fake_jpeg_data"
+        
+        with patch('meta_ads_mcp.core.ads.make_api_request', new_callable=AsyncMock) as mock_api, \
+             patch('meta_ads_mcp.core.ads.get_ad_creatives', new_callable=AsyncMock) as mock_get_creatives, \
+             patch('meta_ads_mcp.core.ads.download_image', new_callable=AsyncMock) as mock_download, \
+             patch('meta_ads_mcp.core.ads.PILImage.open') as mock_pil_open, \
+             patch('meta_ads_mcp.core.ads.io.BytesIO') as mock_bytesio:
+            
+            mock_api.side_effect = [mock_ad_data, mock_creative_details]
+            mock_get_creatives.return_value = mock_get_ad_creatives_response
+            mock_download.return_value = b"fake_image_bytes"
+            mock_pil_open.return_value = mock_pil_image
+            mock_bytesio.return_value = mock_byte_stream
+            
+            # This should prioritize image_urls_for_viewing[0] over thumbnail_url
+            result = await get_ad_image(access_token="test_token", ad_id="test_ad_id")
+            
+            # Verify it used the highest quality URL, not the thumbnail
+            assert result is not None
+            mock_download.assert_called_once_with("https://example.com/high_quality_image.jpg")
+            
+            # Verify it did NOT use the thumbnail URL
+            # Check that the call was made with the high-quality URL, not the thumbnail
+            mock_download.assert_called_once_with("https://example.com/high_quality_image.jpg") 

meta_ads_mcp-0.7.8/RELEASE.md

@@ -1,97 +0,0 @@
-# Release Process
-
-This repository uses GitHub Actions to automatically publish releases to PyPI. Here's how it works:
-
-## Automated Publishing
-
-### Setup Status
-
-✅ **Trusted Publishing Configured**: The repository is already set up with PyPI trusted publishing using the `release` environment.
-
-### Creating a Release
-
-1. **Update the version** in both files:
-   
-   In `pyproject.toml`:
-   ```toml
-   version = "0.3.8"  # Increment as needed
-   ```
-   
-   In `meta_ads_mcp/__init__.py`:
-   ```python
-   __version__ = "0.3.8"  # Must match pyproject.toml
-   ```
-
-2. **Commit and push** the version changes:
-   ```bash
-   git add pyproject.toml meta_ads_mcp/__init__.py
-   git commit -m "Bump version to 0.3.8"
-   git push origin main
-   ```
-
-3. **Wait for build tests to pass** (optional):
-   ```bash
-   # Check the latest test workflow run
-   gh run list --workflow=test.yml --limit 1
-   
-   # Get the run ID and wait for completion
-   RUN_ID=$(gh run list --workflow=test.yml --limit 1 --json databaseId --jq '.[0].databaseId')
-   gh run watch $RUN_ID
-   ```
-   Note: This only tests package building and installation, not the actual pytest tests.
-
-4. **Create a GitHub release**:
-   ```bash
-   gh release create 0.3.8 --title "0.3.8" --generate-notes
-   ```
-   This command will:
-   - Create a release with the specified version (no "v" prefix)
-   - Auto-generate release notes from commits
-   - Automatically trigger the GitHub Action for PyPI publishing
-
-5. **Automatic deployment**:
-   - The GitHub Action will automatically trigger
-   - It will build the package and publish to PyPI
-   - Check the "Actions" tab to monitor progress
-
-## Workflows
-
-### `publish.yml`
-- **Triggers**: When a GitHub release is published, or manual workflow dispatch
-- **Purpose**: Builds and publishes the package to PyPI
-- **Security**: Uses trusted publishing with OIDC tokens (no API keys needed)
-
-### `test.yml`
-- **Triggers**: On pushes and pull requests to main/master
-- **Purpose**: Tests package building and installation across Python versions
-- **Matrix**: Tests Python 3.10, 3.11, and 3.12
-- **Note**: Does not run pytest tests, only validates package structure
-
-## Manual Deployment
-
-If you need to deploy manually:
-
-```bash
-# Install build tools
-pip install build twine
-
-# Build the package
-python -m build
-
-# Upload to PyPI (requires API token or configured credentials)
-python -m twine upload dist/*
-```
-
-## Version Management
-
-- Follow semantic versioning (SemVer): `MAJOR.MINOR.PATCH`
-- **Important**: Update version in BOTH `pyproject.toml` and `meta_ads_mcp/__init__.py`
-- The git tag should match the version (e.g., `v0.3.8` for version `0.3.8`)
-- Keep versions synchronized between the two files
-
-## Security Notes
-
-- Trusted publishing is preferred over API tokens
-- Uses GitHub's OIDC tokens for secure authentication to PyPI
-- Only maintainers should be able to create releases
-- All builds run in isolated GitHub-hosted runners