meta-ads-mcp 0.7.6__tar.gz → 0.7.8__tar.gz

{meta_ads_mcp-0.7.6 → meta_ads_mcp-0.7.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: meta-ads-mcp
-Version: 0.7.6
+Version: 0.7.8
 Summary: Model Context Protocol (MCP) plugin for interacting with Meta Ads API
 Project-URL: Homepage, https://github.com/pipeboard-co/meta-ads-mcp
 Project-URL: Bug Tracker, https://github.com/pipeboard-co/meta-ads-mcp/issues

{meta_ads_mcp-0.7.6 → meta_ads_mcp-0.7.8}/RELEASE.md

@@ -29,15 +29,27 @@ This repository uses GitHub Actions to automatically publish releases to PyPI. H
    git push origin main
    ```
 
-3. **Create a GitHub release**:
-   - Go to https://github.com/pipeboard-co/meta-ads-mcp/releases
-   - Click "Create a new release"
-   - Tag version: `v0.3.8` (must match the version in pyproject.toml)
-   - Release title: `v0.3.8`
-   - Add release notes describing what changed
-   - Click "Publish release"
-
-4. **Automatic deployment**:
+3. **Wait for build tests to pass** (optional):
+   ```bash
+   # Check the latest test workflow run
+   gh run list --workflow=test.yml --limit 1
+   
+   # Get the run ID and wait for completion
+   RUN_ID=$(gh run list --workflow=test.yml --limit 1 --json databaseId --jq '.[0].databaseId')
+   gh run watch $RUN_ID
+   ```
+   Note: This only tests package building and installation, not the actual pytest tests.
+
+4. **Create a GitHub release**:
+   ```bash
+   gh release create 0.3.8 --title "0.3.8" --generate-notes
+   ```
+   This command will:
+   - Create a release with the specified version (no "v" prefix)
+   - Auto-generate release notes from commits
+   - Automatically trigger the GitHub Action for PyPI publishing
+
+5. **Automatic deployment**:
    - The GitHub Action will automatically trigger
    - It will build the package and publish to PyPI
    - Check the "Actions" tab to monitor progress
@@ -49,10 +61,11 @@ This repository uses GitHub Actions to automatically publish releases to PyPI. H
 - **Purpose**: Builds and publishes the package to PyPI
 - **Security**: Uses trusted publishing with OIDC tokens (no API keys needed)
 
-### `test.yml` (if present)
+### `test.yml`
 - **Triggers**: On pushes and pull requests to main/master
 - **Purpose**: Tests package building and installation across Python versions
 - **Matrix**: Tests Python 3.10, 3.11, and 3.12
+- **Note**: Does not run pytest tests, only validates package structure
 
 ## Manual Deployment
 

{meta_ads_mcp-0.7.6 → meta_ads_mcp-0.7.8}/meta_ads_mcp/__init__.py

@@ -7,7 +7,7 @@ with the Claude LLM.
 
 from meta_ads_mcp.core.server import main
 
-__version__ = "0.7.6"
+__version__ = "0.7.8"
 
 __all__ = [
     'get_ad_accounts',

meta_ads_mcp-0.7.8/meta_ads_mcp/core/accounts.py

@@ -0,0 +1,101 @@
+"""Account-related functionality for Meta Ads API."""
+
+import json
+from typing import Optional
+from .api import meta_api_tool, make_api_request
+from .server import mcp_server
+
+
+@mcp_server.tool()
+@meta_api_tool
+async def get_ad_accounts(access_token: str = None, user_id: str = "me", limit: int = 10) -> str:
+    """
+    Get ad accounts accessible by a user.
+    
+    Args:
+        access_token: Meta API access token (optional - will use cached token if not provided)
+        user_id: Meta user ID or "me" for the current user
+        limit: Maximum number of accounts to return (default: 10)
+    """
+    endpoint = f"{user_id}/adaccounts"
+    params = {
+        "fields": "id,name,account_id,account_status,amount_spent,balance,currency,age,business_city,business_country_code",
+        "limit": limit
+    }
+    
+    data = await make_api_request(endpoint, access_token, params)
+    
+    return json.dumps(data, indent=2)
+
+
+@mcp_server.tool()
+@meta_api_tool
+async def get_account_info(access_token: str = None, account_id: str = None) -> str:
+    """
+    Get detailed information about a specific ad account.
+    
+    Args:
+        access_token: Meta API access token (optional - will use cached token if not provided)
+        account_id: Meta Ads account ID (format: act_XXXXXXXXX) - REQUIRED
+    """
+    if not account_id:
+        return {
+            "error": {
+                "message": "Account ID is required",
+                "details": "Please specify an account_id parameter",
+                "example": "Use account_id='act_123456789' or account_id='123456789'"
+            }
+        }
+    
+    # Ensure account_id has the 'act_' prefix for API compatibility
+    if not account_id.startswith("act_"):
+        account_id = f"act_{account_id}"
+    
+    # First, check if the account is accessible to the user
+    endpoint = "me/adaccounts"
+    params = {
+        "fields": "id,name,account_id,account_status,amount_spent,balance,currency,age,business_city,business_country_code",
+        "limit": 50
+    }
+    accessible_accounts_data = await make_api_request(endpoint, access_token, params)
+    
+    if "data" in accessible_accounts_data:
+        accessible_account_ids = [acc["id"] for acc in accessible_accounts_data["data"]]
+        if account_id not in accessible_account_ids:
+            # Provide a helpful error message with accessible accounts
+            accessible_accounts = [
+                {"id": acc["id"], "name": acc["name"]} 
+                for acc in accessible_accounts_data["data"][:10]  # Show first 10
+            ]
+            return {
+                "error": {
+                    "message": f"Account {account_id} is not accessible to your user account",
+                    "details": "This account either doesn't exist or you don't have permission to access it",
+                    "accessible_accounts": accessible_accounts,
+                    "total_accessible_accounts": len(accessible_accounts_data["data"]),
+                    "suggestion": "Try using one of the accessible account IDs listed above"
+                }
+            }
+    
+    endpoint = f"{account_id}"
+    params = {
+        "fields": "id,name,account_id,account_status,amount_spent,balance,currency,age,business_city,business_country_code,timezone_name"
+    }
+    
+    data = await make_api_request(endpoint, access_token, params)
+    
+    # Check if the API request returned an error
+    if "error" in data:
+        return data
+    
+    # Add DSA requirement detection
+    if "business_country_code" in data:
+        european_countries = ["DE", "FR", "IT", "ES", "NL", "BE", "AT", "IE", "DK", "SE", "FI", "NO"]
+        if data["business_country_code"] in european_countries:
+            data["dsa_required"] = True
+            data["dsa_compliance_note"] = "This account is subject to European DSA (Digital Services Act) requirements"
+        else:
+            data["dsa_required"] = False
+            data["dsa_compliance_note"] = "This account is not subject to European DSA requirements"
+    
+    return data 

{meta_ads_mcp-0.7.6 → meta_ads_mcp-0.7.8}/meta_ads_mcp/core/adsets.py

@@ -73,7 +73,7 @@ async def get_adset_details(access_token: str = None, adset_id: str = None) -> s
     endpoint = f"{adset_id}"
     # Explicitly prioritize frequency_control_specs in the fields request
     params = {
-        "fields": "id,name,campaign_id,status,frequency_control_specs{event,interval_days,max_frequency},daily_budget,lifetime_budget,targeting,bid_amount,bid_strategy,optimization_goal,billing_event,start_time,end_time,created_time,updated_time,attribution_spec,destination_type,promoted_object,pacing_type,budget_remaining"
+        "fields": "id,name,campaign_id,status,frequency_control_specs{event,interval_days,max_frequency},daily_budget,lifetime_budget,targeting,bid_amount,bid_strategy,optimization_goal,billing_event,start_time,end_time,created_time,updated_time,attribution_spec,destination_type,promoted_object,pacing_type,budget_remaining,dsa_beneficiary"
     }
     
     data = await make_api_request(endpoint, access_token, params)
@@ -103,6 +103,7 @@ async def create_adset(
     bid_strategy: str = None,
     start_time: str = None,
     end_time: str = None,
+    dsa_beneficiary: str = None,
     access_token: str = None
 ) -> str:
     """
@@ -123,6 +124,7 @@ async def create_adset(
         bid_strategy: Bid strategy (e.g., 'LOWEST_COST', 'LOWEST_COST_WITH_BID_CAP')
         start_time: Start time in ISO 8601 format (e.g., '2023-12-01T12:00:00-0800')
         end_time: End time in ISO 8601 format
+        dsa_beneficiary: DSA beneficiary (person/organization benefiting from ads) for European compliance
         access_token: Meta API access token (optional - will use cached token if not provided)
     """
     # Check required parameters
@@ -181,16 +183,44 @@ async def create_adset(
     if end_time:
         params["end_time"] = end_time
     
+    # Add DSA beneficiary if provided
+    if dsa_beneficiary:
+        params["dsa_beneficiary"] = dsa_beneficiary
+    
     try:
         data = await make_api_request(endpoint, access_token, params, method="POST")
         return json.dumps(data, indent=2)
     except Exception as e:
         error_msg = str(e)
-        return json.dumps({
-            "error": "Failed to create ad set",
-            "details": error_msg,
-            "params_sent": params
-        }, indent=2)
+        
+        # Enhanced error handling for DSA beneficiary issues
+        if "permission" in error_msg.lower() or "insufficient" in error_msg.lower():
+            return json.dumps({
+                "error": "Insufficient permissions to set DSA beneficiary. Please ensure you have business_management permissions.",
+                "details": error_msg,
+                "params_sent": params,
+                "permission_required": True
+            }, indent=2)
+        elif "dsa_beneficiary" in error_msg.lower() and ("not supported" in error_msg.lower() or "parameter" in error_msg.lower()):
+            return json.dumps({
+                "error": "DSA beneficiary parameter not supported in this API version. Please set DSA beneficiary manually in Facebook Ads Manager.",
+                "details": error_msg,
+                "params_sent": params,
+                "manual_setup_required": True
+            }, indent=2)
+        elif "benefits from ads" in error_msg or "DSA beneficiary" in error_msg:
+            return json.dumps({
+                "error": "DSA beneficiary required for European compliance. Please provide the person or organization that benefits from ads in this ad set.",
+                "details": error_msg,
+                "params_sent": params,
+                "dsa_required": True
+            }, indent=2)
+        else:
+            return json.dumps({
+                "error": "Failed to create ad set",
+                "details": error_msg,
+                "params_sent": params
+            }, indent=2)
 
 
 @mcp_server.tool()

{meta_ads_mcp-0.7.6 → meta_ads_mcp-0.7.8}/meta_ads_mcp/core/auth.py

@@ -25,7 +25,7 @@ from .pipeboard_auth import pipeboard_auth_manager
 # Auth constants
 # Scope includes pages_show_list and pages_read_engagement to fix issue #16
 # where get_account_pages failed for regular users due to missing page permissions
-AUTH_SCOPE = "ads_management,ads_read,business_management,public_profile,pages_show_list,pages_read_engagement"
+AUTH_SCOPE = "business_management,public_profile,pages_show_list,pages_read_engagement"
 AUTH_REDIRECT_URI = "http://localhost:8888/callback"
 AUTH_RESPONSE_TYPE = "token"
 
@@ -159,11 +159,41 @@ class AuthManager:
         try:
             with open(cache_path, "r") as f:
                 data = json.load(f)
+                
+                # Validate the cached data structure
+                required_fields = ["access_token", "created_at"]
+                if not all(field in data for field in required_fields):
+                    logger.warning("Cached token data is missing required fields")
+                    return False
+                
+                # Check if the token looks valid (basic format check)
+                if not data.get("access_token") or len(data["access_token"]) < 20:
+                    logger.warning("Cached token appears malformed")
+                    return False
+                
                 self.token_info = TokenInfo.deserialize(data)
                 
                 # Check if token is expired
                 if self.token_info.is_expired():
-                    logger.info("Cached token is expired")
+                    logger.info("Cached token is expired, removing cache file")
+                    # Remove the expired cache file
+                    try:
+                        cache_path.unlink()
+                        logger.info(f"Removed expired token cache: {cache_path}")
+                    except Exception as e:
+                        logger.warning(f"Could not remove expired cache file: {e}")
+                    self.token_info = None
+                    return False
+                
+                # Additional validation: check if token is too old (more than 60 days)
+                current_time = int(time.time())
+                if self.token_info.created_at and (current_time - self.token_info.created_at) > (60 * 24 * 3600):
+                    logger.warning("Cached token is too old (more than 60 days), removing cache file")
+                    try:
+                        cache_path.unlink()
+                        logger.info(f"Removed old token cache: {cache_path}")
+                    except Exception as e:
+                        logger.warning(f"Could not remove old cache file: {e}")
                     self.token_info = None
                     return False
                 
@@ -171,6 +201,12 @@ class AuthManager:
                 return True
         except Exception as e:
             logger.error(f"Error loading cached token: {e}")
+            # If there's any error reading the cache, try to remove the corrupted file
+            try:
+                cache_path.unlink()
+                logger.info(f"Removed corrupted token cache: {cache_path}")
+            except Exception as cleanup_error:
+                logger.warning(f"Could not remove corrupted cache file: {cleanup_error}")
             return False
     
     def _save_token_to_cache(self) -> None:

{meta_ads_mcp-0.7.6 → meta_ads_mcp-0.7.8}/meta_ads_mcp/core/pipeboard_auth.py

@@ -151,6 +151,18 @@ class PipeboardAuthManager:
             with open(cache_path, "r") as f:
                 logger.debug(f"Reading token cache from {cache_path}")
                 data = json.load(f)
+                
+                # Validate the cached data structure
+                required_fields = ["access_token"]
+                if not all(field in data for field in required_fields):
+                    logger.warning("Cached token data is missing required fields")
+                    return False
+                
+                # Check if the token looks valid (basic format check)
+                if not data.get("access_token") or len(data["access_token"]) < 20:
+                    logger.warning("Cached token appears malformed")
+                    return False
+                
                 self.token_info = TokenInfo.deserialize(data)
                 
                 # Log token details (partial token for security)
@@ -159,7 +171,25 @@ class PipeboardAuthManager:
                 
                 # Check if token is expired
                 if self.token_info.is_expired():
-                    logger.info("Cached token is expired")
+                    logger.info("Cached token is expired, removing cache file")
+                    # Remove the expired cache file
+                    try:
+                        cache_path.unlink()
+                        logger.info(f"Removed expired token cache: {cache_path}")
+                    except Exception as e:
+                        logger.warning(f"Could not remove expired cache file: {e}")
+                    self.token_info = None
+                    return False
+                
+                # Additional validation: check if token is too old (more than 60 days)
+                current_time = int(time.time())
+                if self.token_info.created_at and (current_time - self.token_info.created_at) > (60 * 24 * 3600):
+                    logger.warning("Cached token is too old (more than 60 days), removing cache file")
+                    try:
+                        cache_path.unlink()
+                        logger.info(f"Removed old token cache: {cache_path}")
+                    except Exception as e:
+                        logger.warning(f"Could not remove old cache file: {e}")
                     self.token_info = None
                     return False
                 
@@ -174,9 +204,21 @@ class PipeboardAuthManager:
                 logger.debug(f"Raw cache file content (first 100 chars): {raw_content[:100]}")
             except Exception as e2:
                 logger.error(f"Could not read raw cache file: {e2}")
+            # If there's any error reading the cache, try to remove the corrupted file
+            try:
+                cache_path.unlink()
+                logger.info(f"Removed corrupted token cache: {cache_path}")
+            except Exception as cleanup_error:
+                logger.warning(f"Could not remove corrupted cache file: {cleanup_error}")
             return False
         except Exception as e:
             logger.error(f"Error loading cached token: {e}")
+            # If there's any error reading the cache, try to remove the corrupted file
+            try:
+                cache_path.unlink()
+                logger.info(f"Removed corrupted token cache: {cache_path}")
+            except Exception as cleanup_error:
+                logger.warning(f"Could not remove corrupted cache file: {cleanup_error}")
             return False
     
     def _save_token_to_cache(self) -> None:

{meta_ads_mcp-0.7.6 → meta_ads_mcp-0.7.8}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "meta-ads-mcp"
-version = "0.7.6"
+version = "0.7.8"
 description = "Model Context Protocol (MCP) plugin for interacting with Meta Ads API"
 readme = "README.md"
 requires-python = ">=3.10"