meta-ads-mcp 0.4.2__tar.gz → 0.4.3__tar.gz

{meta_ads_mcp-0.4.2 → meta_ads_mcp-0.4.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: meta-ads-mcp
-Version: 0.4.2
+Version: 0.4.3
 Summary: Model Context Protocol (MCP) plugin for interacting with Meta Ads API
 Project-URL: Homepage, https://github.com/pipeboard-co/meta-ads-mcp
 Project-URL: Bug Tracker, https://github.com/pipeboard-co/meta-ads-mcp/issues

{meta_ads_mcp-0.4.2 → meta_ads_mcp-0.4.3}/meta_ads_mcp/__init__.py

@@ -7,7 +7,7 @@ with the Claude LLM.
 
 from meta_ads_mcp.core.server import main
 
-__version__ = "0.4.2"
+__version__ = "0.4.3"
 
 __all__ = [
     'get_ad_accounts',

{meta_ads_mcp-0.4.2 → meta_ads_mcp-0.4.3}/meta_ads_mcp/core/ads.py

@@ -38,26 +38,27 @@ async def get_ads(access_token: str = None, account_id: str = None, limit: int =
         else:
             return json.dumps({"error": "No account ID specified and no accounts found for user"}, indent=2)
     
+    # Prioritize adset_id over campaign_id - use adset-specific endpoint
+    if adset_id:
+        endpoint = f"{adset_id}/ads"
+        params = {
+            "fields": "id,name,adset_id,campaign_id,status,creative,created_time,updated_time,bid_amount,conversion_domain,tracking_specs",
+            "limit": limit
+        }
     # Use campaign-specific endpoint if campaign_id is provided
-    if campaign_id:
+    elif campaign_id:
         endpoint = f"{campaign_id}/ads"
         params = {
             "fields": "id,name,adset_id,campaign_id,status,creative,created_time,updated_time,bid_amount,conversion_domain,tracking_specs",
             "limit": limit
         }
-        # Adset ID can still be used to filter within the campaign
-        if adset_id:
-            params["adset_id"] = adset_id
     else:
-        # Default to account-level endpoint if no campaign_id
+        # Default to account-level endpoint if no specific filters
         endpoint = f"{account_id}/ads"
         params = {
             "fields": "id,name,adset_id,campaign_id,status,creative,created_time,updated_time,bid_amount,conversion_domain,tracking_specs",
             "limit": limit
         }
-        # Adset ID can filter at the account level if no campaign specified
-        if adset_id:
-            params["adset_id"] = adset_id
 
     data = await make_api_request(endpoint, access_token, params)
     

{meta_ads_mcp-0.4.2 → meta_ads_mcp-0.4.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "meta-ads-mcp"
-version = "0.4.2"
+version = "0.4.3"
 description = "Model Context Protocol (MCP) plugin for interacting with Meta Ads API"
 readme = "README.md"
 requires-python = ">=3.10"

{meta_ads_mcp-0.4.2 → meta_ads_mcp-0.4.3}/tests/test_http_transport.py

@@ -231,13 +231,22 @@ class HTTPTransportTester:
             )
             all_results[scenario["name"]] = results
         
+        # Run specific get_ads filtering tests
+        print("\n🧪 Testing get_ads filtering functionality")
+        print("="*50)
+        ads_filter_results = self.test_get_ads_filtering()
+        all_results["get_ads_filtering"] = ads_filter_results
+        
         # Summary
         print("\n🏁 TEST SUITE COMPLETED")
         print("="*30)
         
         all_passed = True
         for scenario_name, results in all_results.items():
-            scenario_success = all(results.values())
+            if isinstance(results, dict):
+                scenario_success = all(results.values())
+            else:
+                scenario_success = results
             status = "✅ SUCCESS" if scenario_success else "❌ FAILED"
             print(f"{scenario_name}: {status}")
             if not scenario_success:
@@ -250,10 +259,72 @@ class HTTPTransportTester:
             print("   • MCP protocol compliance: Complete")
             print("   • Authentication integration: Working")
             print("   • All tools accessible via HTTP")
+            print("   • get_ads filtering: Working correctly")
             print("   • Ready for production use")
         
         return all_passed
 
+    def test_get_ads_filtering(self) -> Dict[str, bool]:
+        """Test get_ads function with different filtering parameters"""
+        results = {}
+        
+        # Test with basic auth headers for these tests
+        auth_headers = {"Authorization": "Bearer test_pipeboard_token_12345"}
+        
+        # Test 1: get_ads without filters (should use account endpoint)
+        print("🔍 Testing get_ads without filters")
+        result1 = self.test_tool_call("get_ads", {
+            "account_id": "act_123456789",
+            "limit": 5
+        }, auth_headers)
+        results["no_filters"] = result1["success"]
+        if result1["success"]:
+            print("✅ get_ads without filters successful")
+        else:
+            print(f"❌ get_ads without filters failed: {result1.get('text', 'Unknown error')}")
+        
+        # Test 2: get_ads with campaign_id filter (should use campaign endpoint)
+        print("🔍 Testing get_ads with campaign_id filter")
+        result2 = self.test_tool_call("get_ads", {
+            "account_id": "act_123456789",
+            "campaign_id": "123456789012345",
+            "limit": 5
+        }, auth_headers)
+        results["campaign_filter"] = result2["success"]
+        if result2["success"]:
+            print("✅ get_ads with campaign_id filter successful")
+        else:
+            print(f"❌ get_ads with campaign_id filter failed: {result2.get('text', 'Unknown error')}")
+        
+        # Test 3: get_ads with adset_id filter (should use adset endpoint)
+        print("🔍 Testing get_ads with adset_id filter")
+        result3 = self.test_tool_call("get_ads", {
+            "account_id": "act_123456789",
+            "adset_id": "120228975637820183",
+            "limit": 5
+        }, auth_headers)
+        results["adset_filter"] = result3["success"]
+        if result3["success"]:
+            print("✅ get_ads with adset_id filter successful")
+        else:
+            print(f"❌ get_ads with adset_id filter failed: {result3.get('text', 'Unknown error')}")
+        
+        # Test 4: get_ads with both campaign_id and adset_id (adset_id should take priority)
+        print("🔍 Testing get_ads with both campaign_id and adset_id (adset_id priority)")
+        result4 = self.test_tool_call("get_ads", {
+            "account_id": "act_123456789",
+            "campaign_id": "123456789012345",
+            "adset_id": "120228975637820183",
+            "limit": 5
+        }, auth_headers)
+        results["priority_test"] = result4["success"]
+        if result4["success"]:
+            print("✅ get_ads priority test successful")
+        else:
+            print(f"❌ get_ads priority test failed: {result4.get('text', 'Unknown error')}")
+        
+        return results
+
 
 def main():
     """Main test execution"""