meta-ads-mcp 0.10.1__tar.gz → 0.10.5__tar.gz

{meta_ads_mcp-0.10.1 → meta_ads_mcp-0.10.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: meta-ads-mcp
-Version: 0.10.1
+Version: 0.10.5
 Summary: Model Context Protocol (MCP) server for interacting with Meta Ads API
 Project-URL: Homepage, https://github.com/pipeboard-co/meta-ads-mcp
 Project-URL: Bug Tracker, https://github.com/pipeboard-co/meta-ads-mcp/issues
@@ -410,24 +410,14 @@ For local installation configuration, authentication options, and advanced techn
 
 ## Licensing
 
-Meta Ads MCP is licensed under the [Business Source License 1.1](LICENSE). This means:
+Meta Ads MCP is licensed under the [Business Source License 1.1](LICENSE), which means:
 
-### ✅ **What you CAN do:**
-- ✅ **Use for free** - Individual and business use at no cost
-- ✅ **Modify and customize** - Edit the source code for your needs
-- ✅ **Internal commercial use** - Deploy within your organization
-- ✅ **Redistribute** - Share the software with others
-- ✅ **Create derivative works** - Build upon the codebase
+- ✅ **Free to use** for individual and business purposes
+- ✅ **Modify and customize** as needed
+- ✅ **Redistribute** to others
+- ✅ **Becomes fully open source** (Apache 2.0) on January 1, 2029
 
-### ❌ **What you CANNOT do:**
-- ❌ **Offer as competing SaaS** - Cannot offer this as a hosted service that competes with ARTELL SOLUÇÕES TECNOLÓGICAS LTDA's commercial offerings
-
-### 🔄 **Future Open Source:**
-- **Change Date**: January 1, 2029
-- **After Change Date**: Automatically converts to Apache License 2.0 (fully open source)
-- **No restrictions**: After the change date, you can use it for any purpose, including competing services
-
-This licensing model ensures the software remains accessible while protecting the commercial interests of the original developers. For questions about commercial licensing or use cases, please contact us.
+The only restriction is that you cannot offer this as a competing hosted service. For questions about commercial licensing, please contact us.
 
 ## Privacy and Security
 

{meta_ads_mcp-0.10.1 → meta_ads_mcp-0.10.5}/README.md

@@ -385,24 +385,14 @@ For local installation configuration, authentication options, and advanced techn
 
 ## Licensing
 
-Meta Ads MCP is licensed under the [Business Source License 1.1](LICENSE). This means:
+Meta Ads MCP is licensed under the [Business Source License 1.1](LICENSE), which means:
 
-### ✅ **What you CAN do:**
-- ✅ **Use for free** - Individual and business use at no cost
-- ✅ **Modify and customize** - Edit the source code for your needs
-- ✅ **Internal commercial use** - Deploy within your organization
-- ✅ **Redistribute** - Share the software with others
-- ✅ **Create derivative works** - Build upon the codebase
+- ✅ **Free to use** for individual and business purposes
+- ✅ **Modify and customize** as needed
+- ✅ **Redistribute** to others
+- ✅ **Becomes fully open source** (Apache 2.0) on January 1, 2029
 
-### ❌ **What you CANNOT do:**
-- ❌ **Offer as competing SaaS** - Cannot offer this as a hosted service that competes with ARTELL SOLUÇÕES TECNOLÓGICAS LTDA's commercial offerings
-
-### 🔄 **Future Open Source:**
-- **Change Date**: January 1, 2029
-- **After Change Date**: Automatically converts to Apache License 2.0 (fully open source)
-- **No restrictions**: After the change date, you can use it for any purpose, including competing services
-
-This licensing model ensures the software remains accessible while protecting the commercial interests of the original developers. For questions about commercial licensing or use cases, please contact us.
+The only restriction is that you cannot offer this as a competing hosted service. For questions about commercial licensing, please contact us.
 
 ## Privacy and Security
 

{meta_ads_mcp-0.10.1 → meta_ads_mcp-0.10.5}/meta_ads_mcp/__init__.py

@@ -7,7 +7,7 @@ with the Claude LLM.
 
 from meta_ads_mcp.core.server import main
 
-__version__ = "0.10.1"
+__version__ = "0.10.5"
 
 __all__ = [
     'get_ad_accounts',

{meta_ads_mcp-0.10.1 → meta_ads_mcp-0.10.5}/meta_ads_mcp/core/ads.py

@@ -564,7 +564,8 @@ async def update_ad(
 async def upload_ad_image(
     access_token: str = None,
     account_id: str = None,
-    image_path: str = None,
+    file: str = None,
+    image_url: str = None,
     name: str = None
 ) -> str:
     """
@@ -573,7 +574,8 @@ async def upload_ad_image(
     Args:
         access_token: Meta API access token (optional - will use cached token if not provided)
         account_id: Meta Ads account ID (format: act_XXXXXXXXX)
-        image_path: Path to the image file to upload
+        file: Data URL or raw base64 string of the image (e.g., "data:image/png;base64,iVBORw0KG...")
+        image_url: Direct URL to an image to fetch and upload
         name: Optional name for the image (default: filename)
     
     Returns:
@@ -583,45 +585,94 @@ async def upload_ad_image(
     if not account_id:
         return json.dumps({"error": "No account ID provided"}, indent=2)
     
-    if not image_path:
-        return json.dumps({"error": "No image path provided"}, indent=2)
+    # Ensure we have image data
+    if not file and not image_url:
+        return json.dumps({"error": "Provide either 'file' (data URL or base64) or 'image_url'"}, indent=2)
     
     # Ensure account_id has the 'act_' prefix for API compatibility
     if not account_id.startswith("act_"):
         account_id = f"act_{account_id}"
     
-    # Check if image file exists
-    if not os.path.exists(image_path):
-        return json.dumps({"error": f"Image file not found: {image_path}"}, indent=2)
-    
     try:
-        # Read image file
-        with open(image_path, "rb") as img_file:
-            image_bytes = img_file.read()
-        
-        # Get image filename if name not provided
-        if not name:
-            name = os.path.basename(image_path)
-        
+        # Determine encoded_image (base64 string without data URL prefix) and a sensible name
+        encoded_image: str = ""
+        inferred_name: str = name or ""
+
+        if file:
+            # Support data URL (e.g., data:image/png;base64,...) and raw base64
+            data_url_prefix = "data:"
+            base64_marker = "base64,"
+            if file.startswith(data_url_prefix) and base64_marker in file:
+                header, base64_payload = file.split(base64_marker, 1)
+                encoded_image = base64_payload.strip()
+
+                # Infer file extension from MIME type if name not provided
+                if not inferred_name:
+                    # Example header: data:image/png;...
+                    mime_type = header[len(data_url_prefix):].split(";")[0].strip()
+                    extension_map = {
+                        "image/png": ".png",
+                        "image/jpeg": ".jpg",
+                        "image/jpg": ".jpg",
+                        "image/webp": ".webp",
+                        "image/gif": ".gif",
+                        "image/bmp": ".bmp",
+                        "image/tiff": ".tiff",
+                    }
+                    ext = extension_map.get(mime_type, ".png")
+                    inferred_name = f"upload{ext}"
+            else:
+                # Assume it's already raw base64
+                encoded_image = file.strip()
+                if not inferred_name:
+                    inferred_name = "upload.png"
+        else:
+            # Download image from URL
+            try:
+                image_bytes = await try_multiple_download_methods(image_url)
+            except Exception as download_error:
+                return json.dumps({
+                    "error": "Failed to download image from URL",
+                    "details": str(download_error),
+                    "image_url": image_url,
+                }, indent=2)
+
+            if not image_bytes:
+                return json.dumps({
+                    "error": "No data returned when downloading image from URL",
+                    "image_url": image_url,
+                }, indent=2)
+
+            import base64  # Local import
+            encoded_image = base64.b64encode(image_bytes).decode("utf-8")
+
+            # Infer name from URL if not provided
+            if not inferred_name:
+                try:
+                    path_no_query = image_url.split("?")[0]
+                    filename_from_url = os.path.basename(path_no_query)
+                    inferred_name = filename_from_url if filename_from_url else "upload.jpg"
+                except Exception:
+                    inferred_name = "upload.jpg"
+
+        # Final name resolution
+        final_name = name or inferred_name or "upload.png"
+
         # Prepare the API endpoint for uploading images
         endpoint = f"{account_id}/adimages"
-        
-        # We need to convert the binary data to base64 for API upload
-        import base64
-        encoded_image = base64.b64encode(image_bytes).decode('utf-8')
-        
-        # Prepare POST parameters
+
+        # Prepare POST parameters expected by Meta API
         params = {
             "bytes": encoded_image,
-            "name": name
+            "name": final_name,
         }
-        
+
         # Make API request to upload the image
         print(f"Uploading image to Facebook Ad Account {account_id}")
         data = await make_api_request(endpoint, access_token, params, method="POST")
-        
+
         return json.dumps(data, indent=2)
-    
+
     except Exception as e:
         return json.dumps({
             "error": "Failed to upload image",

{meta_ads_mcp-0.10.1 → meta_ads_mcp-0.10.5}/meta_ads_mcp/core/adsets.py

@@ -130,8 +130,9 @@ async def create_adset(
         promoted_object: Mobile app configuration for APP_INSTALLS campaigns. Required fields: application_id, object_store_url.
                         Optional fields: custom_event_type, pixel_id, page_id.
                         Example: {"application_id": "123456789012345", "object_store_url": "https://apps.apple.com/app/id123456789"}
-        destination_type: Where users are directed after clicking the ad (e.g., 'APP_STORE', 'DEEPLINK', 'APP_INSTALL').
-                         Required for mobile app campaigns.
+        destination_type: Where users are directed after clicking the ad (e.g., 'APP_STORE', 'DEEPLINK', 'APP_INSTALL', 'ON_AD').
+                         Required for mobile app campaigns and lead generation campaigns.
+                         Use 'ON_AD' for lead generation campaigns where user interaction happens within the ad.
         access_token: Meta API access token (optional - will use cached token if not provided)
     """
     # Check required parameters
@@ -196,7 +197,7 @@ async def create_adset(
     
     # Validate destination_type if provided
     if destination_type:
-        valid_destination_types = ["APP_STORE", "DEEPLINK", "APP_INSTALL"]
+        valid_destination_types = ["APP_STORE", "DEEPLINK", "APP_INSTALL", "ON_AD"]
         if destination_type not in valid_destination_types:
             return json.dumps({
                 "error": f"Invalid destination_type: {destination_type}",

{meta_ads_mcp-0.10.1 → meta_ads_mcp-0.10.5}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "meta-ads-mcp"
-version = "0.10.1"
+version = "0.10.5"
 description = "Model Context Protocol (MCP) server for interacting with Meta Ads API"
 readme = "README.md"
 requires-python = ">=3.10"

{meta_ads_mcp-0.10.1 → meta_ads_mcp-0.10.5}/tests/test_mobile_app_adset_creation.py

@@ -409,6 +409,57 @@ class TestMobileAppAdsetCreation:
         params = call_args[0][2]
         assert params['destination_type'] == "APP_INSTALL"
 
+    @pytest.mark.asyncio
+    async def test_on_ad_destination_type_for_lead_generation(
+        self, mock_api_request, mock_auth_manager, valid_mobile_app_params
+    ):
+        """Test ON_AD destination_type for lead generation campaigns (Issue #009 fix)"""
+        
+        # Create a lead generation adset configuration (without promoted_object since it's for lead gen, not mobile apps)
+        lead_gen_params = valid_mobile_app_params.copy()
+        lead_gen_params.update({
+            "optimization_goal": "LEAD_GENERATION",
+            "billing_event": "IMPRESSIONS"
+        })
+        
+        result = await create_adset(
+            **lead_gen_params,
+            destination_type="ON_AD"
+        )
+        
+        # Should pass validation and include destination_type in API call
+        call_args = mock_api_request.call_args
+        params = call_args[0][2]
+        assert params['destination_type'] == "ON_AD"
+
+    @pytest.mark.asyncio
+    async def test_on_ad_validation_passes(
+        self, mock_api_request, mock_auth_manager, valid_mobile_app_params
+    ):
+        """Test that ON_AD destination_type passes validation (Issue #009 regression test)"""
+        
+        # Use parameters that work with ON_AD (lead generation, not mobile app)
+        lead_gen_params = valid_mobile_app_params.copy()
+        lead_gen_params.update({
+            "optimization_goal": "LEAD_GENERATION",
+            "billing_event": "IMPRESSIONS"
+        })
+        
+        result = await create_adset(
+            **lead_gen_params,
+            destination_type="ON_AD"
+        )
+        
+        result_data = json.loads(result)
+        
+        # Should NOT return a validation error about destination_type
+        # Before the fix, this would return: "Invalid destination_type: ON_AD" 
+        if "data" in result_data:
+            error_data = json.loads(result_data["data"])
+            assert "error" not in error_data or "destination_type" not in error_data.get("error", "").lower()
+        else:
+            assert "error" not in result_data or "destination_type" not in result_data.get("error", "").lower()
+
     # Test: Error Handling
     @pytest.mark.asyncio
     async def test_meta_api_error_handling(