memwal 0.1.9.dev2__tar.gz → 0.1.9.dev3__tar.gz

{memwal-0.1.9.dev2 → memwal-0.1.9.dev3}/CHANGELOG.md

@@ -7,6 +7,7 @@
 - HTTP 503 with `x-auth-error: AUTH_UPSTREAM_UNAVAILABLE` is reported as a retryable credential-verification outage, not a sign-in failure. Other 503s keep the generic sanitized body.
 - `remember_bulk_async` rejects an empty `items` list before the request and raises when the relayer returns a `job_ids` length that does not match the batch.
 - restore `truncated` docs now match WALM-431 retryable semantics.
+- Warn when `server_url` uses plaintext `http://` against a non-localhost host, matching the TypeScript SDK `normalizeServerUrl` guard. Localhost, `127.0.0.1`, `::1`, and `*.localhost` are exempt; invalid URLs are left for the HTTP client to surface. The warning logs only scheme, host, and port so URL userinfo is not written to logs.
 
 ## 0.1.8
 

{memwal-0.1.9.dev2 → memwal-0.1.9.dev3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: memwal
-Version: 0.1.9.dev2
+Version: 0.1.9.dev3
 Summary: Python SDK for Walrus Memory — Privacy-first AI memory with Ed25519 signing
 Project-URL: Homepage, https://memory.walrus.xyz
 Project-URL: Documentation, https://memory.walrus.xyz

{memwal-0.1.9.dev2 → memwal-0.1.9.dev3}/memwal/__init__.py

@@ -122,4 +122,4 @@ __all__ = [
     "RecallManualResult",
 ]
 
-__version__ = "0.1.9.dev2"
+__version__ = "0.1.9.dev3"

{memwal-0.1.9.dev2 → memwal-0.1.9.dev3}/memwal/client.py

@@ -35,6 +35,7 @@ import time
 import uuid
 from datetime import datetime, timezone
 from typing import Any, Dict, List, Optional, Sequence, Tuple, TypeVar, Union
+from urllib.parse import ParseResult, urlparse
 
 import httpx
 import nacl.signing
@@ -107,6 +108,52 @@ UPSTREAM_UNAVAILABLE_MESSAGE = (
 logger = logging.getLogger("memwal")
 
 
+def _server_url_for_log(parsed: ParseResult) -> str:
+    """Scheme/host/port only — never userinfo, path, query, or fragment."""
+
+    host = parsed.hostname or ""
+    if ":" in host:
+        host = f"[{host}]"
+    if parsed.port is not None:
+        return f"{parsed.scheme}://{host}:{parsed.port}"
+    return f"{parsed.scheme}://{host}"
+
+
+def normalize_server_url(url: str) -> str:
+    """Strip a trailing slash and warn on plaintext HTTP to a remote host.
+
+    Ports the TypeScript ``normalizeServerUrl`` helper: localhost,
+    ``127.0.0.1``, ``::1``, and ``*.localhost`` are exempt. Invalid URLs
+    are returned trimmed so the HTTP client can surface the error later.
+
+    The warning logs only scheme/host/port so URL userinfo (HTTPX
+    credentials) and other sensitive components are not written to logs.
+    The returned URL is otherwise unchanged and still used for transport.
+    """
+
+    trimmed = url.rstrip("/")
+    try:
+        parsed = urlparse(trimmed)
+        host = (parsed.hostname or "").lower()
+        is_local = (
+            host == "localhost"
+            or host == "127.0.0.1"
+            or host == "::1"
+            or host.endswith(".localhost")
+        )
+        if parsed.scheme == "http" and host and not is_local:
+            logger.warning(
+                '[memwal] serverUrl "%s" uses plaintext HTTP on a non-localhost host. '
+                "Signed requests and any bearer material will be visible to the network. "
+                "Use https:// in production.",
+                _server_url_for_log(parsed),
+            )
+    except ValueError:
+        # invalid URL — let the HTTP call surface the error at request time
+        pass
+    return trimmed
+
+
 # ============================================================
 # Polling helpers (PR #121 parity with TS SDK)
 # ============================================================
@@ -234,7 +281,7 @@ class MemWal:
         self._private_key_hex = normalize_private_key(config.key)
         self._signing_key = build_signing_key(self._private_key_hex)
         self._account_id = config.account_id
-        self._server_url = config.server_url.rstrip("/")
+        self._server_url = normalize_server_url(config.server_url)
         self._namespace = config.namespace
         self._client: Optional[httpx.AsyncClient] = None
         self._server_config: Optional[Dict[str, str]] = None

{memwal-0.1.9.dev2 → memwal-0.1.9.dev3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "memwal"
-version = "0.1.9.dev2"
+version = "0.1.9.dev3"
 description = "Python SDK for Walrus Memory — Privacy-first AI memory with Ed25519 signing"
 readme = "README.md"
 license = "MIT"

memwal-0.1.9.dev3/tests/test_normalize_server_url.py

@@ -0,0 +1,96 @@
+"""Tests for plaintext HTTP server_url guarding (WALM-452 / #748).
+
+No network: ``MemWal.create`` only stores config, and
+``normalize_server_url`` is a pure parse + log helper.
+"""
+
+from __future__ import annotations
+
+import logging
+
+import pytest
+
+from memwal.client import MemWal, normalize_server_url
+
+_KEY = "ab" * 32
+_ACCOUNT = "0xdummy"
+
+
+def test_plaintext_remote_warns_and_strips(caplog: pytest.LogCaptureFixture) -> None:
+    caplog.set_level(logging.WARNING, logger="memwal")
+    assert (
+        normalize_server_url("http://relayer.example.com/")
+        == "http://relayer.example.com"
+    )
+    assert "plaintext" in caplog.text
+
+
+def test_https_remote_does_not_warn(caplog: pytest.LogCaptureFixture) -> None:
+    caplog.set_level(logging.WARNING, logger="memwal")
+    assert (
+        normalize_server_url("https://relayer.memory.walrus.xyz")
+        == "https://relayer.memory.walrus.xyz"
+    )
+    assert caplog.text == ""
+
+
+@pytest.mark.parametrize(
+    "url",
+    [
+        "http://localhost:8000",
+        "http://127.0.0.1:8000",
+        "http://foo.localhost",
+        "http://[::1]:8000",
+    ],
+)
+def test_plaintext_local_does_not_warn(
+    url: str, caplog: pytest.LogCaptureFixture
+) -> None:
+    caplog.set_level(logging.WARNING, logger="memwal")
+    assert normalize_server_url(url) == url
+    assert caplog.text == ""
+
+
+def test_create_warns_on_plaintext_remote(caplog: pytest.LogCaptureFixture) -> None:
+    caplog.set_level(logging.WARNING, logger="memwal")
+    client = MemWal.create(
+        key=_KEY,
+        account_id=_ACCOUNT,
+        server_url="http://relayer.example.com/",
+    )
+    assert client._server_url == "http://relayer.example.com"
+    assert "plaintext" in caplog.text
+
+
+def test_plaintext_remote_warning_omits_url_credentials(
+    caplog: pytest.LogCaptureFixture,
+) -> None:
+    """HTTPX userinfo must stay on the transport URL and out of the warning."""
+
+    caplog.set_level(logging.WARNING, logger="memwal")
+    url = "http://alice:example-secret@relayer.example.com/?token=super-secret"
+    assert (
+        normalize_server_url(url)
+        == "http://alice:example-secret@relayer.example.com/?token=super-secret"
+    )
+    assert "plaintext" in caplog.text
+    assert "http://relayer.example.com" in caplog.text
+    assert "alice" not in caplog.text
+    assert "example-secret" not in caplog.text
+    assert "super-secret" not in caplog.text
+    for rec in caplog.records:
+        assert "example-secret" not in rec.getMessage()
+        assert "example-secret" not in str(rec.args)
+        assert "super-secret" not in rec.getMessage()
+        assert "super-secret" not in str(rec.args)
+
+
+def test_create_preserves_url_credentials_and_redacts_warning(
+    caplog: pytest.LogCaptureFixture,
+) -> None:
+    caplog.set_level(logging.WARNING, logger="memwal")
+    url = "http://alice:example-secret@relayer.example.com/"
+    client = MemWal.create(key=_KEY, account_id=_ACCOUNT, server_url=url)
+    assert client._server_url == "http://alice:example-secret@relayer.example.com"
+    assert "plaintext" in caplog.text
+    assert "example-secret" not in caplog.text