mcp-github-crunchtools 1.3.1__tar.gz → 1.4.0__tar.gz

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/CHANGELOG.md

@@ -6,6 +6,29 @@ All notable changes to this project are documented here. The format follows
 
 ## [Unreleased]
 
+## [1.4.0] - 2026-10-17
+
+### Added
+
+- `list_issue_comments_tool`: the comments on an issue or a pull request
+  conversation, oldest first, one page at a time, with id, author,
+  author_association, created_at, updated_at, body and html_url (#45).
+
+### Fixed
+
+- `list_pull_request_comments_tool` called on a plain issue returned GitHub's
+  403 "Resource not accessible by personal access token", which reads like a
+  token scope problem. It now says the number is an issue and points to
+  `list_issue_comments_tool` (#45).
+
+## [1.3.2] - 2026-10-17
+
+### Fixed
+
+- The integer ID parameters of the read tools (`issue_number`, `pull_number`,
+  `run_id`) now publish `minimum: 1` in their schema, so `0` and negative IDs
+  are rejected.
+
 ## [1.3.1] - 2026-10-16
 
 ### Fixed

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/CLAUDE.md

@@ -1,6 +1,6 @@
 # Claude Code Instructions
 
-Secure MCP server for the GitHub REST API with 25 tools across issues, pull requests, Actions, releases, files, and search. Works with github.com and GitHub Enterprise Server.
+Secure MCP server for the GitHub REST API with 26 tools across issues, pull requests, Actions, releases, files, and search. Works with github.com and GitHub Enterprise Server.
 
 ## Quick Start
 
@@ -51,11 +51,11 @@ claude mcp add mcp-github-crunchtools \
 | `SSL_CERT_FILE` | No | — | Custom CA bundle for self-hosted instances |
 | `GITHUB_SSL_VERIFY` | No | `true` | Set `false` to disable SSL verification |
 
-## Available Tools (25)
+## Available Tools (26)
 
 | Category | Tools |
 |----------|-------|
-| Issues | `list_issues_tool`, `get_issue_tool`, `create_issue_tool`, `create_issue_comment_tool`, `update_issue_tool` |
+| Issues | `list_issues_tool`, `get_issue_tool`, `list_issue_comments_tool`, `create_issue_tool`, `create_issue_comment_tool`, `update_issue_tool` |
 | Pull Requests | `list_pull_requests_tool`, `get_pull_request_tool`, `get_pull_request_diff_tool`, `get_pull_request_checks_tool`, `list_pull_request_comments_tool`, `create_pull_request_tool`, `update_pull_request_tool`, `reply_to_review_comment_tool`, `merge_pull_request_tool` |
 | Files | `get_file_content_tool`, `list_repo_tree_tool` |
 | Search | `search_code_tool`, `search_issues_tool` |

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/Containerfile

@@ -27,7 +27,7 @@ FROM quay.io/hummingbird/python:latest
 
 # Labels for container metadata
 LABEL name="mcp-github-crunchtools" \
-      version="1.3.0" \
+      version="1.4.0" \
       summary="Secure MCP server for GitHub issues, pull requests, Actions, releases, files, and search" \
       description="A security-focused MCP server for GitHub built on Red Hat UBI" \
       maintainer="crunchtools.com" \

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: mcp-github-crunchtools
-Version: 1.3.1
+Version: 1.4.0
 Summary: Secure MCP server for GitHub issues, pull requests, Actions, releases, files, and search
 Author: crunchtools.com
 License-Expression: AGPL-3.0-or-later
@@ -60,7 +60,7 @@ The container image is built on the [Hummingbird Python base image](https://quay
 
 ## Features
 
-25 tools. Tools marked *write* change something on GitHub; the others only
+26 tools. Tools marked *write* change something on GitHub; the others only
 read and publish `readOnlyHint`. The last column is the fine-grained token
 permission the tool needs (see [Token permissions](#token-permissions)).
 
@@ -70,6 +70,7 @@ permission the tool needs (see [Token permissions](#token-permissions)).
 |------|--------------|------------|
 | `list_issues_tool` | List issues for a repository (pull requests excluded) | Issues: read |
 | `get_issue_tool` | Get a single issue by number | Issues: read |
+| `list_issue_comments_tool` | Comments on an issue or a pull request conversation, oldest first | Issues: read, or Pull requests: read for a PR |
 | `create_issue_tool` | Open an issue (*write*) | Issues: write |
 | `create_issue_comment_tool` | Comment on an issue or pull request (*write*) | Issues: write, or Pull requests: write for a PR |
 | `update_issue_tool` | Edit, close or reopen an issue (*write*) | Issues: write |
@@ -123,7 +124,10 @@ permission the tool needs (see [Token permissions](#token-permissions)).
 
 - `list_pull_request_comments_tool` reads each of its three kinds oldest
   first, up to 300 items per kind. `truncated` and `truncated_kinds` say when
-  newer items were left out.
+  newer items were left out. Called on a plain issue it says so; use
+  `list_issue_comments_tool` there.
+- `list_issue_comments_tool` returns one page (up to 100 comments); follow
+  `pagination.next_page` for more.
 - `get_workflow_run_tool` lists up to 300 jobs; `jobs_truncated` says when the
   run has more.
 - `get_failed_job_logs_tool` returns at most 1000 lines per job (200 by
@@ -218,7 +222,7 @@ For a fine-grained personal access token, the repository permissions are:
 |------------|--------------------|---------------------|
 | Metadata | every tool (GitHub grants it with any other permission) | — |
 | Contents | `get_file_content_tool`, `list_repo_tree_tool` | `merge_pull_request_tool`, `create_release_tool` |
-| Issues | `list_issues_tool`, `get_issue_tool` | `create_issue_tool`, `update_issue_tool`, `create_issue_comment_tool` |
+| Issues | `list_issues_tool`, `get_issue_tool`, `list_issue_comments_tool` | `create_issue_tool`, `update_issue_tool`, `create_issue_comment_tool` |
 | Pull requests | `merge_pull_request_tool`, `list_pull_requests_tool`, `get_pull_request_tool`, `get_pull_request_diff_tool`, `get_pull_request_checks_tool`, `list_pull_request_comments_tool` | `create_pull_request_tool`, `update_pull_request_tool`, `reply_to_review_comment_tool`, `create_issue_comment_tool` on a PR |
 | Actions | `list_workflow_runs_tool`, `get_workflow_run_tool`, `get_failed_job_logs_tool` | `trigger_workflow_tool`, `rerun_workflow_run_tool`, `rerun_failed_jobs_tool` |
 | Commit statuses | `get_pull_request_checks_tool`, `merge_pull_request_tool` | — |

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/README.md

@@ -34,7 +34,7 @@ The container image is built on the [Hummingbird Python base image](https://quay
 
 ## Features
 
-25 tools. Tools marked *write* change something on GitHub; the others only
+26 tools. Tools marked *write* change something on GitHub; the others only
 read and publish `readOnlyHint`. The last column is the fine-grained token
 permission the tool needs (see [Token permissions](#token-permissions)).
 
@@ -44,6 +44,7 @@ permission the tool needs (see [Token permissions](#token-permissions)).
 |------|--------------|------------|
 | `list_issues_tool` | List issues for a repository (pull requests excluded) | Issues: read |
 | `get_issue_tool` | Get a single issue by number | Issues: read |
+| `list_issue_comments_tool` | Comments on an issue or a pull request conversation, oldest first | Issues: read, or Pull requests: read for a PR |
 | `create_issue_tool` | Open an issue (*write*) | Issues: write |
 | `create_issue_comment_tool` | Comment on an issue or pull request (*write*) | Issues: write, or Pull requests: write for a PR |
 | `update_issue_tool` | Edit, close or reopen an issue (*write*) | Issues: write |
@@ -97,7 +98,10 @@ permission the tool needs (see [Token permissions](#token-permissions)).
 
 - `list_pull_request_comments_tool` reads each of its three kinds oldest
   first, up to 300 items per kind. `truncated` and `truncated_kinds` say when
-  newer items were left out.
+  newer items were left out. Called on a plain issue it says so; use
+  `list_issue_comments_tool` there.
+- `list_issue_comments_tool` returns one page (up to 100 comments); follow
+  `pagination.next_page` for more.
 - `get_workflow_run_tool` lists up to 300 jobs; `jobs_truncated` says when the
   run has more.
 - `get_failed_job_logs_tool` returns at most 1000 lines per job (200 by
@@ -192,7 +196,7 @@ For a fine-grained personal access token, the repository permissions are:
 |------------|--------------------|---------------------|
 | Metadata | every tool (GitHub grants it with any other permission) | — |
 | Contents | `get_file_content_tool`, `list_repo_tree_tool` | `merge_pull_request_tool`, `create_release_tool` |
-| Issues | `list_issues_tool`, `get_issue_tool` | `create_issue_tool`, `update_issue_tool`, `create_issue_comment_tool` |
+| Issues | `list_issues_tool`, `get_issue_tool`, `list_issue_comments_tool` | `create_issue_tool`, `update_issue_tool`, `create_issue_comment_tool` |
 | Pull requests | `merge_pull_request_tool`, `list_pull_requests_tool`, `get_pull_request_tool`, `get_pull_request_diff_tool`, `get_pull_request_checks_tool`, `list_pull_request_comments_tool` | `create_pull_request_tool`, `update_pull_request_tool`, `reply_to_review_comment_tool`, `create_issue_comment_tool` on a PR |
 | Actions | `list_workflow_runs_tool`, `get_workflow_run_tool`, `get_failed_job_logs_tool` | `trigger_workflow_tool`, `rerun_workflow_run_tool`, `rerun_failed_jobs_tool` |
 | Commit statuses | `get_pull_request_checks_tool`, `merge_pull_request_tool` | — |

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "mcp-github-crunchtools"
-version = "1.3.1"
+version = "1.4.0"
 description = "Secure MCP server for GitHub issues, pull requests, Actions, releases, files, and search"
 requires-python = ">=3.10"
 license = "AGPL-3.0-or-later"

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/server.json

@@ -7,12 +7,12 @@
     "url": "https://github.com/crunchtools/mcp-github",
     "source": "github"
   },
-  "version": "1.3.0",
+  "version": "1.4.0",
   "packages": [
     {
       "registryType": "pypi",
       "identifier": "mcp-github-crunchtools",
-      "version": "1.3.0",
+      "version": "1.4.0",
       "transport": {
         "type": "stdio"
       }

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/src/mcp_github_crunchtools/__init__.py

@@ -29,7 +29,7 @@ import argparse
 
 from .server import mcp
 
-__version__ = "1.3.1"
+__version__ = "1.4.0"
 __all__ = ["main", "mcp"]
 
 

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/src/mcp_github_crunchtools/server.py

@@ -4,9 +4,10 @@ This module creates and configures the MCP server with all tools.
 """
 
 import logging
-from typing import Any
+from typing import Annotated, Any
 
 from fastmcp import FastMCP
+from pydantic import Field
 
 from .tools import (
     create_issue,
@@ -20,6 +21,7 @@ from .tools import (
     get_pull_request_checks,
     get_pull_request_diff,
     get_workflow_run,
+    list_issue_comments,
     list_issues,
     list_pull_request_comments,
     list_pull_requests,
@@ -44,7 +46,7 @@ READ_ONLY = {"readOnlyHint": True}
 
 mcp = FastMCP(
     name="mcp-github",
-    version="1.3.1",
+    version="1.4.0",
     instructions=(
         "Secure MCP server for GitHub repositories: issues, pull requests "
         "(open, review discussion, diffs, CI checks, merge), Actions runs and "
@@ -89,7 +91,7 @@ async def list_issues_tool(
 @mcp.tool(annotations=READ_ONLY)
 async def get_issue_tool(
     repo: str,
-    issue_number: int,
+    issue_number: Annotated[int, Field(ge=1)],
     owner: str | None = None,
 ) -> dict[str, Any]:
     """Get a single GitHub issue by number.
@@ -105,6 +107,40 @@ async def get_issue_tool(
     return await get_issue(owner=owner, repo=repo, issue_number=issue_number)
 
 
+@mcp.tool(annotations=READ_ONLY)
+async def list_issue_comments_tool(
+    repo: str,
+    issue_number: Annotated[int, Field(ge=1)],
+    owner: str | None = None,
+    per_page: int = 30,
+    page: int = 1,
+) -> dict[str, Any]:
+    """List the comments on a GitHub issue or pull request conversation, oldest first.
+
+    Works for plain issues, which list_pull_request_comments_tool does not.
+    On a pull request it returns only the conversation comments; diff
+    comments and reviews come from list_pull_request_comments_tool.
+
+    Args:
+        repo: Repository name
+        issue_number: Issue or pull request number
+        owner: Repository owner (defaults to GITHUB_DEFAULT_ORG if unset)
+        per_page: Results per page, max 100 (default: 30)
+        page: Page number (default: 1)
+
+    Returns:
+        {"issue_number", "items", "pagination"?}; each item carries id,
+        author, author_association, created_at, updated_at, body, html_url
+    """
+    return await list_issue_comments(
+        owner=owner,
+        repo=repo,
+        issue_number=issue_number,
+        per_page=per_page,
+        page=page,
+    )
+
+
 @mcp.tool()
 async def create_issue_tool(
     repo: str,
@@ -222,7 +258,7 @@ async def list_pull_requests_tool(
 @mcp.tool(annotations=READ_ONLY)
 async def get_pull_request_tool(
     repo: str,
-    pull_number: int,
+    pull_number: Annotated[int, Field(ge=1)],
     owner: str | None = None,
 ) -> dict[str, Any]:
     """Get a single GitHub pull request by number.
@@ -241,7 +277,7 @@ async def get_pull_request_tool(
 @mcp.tool(annotations=READ_ONLY)
 async def get_pull_request_diff_tool(
     repo: str,
-    pull_number: int,
+    pull_number: Annotated[int, Field(ge=1)],
     owner: str | None = None,
 ) -> dict[str, Any]:
     """Get the unified diff for a GitHub pull request.
@@ -260,7 +296,7 @@ async def get_pull_request_diff_tool(
 @mcp.tool(annotations=READ_ONLY)
 async def get_pull_request_checks_tool(
     repo: str,
-    pull_number: int,
+    pull_number: Annotated[int, Field(ge=1)],
     owner: str | None = None,
 ) -> dict[str, Any]:
     """Get a CI verdict for a PR that distinguishes skipped from failed.
@@ -399,7 +435,7 @@ async def merge_pull_request_tool(
 @mcp.tool(annotations=READ_ONLY)
 async def list_pull_request_comments_tool(
     repo: str,
-    pull_number: int,
+    pull_number: Annotated[int, Field(ge=1)],
     owner: str | None = None,
 ) -> dict[str, Any]:
     """List everything said on a GitHub pull request, in one list.
@@ -650,7 +686,7 @@ async def rerun_failed_jobs_tool(
 @mcp.tool(annotations=READ_ONLY)
 async def get_workflow_run_tool(
     repo: str,
-    run_id: int,
+    run_id: Annotated[int, Field(ge=1)],
     owner: str | None = None,
 ) -> dict[str, Any]:
     """Get one GitHub Actions workflow run and its jobs (no logs).
@@ -670,7 +706,7 @@ async def get_workflow_run_tool(
 @mcp.tool(annotations=READ_ONLY)
 async def get_failed_job_logs_tool(
     repo: str,
-    run_id: int,
+    run_id: Annotated[int, Field(ge=1)],
     tail_lines: int = 200,
     owner: str | None = None,
 ) -> dict[str, Any]:

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/src/mcp_github_crunchtools/tools/__init__.py

@@ -16,6 +16,7 @@ from .issues import (
     create_issue,
     create_issue_comment,
     get_issue,
+    list_issue_comments,
     list_issues,
     update_issue,
 )
@@ -45,6 +46,7 @@ __all__ = [
     "get_pull_request_checks",
     "get_pull_request_diff",
     "get_workflow_run",
+    "list_issue_comments",
     "list_issues",
     "list_pull_request_comments",
     "list_pull_requests",

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/src/mcp_github_crunchtools/tools/issues.py

@@ -88,6 +88,62 @@ async def get_issue(
     return await client.get(f"/repos/{owner}/{repo}/issues/{issue_number}")
 
 
+async def list_issue_comments(
+    owner: str | None,
+    repo: str,
+    issue_number: int,
+    per_page: int = 30,
+    page: int = 1,
+) -> dict[str, Any]:
+    """List the comments on an issue or a pull request conversation, oldest first.
+
+    Diff comments and reviews on a pull request are not included; use
+    list_pull_request_comments for those.
+
+    Args:
+        owner: Repository owner (defaults to GITHUB_DEFAULT_ORG if unset)
+        repo: Repository name
+        issue_number: Issue or pull request number
+        per_page: Results per page (max 100)
+        page: Page number
+
+    Returns:
+        {"issue_number", "items", "pagination"?}; each item carries id,
+        author, author_association, created_at, updated_at, body, html_url
+    """
+    owner = resolve_owner(owner)
+    repo = validate_name(repo, "repo")
+    issue_number = validate_positive_int(issue_number, "issue_number")
+
+    client = get_client()
+    result = await client.get(
+        f"/repos/{owner}/{repo}/issues/{issue_number}/comments",
+        params={
+            "per_page": clamp_per_page(per_page),
+            "page": validate_positive_int(page, "page"),
+        },
+    )
+
+    response: dict[str, Any] = {
+        "issue_number": issue_number,
+        "items": [
+            {
+                "id": raw.get("id"),
+                "author": (raw.get("user") or {}).get("login"),
+                "author_association": raw.get("author_association"),
+                "created_at": raw.get("created_at"),
+                "updated_at": raw.get("updated_at"),
+                "body": raw.get("body") or "",
+                "html_url": raw.get("html_url"),
+            }
+            for raw in result.get("items", [])
+        ],
+    }
+    if "pagination" in result:
+        response["pagination"] = result["pagination"]
+    return response
+
+
 async def create_issue(
     owner: str | None,
     repo: str,
@@ -169,9 +225,7 @@ async def update_issue(
         json_data["state"] = state
     if state_reason is not None:
         if state_reason not in ("completed", "not_planned", "reopened"):
-            raise ValidationError(
-                "state_reason must be 'completed', 'not_planned', or 'reopened'"
-            )
+            raise ValidationError("state_reason must be 'completed', 'not_planned', or 'reopened'")
         json_data["state_reason"] = state_reason
     if title is not None:
         json_data["title"] = title

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/src/mcp_github_crunchtools/tools/pull_requests.py

@@ -728,7 +728,19 @@ async def list_pull_request_comments(
     items: list[dict[str, Any]] = []
     truncated_kinds: list[str] = []
     for kind, path in sources.items():
-        raw_items, cut = await _collect_pages(client, path)
+        try:
+            raw_items, cut = await _collect_pages(client, path)
+        except (GitHubApiError, NotFoundError):
+            # GitHub answers /pulls/{n}/... for a plain issue with a 403 that
+            # reads like a token scope problem. Say what is actually wrong.
+            if kind != "issue_comment":
+                issue = await client.get(f"/repos/{owner}/{repo}/issues/{pull_number}")
+                if "pull_request" not in issue:
+                    raise ValidationError(
+                        f"#{pull_number} is an issue, not a pull request; "
+                        "use list_issue_comments_tool"
+                    ) from None
+            raise
         items.extend(_discussion_item(kind, raw) for raw in raw_items)
         if cut:
             truncated_kinds.append(kind)

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/tests/test_tools.py

@@ -38,16 +38,17 @@ class TestToolRegistration:
             assert callable(func), f"{name} is not callable"
 
     def test_tool_count(self) -> None:
-        """Server should export exactly 25 tools."""
+        """Server should export exactly 26 tools."""
         from mcp_github_crunchtools.tools import __all__
 
-        assert len(__all__) == 25
+        assert len(__all__) == 26
 
 
 READ_ONLY = frozenset(
     {
         "list_issues_tool",
         "get_issue_tool",
+        "list_issue_comments_tool",
         "list_pull_requests_tool",
         "get_pull_request_tool",
         "get_pull_request_diff_tool",
@@ -82,6 +83,7 @@ WRITES = frozenset(
 READ_ONLY_CALLS: dict[str, dict[str, object]] = {
     "list_issues_tool": {"owner": "o", "repo": "r"},
     "get_issue_tool": {"owner": "o", "repo": "r", "issue_number": 1},
+    "list_issue_comments_tool": {"owner": "o", "repo": "r", "issue_number": 1},
     "list_pull_requests_tool": {"owner": "o", "repo": "r"},
     "get_pull_request_tool": {"owner": "o", "repo": "r", "pull_number": 1},
     "get_pull_request_diff_tool": {"owner": "o", "repo": "r", "pull_number": 1},
@@ -140,6 +142,20 @@ class TestReadOnlyAnnotation:
     def test_every_read_only_tool_has_call_arguments(self) -> None:
         assert set(READ_ONLY_CALLS) == READ_ONLY
 
+    @pytest.mark.asyncio
+    async def test_read_tool_integer_ids_publish_minimum_one(self) -> None:
+        from mcp_github_crunchtools.server import mcp
+
+        found = 0
+        for tool in await mcp.list_tools():
+            if tool.name not in READ_ONLY:
+                continue
+            for field in ("issue_number", "pull_number", "run_id"):
+                if field in tool.parameters["properties"]:
+                    found += 1
+                    assert tool.parameters["properties"][field]["minimum"] == 1
+        assert found == 8
+
     @pytest.mark.asyncio
     @pytest.mark.parametrize("name", sorted(READ_ONLY))
     async def test_read_only_tool_sends_only_get(self, name: str) -> None:
@@ -384,6 +400,69 @@ class TestIssueTools:
 
         assert result["body"] == "Thanks!"
 
+    @pytest.mark.asyncio
+    async def test_list_issue_comments(self) -> None:
+        from mcp_github_crunchtools.tools import list_issue_comments
+
+        resp = _mock_response(
+            json_data=[
+                {
+                    "id": 7,
+                    "user": {"login": "alice"},
+                    "author_association": "MEMBER",
+                    "created_at": "2026-10-01T10:00:00Z",
+                    "updated_at": "2026-10-01T10:05:00Z",
+                    "body": "Repro attached.",
+                    "html_url": "https://github.com/o/r/issues/42#issuecomment-7",
+                    "reactions": {"dropped": True},
+                },
+                {"id": 8, "user": None, "body": None},
+            ],
+            headers={"link": '<https://api.github.com/x?page=3>; rel="next"'},
+        )
+
+        with _patch_client(resp) as mock_client:
+            result = await list_issue_comments(
+                owner="o", repo="r", issue_number=42, per_page=500, page=2
+            )
+            call = mock_client.return_value.request.call_args
+            assert call.kwargs["method"] == "GET"
+            assert call.kwargs["url"] == "/repos/o/r/issues/42/comments"
+            assert call.kwargs["params"] == {"per_page": 100, "page": 2}
+
+        assert result["issue_number"] == 42
+        assert result["pagination"]["next_page"] == 3
+        assert result["items"][0] == {
+            "id": 7,
+            "author": "alice",
+            "author_association": "MEMBER",
+            "created_at": "2026-10-01T10:00:00Z",
+            "updated_at": "2026-10-01T10:05:00Z",
+            "body": "Repro attached.",
+            "html_url": "https://github.com/o/r/issues/42#issuecomment-7",
+        }
+        assert result["items"][1]["author"] is None
+        assert result["items"][1]["body"] == ""
+
+    @pytest.mark.asyncio
+    async def test_list_issue_comments_refuses_bad_number(self) -> None:
+        from mcp_github_crunchtools.tools import list_issue_comments
+
+        with _patch_client(_mock_response(json_data=[])) as mock_client:
+            with pytest.raises(ValueError, match="positive integer"):
+                await list_issue_comments(owner="o", repo="r", issue_number=0)
+            mock_client.return_value.request.assert_not_awaited()
+
+    @pytest.mark.asyncio
+    async def test_list_issue_comments_not_found(self) -> None:
+        from mcp_github_crunchtools.errors import NotFoundError
+        from mcp_github_crunchtools.tools import list_issue_comments
+
+        resp = _mock_response(status_code=404, json_data={"message": "Not Found"})
+
+        with _patch_client(resp), pytest.raises(NotFoundError):
+            await list_issue_comments(owner="o", repo="r", issue_number=42)
+
     @pytest.mark.asyncio
     async def test_create_issue(self) -> None:
         from mcp_github_crunchtools.tools import create_issue
@@ -902,6 +981,40 @@ class TestPullRequestTools:
         with _patch_client(resp), pytest.raises(NotFoundError):
             await list_pull_request_comments(owner="o", repo="r", pull_number=5)
 
+    @pytest.mark.asyncio
+    async def test_list_pull_request_comments_on_an_issue(self) -> None:
+        """GitHub's 403 for /pulls/{n} on an issue becomes a clear error."""
+        from mcp_github_crunchtools.errors import ValidationError
+        from mcp_github_crunchtools.tools import list_pull_request_comments
+
+        forbidden = _mock_response(
+            status_code=403,
+            json_data={"message": "Resource not accessible by personal access token"},
+        )
+        issue = _mock_response(json_data={"number": 5, "title": "A plain issue"})
+
+        with (
+            _patch_client_sequence(_mock_response(json_data=[]), forbidden, issue) as mock_client,
+            pytest.raises(ValidationError, match="#5 is an issue, not a pull request"),
+        ):
+            await list_pull_request_comments(owner="o", repo="r", pull_number=5)
+        calls = mock_client.return_value.request.call_args_list
+        assert calls[-1].kwargs["url"] == "/repos/o/r/issues/5"
+
+    @pytest.mark.asyncio
+    async def test_list_pull_request_comments_403_on_a_pr_passes_through(self) -> None:
+        from mcp_github_crunchtools.errors import GitHubApiError
+        from mcp_github_crunchtools.tools import list_pull_request_comments
+
+        forbidden = _mock_response(status_code=403, json_data={"message": "Forbidden"})
+        pull = _mock_response(json_data={"number": 5, "pull_request": {"url": "x"}})
+
+        with (
+            _patch_client_sequence(_mock_response(json_data=[]), forbidden, pull),
+            pytest.raises(GitHubApiError, match="403"),
+        ):
+            await list_pull_request_comments(owner="o", repo="r", pull_number=5)
+
     @pytest.mark.asyncio
     async def test_reply_to_review_comment(self) -> None:
         from mcp_github_crunchtools.tools import reply_to_review_comment

{mcp_github_crunchtools-1.3.1 → mcp_github_crunchtools-1.4.0}/uv.lock

@@ -922,7 +922,7 @@ wheels = [
 
 [[package]]
 name = "mcp-github-crunchtools"
-version = "1.3.1"
+version = "1.4.0"
 source = { editable = "." }
 dependencies = [
     { name = "fastmcp" },