mcp-cli-skill 0.8.3__tar.gz → 0.8.4__tar.gz

{mcp_cli_skill-0.8.3 → mcp_cli_skill-0.8.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: mcp-cli-skill
-Version: 0.8.3
+Version: 0.8.4
 Summary: Call any MCP server tool from the command line with shell composition support
 Project-URL: Homepage, https://github.com/wise-toddler/mcp-cli-skill
 Project-URL: Repository, https://github.com/wise-toddler/mcp-cli-skill

{mcp_cli_skill-0.8.3 → mcp_cli_skill-0.8.4}/scripts/mcp_call.py

@@ -296,6 +296,40 @@ def parse_args():
     return server, tool, tool_args
 
 
+def _named_file_with(items, data):
+    """Path named in a text block whose file holds exactly these bytes, else None."""
+    for it in items:
+        text = it.get("text", "") if it.get("type") == "text" else ""
+        for p in re.findall(r"[~/][^\s\"'`,;()<>\[\]{}]+", text):
+            p = os.path.expanduser(p.rstrip(".:"))
+            try:
+                if os.path.getsize(p) == len(data):
+                    with open(p, "rb") as f:
+                        if f.read() == data:
+                            return p
+            except OSError:
+                continue
+    return None
+
+
+def _save_image_copy(item, data):
+    """Write an image block to MCP_CALL_TMPDIR, pruning copies older than 24h; return its path."""
+    os.makedirs(MCP_CALL_TMPDIR, exist_ok=True)
+    cutoff = time.time() - 86400
+    for name in os.listdir(MCP_CALL_TMPDIR):
+        old = os.path.join(MCP_CALL_TMPDIR, name)
+        try:
+            if name.startswith("mcp-") and os.path.getmtime(old) < cutoff:
+                os.remove(old)
+        except OSError:
+            pass
+    ext = item.get("mimeType", "image/png").split("/")[-1]
+    fd, path = tempfile.mkstemp(suffix=f".{ext}", prefix="mcp-", dir=MCP_CALL_TMPDIR)
+    with os.fdopen(fd, "wb") as f:
+        f.write(data)
+    return path
+
+
 def _print_content(items):
     """Print MCP content blocks (text, image, etc.)."""
     for item in items:
@@ -305,12 +339,9 @@ def _print_content(items):
             except json.JSONDecodeError:
                 print(item["text"])
         elif item.get("type") == "image":
-            os.makedirs(MCP_CALL_TMPDIR, exist_ok=True)
-            ext = item.get("mimeType", "image/png").split("/")[-1]
-            fd, path = tempfile.mkstemp(suffix=f".{ext}", prefix="mcp-", dir=MCP_CALL_TMPDIR)
-            os.write(fd, base64.b64decode(item["data"]))
-            os.close(fd)
-            print(path)
+            data = base64.b64decode(item["data"])
+            # the server may already have saved this exact image (e.g. a --path arg): point at it, don't copy
+            print(_named_file_with(items, data) or _save_image_copy(item, data))
         elif item.get("type") == "resource_link":
             line = item.get("uri", "")
             if item.get("name"):

{mcp_cli_skill-0.8.3 → mcp_cli_skill-0.8.4}/src/mcp_cli_skill/__init__.py

@@ -1,2 +1,2 @@
 """MCP CLI - Call any MCP server tool from the command line."""
-__version__ = "0.8.3"
+__version__ = "0.8.4"

{mcp_cli_skill-0.8.3 → mcp_cli_skill-0.8.4}/src/mcp_cli_skill/cli.py

@@ -296,6 +296,40 @@ def parse_args():
     return server, tool, tool_args
 
 
+def _named_file_with(items, data):
+    """Path named in a text block whose file holds exactly these bytes, else None."""
+    for it in items:
+        text = it.get("text", "") if it.get("type") == "text" else ""
+        for p in re.findall(r"[~/][^\s\"'`,;()<>\[\]{}]+", text):
+            p = os.path.expanduser(p.rstrip(".:"))
+            try:
+                if os.path.getsize(p) == len(data):
+                    with open(p, "rb") as f:
+                        if f.read() == data:
+                            return p
+            except OSError:
+                continue
+    return None
+
+
+def _save_image_copy(item, data):
+    """Write an image block to MCP_CALL_TMPDIR, pruning copies older than 24h; return its path."""
+    os.makedirs(MCP_CALL_TMPDIR, exist_ok=True)
+    cutoff = time.time() - 86400
+    for name in os.listdir(MCP_CALL_TMPDIR):
+        old = os.path.join(MCP_CALL_TMPDIR, name)
+        try:
+            if name.startswith("mcp-") and os.path.getmtime(old) < cutoff:
+                os.remove(old)
+        except OSError:
+            pass
+    ext = item.get("mimeType", "image/png").split("/")[-1]
+    fd, path = tempfile.mkstemp(suffix=f".{ext}", prefix="mcp-", dir=MCP_CALL_TMPDIR)
+    with os.fdopen(fd, "wb") as f:
+        f.write(data)
+    return path
+
+
 def _print_content(items):
     """Print MCP content blocks (text, image, etc.)."""
     for item in items:
@@ -305,12 +339,9 @@ def _print_content(items):
             except json.JSONDecodeError:
                 print(item["text"])
         elif item.get("type") == "image":
-            os.makedirs(MCP_CALL_TMPDIR, exist_ok=True)
-            ext = item.get("mimeType", "image/png").split("/")[-1]
-            fd, path = tempfile.mkstemp(suffix=f".{ext}", prefix="mcp-", dir=MCP_CALL_TMPDIR)
-            os.write(fd, base64.b64decode(item["data"]))
-            os.close(fd)
-            print(path)
+            data = base64.b64decode(item["data"])
+            # the server may already have saved this exact image (e.g. a --path arg): point at it, don't copy
+            print(_named_file_with(items, data) or _save_image_copy(item, data))
         elif item.get("type") == "resource_link":
             line = item.get("uri", "")
             if item.get("name"):

{mcp_cli_skill-0.8.3 → mcp_cli_skill-0.8.4}/tests/test_args.py

@@ -5,13 +5,15 @@ import subprocess
 import sys
 import tempfile
 import textwrap
+import time
 import unittest
 
 REPO = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
 
 FAKE_SERVER = textwrap.dedent("""
-    import json, os, sys
-    tools = os.environ.get("FAKE_TOOLS", "echo,slack_channel").split(",")
+    import base64, json, os, sys
+    tools = os.environ.get("FAKE_TOOLS", "echo,slack_channel,shot").split(",")
+    IMG = b"\\x89PNG fake image bytes"
     for line in sys.stdin:
         msg = json.loads(line)
         if msg.get("id") is None:
@@ -25,6 +27,14 @@ FAKE_SERVER = textwrap.dedent("""
             with open(os.environ["FAKE_LOG"], "a") as f:
                 f.write(msg["params"]["name"] + "\\n")
             res = {"content": [{"type": "text", "text": "ok " + msg["params"]["name"]}]}
+            if msg["params"]["name"] == "shot":  # like browser_screenshot: image block (+ saved file if path given)
+                img = {"type": "image", "data": base64.b64encode(IMG).decode(), "mimeType": "image/png"}
+                path = msg["params"].get("arguments", {}).get("path")
+                res = {"content": [img]}
+                if path:
+                    with open(path, "wb") as f:
+                        f.write(IMG)
+                    res["content"].append({"type": "text", "text": f"Saved {path} (1 KB)"})
         sys.stdout.write(json.dumps({"jsonrpc": "2.0", "id": msg["id"], "result": res}) + "\\n")
         sys.stdout.flush()
 """)
@@ -43,7 +53,7 @@ class ArgsTest(unittest.TestCase):
 
     def run_cli(self, *args, tools=None):
         """Run mcp-call in a subprocess with an isolated HOME; return (exit code, stdout, stderr)."""
-        env = {**os.environ, "HOME": self.home, "PYTHONPATH": os.path.join(REPO, "src"), "NO_COLOR": "1"}
+        env = {**os.environ, "HOME": self.home, "TMPDIR": self.home, "PYTHONPATH": os.path.join(REPO, "src"), "NO_COLOR": "1"}
         if tools:
             env["FAKE_TOOLS"] = tools
         p = subprocess.run([sys.executable, "-m", "mcp_cli_skill.cli", *args], env=env, cwd=REPO,
@@ -91,6 +101,30 @@ class ArgsTest(unittest.TestCase):
         self.assertIn("ok brand_new", out)
         self.assertEqual(self.calls(), ["echo", "brand_new"])
 
+    def copies(self):
+        d = os.path.join(self.home, "mcp-call")
+        return sorted(os.listdir(d)) if os.path.isdir(d) else []
+
+    def test_image_already_saved_by_server_is_not_copied(self):
+        path = os.path.join(self.home, "shot.png")
+        code, out, err = self.run_cli("fake", "shot", f"--path={path}")
+        self.assertEqual(code, 0, err)
+        self.assertEqual(out.splitlines()[0], path)  # image block points at the server's file
+        self.assertEqual(self.copies(), [])
+
+    def test_image_without_saved_file_is_copied_and_old_copies_pruned(self):
+        os.makedirs(os.path.join(self.home, "mcp-call"))
+        stale, fresh = (os.path.join(self.home, "mcp-call", n) for n in ("mcp-stale.png", "mcp-fresh.png"))
+        for p in (stale, fresh):
+            open(p, "w").close()
+        os.utime(stale, (time.time() - 2 * 86400,) * 2)
+        code, out, err = self.run_cli("fake", "shot")
+        self.assertEqual(code, 0, err)
+        copy = out.strip()
+        with open(copy, "rb") as f:
+            self.assertEqual(f.read(), b"\x89PNG fake image bytes")
+        self.assertEqual(self.copies(), sorted(["mcp-fresh.png", os.path.basename(copy)]))
+
     def test_schema_unknown_tool_suggests(self):
         code, _, err = self.run_cli("fake", "ech", "--schema")
         self.assertEqual(code, 2)