matrx-orm 3.1.148__tar.gz → 3.1.149__tar.gz

{matrx_orm-3.1.148 → matrx_orm-3.1.149}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: matrx-orm
-Version: 3.1.148
+Version: 3.1.149
 Summary: Async-first PostgreSQL ORM with bidirectional migrations, schema introspection, many-to-many relationships, and built-in state caching
 Project-URL: Homepage, https://github.com/AI-Matrix-Engine/aidream-current
 Project-URL: Repository, https://github.com/AI-Matrix-Engine/aidream-current
@@ -25,7 +25,7 @@ Requires-Python: >=3.13
 Requires-Dist: asyncpg>=0.31.0
 Requires-Dist: cryptography>=43.0
 Requires-Dist: gitpython>=3.1.40
-Requires-Dist: matrx-utils>=2.0.40
+Requires-Dist: matrx-utils>=2.0.41
 Requires-Dist: psycopg-pool>=3.2.5
 Requires-Dist: psycopg[binary]>=3.2.5
 Requires-Dist: python-dotenv>=1.0

{matrx_orm-3.1.148 → matrx_orm-3.1.149}/matrx_orm/secrets_battery/__init__.py

@@ -80,6 +80,7 @@ from .items import (
     FieldSpec,
     ItemGrantSpec,
     SandboxInjectionWithoutEnvKeyError,
+    SealedBrowserFillPasswordError,
     SealedFieldError,
     TransferResult,
     add_credential_field,
@@ -215,6 +216,7 @@ __all__ = [
     "FieldSpec",
     "ItemGrantSpec",
     "SandboxInjectionWithoutEnvKeyError",
+    "SealedBrowserFillPasswordError",
     "SealedFieldError",
     "URI_MATCH_MODES",
     "add_credential_field",

{matrx_orm-3.1.148 → matrx_orm-3.1.149}/matrx_orm/secrets_battery/items.py

@@ -110,6 +110,21 @@ class SandboxInjectionWithoutEnvKeyError(ValueError):
     together) or leave injection off."""
 
 
+class SealedBrowserFillPasswordError(ValueError):
+    """A ``password`` field is (or would become) ``handling='sealed'`` on an
+    item with ``browser_fill_enabled=true``. A sealed value has NO reveal
+    path anywhere — including the browser-fill boundary itself
+    (``vault.py`` ``_prepare_fill_payload`` / ``vault_resolve_for_browser``
+    both refuse a sealed field with "is sealed and cannot be filled into a
+    page"), so a browser-fill login built this way can never actually fill
+    a page: it looks saved but is permanently unusable.
+
+    Refused LOUDLY at every write path instead of accepted-and-broken —
+    'revealable' is the canonical handling for a browser-fill password: it
+    still requires reveal capability + recent auth to resolve, but (unlike
+    'sealed') it is allowed to cross the browser-fill boundary at all."""
+
+
 class ProtectedSecretPurposeError(PermissionError):
     """A generic path reached a native-provider-only secret before decrypt."""
 
@@ -255,6 +270,24 @@ def _validate_sandbox_injectable(
         )
 
 
+def _refuse_sealed_browser_fill_password(
+    *, browser_fill_enabled: bool, field_key: str, handling: str
+) -> None:
+    """Catch the sealed/browser-fill contradiction at the write boundary —
+    see :class:`SealedBrowserFillPasswordError`. Scoped to the ``password``
+    field key: that is the one the browser-fill path actually needs, and
+    the one the live incident hit (a ``website_login`` created with a
+    sealed password was silently unusable)."""
+    if browser_fill_enabled and field_key == "password" and handling == "sealed":
+        raise SealedBrowserFillPasswordError(
+            "field 'password' cannot be handling='sealed' on an item with "
+            "browser_fill_enabled=true — a sealed value is refused at fill "
+            "time, so this login would be saved but could never actually "
+            "fill a page. Use handling='revealable' for a browser-fill "
+            "login instead."
+        )
+
+
 def _validate_uri_match_mode(mode: str) -> None:
     if mode not in URI_MATCH_MODES:
         raise ValueError(f"uri_match_mode must be one of {URI_MATCH_MODES}; got {mode!r}")
@@ -588,6 +621,11 @@ async def create_credential_bundle(
             env_key=spec.env_key,
             inject_into_sandbox=spec.inject_into_sandbox,
         )
+        _refuse_sealed_browser_fill_password(
+            browser_fill_enabled=bool(browser_fill_enabled),
+            field_key=spec.field_key,
+            handling=spec.handling,
+        )
         if not isinstance(spec.value, str):
             raise ValueError(f"field {spec.field_key!r}: value must be a string")
         if spec.field_key in seen:
@@ -709,6 +747,21 @@ async def update_credential_item(
     touches ciphertext."""
     if status is not None and status not in ITEM_STATUSES:
         raise ValueError(f"status must be one of {ITEM_STATUSES}; got {status!r}")
+    if browser_fill_enabled:
+        sealed_password = await UserSecret.filter(
+            credential_item_id=item_id,
+            field_key="password",
+            handling="sealed",
+            is_active=True,
+            deleted_at__isnull=True,
+        ).values("id")
+        if sealed_password:
+            raise SealedBrowserFillPasswordError(
+                "cannot set browser_fill_enabled=true — this item's 'password' field is "
+                "handling='sealed', which is refused at fill time, so the login would be "
+                "saved but could never actually fill a page. Rotate/replace the password "
+                "field with handling='revealable' first."
+            )
     updates: dict[str, Any] = {"updated_by": actor_id, "updated_at": datetime.now(UTC)}
     if display_name is not None:
         updates["display_name"] = display_name
@@ -827,6 +880,11 @@ async def add_credential_field(
         raise ValueError("value must be a string")
     async with transaction(PACKAGE_DB_NAME):
         raw = await _lock_item_raw(item_id)
+        _refuse_sealed_browser_fill_password(
+            browser_fill_enabled=bool(raw.get("browser_fill_enabled")),
+            field_key=spec.field_key,
+            handling=spec.handling,
+        )
         instance = await UserSecret.create(
             user_id=raw.get("user_id"),
             organization_id=raw.get("organization_id"),
@@ -999,8 +1057,9 @@ async def update_field_metadata(
         rows = await UserSecret.filter(id=field_id, deleted_at__isnull=True).values("credential_item_id")
         if not rows:
             raise SecretNotFoundError(f"credential field {field_id} not found")
+        item_raw: dict[str, Any] | None = None
         if rows[0].get("credential_item_id"):
-            await _lock_item_raw(str(rows[0]["credential_item_id"]))
+            item_raw = await _lock_item_raw(str(rows[0]["credential_item_id"]))
         rows = await UserSecret.filter(id=field_id, deleted_at__isnull=True).select_for_update().values(
             *_FIELD_FIELDS, "user_id", "organization_id"
         )
@@ -1014,6 +1073,12 @@ async def update_field_metadata(
                 f"field {raw.get('field_key') or raw.get('key')!r} is sealed — sealing is "
                 "a one-way door; rotate/replace the field instead of unsealing it"
             )
+        if handling is not None:
+            _refuse_sealed_browser_fill_password(
+                browser_fill_enabled=bool((item_raw or {}).get("browser_fill_enabled")),
+                field_key=str(raw.get("field_key") or ""),
+                handling=handling,
+            )
 
         # The POST-patch state is what matters: enabling injection on a keyless
         # field AND clearing the alias of an already-injecting field are the

{matrx_orm-3.1.148 → matrx_orm-3.1.149}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "matrx-orm"
-version = "3.1.148"
+version = "3.1.149"
 description = "Async-first PostgreSQL ORM with bidirectional migrations, schema introspection, many-to-many relationships, and built-in state caching"
 readme = "README.md"
 license = { text = "MIT" }
@@ -41,7 +41,7 @@ dependencies = [
     "gitpython>=3.1.40",
     "psycopg[binary]>=3.2.5",
     "psycopg-pool>=3.2.5",
-    "matrx-utils>=2.0.40",
+    "matrx-utils>=2.0.41",
     "pyyaml>=6.0.3",
     "python-dotenv>=1.0",
     "cryptography>=43.0",

{matrx_orm-3.1.148 → matrx_orm-3.1.149}/tests/test_secrets_battery.py

@@ -923,3 +923,96 @@ def test_error_taxonomy():
     assert issubclass(SealedFieldError, PermissionError)
     assert issubclass(FieldNotEditableError, PermissionError)
     assert issubclass(CredentialItemNotFoundError, LookupError)
+
+
+# ── Sealed password on a browser-fill item (live incident: a website_login
+# created with handling='sealed' was accepted, then unusable — vault.py's
+# browser-fill path refuses any sealed field at fill time) ─────────────────
+
+
+def test_refuse_sealed_browser_fill_password_helper():
+    """Direct coverage of the boundary check: only the exact combination
+    (browser_fill_enabled AND field_key == 'password' AND handling ==
+    'sealed') is refused — every other combination is fine."""
+    from matrx_orm.secrets_battery.items import (
+        SealedBrowserFillPasswordError,
+        _refuse_sealed_browser_fill_password,
+    )
+
+    with pytest.raises(SealedBrowserFillPasswordError, match="cannot be handling='sealed'"):
+        _refuse_sealed_browser_fill_password(
+            browser_fill_enabled=True, field_key="password", handling="sealed"
+        )
+
+    # A sealed field that is not 'password' does not collide with browser fill.
+    _refuse_sealed_browser_fill_password(
+        browser_fill_enabled=True, field_key="totp_seed", handling="sealed"
+    )
+    # A sealed password is fine when the item never fills into a browser.
+    _refuse_sealed_browser_fill_password(
+        browser_fill_enabled=False, field_key="password", handling="sealed"
+    )
+    # 'revealable' is exactly the handling the browser-fill path accepts.
+    _refuse_sealed_browser_fill_password(
+        browser_fill_enabled=True, field_key="password", handling="revealable"
+    )
+
+
+def test_create_credential_bundle_refuses_sealed_password_with_browser_fill_enabled():
+    """RED before the fix: a website_login created with browser_fill_enabled
+    plus a sealed password field used to be accepted silently and was then
+    permanently unfillable (vault.py ~1741 'is sealed and cannot be filled
+    into a page'). All field validation in create_credential_bundle runs
+    BEFORE the DB transaction opens, so this raises with no DB configured —
+    proof the refusal happens at the write boundary, not deep in a query."""
+    import asyncio
+
+    from matrx_orm.secrets_battery import FieldSpec
+    from matrx_orm.secrets_battery.items import (
+        SealedBrowserFillPasswordError,
+        create_credential_bundle,
+    )
+
+    with pytest.raises(SealedBrowserFillPasswordError, match="password.*browser_fill_enabled"):
+        asyncio.run(
+            create_credential_bundle(
+                user_id="u1",
+                display_name="AI Matrx",
+                browser_fill_enabled=True,
+                login_urls=["https://www.aimatrx.com/login"],
+                fields=[
+                    FieldSpec("username", "me@example.com"),
+                    FieldSpec("password", "hunter2", handling="sealed"),
+                ],
+            )
+        )
+
+
+def test_create_credential_bundle_validation_accepts_revealable_password():
+    """The canonical fix: 'revealable' clears the same validation loop and
+    the function proceeds past field validation toward the DB transaction
+    (which then fails for lack of a configured database in this DB-free
+    test) — proof the guard targets 'sealed' specifically, not every
+    browser-fill password."""
+    import asyncio
+
+    from matrx_orm.secrets_battery import FieldSpec
+    from matrx_orm.secrets_battery.items import (
+        SealedBrowserFillPasswordError,
+        create_credential_bundle,
+    )
+
+    with pytest.raises(Exception) as excinfo:
+        asyncio.run(
+            create_credential_bundle(
+                user_id="u1",
+                display_name="AI Matrx",
+                browser_fill_enabled=True,
+                login_urls=["https://www.aimatrx.com/login"],
+                fields=[
+                    FieldSpec("username", "me@example.com"),
+                    FieldSpec("password", "hunter2", handling="revealable"),
+                ],
+            )
+        )
+    assert not isinstance(excinfo.value, SealedBrowserFillPasswordError)