maintainability-agent 4.4.4__tar.gz → 4.4.5__tar.gz

{maintainability_agent-4.4.4/src/maintainability_agent.egg-info → maintainability_agent-4.4.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: maintainability-agent
-Version: 4.4.4
+Version: 4.4.5
 Summary: Maintainability gate and AI remediation prompt generator for CI.
 Author: Marshall Guillory
 License: MIT
@@ -47,7 +47,7 @@ Dynamic: license-file
 **A deterministic, offline maintainability audit whose output is a _bounded
 work order_ for an AI coding agent** — a copy-paste prompt, per finding, that
 says *fix exactly these and refactor nothing else*. Chat-primary; CLI for CI.
-Version **4.4.4**.
+Version **4.4.5**.
 
 > ## **Calibrated against 201 mature open-source repositories in fifteen languages.**
 >
@@ -517,7 +517,7 @@ instead of an invokable skill:
 This repo ships `action.yml`, usable as a composite action:
 
 ```yaml
-- uses: marshallguillory86/maintainability-agent@v4.4.4
+- uses: marshallguillory86/maintainability-agent@v4.4.5
   with:
     config: maintainability-agent.json
     changed-only: main...HEAD

{maintainability_agent-4.4.4 → maintainability_agent-4.4.5}/README.md

@@ -5,7 +5,7 @@
 **A deterministic, offline maintainability audit whose output is a _bounded
 work order_ for an AI coding agent** — a copy-paste prompt, per finding, that
 says *fix exactly these and refactor nothing else*. Chat-primary; CLI for CI.
-Version **4.4.4**.
+Version **4.4.5**.
 
 > ## **Calibrated against 201 mature open-source repositories in fifteen languages.**
 >
@@ -475,7 +475,7 @@ instead of an invokable skill:
 This repo ships `action.yml`, usable as a composite action:
 
 ```yaml
-- uses: marshallguillory86/maintainability-agent@v4.4.4
+- uses: marshallguillory86/maintainability-agent@v4.4.5
   with:
     config: maintainability-agent.json
     changed-only: main...HEAD

{maintainability_agent-4.4.4 → maintainability_agent-4.4.5/src/maintainability_agent.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: maintainability-agent
-Version: 4.4.4
+Version: 4.4.5
 Summary: Maintainability gate and AI remediation prompt generator for CI.
 Author: Marshall Guillory
 License: MIT
@@ -47,7 +47,7 @@ Dynamic: license-file
 **A deterministic, offline maintainability audit whose output is a _bounded
 work order_ for an AI coding agent** — a copy-paste prompt, per finding, that
 says *fix exactly these and refactor nothing else*. Chat-primary; CLI for CI.
-Version **4.4.4**.
+Version **4.4.5**.
 
 > ## **Calibrated against 201 mature open-source repositories in fifteen languages.**
 >
@@ -517,7 +517,7 @@ instead of an invokable skill:
 This repo ships `action.yml`, usable as a composite action:
 
 ```yaml
-- uses: marshallguillory86/maintainability-agent@v4.4.4
+- uses: marshallguillory86/maintainability-agent@v4.4.5
   with:
     config: maintainability-agent.json
     changed-only: main...HEAD

{maintainability_agent-4.4.4 → maintainability_agent-4.4.5}/src/maintainability_agent.egg-info/SOURCES.txt

@@ -206,6 +206,7 @@ tests/test_band_concealment_class.py
 tests/test_band_concealment_p3.py
 tests/test_band_pressures.py
 tests/test_bands.py
+tests/test_base_ref_only_where_it_exists.py
 tests/test_behaviour_suites_are_tests.py
 tests/test_body_or_signature_class.py
 tests/test_both_setup_paths_ask_the_same_stage.py

{maintainability_agent-4.4.4 → maintainability_agent-4.4.5}/src/maintainability_audit/__init__.py

@@ -1,3 +1,3 @@
 """Maintainability Audit CI."""
 
-__version__ = "4.4.4"
+__version__ = "4.4.5"

{maintainability_agent-4.4.4 → maintainability_agent-4.4.5}/src/maintainability_audit/cli.py

@@ -43,7 +43,7 @@ from .config import (
     load_config,
     repository_path,
 )
-from .git_tools import changed_paths
+from .git_tools import GitCommandFailed, changed_paths
 from .instructions import (
     INSTRUCTION_TARGETS,
     UnknownTarget,
@@ -492,7 +492,14 @@ def main(argv: list[str] | None = None) -> int:
         return 0
 
     selection = _selection_from(parser, args.work)
-    only_paths = changed_paths(root, args.changed_only) if args.changed_only else None
+    try:
+        only_paths = changed_paths(root, args.changed_only) if args.changed_only else None
+    except GitCommandFailed as unresolved:
+        # A range git cannot resolve is a bad input, said so by name, not a
+        # traceback a pipeline cannot tell from a broken tool (D234).
+        print(f"maintainability-agent: --changed-only {args.changed_only} cannot be "
+              f"resolved ({unresolved})", file=sys.stderr)
+        return 2
     external_findings = read_sarif_inputs(args.sarif_input)
     report = build_report(root, config, only_paths=only_paths,
                           changed_revspec=args.changed_only,

maintainability_agent-4.4.5/tests/test_base_ref_only_where_it_exists.py

@@ -0,0 +1,75 @@
+"""`github.base_ref` is used only where it has a value (D234).
+
+`base_ref` is set on a pull request and empty on every other event. When
+CI stopped running the maintainability audit on pull requests and moved it
+to pushes on main (Decision 18, 2026-10-15), its `changed-only` stayed
+`origin/${{ github.base_ref }}...HEAD`. On a push that is `origin/...HEAD`,
+git cannot resolve it, and the job failed on every push to main from that
+day — while every pull request, where the value exists, passed.
+
+A job that reads `base_ref` either belongs to a workflow only pull requests
+trigger, or is guarded to them with `if: github.event_name == 'pull_request'`.
+The jobs are read from the workflow files, so a job added later is held to it.
+"""
+
+from __future__ import annotations
+
+import re
+from pathlib import Path
+
+ROOT = Path(__file__).resolve().parents[1]
+WORKFLOWS = sorted((ROOT / ".github" / "workflows").glob("*.yml"))
+PULL_REQUEST_EVENTS = {"pull_request", "pull_request_target"}
+
+
+def _triggers(text: str) -> set[str]:
+    block = re.search(r"^on:\s*\n((?:(?:\s*#.*|  .*)?\n)+)", text, re.M)
+    assert block, "a workflow without an `on:` block"
+    return set(re.findall(r"^  ([a-z_]+):", block.group(1), re.M))
+
+
+def _jobs(text: str) -> dict[str, str]:
+    body = text.split("\njobs:\n", 1)[1]
+    parts = re.split(r"^  ([A-Za-z0-9_-]+):\s*$", body, flags=re.M)
+    return dict(zip(parts[1::2], parts[2::2], strict=True))
+
+
+def test_every_job_reading_base_ref_runs_only_on_pull_requests() -> None:
+    readers, unguarded = [], []
+    for workflow in WORKFLOWS:
+        text = workflow.read_text(encoding="utf-8")
+        only_pull_requests = _triggers(text) <= PULL_REQUEST_EVENTS
+        for job, body in _jobs(text).items():
+            if "github.base_ref" not in body:
+                continue
+            readers.append(f"{workflow.name}:{job}")
+            guarded = re.search(r"^    if: github\.event_name == 'pull_request'", body, re.M)
+            if not (only_pull_requests or guarded):
+                unguarded.append(f"{workflow.name}:{job}")
+    # A parser that found no reader would pass this vacuously.
+    assert len(readers) >= 2, readers
+    assert unguarded == [], f"these jobs read base_ref on events where it is empty: {unguarded}"
+
+
+def test_a_range_git_cannot_resolve_is_refused_by_name_not_a_traceback(tmp_path: Path, capsys) -> None:
+    """The second half: the audit crashed with `GitCommandFailed` and a traceback.
+
+    A pipeline reading that cannot tell a bad input from a broken tool. The
+    pre-commit mode already refuses by name with exit 2; the audit does too.
+    """
+    import subprocess
+
+    from maintainability_audit.cli import main
+
+    root = tmp_path / "repo"
+    root.mkdir()
+    subprocess.run(["git", "-C", str(root), "init", "-q", "-b", "main"], check=True)
+    (root / "a.py").write_text("x = 1\n", encoding="utf-8")
+    subprocess.run(["git", "-C", str(root), "add", "."], check=True)
+    subprocess.run(["git", "-C", str(root), "-c", "user.email=t@t", "-c", "user.name=t",
+                    "commit", "-qm", "base"], check=True)
+
+    code = main(["--root", str(root), "--no-analyzers", "--changed-only", "origin/...HEAD"])
+
+    assert code == 2
+    assert "origin/...HEAD" in capsys.readouterr().err