magmascript 3.2.3__tar.gz → 3.2.4__tar.gz

{magmascript-3.2.3 → magmascript-3.2.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: magmascript
-Version: 3.2.3
+Version: 3.2.4
 Summary: Scripting toolkit with domain-first subcommands
 Author: Jake McCoy
 License-Expression: MIT
@@ -702,6 +702,7 @@ Full documentation on the [Wiki](https://github.com/magmacrunch-media/magmascrip
 If you find magmascript useful, consider supporting its development:
 
 [![Sponsor](https://img.shields.io/badge/%E2%9D%A4_Sponsor-pink)](https://github.com/sponsors/magmacrunch-media)
+[![PayPal](https://img.shields.io/badge/Donate-PayPal-blue)](https://www.paypal.biz/magmacrunchmedia)
 
 ## License
 

{magmascript-3.2.3 → magmascript-3.2.4}/README.md

@@ -664,6 +664,7 @@ Full documentation on the [Wiki](https://github.com/magmacrunch-media/magmascrip
 If you find magmascript useful, consider supporting its development:
 
 [![Sponsor](https://img.shields.io/badge/%E2%9D%A4_Sponsor-pink)](https://github.com/sponsors/magmacrunch-media)
+[![PayPal](https://img.shields.io/badge/Donate-PayPal-blue)](https://www.paypal.biz/magmacrunchmedia)
 
 ## License
 

{magmascript-3.2.3 → magmascript-3.2.4}/magmascript/__init__.py

@@ -1,6 +1,15 @@
 """magmascript — a scripting toolkit with domain-first subcommands."""
 
-__version__ = "3.2.2"
+# The version lives in pyproject.toml alone. It was also a literal here, and the
+# two drifted: 3.2.3 shipped reporting itself as 3.2.2, in the REPL banner and
+# in the MCP client's User-Agent.
+from importlib.metadata import PackageNotFoundError as _PackageNotFoundError
+from importlib.metadata import version as _version
+
+try:
+    __version__ = _version("magmascript")
+except _PackageNotFoundError:  # running from a source tree that was never installed
+    __version__ = "0+unknown"
 
 from magmascript.core.config import Config, GHConfig, MediaConfig, MC1Config, PIConfig, get_config, load_config, set_config
 from magmascript.core.registry import get_domain, list_domains, register_domain

{magmascript-3.2.3 → magmascript-3.2.4}/magmascript/cli.py

@@ -11,6 +11,7 @@ from __future__ import annotations
 
 import json
 import sys
+from datetime import datetime
 from functools import wraps
 from typing import Callable
 
@@ -66,7 +67,12 @@ def _generate_channels_js(channels: list[dict]) -> str:
 
 # -- register domain commands --------------------------------------------
 
+_DOMAINS_REGISTERED = False
+
+
 def _register_domains():
+    global _DOMAINS_REGISTERED
+
     from magmascript.domains.mcp import MCPClient
     from magmascript.domains.pi import PIClient
     from magmascript.domains.mac import MacClient
@@ -138,6 +144,8 @@ def _register_domains():
 
     register("search", "Site search index builder")(_search_handler)
 
+    _DOMAINS_REGISTERED = True
+
 
 # -- register built-in meta commands ------------------------------------
 
@@ -437,8 +445,15 @@ def main():
         no_cache = True
         rest.remove("--no-cache")
 
-    # Register domain commands (lazy, on first use)
-    if not COMMANDS:
+    # Register domain commands (lazy, on first use).
+    #
+    # This was `if not COMMANDS:`, which assumed the table starts empty. It did
+    # until 3.2.2 registered the built-in commands (run, repl, cache, ...) with
+    # @register at import. From then on COMMANDS was never empty, this never
+    # ran, and every domain command -- archive, mb, lastfm, scores, search and
+    # the rest -- failed as "Unknown domain" in 3.2.2 and 3.2.3. A flag says
+    # what is actually meant: have the domains been registered yet.
+    if not _DOMAINS_REGISTERED:
         _register_domains()
 
     try:

{magmascript-3.2.3 → magmascript-3.2.4}/magmascript/domains/archive/client.py

@@ -98,7 +98,7 @@ class ArchiveClient:
             "events": "c-events",
             "games": "c-games",
             "links": "c-links",
-            "music videos": "c-music-videos",
+            "videos": "c-videos",
             "network": "c-network",
             "documentary": "c-documentary",
             "personnel": "c-personnel",

{magmascript-3.2.3 → magmascript-3.2.4}/magmascript/domains/mcp/client.py

@@ -43,6 +43,14 @@ from magmascript.domains.mcp.tools import (
 )
 
 
+def _user_agent() -> str:
+    # Imported here, not at module level: magmascript/__init__.py imports this
+    # module. It was a literal "magmascript/3.2.2", still sent by 3.2.3.
+    from magmascript import __version__
+
+    return f"magmascript/{__version__} (https://github.com/magmacrunch-media/magmascript)"
+
+
 def _wrap_mcp_error(e: Exception, context: str = "") -> Exception:
     """Wrap RPC and HTTP exceptions into typed magmascript errors."""
     if isinstance(e, RPCError):
@@ -262,7 +270,7 @@ class MCPClient:
         """Search MusicBrainz for releases by query string."""
         url = "https://musicbrainz.org/ws/2/release/"
         params = {"query": query, "fmt": "json", "limit": limit}
-        headers = {"User-Agent": "magmascript/3.2.2 (https://github.com/magmacrunch-media/magmascript)"}
+        headers = {"User-Agent": _user_agent()}
         try:
             resp = httpx.get(url, params=params, headers=headers, timeout=10.0)
             resp.raise_for_status()
@@ -275,7 +283,7 @@ class MCPClient:
         """Get full release details including track list with recordings."""
         url = f"https://musicbrainz.org/ws/2/release/{mbid}"
         params = {"fmt": "json", "inc": "artist-credits+recordings"}
-        headers = {"User-Agent": "magmascript/3.2.2 (https://github.com/magmacrunch-media/magmascript)"}
+        headers = {"User-Agent": _user_agent()}
         try:
             resp = httpx.get(url, params=params, headers=headers, timeout=10.0)
             resp.raise_for_status()
@@ -288,7 +296,7 @@ class MCPClient:
         """Get recording details including ISRCs and work relationships."""
         url = f"https://musicbrainz.org/ws/2/recording/{mbid}"
         params = {"fmt": "json", "inc": "artist-credits+isrcs+work-rels"}
-        headers = {"User-Agent": "magmascript/3.2.2 (https://github.com/magmacrunch-media/magmascript)"}
+        headers = {"User-Agent": _user_agent()}
         try:
             resp = httpx.get(url, params=params, headers=headers, timeout=10.0)
             resp.raise_for_status()

{magmascript-3.2.3 → magmascript-3.2.4}/magmascript.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: magmascript
-Version: 3.2.3
+Version: 3.2.4
 Summary: Scripting toolkit with domain-first subcommands
 Author: Jake McCoy
 License-Expression: MIT
@@ -702,6 +702,7 @@ Full documentation on the [Wiki](https://github.com/magmacrunch-media/magmascrip
 If you find magmascript useful, consider supporting its development:
 
 [![Sponsor](https://img.shields.io/badge/%E2%9D%A4_Sponsor-pink)](https://github.com/sponsors/magmacrunch-media)
+[![PayPal](https://img.shields.io/badge/Donate-PayPal-blue)](https://www.paypal.biz/magmacrunchmedia)
 
 ## License
 

{magmascript-3.2.3 → magmascript-3.2.4}/magmascript.egg-info/SOURCES.txt

@@ -87,6 +87,7 @@ tests/test_astheno.py
 tests/test_cache.py
 tests/test_classes.py
 tests/test_cli.py
+tests/test_cli_regressions.py
 tests/test_commands.py
 tests/test_domain_bridge.py
 tests/test_import.py

{magmascript-3.2.3 → magmascript-3.2.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "magmascript"
-version = "3.2.3"
+version = "3.2.4"
 description = "Scripting toolkit with domain-first subcommands"
 readme = "README.md"
 license = "MIT"

{magmascript-3.2.3 → magmascript-3.2.4}/tests/test_cli.py

@@ -5,9 +5,26 @@ from unittest.mock import MagicMock, patch
 
 import pytest
 
+from magmascript import cli
 from magmascript.cli import main
 
 
+@pytest.fixture(autouse=True)
+def fresh_domain_registration():
+    """Register the domains again inside each test.
+
+    Registration binds each domain's client class once, at first use, so the
+    first test to reach it would fix its own patched MCPClient in place for
+    every later test -- test_scoreboards_action then asserts against a mock the
+    handler never calls. This order dependence was hidden while registration
+    never ran at all (3.2.2 and 3.2.3, where these tests failed as "Unknown
+    domain" instead).
+    """
+    cli._DOMAINS_REGISTERED = False
+    yield
+    cli._DOMAINS_REGISTERED = False
+
+
 class TestCLI:
     def test_help_exits(self):
         with pytest.raises(SystemExit) as exc_info:

magmascript-3.2.4/tests/test_cli_regressions.py

@@ -0,0 +1,99 @@
+"""Regression tests for the three faults fixed in 3.2.4.
+
+Each of these shipped. The first two broke the website's bots and CI. The third
+left `archive check-format` blind to the site's "videos" buttons: a label
+missing from its map is not checked at all, so a wrong class there passed.
+"""
+
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from magmascript import cli
+from magmascript.cli import COMMANDS, main
+from magmascript.domains.archive import ArchiveClient
+from magmascript.domains.scores.tools import PlayerStats, ScoresReport
+
+
+class TestDomainRegistration:
+    """3.2.2 and 3.2.3: every domain command was "Unknown domain".
+
+    Registration ran only `if not COMMANDS`, and the built-in commands had
+    started registering themselves at import, so the table was never empty.
+    """
+
+    def test_builtins_are_registered_at_import(self):
+        # The precondition that exposed the bug. If this stops holding, the
+        # test below no longer exercises it.
+        assert "run" in COMMANDS
+
+    @pytest.mark.parametrize("domain", ["archive", "mb", "lastfm", "scores", "search"])
+    def test_domain_commands_are_reachable(self, domain, capsys):
+        with patch("sys.argv", ["magmascript", domain, "--help"]):
+            try:
+                main()
+            except SystemExit:
+                pass
+        assert "Unknown domain" not in capsys.readouterr().err
+        assert domain in COMMANDS
+        assert cli._DOMAINS_REGISTERED
+
+
+class TestScoresReportPostDiscussion:
+    """Every release: `scores report --post-discussion` raised NameError.
+
+    cli.py called datetime.now() without importing datetime, so the report
+    printed and the Discussion was never posted.
+    """
+
+    def test_posts_with_a_dated_title(self, capsys):
+        client = MagicMock()
+        client.report.return_value = ScoresReport(
+            generated_at="September 16, 2026",
+            total_games=0,
+            total_scores=0,
+            scoreboards=[],
+            player_stats=[PlayerStats(name="JAM", total_entries=1, games_played=1)],
+        )
+        gh = MagicMock()
+        gh.create_discussion.return_value = "https://example.invalid/discussions/1"
+
+        with patch("magmascript.core.config.get_config"), \
+             patch("magmascript.domains.gh.GHClient", return_value=gh):
+            cli._dispatch_scores("report", ["--post-discussion"], client, "table")
+
+        title, body, category = gh.create_discussion.call_args.args
+        assert title.startswith("Weekly High Scores — 20")
+        assert "# Weekly High Scores" in body
+        assert category == "high-scores"
+        gh.close.assert_called_once()
+
+
+class TestArchiveVideosLabel:
+    """The site renamed the artist "music videos" pages to "videos" (website
+    53dc9606). With the old map, "videos" was not a known label, so the checker
+    skipped those buttons -- 34 of them on the site at the time -- and the
+    mismatch below went unreported."""
+
+    CSS = ".nav-card.c-videos { color: red; }\n.nav-card.c-music-videos { color: red; }\n"
+
+    def _page(self, tmp_path, cls):
+        artist = tmp_path / "archive" / "by-artist" / "someone"
+        artist.mkdir(parents=True)
+        (artist / "someone-shared.css").write_text(self.CSS, encoding="utf-8")
+        (artist / "about.html").write_text(
+            '<div class="sub-nav">\n'
+            '    <a href="./" class="nav-card c-back">← back</a>\n'
+            f'    <a href="videos.html" class="nav-card {cls}">videos</a>\n'
+            '</div>\n',
+            encoding="utf-8",
+        )
+        return ArchiveClient(project_root=tmp_path)
+
+    def test_videos_link_with_videos_class_is_clean(self, tmp_path):
+        assert self._page(tmp_path, "c-videos").check_format() == []
+
+    def test_videos_link_with_old_class_warns(self, tmp_path):
+        warnings = self._page(tmp_path, "c-music-videos").check_format()
+        assert len(warnings) == 1
+        assert "expected c-videos" in warnings[0].msg