luv-cli 0.6.2__tar.gz → 0.6.3__tar.gz

{luv_cli-0.6.2 → luv_cli-0.6.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: luv-cli
-Version: 0.6.2
+Version: 0.6.3
 Summary: Launch Claude Code or Codex agents on GitHub repos with isolated workspaces and optional Docker dev environments
 Project-URL: Homepage, https://github.com/exospherehost/luv
 Project-URL: Repository, https://github.com/exospherehost/luv

{luv_cli-0.6.2 → luv_cli-0.6.3}/luv/__init__.py

@@ -59,12 +59,14 @@ def die(msg: str) -> None:
 
 
 def run(cmd: list[str], *, cwd: str | None = None, timeout: float | None = None,
-        stdin: int | None = None) -> subprocess.CompletedProcess:
+        stdin: int | None = None,
+        new_session: bool = False) -> subprocess.CompletedProcess:
     """Capture a subprocess. A timeout surfaces as a failure, not an exception,
     so callers keep their plain returncode checks."""
     try:
         return subprocess.run(cmd, capture_output=True, text=True, cwd=cwd,
-                              timeout=timeout, stdin=stdin)
+                              timeout=timeout, stdin=stdin,
+                              start_new_session=new_session)
     except subprocess.TimeoutExpired:
         return subprocess.CompletedProcess(cmd, 124, "", f"timed out after {timeout}s")
 
@@ -773,10 +775,13 @@ def shell_env() -> dict[str, str]:
     code = ("import json,os,sys;"
             f"sys.stdout.write({marker!r} + json.dumps(dict(os.environ)))")
     probe = f"{shlex.quote(sys.executable)} -c {shlex.quote(code)}"
-    # DEVNULL because an interactive shell sharing our tty would fight the
-    # agent for it, and lose to SIGTTOU rather than to the timeout.
+    # A session of its own, so the probe has no controlling tty to touch. An
+    # interactive zsh opens /dev/tty whatever stdin is and makes its own process
+    # group the foreground one, then execs the probe rather than forking it, so
+    # nothing is left to hand the terminal back. luv and the agent it execs would
+    # be in the background, and the agent's first tcsetattr gets SIGTTOU.
     r = run([shell, "-lic", probe], timeout=SHELL_ENV_TIMEOUT,
-            stdin=subprocess.DEVNULL)
+            stdin=subprocess.DEVNULL, new_session=True)
     # Match on the marker, not the exit status: rc files greet, warn, and fail
     # in ways that say nothing about whether the environment came back. What
     # precedes the marker is the greeting; raw_decode drops anything an exit

{luv_cli-0.6.2 → luv_cli-0.6.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "luv-cli"
-version = "0.6.2"
+version = "0.6.3"
 description = "Launch Claude Code or Codex agents on GitHub repos with isolated workspaces and optional Docker dev environments"
 requires-python = ">=3.10"
 license = "MIT"

{luv_cli-0.6.2 → luv_cli-0.6.3}/tests/test_agents.py

@@ -1,7 +1,10 @@
 import contextlib
 import io
 import json
+import os
+import pty
 import re
+import shutil
 import subprocess
 import tempfile
 import time
@@ -880,8 +883,33 @@ class ShellEnvTests(unittest.TestCase):
         self.assertEqual(env, {"API_BASE": "https://x"})
         self.assertEqual(call.args[0][:2], ["/bin/zsh", "-lic"])
         self.assertEqual(call.kwargs["stdin"], subprocess.DEVNULL)
+        self.assertTrue(call.kwargs["new_session"])
         self.assertEqual(call.kwargs["timeout"], luv.SHELL_ENV_TIMEOUT)
 
+    @unittest.skipUnless(shutil.which("zsh"), "needs zsh")
+    def test_probe_leaves_the_terminal_in_the_foreground_of_the_caller(self):
+        # A real zsh on a real pty, because only that shows the failure: zsh
+        # takes the foreground and execs the probe, so the caller, and the agent
+        # it later execs, would be stopped by SIGTTOU on touching the terminal.
+        with tempfile.TemporaryDirectory() as zdotdir:
+            pid, fd = pty.fork()
+            if pid == 0:
+                status = 1
+                try:
+                    with patch.dict(luv.os.environ,
+                                    {"SHELL": "zsh", "ZDOTDIR": zdotdir}):
+                        luv.shell_env()
+                    status = 0 if os.tcgetpgrp(0) == os.getpgrp() else 1
+                finally:
+                    os._exit(status)
+            with contextlib.suppress(OSError):
+                while os.read(fd, 4096):
+                    pass
+            os.close(fd)
+            _, status = os.waitpid(pid, 0)
+
+        self.assertEqual(os.waitstatus_to_exitcode(status), 0)
+
     def test_greeting_before_the_marker_is_ignored(self):
         env, _ = self._probe(_shell_env_output({"A": "1"}, before="welcome back!\n"))