logdetective 1.1.0__tar.gz → 1.2.0__tar.gz

{logdetective-1.1.0 → logdetective-1.2.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: logdetective
-Version: 1.1.0
+Version: 1.2.0
 Summary: Log using LLM AI to search for build/test failures and provide ideas for fixing these.
 License: Apache-2.0
 Author: Jiri Podivin
@@ -35,7 +35,7 @@ Requires-Dist: psycopg2-binary (>=2.9.9,<3.0.0) ; extra == "server-testing"
 Requires-Dist: pydantic (>=2.8.2,<3.0.0)
 Requires-Dist: python-gitlab (>=4.4.0)
 Requires-Dist: pyyaml (>=6.0.1,<7.0.0)
-Requires-Dist: sentry-sdk[fastapi] (>=2.17.0,<3.0.0)
+Requires-Dist: sentry-sdk[fastapi] (>=2.17.0,<3.0.0) ; extra == "server" or extra == "server-testing"
 Requires-Dist: sqlalchemy (>=2.0.36,<3.0.0) ; extra == "server" or extra == "server-testing"
 Project-URL: homepage, https://github.com/fedora-copr/logdetective
 Project-URL: issues, https://github.com/fedora-copr/logdetective/issues
@@ -204,6 +204,9 @@ Make changes to the code as needed and run pre-commit.
 Tests
 -----
 
+Tests for code used by server must placed in the `./tests/server/` path, while tests for general
+code must be in the `./tests/base/` path.
+
 The [tox](https://github.com/tox-dev/tox) is used to manage tests. Please install `tox` package into your distribution and run:
 
     tox
@@ -218,7 +221,17 @@ or
 
     tox run -e lint # to run pylint
 
-To run full test suite you will need postgresql client utilities.
+Tox environments for base and server tests are separate, each installs different dependencies.
+
+Running base tests:
+
+    tox run -e pytest_base
+
+Running server tests:
+
+    tox run -e pytest_server
+
+To run server test suite you will need postgresql client utilities.
 
     dnf install postgresql
 

{logdetective-1.1.0 → logdetective-1.2.0}/README.md

@@ -161,6 +161,9 @@ Make changes to the code as needed and run pre-commit.
 Tests
 -----
 
+Tests for code used by server must placed in the `./tests/server/` path, while tests for general
+code must be in the `./tests/base/` path.
+
 The [tox](https://github.com/tox-dev/tox) is used to manage tests. Please install `tox` package into your distribution and run:
 
     tox
@@ -175,7 +178,17 @@ or
 
     tox run -e lint # to run pylint
 
-To run full test suite you will need postgresql client utilities.
+Tox environments for base and server tests are separate, each installs different dependencies.
+
+Running base tests:
+
+    tox run -e pytest_base
+
+Running server tests:
+
+    tox run -e pytest_server
+
+To run server test suite you will need postgresql client utilities.
 
     dnf install postgresql
 

{logdetective-1.1.0 → logdetective-1.2.0}/logdetective/remote_log.py

@@ -2,7 +2,7 @@ import logging
 from urllib.parse import urlparse
 
 import aiohttp
-from fastapi import HTTPException
+from aiohttp.web import HTTPBadRequest
 
 LOG = logging.getLogger("logdetective")
 
@@ -64,6 +64,6 @@ class RemoteLog:
         try:
             return await self.get_url_content()
         except RuntimeError as ex:
-            raise HTTPException(
-                status_code=400, detail=f"We couldn't obtain the logs: {ex}"
+            raise HTTPBadRequest(
+                reason=f"We couldn't obtain the logs: {ex}"
             ) from ex

{logdetective-1.1.0 → logdetective-1.2.0}/logdetective/server/gitlab.py

@@ -193,9 +193,12 @@ async def retrieve_and_preprocess_koji_logs(
             # may be presented only at the top level.
             # The paths look like `kojilogs/noarch-XXXXXX/task_failed.log`
             # or `kojilogs/noarch-XXXXXX/x86_64-XXXXXX/task_failed.log`
+            # We prefix "toplevel" with '~' so that later when we sort the
+            # keys to see if there are any unrecognized arches, it will always
+            # sort last.
             path = PurePath(zipinfo.filename)
             if len(path.parts) <= 3:
-                failed_arches["toplevel"] = path
+                failed_arches["~toplevel"] = path
                 continue
 
             # Extract the architecture from the immediate parent path
@@ -246,12 +249,11 @@ async def retrieve_and_preprocess_koji_logs(
     elif "noarch" in failed_arches:
         # May have failed during BuildSRPMFromSCM phase
         failed_arch = "noarch"
-    elif "toplevel" in failed_arches:
-        # Probably a Koji-specific error, not a build error
-        failed_arch = "toplevel"
     else:
         # We have one or more architectures that we don't know about? Just
-        # pick the first alphabetically.
+        # pick the first alphabetically. If the issue was a Koji error
+        # rather than a build failure, this will fall back to ~toplevel as
+        # the lowest-sorting possibility.
         failed_arch = sorted(list(failed_arches.keys()))[0]
 
     LOG.debug("Failed architecture: %s", failed_arch)

{logdetective-1.1.0 → logdetective-1.2.0}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "logdetective"
-version = "1.1.0"
+version = "1.2.0"
 description = "Log using LLM AI to search for build/test failures and provide ideas for fixing these."
 authors = ["Jiri Podivin <jpodivin@gmail.com>"]
 license = "Apache-2.0"
@@ -51,11 +51,11 @@ psycopg2 = {version = "^2.9.9", optional = true }
 alembic = {version = "^1.13.3", optional = true }
 matplotlib = {version = "^3.8.4", optional = true }
 backoff = {version = "2.2.1", optional = true }
-sentry-sdk = {version = "^2.17.0", extras = ["fastapi"]}
+sentry-sdk = {version = "^2.17.0", optional = true, extras = ["fastapi"]}
 
 [tool.poetry.extras]
-server = ["fastapi", "sqlalchemy", "psycopg2", "alembic", "matplotlib", "backoff", "aiolimiter"]
-server-testing = ["fastapi", "sqlalchemy", "psycopg2-binary", "alembic", "matplotlib", "backoff", "pytest-asyncio"]
+server = ["fastapi", "sqlalchemy", "psycopg2", "alembic", "matplotlib", "backoff", "aiolimiter", "sentry-sdk"]
+server-testing = ["fastapi", "sqlalchemy", "psycopg2-binary", "alembic", "matplotlib", "backoff", "pytest-asyncio", "sentry-sdk"]
 
 [build-system]
 requires = ["poetry-core"]