localcode 0.3.37__tar.gz → 0.3.39__tar.gz

{localcode-0.3.37/src/localcode.egg-info → localcode-0.3.39}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: localcode
-Version: 0.3.37
+Version: 0.3.39
 Summary: High-performance AI coding on consumer hardware.
 Author: LocalCode contributors
 License-Expression: Apache-2.0
@@ -121,7 +121,6 @@ LocalCode is early software. Hardware support is expected to broaden, but only t
 | M4 MacBook | 16 GB | Tested | Validated at the 16 GB floor |
 | M1/M2/M3 Apple Silicon | 16 GB+ | Not yet tested | Expected to work, but needs validation |
 | M4 Apple Silicon | 24 GB+ | Not yet tested | Expected to support larger contexts, but needs validation |
-| Intel Mac | Any | Not supported | LocalCode targets Apple Silicon |
 
 > Linux installs and runs in CI for development, but Apple Silicon is the
 > supported target — the Metal-accelerated inference path is Mac-only.

{localcode-0.3.37 → localcode-0.3.39}/README.md

@@ -74,7 +74,6 @@ LocalCode is early software. Hardware support is expected to broaden, but only t
 | M4 MacBook | 16 GB | Tested | Validated at the 16 GB floor |
 | M1/M2/M3 Apple Silicon | 16 GB+ | Not yet tested | Expected to work, but needs validation |
 | M4 Apple Silicon | 24 GB+ | Not yet tested | Expected to support larger contexts, but needs validation |
-| Intel Mac | Any | Not supported | LocalCode targets Apple Silicon |
 
 > Linux installs and runs in CI for development, but Apple Silicon is the
 > supported target — the Metal-accelerated inference path is Mac-only.

{localcode-0.3.37 → localcode-0.3.39}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "localcode"
-version = "0.3.37"
+version = "0.3.39"
 description = "High-performance AI coding on consumer hardware."
 readme = "README.md"
 requires-python = ">=3.10"

{localcode-0.3.37 → localcode-0.3.39}/src/localcode/__init__.py

@@ -8,4 +8,4 @@ from importlib.metadata import PackageNotFoundError, version as _pkg_version
 try:
     __version__ = _pkg_version("localcode")
 except PackageNotFoundError:  # not installed (e.g. raw source checkout)
-    __version__ = "0.3.37"
+    __version__ = "0.3.39"

{localcode-0.3.37 → localcode-0.3.39}/src/localcode/agent/turn_finalization.py

@@ -123,6 +123,7 @@ def finalize_turn(
         app._last_turn_task_status = task_status
         app._last_turn_task_stage = final_task_stage
         app._last_turn_blocked_reason = blocked_reason
+        app._last_turn_loop_exit_reason = loop_exit_reason
         app._last_turn_goal = goal_state.as_dict()
     except Exception as exc:
         _emit_finalization_error(turn_id, "turn_store_update", exc)

{localcode-0.3.37 → localcode-0.3.39}/src/localcode/headless_json.py

@@ -98,6 +98,25 @@ def _as_int(value: Any) -> int:
         return 0
 
 
+def _terminal_from_status(
+    *, completion_status: str, blocked_reason: str, loop_exit_reason: str,
+    final_text: str = "",
+) -> tuple[str, int, str, str]:
+    """Map the loop's persisted turn status to a headless (status, exit, reason).
+
+    A completion_status of `completed` (the only success value from
+    `status_for_exit`) exits 0/`ok`; any other non-empty status (blocked,
+    interrupted, stopped_early, error, incomplete) exits 1/`incomplete`. An
+    unset status falls through to `ok` so a run that never populated it isn't
+    reported as a false failure.
+    """
+    completion = (completion_status or "").strip()
+    reason = (blocked_reason or loop_exit_reason or "completed").strip() or "completed"
+    if completion and completion != "completed":
+        return "incomplete", 1, reason, final_text or ""
+    return "ok", 0, reason, final_text or ""
+
+
 def run_headless_json(config, args) -> int:
     """Headless run that emits the agent event stream as JSONL on stdout.
 
@@ -202,12 +221,17 @@ def run_headless_json(config, args) -> int:
         except Exception:
             pass
 
-    turn_end = emitter.last_turn_end
-    completion = str(turn_end.get("completion_status") or "")
-    reason = str(turn_end.get("loop_exit_reason") or "completed")
-    if completion and completion != "completed":
-        return _emit_result("incomplete", 1, reason, result_text or "")
-    return _emit_result("ok", 0, reason, result_text or "")
+    # `turn_end` is emitted to the events file, not through the OutputManager
+    # callback, so `emitter.last_turn_end` is always empty and can't drive the
+    # exit code. Read the status the loop persisted on the app instead
+    # (finalize_turn sets these `_last_turn_*` attrs every turn).
+    status, code, reason, text = _terminal_from_status(
+        completion_status=str(getattr(app, "_last_turn_completion_status", "") or ""),
+        blocked_reason=str(getattr(app, "_last_turn_blocked_reason", "") or ""),
+        loop_exit_reason=str(getattr(app, "_last_turn_loop_exit_reason", "") or ""),
+        final_text=result_text or "",
+    )
+    return _emit_result(status, code, reason, text)
 
 
 def open_clean_stdout() -> TextIO:

{localcode-0.3.37 → localcode-0.3.39}/src/localcode/protocol/outcomes.py

@@ -152,8 +152,10 @@ def outcome_from_parse(parsed: ParseResult) -> RunOutcome:
     result carrying an error status counts toward `tool_failures`.
     """
     terminal = parsed.terminal
-    status = str(terminal.get("status") if terminal else "") or ""
-    reason = str(terminal.get("reason") if terminal else "") or ""
+    # Coalesce a missing/None field to "" BEFORE str(), otherwise str(None)
+    # yields the literal "None" (truthy, so a trailing `or ""` can't rescue it).
+    status = str(terminal.get("status") or "") if terminal else ""
+    reason = str(terminal.get("reason") or "") if terminal else ""
 
     # A protocol violation (missing/duplicate terminal) is itself a category —
     # the stream can't be trusted, so we don't pretend to know the LocalCode
@@ -190,7 +192,7 @@ def outcome_from_parse(parsed: ParseResult) -> RunOutcome:
         status=status,
         category=category,
         raw_reason=reason,
-        final_text=str(terminal.get("final_text") if terminal else "") or "",
+        final_text=str(terminal.get("final_text") or "") if terminal else "",
         prompt_tokens=prompt,
         completion_tokens=completion,
         total_tokens=total,

{localcode-0.3.37 → localcode-0.3.39}/src/localcode/tools/glob_tool.py

@@ -28,10 +28,13 @@ def execute(ctx: ToolContext, args: dict) -> str:
         key=lambda f: f.stat().st_mtime if f.exists() else 0,
         reverse=True,
     )
+    # Exclude noise dirs BEFORE truncating — otherwise a repo whose 100 newest
+    # matches are dominated by node_modules/.venv would hide real source files
+    # that sort just past the cut.
     results = [
-        str(m.relative_to(repo)) for m in matches[:100]
+        str(m.relative_to(repo)) for m in matches
         if not any(p in str(m) for p in (".git", "__pycache__", "node_modules", ".venv"))
-    ]
+    ][:100]
     return "\n".join(results) or "No matches"
 
 

{localcode-0.3.37 → localcode-0.3.39}/src/localcode/tui/screens/chat.py

@@ -4008,6 +4008,14 @@ class ChatScreen(Screen):
             # was still running ask() — two agent loops mutating one session.
             if event.worker.name == "run_agent_turn":
                 self._on_turn_done()
+        elif event.state == WorkerState.CANCELLED:
+            # Esc-to-interrupt cancels the worker (`_interrupt_turn` calls
+            # `w.cancel()`), so a cancelled agent turn lands here — NOT in the
+            # SUCCESS branch. Without this the turn never finalizes: the
+            # `◆ thinking…` indicator keeps animating and `_agent_busy` stays
+            # True (input wedged) after a cancel. Mirror the SUCCESS/ERROR cleanup.
+            if event.worker.name == "run_agent_turn":
+                self._on_turn_done()
 
     def _recover_stuck_state(self) -> None:
         """Clear blocking flags after a worker crash so the UI can't wedge.

{localcode-0.3.37 → localcode-0.3.39/src/localcode.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: localcode
-Version: 0.3.37
+Version: 0.3.39
 Summary: High-performance AI coding on consumer hardware.
 Author: LocalCode contributors
 License-Expression: Apache-2.0
@@ -121,7 +121,6 @@ LocalCode is early software. Hardware support is expected to broaden, but only t
 | M4 MacBook | 16 GB | Tested | Validated at the 16 GB floor |
 | M1/M2/M3 Apple Silicon | 16 GB+ | Not yet tested | Expected to work, but needs validation |
 | M4 Apple Silicon | 24 GB+ | Not yet tested | Expected to support larger contexts, but needs validation |
-| Intel Mac | Any | Not supported | LocalCode targets Apple Silicon |
 
 > Linux installs and runs in CI for development, but Apple Silicon is the
 > supported target — the Metal-accelerated inference path is Mac-only.

{localcode-0.3.37 → localcode-0.3.39}/src/localcode.egg-info/SOURCES.txt

@@ -929,6 +929,7 @@ tests/test_agent_state_machine.py
 tests/test_anchor_guard.py
 tests/test_architecture.py
 tests/test_bootstrap.py
+tests/test_chat_worker_cancel.py
 tests/test_checkpoint.py
 tests/test_churn_detection.py
 tests/test_clipboard_image.py

localcode-0.3.39/tests/test_chat_worker_cancel.py

@@ -0,0 +1,37 @@
+"""Regression: an Esc-interrupted (cancelled) agent turn must finalize.
+
+_interrupt_turn calls `worker.cancel()`, so the run_agent_turn worker lands in
+WorkerState.CANCELLED — not SUCCESS. Before the fix, on_worker_state_changed
+handled only SUCCESS/ERROR, so a cancel left the thinking indicator animating
+and `_agent_busy` stuck True (input wedged). The CANCELLED branch must call
+_on_turn_done() for the agent-turn worker (and only that worker).
+"""
+from __future__ import annotations
+
+import types
+
+from textual.worker import WorkerState
+
+from localcode.tui.screens.chat import ChatScreen
+
+
+def _event(state, name):
+    return types.SimpleNamespace(
+        state=state,
+        worker=types.SimpleNamespace(name=name, error=None),
+    )
+
+
+def test_cancelled_agent_turn_calls_on_turn_done():
+    calls = {"done": 0}
+    fake = types.SimpleNamespace(_on_turn_done=lambda: calls.__setitem__("done", calls["done"] + 1))
+    ChatScreen.on_worker_state_changed(fake, _event(WorkerState.CANCELLED, "run_agent_turn"))
+    assert calls["done"] == 1
+
+
+def test_cancelled_non_agent_worker_does_not_finalize_turn():
+    calls = {"done": 0}
+    fake = types.SimpleNamespace(_on_turn_done=lambda: calls.__setitem__("done", calls["done"] + 1))
+    # a cancelled helper worker (e.g. a model-swap probe) must not end the turn
+    ChatScreen.on_worker_state_changed(fake, _event(WorkerState.CANCELLED, "some_helper"))
+    assert calls["done"] == 0

{localcode-0.3.37 → localcode-0.3.39}/tests/test_protocol.py

@@ -171,3 +171,25 @@ def test_redact_masks_secret_fields_recursively():
     assert red["servers"][0]["url"] == "http://x"
     # input not mutated
     assert cfg["api_key"] == "sk-live-xxx"
+
+
+# ── regression: missing terminal fields must be "", never "None" ─────
+
+def test_missing_terminal_fields_are_empty_not_none_string():
+    """A result event may omit optional fields (final_text especially). The
+    normalized outcome must surface "" for a missing field, never the literal
+    string "None" — regression: str(None) is truthy, so a trailing `or ""`
+    could not rescue it."""
+    # final_text omitted (the common case — it's optional)
+    out = outcome_from_parse(parse_stream(
+        ['{"type":"result","status":"ok","reason":"completed"}']))
+    assert out.final_text == ""
+    # status omitted entirely
+    out2 = outcome_from_parse(parse_stream(
+        ['{"type":"result","reason":"completed"}']))
+    assert out2.status == ""
+    assert out2.raw_reason == "completed"
+    # present values still pass through untouched
+    out3 = outcome_from_parse(parse_stream(
+        ['{"type":"result","status":"ok","reason":"completed","final_text":"hi"}']))
+    assert out3.final_text == "hi"

{localcode-0.3.37 → localcode-0.3.39}/tests/test_run_json.py

@@ -196,3 +196,23 @@ def test_emitter_accumulates_tokens():
     lines = [json.loads(l) for l in buf.getvalue().splitlines() if l.strip()]
     result = lines[-1]
     assert result["tokens"] == {"prompt": 13, "completion": 7, "total": 20}
+
+
+def test_terminal_from_status_maps_failure_to_nonzero_exit():
+    """Regression: headless exit code must reflect the loop's real completion
+    status. Previously it read the always-empty `emitter.last_turn_end`, so a
+    stalled/blocked/errored run still reported ('ok', 0)."""
+    from localcode.headless_json import _terminal_from_status as T
+    # the only success value from status_for_exit
+    assert T(completion_status="completed", blocked_reason="",
+             loop_exit_reason="model_done")[:2] == ("ok", 0)
+    # a stalled run must NOT report success
+    assert T(completion_status="incomplete", blocked_reason="",
+             loop_exit_reason="stall_exhausted")[:2] == ("incomplete", 1)
+    # blocked-on-user-input: non-zero exit, reason carries the blocked text
+    s, code, reason, _ = T(completion_status="blocked_user_input",
+                           blocked_reason="need creds",
+                           loop_exit_reason="blocked_question")
+    assert (s, code) == ("incomplete", 1) and reason == "need creds"
+    # an unpopulated status is not a false failure
+    assert T(completion_status="", blocked_reason="", loop_exit_reason="")[:2] == ("ok", 0)

{localcode-0.3.37 → localcode-0.3.39}/tests/test_toolkit.py

@@ -411,3 +411,18 @@ class TestMCPTransportConfig:
                                                 "url": "https://x"})
         with pytest.raises(RuntimeError):
             cli._make_transport()
+
+
+def test_glob_excludes_noise_before_truncating(tmp_path):
+    """Regression: the noise-dir exclusion must run BEFORE the 100-item cut,
+    or a repo whose newest 100 matches are node_modules/.venv hides real source."""
+    import types
+    from localcode.tools import glob_tool
+    (tmp_path / "real_module.py").write_text("x = 1\n")          # older mtime
+    nm = tmp_path / "node_modules" / "pkg"
+    nm.mkdir(parents=True)
+    for i in range(120):                                          # newer, would fill first 100
+        (nm / f"f{i}.py").write_text("y\n")
+    out = glob_tool.execute(types.SimpleNamespace(repo=tmp_path), {"pattern": "**/*.py"})
+    assert "real_module.py" in out          # was hidden past the [:100] cut
+    assert "node_modules" not in out        # noise excluded