lintrunner 0.12.4__tar.gz → 0.12.5__tar.gz

{lintrunner-0.12.4 → lintrunner-0.12.5}/.github/workflows/Lint.yml

@@ -57,3 +57,5 @@ jobs:
           sarif_file: lintrunner.sarif
           category: lintrunner
           checkout_path: ${{ github.workspace }}
+      - name: Run Clippy
+        run: cargo clippy -- -D warnings --verbose

{lintrunner-0.12.4 → lintrunner-0.12.5}/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.12.5] - 2024-04-09
+
+### Features
+
+- Add gist/pastry upload to lintrunner rage ([bd224ae](https://github.com/suo/lintrunner/commit/bd224aefdc5144cc85276695cd4fabf170f183a0))
+
 ## [0.12.1] - 2024-02-10
 
 ### Bug Fixes

{lintrunner-0.12.4 → lintrunner-0.12.5}/Cargo.lock

@@ -4,9 +4,9 @@ version = 3
 
 [[package]]
 name = "aho-corasick"
-version = "1.1.2"
+version = "1.1.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b2969dcb958b36655471fc61f7e416fa76033bdd4bfed0678d8fee1e2d07a1f0"
+checksum = "8e60d3430d3a69478ad0993f19238d2df97c507009a52b3c10addcd7f6bcb916"
 dependencies = [
  "memchr",
 ]
@@ -87,9 +87,9 @@ dependencies = [
 
 [[package]]
 name = "autocfg"
-version = "1.1.0"
+version = "1.2.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d468802bab17cbc0cc575e9b053f41e72aa36bfa6b7f55e3529ffa43161b97fa"
+checksum = "f1fdabc7756949593fe60f30ec81974b613357de856987752631dea1e3394c80"
 
 [[package]]
 name = "bitflags"
@@ -138,9 +138,9 @@ dependencies = [
 
 [[package]]
 name = "bumpalo"
-version = "3.15.4"
+version = "3.16.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7ff69b9dd49fd426c69a0db9fc04dd934cdb6645ff000864d98f7e2af8830eaa"
+checksum = "79296716171880943b8470b5f8d03aa55eb2e645a4874bdbb28adb49162e012c"
 
 [[package]]
 name = "bytemuck"
@@ -150,9 +150,9 @@ checksum = "5d6d68c57235a3a081186990eca2867354726650f42f7516ca50c28d6281fd15"
 
 [[package]]
 name = "cc"
-version = "1.0.90"
+version = "1.0.92"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8cd6604a82acf3039f1144f54b8eb34e91ffba622051189e71b781822d5ee1f5"
+checksum = "2678b2e3449475e95b0aa6f9b506a28e61b3dc8996592b983695e8ebb58a8b41"
 
 [[package]]
 name = "cfg-if"
@@ -162,9 +162,9 @@ checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd"
 
 [[package]]
 name = "chrono"
-version = "0.4.35"
+version = "0.4.37"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8eaf5903dcbc0a39312feb77df2ff4c76387d591b9fc7b04a238dcf8bb62639a"
+checksum = "8a0d04d43504c61aa6c7531f1871dd0d418d91130162063b789da00fd7057a5e"
 dependencies = [
  "android-tzdata",
  "iana-time-zone",
@@ -352,9 +352,9 @@ dependencies = [
 
 [[package]]
 name = "fastrand"
-version = "2.0.1"
+version = "2.0.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "25cbce373ec4653f1a01a31e8a5e5ec0c622dc27ff9c4e6606eefef5cbbed4a5"
+checksum = "658bd65b1cf4c852a3cc96f18a8ce7b5640f6b703f905c7d74532294c2a63984"
 
 [[package]]
 name = "fern"
@@ -392,9 +392,9 @@ dependencies = [
 
 [[package]]
 name = "getrandom"
-version = "0.2.12"
+version = "0.2.14"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "190092ea657667030ac6a35e305e62fc4dd69fd98ac98631e5d3a2b1575a12b5"
+checksum = "94b22e06ecb0110981051723910cbf0b5f5e09a2062dd7663334ee79a9d1286c"
 dependencies = [
  "cfg-if",
  "libc",
@@ -475,9 +475,9 @@ dependencies = [
 
 [[package]]
 name = "indexmap"
-version = "2.2.5"
+version = "2.2.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7b0b929d511467233429c45a44ac1dcaa21ba0f5ba11e4879e6ed28ddb4f9df4"
+checksum = "168fb715dda47215e360912c096649d23d58bf392ac62f73919e831745e40f26"
 dependencies = [
  "equivalent",
  "hashbrown 0.14.3",
@@ -503,9 +503,9 @@ checksum = "c8fae54786f62fb2918dcfae3d568594e50eb9b5c25bf04371af6fe7516452fb"
 
 [[package]]
 name = "insta"
-version = "1.36.1"
+version = "1.38.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0a7c22c4d34ef4788c351e971c52bfdfe7ea2766f8c5466bc175dd46e52ac22e"
+checksum = "3eab73f58e59ca6526037208f0e98851159ec1633cf17b6cd2e1f2c3fd5d53cc"
 dependencies = [
  "console",
  "lazy_static",
@@ -514,7 +514,6 @@ dependencies = [
  "pest_derive",
  "serde",
  "similar",
- "yaml-rust",
 ]
 
 [[package]]
@@ -539,9 +538,9 @@ dependencies = [
 
 [[package]]
 name = "itoa"
-version = "1.0.10"
+version = "1.0.11"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b1a46d1a171d865aa5f83f92695765caa047a9b4cbae2cbf37dbd613a793fd4c"
+checksum = "49f1f14873335454500d59611f1cf4a4b0f786f9ac11f4312a78e4cf2566695b"
 
 [[package]]
 name = "js-sys"
@@ -566,13 +565,12 @@ checksum = "9c198f91728a82281a64e1f4f9eeb25d82cb32a5de251c6bd1b5154d63a8e7bd"
 
 [[package]]
 name = "libredox"
-version = "0.0.1"
+version = "0.1.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "85c833ca1e66078851dba29046874e38f08b2c883700aa29a03ddd3b23814ee8"
+checksum = "c0ff37bd590ca25063e35af745c343cb7a0271906fb7b37e4813e8f79f00268d"
 dependencies = [
  "bitflags 2.5.0",
  "libc",
- "redox_syscall",
 ]
 
 [[package]]
@@ -583,7 +581,7 @@ checksum = "0717cef1bc8b636c6e1c1bbdefc09e6322da8a9321966e8928ef80d20f7f770f"
 
 [[package]]
 name = "lintrunner"
-version = "0.12.4"
+version = "0.12.5"
 dependencies = [
  "anyhow",
  "assert_cmd",
@@ -625,9 +623,9 @@ checksum = "90ed8c1e510134f979dbc4f070f87d4313098b704861a105fe34231c70a3901c"
 
 [[package]]
 name = "memchr"
-version = "2.7.1"
+version = "2.7.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "523dc4f511e55ab87b694dc30d0f820d60906ef06413f93d4d7a1385599cc149"
+checksum = "6c8640c5d730cb13ebd907d8d04b52f55ac9a2eec55b440c8892f40d56c76c1d"
 
 [[package]]
 name = "num-traits"
@@ -658,9 +656,9 @@ checksum = "e2355d85b9a3786f481747ced0e0ff2ba35213a1f9bd406ed906554d7af805a1"
 
 [[package]]
 name = "pear"
-version = "0.2.8"
+version = "0.2.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4ccca0f6c17acc81df8e242ed473ec144cbf5c98037e69aa6d144780aad103c8"
+checksum = "bdeeaa00ce488657faba8ebf44ab9361f9365a97bd39ffb8a60663f57ff4b467"
 dependencies = [
  "inlinable_string",
  "pear_codegen",
@@ -669,21 +667,21 @@ dependencies = [
 
 [[package]]
 name = "pear_codegen"
-version = "0.2.8"
+version = "0.2.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2e22670e8eb757cff11d6c199ca7b987f352f0346e0be4dd23869ec72cb53c77"
+checksum = "4bab5b985dc082b345f812b7df84e1bef27e7207b39e448439ba8bd69c93f147"
 dependencies = [
  "proc-macro2",
  "proc-macro2-diagnostics",
  "quote",
- "syn 2.0.53",
+ "syn 2.0.58",
 ]
 
 [[package]]
 name = "pest"
-version = "2.7.8"
+version = "2.7.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "56f8023d0fb78c8e03784ea1c7f3fa36e68a723138990b8d5a47d916b651e7a8"
+checksum = "311fb059dee1a7b802f036316d790138c613a4e8b180c822e3925a662e9f0c95"
 dependencies = [
  "memchr",
  "thiserror",
@@ -692,9 +690,9 @@ dependencies = [
 
 [[package]]
 name = "pest_derive"
-version = "2.7.8"
+version = "2.7.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b0d24f72393fd16ab6ac5738bc33cdb6a9aa73f8b902e8fe29cf4e67d7dd1026"
+checksum = "f73541b156d32197eecda1a4014d7f868fd2bcb3c550d5386087cfba442bf69c"
 dependencies = [
  "pest",
  "pest_generator",
@@ -702,22 +700,22 @@ dependencies = [
 
 [[package]]
 name = "pest_generator"
-version = "2.7.8"
+version = "2.7.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "fdc17e2a6c7d0a492f0158d7a4bd66cc17280308bbaff78d5bef566dca35ab80"
+checksum = "c35eeed0a3fab112f75165fdc026b3913f4183133f19b49be773ac9ea966e8bd"
 dependencies = [
  "pest",
  "pest_meta",
  "proc-macro2",
  "quote",
- "syn 2.0.53",
+ "syn 2.0.58",
 ]
 
 [[package]]
 name = "pest_meta"
-version = "2.7.8"
+version = "2.7.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "934cd7631c050f4674352a6e835d5f6711ffbfb9345c2fc0107155ac495ae293"
+checksum = "2adbf29bb9776f28caece835398781ab24435585fe0d4dc1374a61db5accedca"
 dependencies = [
  "once_cell",
  "pest",
@@ -792,7 +790,7 @@ checksum = "af066a9c399a26e020ada66a034357a868728e72cd426f3adcd35f80d88d88c8"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.53",
+ "syn 2.0.58",
  "version_check",
  "yansi",
 ]
@@ -806,20 +804,11 @@ dependencies = [
  "proc-macro2",
 ]
 
-[[package]]
-name = "redox_syscall"
-version = "0.4.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4722d768eff46b75989dd134e5c353f0d6296e5aaa3132e776cbdb56be7731aa"
-dependencies = [
- "bitflags 1.3.2",
-]
-
 [[package]]
 name = "redox_users"
-version = "0.4.4"
+version = "0.4.5"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a18479200779601e498ada4e8c1e1f50e3ee19deb0259c25825a98b5603b2cb4"
+checksum = "bd283d9651eeda4b2a83a43c1c91b266c40fd76ecd39a50a8c630ae69dc72891"
 dependencies = [
  "getrandom",
  "libredox",
@@ -828,9 +817,9 @@ dependencies = [
 
 [[package]]
 name = "regex"
-version = "1.10.3"
+version = "1.10.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b62dbe01f0b06f9d8dc7d49e05a0785f153b00b2c227856282f671e0318c9b15"
+checksum = "c117dbdfde9c8308975b6a18d71f3f385c89461f7b3fb054288ecf2a2058ba4c"
 dependencies = [
  "aho-corasick",
  "memchr",
@@ -851,15 +840,15 @@ dependencies = [
 
 [[package]]
 name = "regex-syntax"
-version = "0.8.2"
+version = "0.8.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c08c74e62047bb2de4ff487b251e4a92e24f48745648451635cec7d591162d9f"
+checksum = "adad44e29e4c806119491a7f06f03de4d1af22c3a680dd47f1e6e179439d1f56"
 
 [[package]]
 name = "rustix"
-version = "0.38.31"
+version = "0.38.32"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6ea3e1a662af26cd7a3ba09c0297a31af215563ecf42817c98df621387f4e949"
+checksum = "65e04861e65f21776e67888bfbea442b3642beaa0138fdb1dd7a84a52dffdb89"
 dependencies = [
  "bitflags 2.5.0",
  "errno",
@@ -891,14 +880,14 @@ checksum = "7eb0b34b42edc17f6b7cac84a52a1c5f0e1bb2227e997ca9011ea3dd34e8610b"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.53",
+ "syn 2.0.58",
 ]
 
 [[package]]
 name = "serde_json"
-version = "1.0.114"
+version = "1.0.115"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c5f09b1bd632ef549eaa9f60a1f8de742bdbc698e6cee2095fc84dde5f549ae0"
+checksum = "12dc5c46daa8e9fdf4f5e71b6cf9a53f2487da0e86e55808e2d35539666497dd"
 dependencies = [
  "itoa",
  "ryu",
@@ -933,9 +922,9 @@ checksum = "24188a676b6ae68c3b2cb3a01be17fbf7240ce009799bb56d5b1409051e78fde"
 
 [[package]]
 name = "similar"
-version = "2.4.0"
+version = "2.5.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "32fea41aca09ee824cc9724996433064c89f7777e60762749a4170a14abbfa21"
+checksum = "fa42c91313f1d05da9b26f267f931cf178d4aba455b4c4622dd7355eb80c6640"
 
 [[package]]
 name = "smawk"
@@ -962,9 +951,9 @@ dependencies = [
 
 [[package]]
 name = "syn"
-version = "2.0.53"
+version = "2.0.58"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7383cd0e49fff4b6b90ca5670bfd3e9d6a733b3f90c686605aa7eec8c4996032"
+checksum = "44cfb93f38070beee36b3fef7d4f5a16f27751d94b187b666a5cc5e9b0d30687"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -1043,7 +1032,7 @@ checksum = "c61f3ba182994efc43764a46c018c347bc492c79f024e705f46567b418f6d4f7"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.53",
+ "syn 2.0.58",
 ]
 
 [[package]]
@@ -1078,11 +1067,11 @@ dependencies = [
 
 [[package]]
 name = "toml_edit"
-version = "0.22.8"
+version = "0.22.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c12219811e0c1ba077867254e5ad62ee2c9c190b0d957110750ac0cda1ae96cd"
+checksum = "8e40bb779c5187258fd7aad0eb68cb8706a0a81fa712fbea808ab43c4b8374c4"
 dependencies = [
- "indexmap 2.2.5",
+ "indexmap 2.2.6",
  "serde",
  "serde_spanned",
  "toml_datetime",
@@ -1170,7 +1159,7 @@ dependencies = [
  "once_cell",
  "proc-macro2",
  "quote",
- "syn 2.0.53",
+ "syn 2.0.58",
  "wasm-bindgen-shared",
 ]
 
@@ -1192,7 +1181,7 @@ checksum = "e94f17b526d0a461a191c78ea52bbce64071ed5c04c9ffe424dcb38f74171bb7"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.53",
+ "syn 2.0.58",
  "wasm-bindgen-backend",
  "wasm-bindgen-shared",
 ]
@@ -1318,15 +1307,6 @@ dependencies = [
  "memchr",
 ]
 
-[[package]]
-name = "yaml-rust"
-version = "0.4.5"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "56c1936c4cc7a1c9ab21a1ebb602eb942ba868cbd44a99cb7cdc5892335e1c85"
-dependencies = [
- "linked-hash-map",
-]
-
 [[package]]
 name = "yansi"
 version = "1.0.1"

{lintrunner-0.12.4 → lintrunner-0.12.5}/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "lintrunner"
-version = "0.12.4"
+version = "0.12.5"
 authors = ["Michael Suo <suo@fb.com>"]
 edition = "2021"
 description = "A lint running tool and framework."

{lintrunner-0.12.4 → lintrunner-0.12.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: lintrunner
-Version: 0.12.4
+Version: 0.12.5
 Classifier: Programming Language :: Rust
 Classifier: Programming Language :: Python :: Implementation :: CPython
 Classifier: Programming Language :: Python :: Implementation :: PyPy

{lintrunner-0.12.4 → lintrunner-0.12.5}/src/git.rs

@@ -361,7 +361,7 @@ mod tests {
     }
 
     #[test]
-    fn invalid_get_paths_from_cmd_fails() -> () {
+    fn invalid_get_paths_from_cmd_fails() {
         assert!(get_paths_from_cmd("asoidjfoaisdjf").is_err());
         assert!(get_paths_from_cmd("false").is_err());
     }

{lintrunner-0.12.4 → lintrunner-0.12.5}/src/lib.rs

@@ -42,9 +42,7 @@ fn group_lints_by_file(
     lints: Vec<LintMessage>,
 ) {
     lints.into_iter().fold(all_lints, |acc, lint| {
-        acc.entry(lint.path.clone())
-            .or_insert_with(Vec::new)
-            .push(lint);
+        acc.entry(lint.path.clone()).or_default().push(lint);
         acc
     });
 }
@@ -160,6 +158,7 @@ pub fn get_version_control() -> Result<Box<dyn VersionControl>> {
     Ok(Box::new(sapling::Repo::new()?))
 }
 
+#[allow(clippy::too_many_arguments)]
 pub fn do_lint(
     linters: Vec<Linter>,
     paths_opt: PathsOpt,
@@ -207,10 +206,7 @@ pub fn do_lint(
 
     // Sort and unique the files so we pass a consistent ordering to linters
     if let Some(config_dir) = config_dir {
-        files = files
-            .into_iter()
-            .filter(|path| path.starts_with(&config_dir))
-            .collect();
+        files.retain(|path| path.starts_with(&config_dir));
     }
     files.sort();
     files.dedup();

{lintrunner-0.12.4 → lintrunner-0.12.5}/src/main.rs

@@ -141,6 +141,12 @@ enum SubCommand {
         /// Choose a specific invocation to report on. 0 is the most recent run.
         #[clap(long, short)]
         invocation: Option<usize>,
+        /// Set to upload the report to github gist (if available)
+        #[clap(long, short, action)]
+        gist: bool,
+        /// Set to upload the report to pastry (if available)
+        #[clap(long, short, action)]
+        pastry: bool,
     },
 }
 
@@ -172,7 +178,7 @@ fn do_main() -> Result<i32> {
     // clone split by commas and trim whitespace
     let config_paths: Vec<String> = args
         .configs
-        .split(",")
+        .split(',')
         .map(|path| path.trim().to_string())
         .collect_vec();
     // check if first config path exists
@@ -315,7 +321,11 @@ fn do_main() -> Result<i32> {
                 only_lint_under_config_dir,
             )
         }
-        SubCommand::Rage { invocation } => do_rage(&persistent_data_store, invocation),
+        SubCommand::Rage {
+            invocation,
+            gist,
+            pastry,
+        } => do_rage(&persistent_data_store, invocation, gist, pastry),
         SubCommand::List => {
             println!("Available linters:");
             for linter in &lint_runner_config.linters {

{lintrunner-0.12.4 → lintrunner-0.12.5}/src/path.rs

@@ -109,8 +109,8 @@ pub fn path_relative_from(path: &Path, base: &Path) -> Option<PathBuf> {
                 }
                 (None, _) => comps.push(Component::ParentDir),
                 (Some(a), Some(b)) if comps.is_empty() && a == b => (),
-                (Some(a), Some(b)) if b == Component::CurDir => comps.push(a),
-                (Some(_), Some(b)) if b == Component::ParentDir => return None,
+                (Some(a), Some(Component::CurDir)) => comps.push(a),
+                (Some(_), Some(Component::ParentDir)) => return None,
                 (Some(a), Some(_)) => {
                     comps.push(Component::ParentDir);
                     for _ in itb {

{lintrunner-0.12.4 → lintrunner-0.12.5}/src/persistent_data.rs

@@ -72,7 +72,7 @@ impl PersistentDataStore {
         let runs_dir = config_data_dir.join(RUNS_DIR_NAME);
         let cur_run_dir = runs_dir.join(cur_run_info.dir_name());
 
-        std::fs::create_dir_all(&cur_run_dir)?;
+        std::fs::create_dir_all(cur_run_dir)?;
 
         PersistentDataStore::clean_old_runs(&runs_dir)?;
 
@@ -116,10 +116,10 @@ impl PersistentDataStore {
             std::fs::create_dir(&run_path)?;
         }
         let run_info = serde_json::to_string_pretty(&self.cur_run_info)?;
-        std::fs::write(&run_path.join("run_info.json"), &run_info)?;
+        std::fs::write(run_path.join("run_info.json"), run_info)?;
 
         let exit_info = serde_json::to_string_pretty(&exit_info)?;
-        std::fs::write(&run_path.join("exit_info.json"), exit_info)?;
+        std::fs::write(run_path.join("exit_info.json"), exit_info)?;
         Ok(())
     }
 
@@ -257,7 +257,7 @@ impl PersistentDataStore {
         let config_contents = config_contents.extract::<LintRunnerConfig>()?;
         let path = self.relative_path(CONFIG_DATA_NAME);
         let serialized_contents = serde_json::to_string_pretty(&config_contents)?;
-        std::fs::write(path, &serialized_contents)?;
+        std::fs::write(path, serialized_contents)?;
         Ok(())
     }
 

{lintrunner-0.12.4 → lintrunner-0.12.5}/src/rage.rs

@@ -2,6 +2,9 @@ use crate::persistent_data::{PersistentDataStore, RunInfo};
 use anyhow::{Context, Result};
 use console::style;
 use dialoguer::{theme::ColorfulTheme, Select};
+use std::io::Write;
+use std::process::Command;
+use std::process::Stdio;
 
 fn select_past_runs(persistent_data_store: &PersistentDataStore) -> Result<Option<RunInfo>> {
     let runs = persistent_data_store.past_runs()?;
@@ -34,9 +37,22 @@ fn select_past_runs(persistent_data_store: &PersistentDataStore) -> Result<Optio
     Ok(selection.map(|i| runs.into_iter().nth(i).unwrap().0))
 }
 
+fn upload(report: String, cmd: &mut Command) -> Result<()> {
+    let mut child = cmd.stdin(Stdio::piped()).spawn()?;
+
+    if let Some(mut stdin) = child.stdin.take() {
+        stdin.write_all(report.as_bytes())?;
+    }
+
+    child.wait()?;
+    Ok(())
+}
+
 pub fn do_rage(
     persistent_data_store: &PersistentDataStore,
     invocation: Option<usize>,
+    gist: bool,
+    pastry: bool,
 ) -> Result<i32> {
     let run = match invocation {
         Some(invocation) => Some(persistent_data_store.past_run(invocation)?),
@@ -48,7 +64,16 @@ pub fn do_rage(
             let report = persistent_data_store
                 .get_run_report(&run)
                 .context("getting selected run report")?;
-            print!("{}", report);
+            if gist {
+                upload(
+                    report.clone(),
+                    Command::new("gh").args(["gist", "create", "-"]),
+                )?;
+            } else if pastry {
+                upload(report.clone(), &mut Command::new("pastry"))?;
+            } else {
+                print!("{}", report);
+            }
         }
         None => {
             println!("{}", style("Nothing selected, exiting.").yellow());

{lintrunner-0.12.4 → lintrunner-0.12.5}/src/render.rs

@@ -225,7 +225,7 @@ fn write_context_diff(stdout: &mut impl Write, original: &str, replacement: &str
     let diff = TextDiff::from_lines(original, replacement);
 
     let mut max_line_number = 1;
-    for (_, group) in diff.grouped_ops(3).iter().enumerate() {
+    for group in diff.grouped_ops(3).iter() {
         for op in group {
             for change in diff.iter_inline_changes(op) {
                 let old_line = change.old_index().unwrap_or(0) + 1;

{lintrunner-0.12.4 → lintrunner-0.12.5}/src/testing.rs

@@ -55,7 +55,7 @@ impl GitCheckout {
 
     pub fn checkout_new_branch(&self, branch_name: &str) -> Result<()> {
         let output = Command::new("git")
-            .args(&["checkout", "-b", branch_name])
+            .args(["checkout", "-b", branch_name])
             .current_dir(self.root())
             .output()?;
         assert!(output.status.success());
@@ -64,7 +64,7 @@ impl GitCheckout {
 
     pub fn add(&self, pathspec: &str) -> Result<()> {
         let output = Command::new("git")
-            .args(&["add", pathspec])
+            .args(["add", pathspec])
             .current_dir(self.root())
             .output()?;
         assert!(output.status.success());
@@ -73,7 +73,7 @@ impl GitCheckout {
 
     pub fn commit(&self, message: &str) -> Result<()> {
         let output = Command::new("git")
-            .args(&["commit", "-m", message])
+            .args(["commit", "-m", message])
             .current_dir(self.root())
             .output()?;
         assert!(output.status.success());

{lintrunner-0.12.4 → lintrunner-0.12.5}/tests/integration_test.rs

@@ -3,7 +3,7 @@ use assert_cmd::Command;
 use insta::{assert_snapshot, assert_yaml_snapshot};
 use lintrunner::lint_message::{LintMessage, LintSeverity};
 use regex::Regex;
-use serde_json;
+
 use std::io::Write;
 
 fn assert_output_snapshot(name: &str, cmd: &mut Command) -> Result<()> {
@@ -870,7 +870,7 @@ fn linter_replacement_trailing_newlines() -> Result<()> {
         "--data-path={}",
         data_path.path().to_str().unwrap()
     ));
-    cmd.arg(format!("--force-color"));
+    cmd.arg("--force-color");
     // Run on a file to ensure that the linter is run.
     cmd.arg("README.md");
     cmd.assert().failure();