lintrunner 0.11.1__tar.gz → 0.12.2__tar.gz

{lintrunner-0.11.1 → lintrunner-0.12.2}/CHANGELOG.md

@@ -2,6 +2,29 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.12.1] - 2024-02-10
+
+### Bug Fixes
+
+- Properly filter ignored files in sapling all-files ([34dd8b2](https://github.com/suo/lintrunner/commit/34dd8b295c58b1055916f18dd55272fffc64e705))
+- Make rage command robust to missing data ([a96ceec](https://github.com/suo/lintrunner/commit/a96ceec6ce3f8ae798f08d34c5f6de133814363b))
+
+## [0.12.0] - 2024-02-10
+
+### Bug Fixes
+
+- Properly fail if --get_paths cmd fails ([53c4961](https://github.com/suo/lintrunner/commit/53c496184eac9545e83d6a2714adf0bc1457316c))
+- Dont panic when no linters are specified ([0527cf0](https://github.com/suo/lintrunner/commit/0527cf0792956a88a5fb2454688c975d0a8c8baf))
+- Make --all-files work with sl ([2df4572](https://github.com/suo/lintrunner/commit/2df4572ddf1a630889a0150ac8e6bf9d63340839))
+
+### Features
+
+- Add a list subcommand to show available linters ([0765237](https://github.com/suo/lintrunner/commit/0765237900aaa7e0ecb3491227b073fa72216b36))
+
+### Testing
+
+- Fix snapshot test ([7c345da](https://github.com/suo/lintrunner/commit/7c345da7342aca42645cab8551ef232581083f11))
+
 ## [0.11.1] - 2024-01-30
 
 ### Bug Fixes

{lintrunner-0.11.1 → lintrunner-0.12.2}/Cargo.lock

@@ -28,9 +28,9 @@ dependencies = [
 
 [[package]]
 name = "anstyle"
-version = "1.0.5"
+version = "1.0.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2faccea4cc4ab4a667ce676a30e8ec13922a692c99bb8f5b11f1502c72e04220"
+checksum = "8901269c6307e8d93993578286ac0edf7f195079ffff5ebdeea6a59ffb7e36bc"
 
 [[package]]
 name = "anyhow"
@@ -144,9 +144,9 @@ checksum = "7f30e7476521f6f8af1a1c4c0b8cc94f0bee37d91763d0ca2665f299b6cd8aec"
 
 [[package]]
 name = "bytemuck"
-version = "1.14.1"
+version = "1.14.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ed2490600f404f2b94c167e31d3ed1d5f3c225a0f3b80230053b3e0b7b962bd9"
+checksum = "a2ef034f05691a48569bd920a96c81b9d91bbad1ab5ac7c4616c1f6ef36cb79f"
 
 [[package]]
 name = "cc"
@@ -327,9 +327,9 @@ checksum = "fea41bba32d969b513997752735605054bc0dfa92b4c56bf1189f2e174be7a10"
 
 [[package]]
 name = "either"
-version = "1.9.0"
+version = "1.10.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a26ae43d7bcc3b814de94796a5e736d4029efb0ee900c12e2d54c993ad1a1e07"
+checksum = "11157ac094ffbdde99aa67b23417ebdd801842852b500e395a45a9c0aac03e4a"
 
 [[package]]
 name = "encode_unicode"
@@ -378,7 +378,7 @@ dependencies = [
  "atomic",
  "pear",
  "serde",
- "toml 0.8.8",
+ "toml 0.8.10",
  "uncased",
  "version_check",
 ]
@@ -439,15 +439,15 @@ dependencies = [
 
 [[package]]
 name = "hermit-abi"
-version = "0.3.4"
+version = "0.3.5"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5d3d0e0f38255e7fa3cf31335b3a56f05febd18025f4db5ef7a0cfb4f8da651f"
+checksum = "d0c62115964e08cb8039170eb33c1d0e2388a256930279edca206fff675f82c3"
 
 [[package]]
 name = "iana-time-zone"
-version = "0.1.59"
+version = "0.1.60"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b6a67363e2aa4443928ce15e57ebae94fd8949958fd1223c4cfc0cd473ad7539"
+checksum = "e7ffbb5a1b541ea2561f8c41c087286cc091e21e556a4f09a8f6cbf17b69b141"
 dependencies = [
  "android_system_properties",
  "core-foundation-sys",
@@ -478,9 +478,9 @@ dependencies = [
 
 [[package]]
 name = "indexmap"
-version = "2.2.1"
+version = "2.2.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "433de089bd45971eecf4668ee0ee8f4cec17db4f8bd8f7bc3197a6ce37aa7d9b"
+checksum = "824b2ae422412366ba479e8111fd301f7b5faece8149317bb81925979a53f520"
 dependencies = [
  "equivalent",
  "hashbrown 0.14.3",
@@ -522,12 +522,12 @@ dependencies = [
 
 [[package]]
 name = "is-terminal"
-version = "0.4.10"
+version = "0.4.12"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0bad00257d07be169d870ab665980b06cdb366d792ad690bf2e76876dc503455"
+checksum = "f23ff5ef2b80d608d61efee834934d862cd92461afc0560dedf493e4c033738b"
 dependencies = [
- "hermit-abi 0.3.4",
- "rustix",
+ "hermit-abi 0.3.5",
+ "libc",
  "windows-sys",
 ]
 
@@ -548,9 +548,9 @@ checksum = "b1a46d1a171d865aa5f83f92695765caa047a9b4cbae2cbf37dbd613a793fd4c"
 
 [[package]]
 name = "js-sys"
-version = "0.3.67"
+version = "0.3.68"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "9a1d36f1235bc969acba30b7f5990b864423a6068a10f7c90ae8f0112e3a59d1"
+checksum = "406cda4b368d531c842222cf9d2600a9a4acce8d29423695379c6868a143a9ee"
 dependencies = [
  "wasm-bindgen",
 ]
@@ -563,9 +563,9 @@ checksum = "e2abad23fbc42b3700f2f279844dc832adb2b2eb069b2df918f455c4e18cc646"
 
 [[package]]
 name = "libc"
-version = "0.2.152"
+version = "0.2.153"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "13e3bf6590cbc649f4d1a3eefc9d5d6eb746f5200ffb04e5e142700b8faa56e7"
+checksum = "9c198f91728a82281a64e1f4f9eeb25d82cb32a5de251c6bd1b5154d63a8e7bd"
 
 [[package]]
 name = "libredox"
@@ -586,7 +586,7 @@ checksum = "0717cef1bc8b636c6e1c1bbdefc09e6322da8a9321966e8928ef80d20f7f770f"
 
 [[package]]
 name = "lintrunner"
-version = "0.11.1"
+version = "0.12.2"
 dependencies = [
  "anyhow",
  "assert_cmd",
@@ -634,9 +634,9 @@ checksum = "523dc4f511e55ab87b694dc30d0f820d60906ef06413f93d4d7a1385599cc149"
 
 [[package]]
 name = "num-traits"
-version = "0.2.17"
+version = "0.2.18"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "39e3200413f237f41ab11ad6d161bc7239c84dcb631773ccd7de3dfe4b5c267c"
+checksum = "da0df0e5185db44f69b44f26786fe401b6c293d1907744beaa7fa62b2e5a517a"
 dependencies = [
  "autocfg",
 ]
@@ -684,9 +684,9 @@ dependencies = [
 
 [[package]]
 name = "pest"
-version = "2.7.6"
+version = "2.7.7"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1f200d8d83c44a45b21764d1916299752ca035d15ecd46faca3e9a2a2bf6ad06"
+checksum = "219c0dcc30b6a27553f9cc242972b67f75b60eb0db71f0b5462f38b058c41546"
 dependencies = [
  "memchr",
  "thiserror",
@@ -695,9 +695,9 @@ dependencies = [
 
 [[package]]
 name = "pest_derive"
-version = "2.7.6"
+version = "2.7.7"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "bcd6ab1236bbdb3a49027e920e693192ebfe8913f6d60e294de57463a493cfde"
+checksum = "22e1288dbd7786462961e69bfd4df7848c1e37e8b74303dbdab82c3a9cdd2809"
 dependencies = [
  "pest",
  "pest_generator",
@@ -705,9 +705,9 @@ dependencies = [
 
 [[package]]
 name = "pest_generator"
-version = "2.7.6"
+version = "2.7.7"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2a31940305ffc96863a735bef7c7994a00b325a7138fdbc5bda0f1a0476d3275"
+checksum = "1381c29a877c6d34b8c176e734f35d7f7f5b3adaefe940cb4d1bb7af94678e2e"
 dependencies = [
  "pest",
  "pest_meta",
@@ -718,9 +718,9 @@ dependencies = [
 
 [[package]]
 name = "pest_meta"
-version = "2.7.6"
+version = "2.7.7"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a7ff62f5259e53b78d1af898941cdcdccfae7385cf7d793a6e55de5d05bb4b7d"
+checksum = "d0934d6907f148c22a3acbda520c7eed243ad7487a30f51f6ce52b58b7077a8a"
 dependencies = [
  "once_cell",
  "pest",
@@ -860,9 +860,9 @@ checksum = "c08c74e62047bb2de4ff487b251e4a92e24f48745648451635cec7d591162d9f"
 
 [[package]]
 name = "rustix"
-version = "0.38.30"
+version = "0.38.31"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "322394588aaf33c24007e8bb3238ee3e4c5c09c084ab32bc73890b99ff326bca"
+checksum = "6ea3e1a662af26cd7a3ba09c0297a31af215563ecf42817c98df621387f4e949"
 dependencies = [
  "bitflags 2.4.2",
  "errno",
@@ -976,13 +976,12 @@ dependencies = [
 
 [[package]]
 name = "tempfile"
-version = "3.9.0"
+version = "3.10.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "01ce4141aa927a6d1bd34a041795abd0db1cccba5d5f24b009f694bdf3a1f3fa"
+checksum = "a365e8cd18e44762ef95d87f284f4b5cd04107fec2ff3052bd6a3e6069669e67"
 dependencies = [
  "cfg-if",
  "fastrand",
- "redox_syscall",
  "rustix",
  "windows-sys",
 ]
@@ -1061,9 +1060,9 @@ dependencies = [
 
 [[package]]
 name = "toml"
-version = "0.8.8"
+version = "0.8.10"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a1a195ec8c9da26928f773888e0742ca3ca1040c6cd859c919c9f59c1954ab35"
+checksum = "9a9aad4a3066010876e8dcf5a8a06e70a558751117a145c6ce2b82c2e2054290"
 dependencies = [
  "serde",
  "serde_spanned",
@@ -1082,11 +1081,11 @@ dependencies = [
 
 [[package]]
 name = "toml_edit"
-version = "0.21.0"
+version = "0.22.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d34d383cd00a163b4a5b85053df514d45bc330f6de7737edfe0a93311d1eaa03"
+checksum = "0c9ffdf896f8daaabf9b66ba8e77ea1ed5ed0f72821b398aba62352e95062951"
 dependencies = [
- "indexmap 2.2.1",
+ "indexmap 2.2.2",
  "serde",
  "serde_spanned",
  "toml_datetime",
@@ -1155,9 +1154,9 @@ checksum = "9c8d87e72b64a3b4db28d11ce29237c246188f4f51057d65a7eab63b7987e423"
 
 [[package]]
 name = "wasm-bindgen"
-version = "0.2.90"
+version = "0.2.91"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b1223296a201415c7fad14792dbefaace9bd52b62d33453ade1c5b5f07555406"
+checksum = "c1e124130aee3fb58c5bdd6b639a0509486b0338acaaae0c84a5124b0f588b7f"
 dependencies = [
  "cfg-if",
  "wasm-bindgen-macro",
@@ -1165,9 +1164,9 @@ dependencies = [
 
 [[package]]
 name = "wasm-bindgen-backend"
-version = "0.2.90"
+version = "0.2.91"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "fcdc935b63408d58a32f8cc9738a0bffd8f05cc7c002086c6ef20b7312ad9dcd"
+checksum = "c9e7e1900c352b609c8488ad12639a311045f40a35491fb69ba8c12f758af70b"
 dependencies = [
  "bumpalo",
  "log",
@@ -1180,9 +1179,9 @@ dependencies = [
 
 [[package]]
 name = "wasm-bindgen-macro"
-version = "0.2.90"
+version = "0.2.91"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3e4c238561b2d428924c49815533a8b9121c664599558a5d9ec51f8a1740a999"
+checksum = "b30af9e2d358182b5c7449424f017eba305ed32a7010509ede96cdc4696c46ed"
 dependencies = [
  "quote",
  "wasm-bindgen-macro-support",
@@ -1190,9 +1189,9 @@ dependencies = [
 
 [[package]]
 name = "wasm-bindgen-macro-support"
-version = "0.2.90"
+version = "0.2.91"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "bae1abb6806dc1ad9e560ed242107c0f6c84335f1749dd4e8ddb012ebd5e25a7"
+checksum = "642f325be6301eb8107a83d12a8ac6c1e1c54345a7ef1a9261962dfefda09e66"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -1203,9 +1202,9 @@ dependencies = [
 
 [[package]]
 name = "wasm-bindgen-shared"
-version = "0.2.90"
+version = "0.2.91"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4d91413b1c31d7539ba5ef2451af3f0b833a005eb27a631cec32bc0635a8602b"
+checksum = "4f186bd2dcf04330886ce82d6f33dd75a7bfcf69ecf5763b89fcde53b6ac9838"
 
 [[package]]
 name = "winapi"
@@ -1315,9 +1314,9 @@ checksum = "dff9641d1cd4be8d1a070daf9e3773c5f67e78b4d9d42263020c057706765c04"
 
 [[package]]
 name = "winnow"
-version = "0.5.35"
+version = "0.5.39"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1931d78a9c73861da0134f453bb1f790ce49b2e30eba8410b4b79bac72b46a2d"
+checksum = "5389a154b01683d28c77f8f68f49dea75f0a4da32557a58f68ee51ebba472d29"
 dependencies = [
  "memchr",
 ]

{lintrunner-0.11.1 → lintrunner-0.12.2}/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "lintrunner"
-version = "0.11.1"
+version = "0.12.2"
 authors = ["Michael Suo <suo@fb.com>"]
 edition = "2021"
 description = "A lint running tool and framework."

{lintrunner-0.11.1 → lintrunner-0.12.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: lintrunner
-Version: 0.11.1
+Version: 0.12.2
 Classifier: Programming Language :: Rust
 Classifier: Programming Language :: Python :: Implementation :: CPython
 Classifier: Programming Language :: Python :: Implementation :: PyPy

{lintrunner-0.11.1 → lintrunner-0.12.2}/src/git.rs

@@ -3,7 +3,7 @@ use std::{collections::HashSet, convert::TryFrom, process::Command};
 use crate::{
     log_utils::{ensure_output, log_files},
     path::AbsPath,
-    version_control,
+    version_control::VersionControl,
 };
 use anyhow::{ensure, Context, Result};
 use log::debug;
@@ -13,7 +13,7 @@ pub struct Repo {
     root: AbsPath,
 }
 
-impl version_control::System for Repo {
+impl VersionControl for Repo {
     fn new() -> Result<Repo> {
         // Retrieve the git root based on the current working directory.
         let output = Command::new("git")
@@ -145,6 +145,30 @@ impl version_control::System for Repo {
             .collect::<Vec<AbsPath>>();
         Ok(filtered_files)
     }
+
+    fn get_all_files(&self, _under: Option<&AbsPath>) -> Result<Vec<AbsPath>> {
+        let output = Command::new("git")
+            .arg("grep")
+            .arg("-Il")
+            .arg(".")
+            .current_dir(&self.root)
+            .output()?;
+
+        ensure_output("git grep -Il", &output)?;
+
+        let files =
+            std::str::from_utf8(&output.stdout).context("failed to parse paths_cmd output")?;
+        let files = files
+            .lines()
+            .map(|s| s.to_string())
+            .collect::<HashSet<String>>();
+        let mut files = files.into_iter().collect::<Vec<String>>();
+        files.sort();
+        files
+            .into_iter()
+            .map(AbsPath::try_from)
+            .collect::<Result<_>>()
+    }
 }
 
 pub fn get_paths_from_cmd(paths_cmd: &str) -> Result<Vec<AbsPath>> {
@@ -162,6 +186,11 @@ pub fn get_paths_from_cmd(paths_cmd: &str) -> Result<Vec<AbsPath>> {
         .output()
         .context("failed to run provided paths_cmd")?;
 
+    ensure!(
+        output.status.success(),
+        format!("Failed to run provided paths_cmd: '{}'", paths_cmd)
+    );
+
     let files = std::str::from_utf8(&output.stdout).context("failed to parse paths_cmd output")?;
     let files = files
         .lines()
@@ -331,6 +360,12 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    fn invalid_get_paths_from_cmd_fails() -> () {
+        assert!(get_paths_from_cmd("asoidjfoaisdjf").is_err());
+        assert!(get_paths_from_cmd("false").is_err());
+    }
+
     #[test]
     fn merge_base_with() -> Result<()> {
         let git = GitCheckout::new()?;

{lintrunner-0.11.1 → lintrunner-0.12.2}/src/lib.rs

@@ -13,6 +13,7 @@ use std::convert::TryFrom;
 use std::fs::OpenOptions;
 use std::sync::{Arc, Mutex};
 use std::thread;
+use version_control::VersionControl;
 
 pub mod git;
 pub mod init;
@@ -150,8 +151,16 @@ pub enum RenderOpt {
     Oneline,
 }
 
+pub fn get_version_control() -> Result<Box<dyn VersionControl>> {
+    let repo = git::Repo::new();
+    if let Ok(repo) = repo {
+        return Ok(Box::new(repo));
+    }
+
+    Ok(Box::new(sapling::Repo::new()?))
+}
+
 pub fn do_lint(
-    repo: &version_control::Repo,
     linters: Vec<Linter>,
     paths_opt: PathsOpt,
     should_apply_patches: bool,
@@ -165,6 +174,18 @@ pub fn do_lint(
         "Running linters: {:?}",
         linters.iter().map(|l| &l.code).collect::<Vec<_>>()
     );
+    let repo = get_version_control()?;
+    let mut stdout = Term::stdout();
+    if linters.is_empty() {
+        stdout.write_line("No linters ran.")?;
+        return Ok(0);
+    }
+
+    let config_dir = if only_lint_under_config_dir {
+        Some(AbsPath::try_from(linters[0].get_config_dir())?)
+    } else {
+        None
+    };
 
     let mut files = match paths_opt {
         PathsOpt::Auto => {
@@ -181,20 +202,18 @@ pub fn do_lint(
         PathsOpt::PathsCmd(paths_cmd) => get_paths_from_cmd(&paths_cmd)?,
         PathsOpt::Paths(paths) => get_paths_from_input(paths)?,
         PathsOpt::PathsFile(file) => get_paths_from_file(file)?,
-        PathsOpt::AllFiles => get_paths_from_cmd("git grep -Il .")?,
+        PathsOpt::AllFiles => repo.get_all_files(config_dir.as_ref())?,
     };
 
     // Sort and unique the files so we pass a consistent ordering to linters
-    files.sort();
-    files.dedup();
-
-    if only_lint_under_config_dir {
-        let config_dir = linters[0].get_config_dir();
+    if let Some(config_dir) = config_dir {
         files = files
             .into_iter()
-            .filter(|path| path.starts_with(config_dir))
+            .filter(|path| path.starts_with(&config_dir))
             .collect();
     }
+    files.sort();
+    files.dedup();
 
     let files = Arc::new(files);
 
@@ -261,8 +280,6 @@ pub fn do_lint(
     // Flush the logger before rendering results.
     log::logger().flush();
 
-    let mut stdout = Term::stdout();
-
     let did_print = match render_opt {
         RenderOpt::Default => render_lint_messages(&mut stdout, &all_lints)?,
         RenderOpt::Json => render_lint_messages_json(&mut stdout, &all_lints)?,

{lintrunner-0.11.1 → lintrunner-0.12.2}/src/main.rs

@@ -67,11 +67,15 @@ struct Args {
     #[clap(long, short, conflicts_with_all=&["paths", "paths-cmd", "paths-from", "revision"], global = true)]
     merge_base_with: Option<String>,
 
-    /// Comma-separated list of linters to skip (e.g. --skip CLANGFORMAT,NOQA)
+    /// Comma-separated list of linters to skip (e.g. --skip CLANGFORMAT,NOQA).
+    ///
+    /// You can run: `lintrunner list` to see available linters.
     #[clap(long, global = true)]
     skip: Option<String>,
 
-    /// Comma-separated list of linters to run (opposite of --skip)
+    /// Comma-separated list of linters to run (opposite of --skip).
+    ///
+    /// You can run: `lintrunner list` to see available linters.
     #[clap(long, global = true)]
     take: Option<String>,
 
@@ -129,6 +133,9 @@ enum SubCommand {
     /// Run linters. This is the default if no subcommand is provided.
     Lint,
 
+    /// Show the list of available linters, based on this repo's .lintrunner.toml.
+    List,
+
     /// Create a bug report for a past invocation of lintrunner.
     Rage {
         /// Choose a specific invocation to report on. 0 is the most recent run.
@@ -183,8 +190,6 @@ fn do_main() -> Result<i32> {
     debug!("Version: {VERSION}");
     debug!("Passed args: {:?}", std::env::args());
     debug!("Computed args: {:?}", args);
-    let repo = version_control::Repo::new()?;
-    debug!("Current rev: {}", repo.get_head()?);
 
     // report config paths which do not exist
     for path in &config_paths {
@@ -286,7 +291,6 @@ fn do_main() -> Result<i32> {
         SubCommand::Format => {
             check_init_changed(&persistent_data_store, &lint_runner_config)?;
             do_lint(
-                &repo,
                 linters,
                 paths_opt,
                 true, // always apply patches when we use the format command
@@ -301,7 +305,6 @@ fn do_main() -> Result<i32> {
             // Default command is to just lint.
             check_init_changed(&persistent_data_store, &lint_runner_config)?;
             do_lint(
-                &repo,
                 linters,
                 paths_opt,
                 args.apply_patches,
@@ -313,6 +316,13 @@ fn do_main() -> Result<i32> {
             )
         }
         SubCommand::Rage { invocation } => do_rage(&persistent_data_store, invocation),
+        SubCommand::List => {
+            println!("Available linters:");
+            for linter in &lint_runner_config.linters {
+                println!("  {}", linter.code);
+            }
+            Ok(0)
+        }
     };
 
     let exit_info = match &res {

{lintrunner-0.11.1 → lintrunner-0.12.2}/src/persistent_data.rs

@@ -175,7 +175,7 @@ impl PersistentDataStore {
             .collect::<Result<Vec<_>, std::io::Error>>()?;
 
         run_dirs.sort_unstable();
-        run_dirs.pop(); // Don't include the current run.
+        run_dirs.pop();  // pop most recent job as it won't have a report yet.
         run_dirs.reverse();
 
         debug!("Found past runs: {:?}", run_dirs);
@@ -209,14 +209,19 @@ impl PersistentDataStore {
 
         let mut ret = Vec::new();
 
-        // Skip the first one as it is the current run.
         for dir in run_dirs.into_iter() {
             debug!("Reading run info from {}", dir.display());
+            let run_data = std::fs::read_to_string(dir.join("run_info.json"));
+            let exit_data = std::fs::read_to_string(dir.join("exit_info.json"));
+            if run_data.is_err() || exit_data.is_err() {
+                // If we couldn't find one of the runfiles, just skip it. We can
+                // fail to write it for a variety of reasons, including a simple
+                // sigterm.
+                continue;
+            }
 
-            let run_info: RunInfo =
-                serde_json::from_str(&std::fs::read_to_string(dir.join("run_info.json"))?)?;
-            let exit_info: ExitInfo =
-                serde_json::from_str(&std::fs::read_to_string(dir.join("exit_info.json"))?)?;
+            let run_info: RunInfo = serde_json::from_str(&run_data?)?;
+            let exit_info: ExitInfo = serde_json::from_str(&exit_data?)?;
             ret.push((run_info, exit_info));
         }
         Ok(ret)

{lintrunner-0.11.1 → lintrunner-0.12.2}/src/sapling.rs

@@ -1,4 +1,8 @@
-use crate::{log_utils, path, version_control};
+use crate::{
+    log_utils,
+    path::{self, AbsPath},
+    version_control::VersionControl,
+};
 
 use anyhow;
 
@@ -6,7 +10,7 @@ pub struct Repo {
     root: path::AbsPath,
 }
 
-impl version_control::System for Repo {
+impl VersionControl for Repo {
     fn new() -> anyhow::Result<Self> {
         let output = std::process::Command::new("sl").arg("root").output()?;
         anyhow::ensure!(output.status.success(), "Failed to determine Sapling root");
@@ -41,6 +45,44 @@ impl version_control::System for Repo {
         Ok(merge_base.to_string())
     }
 
+    fn get_all_files(&self, under: Option<&AbsPath>) -> anyhow::Result<Vec<AbsPath>> {
+        // Output of sl status looks like:
+        // D    src/lib.rs
+        // M    foo/bar.baz
+        let re = regex::Regex::new(r"^[A-Z?]\s+")?;
+
+        let mut cmd = std::process::Command::new("sl");
+        cmd.arg("status").arg("--all");
+        if let Some(under) = under {
+            cmd.arg(under.as_os_str());
+        }
+        cmd.current_dir(&self.root);
+        let output = cmd.output()?;
+        log_utils::ensure_output(&format!("{:?}", cmd), &output)?;
+        let all_files_str = std::str::from_utf8(&output.stdout)?;
+        let all_files: std::collections::HashSet<String> = all_files_str
+            .split('\n')
+            .map(|x| x.to_string())
+            .filter(|line| !line.starts_with('I'))
+            .map(|line| re.replace(&line, "").to_string())
+            .filter(|line| !line.is_empty())
+            .collect();
+
+        let filtered_all_files = all_files
+            .into_iter()
+            .map(|f| format!("{}", self.root.join(f).display()))
+            .filter_map(|f| match path::AbsPath::try_from(&f) {
+                Ok(abs_path) => Some(abs_path),
+                Err(_) => {
+                    eprintln!("Failed to find file while gathering files to lint: {}", f);
+                    None
+                }
+            })
+            .collect::<Vec<path::AbsPath>>();
+
+        Ok(filtered_all_files)
+    }
+
     fn get_changed_files(&self, relative_to: Option<&str>) -> anyhow::Result<Vec<path::AbsPath>> {
         // Output of sl status looks like:
         // D    src/lib.rs
@@ -175,7 +217,6 @@ mod tests {
         fn changed_files(&self, relative_to: Option<&str>) -> Result<Vec<String>> {
             let _shared = SL_GLOBAL_MUTEX.lock().unwrap();
             std::env::set_current_dir(&self.root)?;
-            use version_control::System;
             let repo = Repo::new()?;
             let files = repo.get_changed_files(relative_to)?;
             let files = files
@@ -188,10 +229,16 @@ mod tests {
         fn merge_base_with(&self, merge_base_with: &str) -> Result<String> {
             let _shared = SL_GLOBAL_MUTEX.lock().unwrap();
             std::env::set_current_dir(&self.root)?;
-            use version_control::System;
             let repo = Repo::new()?;
             repo.get_merge_base_with(merge_base_with)
         }
+
+        fn get_all_files(&self) -> Result<Vec<AbsPath>> {
+            let _shared = SL_GLOBAL_MUTEX.lock().unwrap();
+            std::env::set_current_dir(&self.root)?;
+            let repo = Repo::new()?;
+            repo.get_all_files(None)
+        }
     }
 
     // Should properly detect changes in the commit (and not check other files)
@@ -374,6 +421,34 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    #[cfg_attr(target_os = "windows", ignore)] // remove when sapling installation is better
+    #[cfg_attr(target_os = "linux", ignore)] // remove when sapling installation is better
+    fn get_all_files() -> Result<()> {
+        let git = testing::GitCheckout::new()?;
+        git.write_file("test_1.txt", "Initial commit")?;
+        git.write_file("test_2.txt", "Initial commit")?;
+        git.write_file("test_3.txt", "Initial commit")?;
+        git.write_file("test_4.txt", "Initial commit")?;
+
+        git.add(".")?;
+        git.commit("I am main")?;
+        let sl = SaplingClone::new(&git)?;
+        let mut all_files = sl.get_all_files()?;
+        all_files.sort();
+        assert_eq!(
+            all_files,
+            vec!(
+                AbsPath::try_from("README")?,
+                AbsPath::try_from("test_1.txt")?,
+                AbsPath::try_from("test_2.txt")?,
+                AbsPath::try_from("test_3.txt")?,
+                AbsPath::try_from("test_4.txt")?
+            )
+        );
+        Ok(())
+    }
+
     #[test]
     #[cfg_attr(target_os = "windows", ignore)] // remove when sapling installation is better
     #[cfg_attr(target_os = "linux", ignore)] // remove when sapling installation is better

{lintrunner-0.11.1 → lintrunner-0.12.2}/src/testing.rs

@@ -1,6 +1,6 @@
 use std::{fs::OpenOptions, io::Write, process::Command};
 
-use crate::version_control;
+use crate::get_version_control;
 
 use anyhow::Result;
 use tempfile::TempDir;
@@ -82,7 +82,7 @@ impl GitCheckout {
 
     pub fn changed_files(&self, relative_to: Option<&str>) -> Result<Vec<String>> {
         std::env::set_current_dir(self.root())?;
-        let repo = version_control::Repo::new()?;
+        let repo = get_version_control()?;
         let files = repo.get_changed_files(relative_to)?;
         let files = files
             .into_iter()
@@ -93,7 +93,7 @@ impl GitCheckout {
 
     pub fn merge_base_with(&self, merge_base_with: &str) -> Result<String> {
         std::env::set_current_dir(self.root())?;
-        let repo = version_control::Repo::new()?;
+        let repo = get_version_control()?;
         repo.get_merge_base_with(merge_base_with)
     }
 

lintrunner-0.12.2/src/version_control.rs

@@ -0,0 +1,26 @@
+use anyhow;
+
+use crate::path::AbsPath;
+
+// Trait describing the operations we need in lintrunner for a version
+// control system.
+pub trait VersionControl {
+    // Creates a new instance, trying the different implementations we
+    // have available.
+    fn new() -> anyhow::Result<Self>
+    where
+        Self: Sized;
+
+    // Gets the tip of the repository.
+    fn get_head(&self) -> anyhow::Result<String>;
+
+    // Gets the most recent common ancestor between the tip and the
+    // given commit.
+    fn get_merge_base_with(&self, merge_base_with: &str) -> anyhow::Result<String>;
+
+    // Gets the files that have changed relative to the given commit.
+    fn get_changed_files(&self, relative_to: Option<&str>) -> anyhow::Result<Vec<AbsPath>>;
+
+    // Get all files in the repo.
+    fn get_all_files(&self, under: Option<&AbsPath>) -> anyhow::Result<Vec<AbsPath>>;
+}

{lintrunner-0.11.1 → lintrunner-0.12.2}/tests/integration_test.rs

@@ -878,3 +878,42 @@ fn linter_replacement_trailing_newlines() -> Result<()> {
 
     Ok(())
 }
+
+#[test]
+fn lint_with_no_linters() -> Result<()> {
+    let data_path = tempfile::tempdir()?;
+    let lint_message = LintMessage {
+        path: Some("tests/fixtures/fake_source_file.rs".to_string()),
+        line: Some(9),
+        char: Some(1),
+        code: "DUMMY".to_string(),
+        name: "dummy failure".to_string(),
+        severity: LintSeverity::Advice,
+        original: None,
+        replacement: None,
+        description: Some("A dummy linter failure".to_string()),
+    };
+    let config = temp_config(&format!(
+        "\
+            [[linter]]
+            code = 'TESTLINTER'
+            include_patterns = ['**']
+            command = ['echo', '{}']
+        ",
+        serde_json::to_string(&lint_message)?
+    ))?;
+
+    let mut cmd = Command::cargo_bin("lintrunner")?;
+    cmd.arg(format!("--config={}", config.path().to_str().unwrap()));
+    cmd.arg(format!(
+        "--data-path={}",
+        data_path.path().to_str().unwrap()
+    ));
+
+    // Run on a file to ensure that the linter is run.
+    cmd.arg("--skip=TESTLINTER");
+    cmd.assert().success();
+    assert_output_snapshot("lint_with_no_linters", &mut cmd)?;
+
+    Ok(())
+}

{lintrunner-0.11.1 → lintrunner-0.12.2}/tests/snapshots/integration_test__format_command_doesnt_use_nonformat_linter.snap

@@ -1,11 +1,9 @@
 ---
 source: tests/integration_test.rs
-assertion_line: 20
 expression: output_lines
 ---
 - "STDOUT:"
-- ok No lint issues.
-- Successfully applied all patches.
+- No linters ran.
 - ""
 - ""
 - "STDERR:"

lintrunner-0.12.2/tests/snapshots/integration_test__lint_with_no_linters.snap

@@ -0,0 +1,11 @@
+---
+source: tests/integration_test.rs
+expression: output_lines
+---
+- "STDOUT:"
+- No linters ran.
+- ""
+- ""
+- "STDERR:"
+- "WARNING: No previous init data found. If this is the first time you're running lintrunner, you should run `lintrunner init`."
+

lintrunner-0.11.1/src/version_control.rs

@@ -1,60 +0,0 @@
-use crate::{git, path, sapling};
-
-use anyhow;
-
-pub struct Repo(RepoImpl);
-
-enum RepoImpl {
-    Git(git::Repo),
-    Sapling(sapling::Repo),
-}
-
-// Trait describing the operations we need in lintrunner for a version
-// control system.
-pub trait System {
-    // Creates a new instance, trying the different implementations we
-    // have available.
-    fn new() -> anyhow::Result<Self>
-    where
-        Self: Sized;
-
-    // Gets the tip of the repository.
-    fn get_head(&self) -> anyhow::Result<String>;
-
-    // Gets the most recent common ancestor between the tip and the
-    // given commit.
-    fn get_merge_base_with(&self, merge_base_with: &str) -> anyhow::Result<String>;
-
-    // Gets the files that have changed relative to the given commit.
-    fn get_changed_files(&self, relative_to: Option<&str>) -> anyhow::Result<Vec<path::AbsPath>>;
-}
-
-impl Repo {
-    pub fn new() -> anyhow::Result<Self> {
-        git::Repo::new()
-            .and_then(|repo| Ok(Repo(RepoImpl::Git(repo))))
-            .or_else(|_| sapling::Repo::new().and_then(|repo| Ok(Repo(RepoImpl::Sapling(repo)))))
-    }
-
-    pub fn get_head(&self) -> anyhow::Result<String> {
-        self.get_system().get_head()
-    }
-
-    pub fn get_merge_base_with(&self, merge_base_with: &str) -> anyhow::Result<String> {
-        self.get_system().get_merge_base_with(merge_base_with)
-    }
-
-    pub fn get_changed_files(
-        &self,
-        relative_to: Option<&str>,
-    ) -> anyhow::Result<Vec<path::AbsPath>> {
-        self.get_system().get_changed_files(relative_to)
-    }
-
-    fn get_system<'a>(&'a self) -> Box<&'a dyn System> {
-        match &self.0 {
-            RepoImpl::Git(git) => Box::new(git as &dyn System),
-            RepoImpl::Sapling(sapling) => Box::new(sapling as &dyn System),
-        }
-    }
-}