linthis 0.0.7__tar.gz → 0.0.8__tar.gz

{linthis-0.0.7 → linthis-0.0.8}/Cargo.lock

@@ -497,7 +497,7 @@ dependencies = [
 
 [[package]]
 name = "linthis"
-version = "0.0.7"
+version = "0.0.8"
 dependencies = [
  "anyhow",
  "chrono",
@@ -514,6 +514,7 @@ dependencies = [
  "serde",
  "serde_json",
  "serde_yaml",
+ "similar",
  "tempfile",
  "thiserror",
  "toml",
@@ -745,6 +746,12 @@ version = "1.3.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "0fda2ff0d084019ba4d7c6f371c95d8fd75ce3524c3cb8fb653a3023f6323e64"
 
+[[package]]
+name = "similar"
+version = "2.7.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "bbbb5d9659141646ae647b42fe094daf6c6192d1620870b449d9557f748b2daa"
+
 [[package]]
 name = "strsim"
 version = "0.10.0"

{linthis-0.0.7 → linthis-0.0.8}/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "linthis"
-version = "0.0.7"
+version = "0.0.8"
 edition = "2021"
 authors = ["zhlinh"]
 description = "A fast, cross-platform multi-language linter and formatter"
@@ -42,6 +42,9 @@ regex = "1.8"
 # Glob pattern matching
 globset = "0.4"
 
+# Diff algorithm
+similar = "2.4"
+
 # Lazy initialization
 lazy_static = "1.4"
 

{linthis-0.0.7 → linthis-0.0.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: linthis
-Version: 0.0.7
+Version: 0.0.8
 Classifier: Development Status :: 3 - Alpha
 Classifier: Environment :: Console
 Classifier: Intended Audience :: Developers
@@ -152,15 +152,16 @@ linthis plugin add --global <alias> <git-url>
 
 ### Use Plugin
 
+Plugins are automatically loaded when running linthis. After adding a plugin:
+
 ```bash
-# Use plugin configuration for linting and formatting
-linthis -p myplugin
-linthis --plugin myplugin
+# Plugin configs are auto-loaded
+linthis
 
 # Combine with other options
-linthis -p myplugin -l python -i src/
-linthis --plugin myplugin --check-only
-linthis --plugin myplugin --staged
+linthis -l python -i src/
+linthis --check-only
+linthis --staged
 ```
 
 ### Remove Plugin
@@ -188,8 +189,9 @@ linthis plugin list
 linthis plugin list -g
 linthis plugin list --global
 
-# Update plugin cache
-linthis --plugin-update
+# Sync (update) plugins
+linthis plugin sync          # Sync local plugins
+linthis plugin sync --global # Sync global plugins
 
 # Initialize new plugin
 linthis plugin init my-config
@@ -427,7 +429,6 @@ All modifications preserve TOML file format and comments.
 | ----- | ----------------------- | ---------------------------------------- | ----------------------- |
 | `-i`  | `--include`             | Specify files or directories to check    | `-i src -i lib`         |
 | `-e`  | `--exclude`             | Exclude patterns (can be used multiple times) | `-e "*.test.js"`        |
-| `-p`  | `--plugin`              | Use plugin (alias or Git URL)            | `-p myplugin`           |
 | `-c`  | `--check-only`          | Check only, no formatting                | `-c`                    |
 | `-f`  | `--format-only`         | Format only, no checking                 | `-f`                    |
 | `-s`  | `--staged`              | Check only Git staged files              | `-s`                    |
@@ -438,9 +439,9 @@ All modifications preserve TOML file format and comments.
 |       | `--config`              | Specify config file path                 | `--config custom.toml`  |
 |       | `--init`                | Initialize .linthis.toml config file     | `--init`                |
 |       | `--preset`              | Format preset                            | `--preset google`       |
-|       | `--plugin-update`       | Force update plugin cache                | `--plugin-update`       |
 |       | `--no-default-excludes` | Disable default exclude rules            | `--no-default-excludes` |
 |       | `--no-gitignore`        | Disable .gitignore rules                 | `--no-gitignore`        |
+|       | `--no-plugin`           | Skip loading plugins, use default config | `--no-plugin`           |
 
 ### Plugin Management Subcommands
 
@@ -695,7 +696,7 @@ git push -u origin main
 
 ```bash
 linthis plugin add company https://github.com/mycompany/linthis-standards.git
-linthis --plugin company
+linthis  # Plugin configs are auto-loaded
 ```
 
 ## FAQ
@@ -721,7 +722,8 @@ linthis -l python  # Only check Python files
 ### Q: How to update plugins?
 
 ```bash
-linthis --plugin-update
+linthis plugin sync          # Sync local plugins
+linthis plugin sync --global # Sync global plugins
 ```
 
 ### Q: What is the plugin Git reference (ref) used for?

{linthis-0.0.7 → linthis-0.0.8}/README.md

@@ -130,15 +130,16 @@ linthis plugin add --global <alias> <git-url>
 
 ### Use Plugin
 
+Plugins are automatically loaded when running linthis. After adding a plugin:
+
 ```bash
-# Use plugin configuration for linting and formatting
-linthis -p myplugin
-linthis --plugin myplugin
+# Plugin configs are auto-loaded
+linthis
 
 # Combine with other options
-linthis -p myplugin -l python -i src/
-linthis --plugin myplugin --check-only
-linthis --plugin myplugin --staged
+linthis -l python -i src/
+linthis --check-only
+linthis --staged
 ```
 
 ### Remove Plugin
@@ -166,8 +167,9 @@ linthis plugin list
 linthis plugin list -g
 linthis plugin list --global
 
-# Update plugin cache
-linthis --plugin-update
+# Sync (update) plugins
+linthis plugin sync          # Sync local plugins
+linthis plugin sync --global # Sync global plugins
 
 # Initialize new plugin
 linthis plugin init my-config
@@ -405,7 +407,6 @@ All modifications preserve TOML file format and comments.
 | ----- | ----------------------- | ---------------------------------------- | ----------------------- |
 | `-i`  | `--include`             | Specify files or directories to check    | `-i src -i lib`         |
 | `-e`  | `--exclude`             | Exclude patterns (can be used multiple times) | `-e "*.test.js"`        |
-| `-p`  | `--plugin`              | Use plugin (alias or Git URL)            | `-p myplugin`           |
 | `-c`  | `--check-only`          | Check only, no formatting                | `-c`                    |
 | `-f`  | `--format-only`         | Format only, no checking                 | `-f`                    |
 | `-s`  | `--staged`              | Check only Git staged files              | `-s`                    |
@@ -416,9 +417,9 @@ All modifications preserve TOML file format and comments.
 |       | `--config`              | Specify config file path                 | `--config custom.toml`  |
 |       | `--init`                | Initialize .linthis.toml config file     | `--init`                |
 |       | `--preset`              | Format preset                            | `--preset google`       |
-|       | `--plugin-update`       | Force update plugin cache                | `--plugin-update`       |
 |       | `--no-default-excludes` | Disable default exclude rules            | `--no-default-excludes` |
 |       | `--no-gitignore`        | Disable .gitignore rules                 | `--no-gitignore`        |
+|       | `--no-plugin`           | Skip loading plugins, use default config | `--no-plugin`           |
 
 ### Plugin Management Subcommands
 
@@ -673,7 +674,7 @@ git push -u origin main
 
 ```bash
 linthis plugin add company https://github.com/mycompany/linthis-standards.git
-linthis --plugin company
+linthis  # Plugin configs are auto-loaded
 ```
 
 ## FAQ
@@ -699,7 +700,8 @@ linthis -l python  # Only check Python files
 ### Q: How to update plugins?
 
 ```bash
-linthis --plugin-update
+linthis plugin sync          # Sync local plugins
+linthis plugin sync --global # Sync global plugins
 ```
 
 ### Q: What is the plugin Git reference (ref) used for?

{linthis-0.0.7 → linthis-0.0.8}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "maturin"
 
 [project]
 name = "linthis"
-version = "0.0.7"
+version = "0.0.8"
 description = "A fast, cross-platform multi-language linter and formatter"
 readme = "README.md"
 requires-python = ">=3.8"

{linthis-0.0.7 → linthis-0.0.8}/src/checkers/cpp.rs

@@ -44,6 +44,10 @@ pub struct CppChecker {
     cpplint_cpp_config: CpplintConfig,
     /// Cpplint config for Objective-C files
     cpplint_oc_config: CpplintConfig,
+    /// Clang-tidy checks to ignore for C++ files
+    cpp_ignored_checks: Vec<String>,
+    /// Clang-tidy checks to ignore for Objective-C files
+    oc_ignored_checks: Vec<String>,
 }
 
 impl CppChecker {
@@ -54,11 +58,16 @@ impl CppChecker {
         // Load clang-tidy config from linthis plugin configs
         let clang_tidy_config = Self::find_plugin_clang_tidy_config();
 
+        // Load ignored checks for clang-tidy
+        let (cpp_ignored, oc_ignored) = Self::load_ignored_checks();
+
         Self {
             config_path: clang_tidy_config,
             compile_commands_dir: None,
             cpplint_cpp_config: cpp_config,
             cpplint_oc_config: oc_config,
+            cpp_ignored_checks: cpp_ignored,
+            oc_ignored_checks: oc_ignored,
         }
     }
 
@@ -147,6 +156,34 @@ impl CppChecker {
         (cpp_config, oc_config)
     }
 
+    /// Load clang-tidy ignored checks from linthis configuration
+    fn load_ignored_checks() -> (Vec<String>, Vec<String>) {
+        use crate::config::Config;
+
+        let project_dir = std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."));
+        let merged = Config::load_merged(&project_dir);
+
+        // Default ignored checks for Objective-C (ARC-related false positives)
+        let default_oc_ignored = vec![
+            "clang-analyzer-osx.cocoa.RetainCount".to_string(),
+            "clang-analyzer-osx.cocoa.Dealloc".to_string(),
+        ];
+
+        let cpp_ignored = merged
+            .language_overrides
+            .cpp
+            .and_then(|c| c.clang_tidy_ignored_checks)
+            .unwrap_or_default();
+
+        let oc_ignored = merged
+            .language_overrides
+            .oc
+            .and_then(|c| c.clang_tidy_ignored_checks)
+            .unwrap_or(default_oc_ignored);
+
+        (cpp_ignored, oc_ignored)
+    }
+
     /// Merge two filter strings, removing duplicates
     fn merge_filters(base: Option<&str>, additional: &str) -> String {
         use std::collections::HashSet;
@@ -423,7 +460,16 @@ impl CppChecker {
             .map_err(|e| crate::LintisError::Checker(format!("Failed to run clang-tidy: {}", e)))?;
 
         let stdout = String::from_utf8_lossy(&output.stdout);
-        let issues = Self::parse_clang_tidy_output(&stdout, path);
+
+        // Select ignored checks based on file type
+        let is_oc = Self::is_objective_c(path);
+        let ignored_checks = if is_oc {
+            &self.oc_ignored_checks
+        } else {
+            &self.cpp_ignored_checks
+        };
+
+        let issues = Self::parse_clang_tidy_output(&stdout, path, ignored_checks);
 
         Ok(issues)
     }
@@ -470,11 +516,21 @@ impl CppChecker {
 
     /// Parse clang-tidy output
     /// Format: file:line:col: severity: message [check-name]
-    fn parse_clang_tidy_output(output: &str, file_path: &Path) -> Vec<LintIssue> {
+    fn parse_clang_tidy_output(
+        output: &str,
+        file_path: &Path,
+        ignored_checks: &[String],
+    ) -> Vec<LintIssue> {
         let mut issues = Vec::new();
 
         for line in output.lines() {
             if let Some(issue) = Self::parse_clang_tidy_line(line, file_path) {
+                // Filter out ignored checks
+                if let Some(ref code) = issue.code {
+                    if ignored_checks.iter().any(|ignored| code == ignored) {
+                        continue;
+                    }
+                }
                 issues.push(issue);
             }
         }
@@ -559,9 +615,12 @@ impl CppChecker {
             issue = issue.with_code(c);
         }
 
-        // Read the source code line
-        if let Some(code_line) = crate::utils::read_file_line(&file_path, line_num) {
-            issue = issue.with_code_line(code_line);
+        // Read the source code line with context
+        if let Some(ctx) = crate::utils::read_file_line_with_context(&file_path, line_num, 1) {
+            issue = issue
+                .with_code_line(ctx.line)
+                .with_context_before(ctx.before)
+                .with_context_after(ctx.after);
         }
 
         Some(issue)
@@ -631,9 +690,12 @@ impl CppChecker {
             issue = issue.with_code(c);
         }
 
-        // Read the source code line
-        if let Some(code_line) = crate::utils::read_file_line(&file_path, line_num) {
-            issue = issue.with_code_line(code_line);
+        // Read the source code line with context
+        if let Some(ctx) = crate::utils::read_file_line_with_context(&file_path, line_num, 1) {
+            issue = issue
+                .with_code_line(ctx.line)
+                .with_context_before(ctx.before)
+                .with_context_after(ctx.after);
         }
 
         Some(issue)

{linthis-0.0.7 → linthis-0.0.8}/src/config/mod.rs

@@ -176,6 +176,9 @@ pub struct CppLanguageConfig {
     /// Cpplint filter rules (e.g., "-build/c++11,-build/header_guard")
     #[serde(default)]
     pub cpplint_filter: Option<String>,
+    /// Clang-tidy checks to ignore (e.g., ["clang-analyzer-osx.cocoa.RetainCount"])
+    #[serde(default)]
+    pub clang_tidy_ignored_checks: Option<Vec<String>>,
 }
 
 impl LanguageOverrides {

linthis-0.0.8/src/interactive/editor.rs

@@ -0,0 +1,300 @@
+// Copyright 2024 zhlinh and linthis Project Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found at
+//
+// https://opensource.org/license/MIT
+//
+// The above copyright notice and this permission
+// notice shall be included in all copies or
+// substantial portions of the Software.
+
+//! Cross-platform editor integration for opening files at specific lines.
+
+use std::fs;
+use std::path::Path;
+use std::process::Command;
+use similar::{ChangeTag, TextDiff};
+
+/// Result of opening a file in an editor
+#[derive(Debug)]
+pub struct EditorResult {
+    /// Whether the editor operation succeeded
+    pub success: bool,
+    /// Lines that were changed (if any)
+    pub changes: Vec<LineChange>,
+    /// Error message if operation failed
+    pub error: Option<String>,
+}
+
+/// Information about a changed line
+#[derive(Debug, Clone)]
+pub struct LineChange {
+    pub line_number: usize,
+    pub old_content: String,
+    pub new_content: String,
+}
+
+/// Open a file in the user's preferred editor at a specific line and detect changes.
+///
+/// # Platform Support
+/// - Unix: Uses $EDITOR environment variable, defaults to vim
+/// - Windows: Uses $EDITOR if set, otherwise tries code, notepad++, then notepad
+///
+/// # Editor-specific line number arguments
+/// - vim/nvim/vi: +{line}
+/// - code (VS Code): --goto {file}:{line}:{column}
+/// - emacs: +{line} {file}
+/// - nano: +{line} {file}
+/// - sublime/subl: {file}:{line}
+/// - notepad++: -n{line} {file}
+/// - atom: {file}:{line}
+///
+/// # Arguments
+/// * `file` - Path to the file to open
+/// * `line` - Line number (1-indexed)
+/// * `column` - Optional column number (1-indexed)
+///
+/// # Returns
+/// * `EditorResult` with change information and success status
+pub fn open_in_editor(file: &Path, line: usize, column: Option<usize>) -> EditorResult {
+    // Read file content before editing
+    let original_content = match fs::read_to_string(file) {
+        Ok(content) => content,
+        Err(e) => {
+            return EditorResult {
+                success: false,
+                changes: vec![],
+                error: Some(format!("Failed to read file: {}", e)),
+            }
+        }
+    };
+    let editor = get_editor();
+    let editor_lower = editor.to_lowercase();
+
+    // Determine editor type and build command
+    let mut cmd = Command::new(&editor);
+
+    // Get the base name of the editor for matching
+    let editor_name = Path::new(&editor_lower)
+        .file_stem()
+        .and_then(|s| s.to_str())
+        .unwrap_or(&editor_lower);
+
+    match editor_name {
+        // VS Code family
+        "code" | "code-insiders" | "codium" => {
+            let col = column.unwrap_or(1);
+            cmd.arg("--goto")
+                .arg(format!("{}:{}:{}", file.display(), line, col));
+        }
+        // Vim family
+        "vim" | "nvim" | "vi" | "gvim" | "mvim" => {
+            cmd.arg(format!("+{}", line)).arg(file);
+        }
+        // Emacs
+        "emacs" | "emacsclient" => {
+            cmd.arg(format!("+{}", line)).arg(file);
+        }
+        // Nano
+        "nano" => {
+            cmd.arg(format!("+{}", line)).arg(file);
+        }
+        // Sublime Text
+        "sublime" | "subl" | "sublime_text" => {
+            let col = column.unwrap_or(1);
+            cmd.arg(format!("{}:{}:{}", file.display(), line, col));
+        }
+        // Notepad++
+        "notepad++" => {
+            cmd.arg(format!("-n{}", line)).arg(file);
+        }
+        // Atom (deprecated but still used)
+        "atom" => {
+            let col = column.unwrap_or(1);
+            cmd.arg(format!("{}:{}:{}", file.display(), line, col));
+        }
+        // Helix
+        "hx" | "helix" => {
+            let col = column.unwrap_or(1);
+            cmd.arg(format!("{}:{}:{}", file.display(), line, col));
+        }
+        // Kakoune
+        "kak" => {
+            cmd.arg(format!("+{}", line)).arg(file);
+        }
+        // JetBrains IDEs (idea, goland, pycharm, etc.) via command line
+        name if name.contains("idea") || name.contains("goland") || name.contains("pycharm") => {
+            let col = column.unwrap_or(1);
+            cmd.arg("--line")
+                .arg(line.to_string())
+                .arg("--column")
+                .arg(col.to_string())
+                .arg(file);
+        }
+        // Default: try vim-style +line argument
+        _ => {
+            cmd.arg(format!("+{}", line)).arg(file);
+        }
+    }
+
+    // Spawn the editor
+    let spawn_result = cmd.spawn();
+
+    match spawn_result {
+        Ok(mut child) => {
+            // Wait for the editor to close
+            match child.wait() {
+                Ok(status) => {
+                    if !status.success() {
+                        return EditorResult {
+                            success: false,
+                            changes: vec![],
+                            error: Some(format!(
+                                "Editor '{}' exited with status: {}",
+                                editor,
+                                status.code().unwrap_or(-1)
+                            )),
+                        };
+                    }
+
+                    // Read file content after editing
+                    let new_content = match fs::read_to_string(file) {
+                        Ok(content) => content,
+                        Err(e) => {
+                            return EditorResult {
+                                success: false,
+                                changes: vec![],
+                                error: Some(format!("Failed to read file after editing: {}", e)),
+                            }
+                        }
+                    };
+
+                    // Detect changes
+                    let changes = detect_changes(&original_content, &new_content);
+
+                    EditorResult {
+                        success: true,
+                        changes,
+                        error: None,
+                    }
+                }
+                Err(e) => EditorResult {
+                    success: false,
+                    changes: vec![],
+                    error: Some(format!("Failed to wait for editor '{}': {}", editor, e)),
+                },
+            }
+        }
+        Err(e) => EditorResult {
+            success: false,
+            changes: vec![],
+            error: Some(format!("Failed to launch editor '{}': {}", editor, e)),
+        },
+    }
+}
+
+/// Detect changes between two versions of file content using proper diff algorithm
+fn detect_changes(original: &str, new: &str) -> Vec<LineChange> {
+    let mut changes = Vec::new();
+
+    // Use the similar crate's TextDiff to compute proper line-based diff
+    let diff = TextDiff::from_lines(original, new);
+
+    // Track current line number in new version
+    let mut new_line_num = 0;
+
+    // Process each change operation
+    for change in diff.iter_all_changes() {
+        match change.tag() {
+            ChangeTag::Equal => {
+                // Line unchanged, just increment counter
+                new_line_num += 1;
+            }
+            ChangeTag::Delete => {
+                // Line deleted from old version
+                changes.push(LineChange {
+                    line_number: new_line_num + 1, // Position in new file where deletion occurred
+                    old_content: change.to_string().trim_end().to_string(),
+                    new_content: String::new(), // Deleted, so new content is empty
+                });
+            }
+            ChangeTag::Insert => {
+                // Line inserted in new version
+                new_line_num += 1;
+                changes.push(LineChange {
+                    line_number: new_line_num,
+                    old_content: String::new(), // Inserted, so old content is empty
+                    new_content: change.to_string().trim_end().to_string(),
+                });
+            }
+        }
+    }
+
+    changes
+}
+
+/// Get the user's preferred editor from environment variables.
+///
+/// Checks in order:
+/// 1. $EDITOR
+/// 2. $VISUAL
+/// 3. Platform-specific defaults
+fn get_editor() -> String {
+    // Check EDITOR first
+    if let Ok(editor) = std::env::var("EDITOR") {
+        if !editor.is_empty() {
+            return editor;
+        }
+    }
+
+    // Check VISUAL
+    if let Ok(visual) = std::env::var("VISUAL") {
+        if !visual.is_empty() {
+            return visual;
+        }
+    }
+
+    // Platform-specific defaults
+    #[cfg(windows)]
+    {
+        // On Windows, try to find a reasonable editor
+        // Check if common editors are available in PATH
+        for editor in &["code", "notepad++", "notepad"] {
+            if which_exists(editor) {
+                return editor.to_string();
+            }
+        }
+        "notepad".to_string()
+    }
+
+    #[cfg(not(windows))]
+    {
+        // On Unix, default to vim
+        "vim".to_string()
+    }
+}
+
+/// Check if a command exists in PATH (Windows-compatible)
+#[cfg(windows)]
+fn which_exists(cmd: &str) -> bool {
+    use std::process::Stdio;
+    Command::new("where")
+        .arg(cmd)
+        .stdout(Stdio::null())
+        .stderr(Stdio::null())
+        .status()
+        .map(|s| s.success())
+        .unwrap_or(false)
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_get_editor_default() {
+        // This test depends on environment, just ensure it returns something
+        let editor = get_editor();
+        assert!(!editor.is_empty());
+    }
+}