linthis 0.0.12__tar.gz → 0.0.13__tar.gz

{linthis-0.0.12 → linthis-0.0.13}/Cargo.lock

@@ -1208,7 +1208,7 @@ dependencies = [
 
 [[package]]
 name = "linthis"
-version = "0.0.12"
+version = "0.0.13"
 dependencies = [
  "anyhow",
  "async-trait",

{linthis-0.0.12 → linthis-0.0.13}/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "linthis"
-version = "0.0.12"
+version = "0.0.13"
 edition = "2021"
 authors = ["zhlinh"]
 description = "A fast, cross-platform multi-language linter and formatter"

{linthis-0.0.12 → linthis-0.0.13}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: linthis
-Version: 0.0.12
+Version: 0.0.13
 Classifier: Development Status :: 3 - Alpha
 Classifier: Environment :: Console
 Classifier: Intended Audience :: Developers

{linthis-0.0.12 → linthis-0.0.13}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "maturin"
 
 [project]
 name = "linthis"
-version = "0.0.12"
+version = "0.0.13"
 description = "A fast, cross-platform multi-language linter and formatter"
 readme = "README.md"
 requires-python = ">=3.8"

{linthis-0.0.12 → linthis-0.0.13}/src/checkers/cpp.rs

@@ -18,6 +18,7 @@ use std::process::Command;
 
 /// Cpplint configuration for different languages
 #[derive(Debug, Clone)]
+#[derive(Default)]
 pub struct CpplintConfig {
     /// Line length limit
     pub linelength: Option<u32>,
@@ -25,14 +26,6 @@ pub struct CpplintConfig {
     pub filter: Option<String>,
 }
 
-impl Default for CpplintConfig {
-    fn default() -> Self {
-        Self {
-            linelength: None,
-            filter: None,
-        }
-    }
-}
 
 /// C/C++ checker using clang-tidy (preferred) or cpplint.
 pub struct CppChecker {

{linthis-0.0.12 → linthis-0.0.13}/src/cli/init.rs

@@ -65,7 +65,7 @@ fn handle_config_migrate(
 
     // Parse tool filter
     let tool_filter = match from_tool.as_ref() {
-        Some(t) => match Tool::from_str(t) {
+        Some(t) => match Tool::parse(t) {
             Some(tool) => Some(tool),
             None => {
                 eprintln!(
@@ -147,7 +147,7 @@ fn handle_config_migrate(
                 println!();
                 println!("{}", "Suggestions:".bold());
                 for suggestion in &result.suggestions {
-                    println!("  {} {}", "💡", suggestion);
+                    println!("  💡 {}", suggestion);
                 }
             }
 

{linthis-0.0.12 → linthis-0.0.13}/src/cli/runner.rs

@@ -55,13 +55,12 @@ pub fn perform_self_update(self_update_config: Option<&linthis::self_update::Sel
     let latest = manager.get_latest_version().unwrap_or_else(|| "unknown".to_string());
 
     // Prompt user if needed
-    if config.should_prompt() {
-        if !manager.prompt_user(&current, &latest) {
+    if config.should_prompt()
+        && !manager.prompt_user(&current, &latest) {
             // User declined, update timestamp to avoid repeated prompts
             let _ = manager.update_last_check_time();
             return false;
         }
-    }
 
     // Perform upgrade
     match manager.upgrade() {

{linthis-0.0.12 → linthis-0.0.13}/src/config/migrate/converters/eslint.rs

@@ -88,11 +88,12 @@ pub(crate) fn convert(
 
 /// Generate ESLint JavaScript config file content
 fn generate_eslint_js(config: &ESLintConfig) -> String {
-    let mut lines = Vec::new();
-    lines.push("// Migrated from existing ESLint config by linthis".to_string());
-    lines.push("// Review and adjust as needed".to_string());
-    lines.push(String::new());
-    lines.push("module.exports = {".to_string());
+    let mut lines = vec![
+        "// Migrated from existing ESLint config by linthis".to_string(),
+        "// Review and adjust as needed".to_string(),
+        String::new(),
+        "module.exports = {".to_string(),
+    ];
 
     // Add env
     if !config.env.is_empty() {

{linthis-0.0.12 → linthis-0.0.13}/src/config/migrate/converters/prettier.rs

@@ -59,15 +59,15 @@ pub(crate) fn convert(
 
 /// Generate Prettier JavaScript config file content
 fn generate_prettier_js(config: &prettier::PrettierConfig) -> String {
-    let mut lines = Vec::new();
-    lines.push("// Migrated from existing Prettier config by linthis".to_string());
-    lines.push("// Review and adjust as needed".to_string());
-    lines.push(String::new());
-    lines.push("module.exports = ".to_string());
-    lines.push(config.to_js_object());
-    lines.push(";".to_string());
-
-    lines.join("\n")
+    [
+        "// Migrated from existing Prettier config by linthis",
+        "// Review and adjust as needed",
+        "",
+        "module.exports = ",
+        &config.to_js_object(),
+        ";",
+    ]
+    .join("\n")
 }
 
 #[cfg(test)]

{linthis-0.0.12 → linthis-0.0.13}/src/config/migrate/mod.rs

@@ -44,7 +44,7 @@ impl Tool {
     }
 
     /// Parse tool from string
-    pub fn from_str(s: &str) -> Option<Self> {
+    pub fn parse(s: &str) -> Option<Self> {
         match s.to_lowercase().as_str() {
             "eslint" => Some(Tool::ESLint),
             "prettier" => Some(Tool::Prettier),

{linthis-0.0.12 → linthis-0.0.13}/src/config/migrate/parsers/prettier.rs

@@ -158,39 +158,39 @@ fn parse_js(content: &str) -> Result<PrettierConfig, String> {
 }
 
 fn extract_prettier_config(value: &serde_json::Value) -> Result<PrettierConfig, String> {
-    let mut config = PrettierConfig::default();
-
-    config.tab_width = value
-        .get("tabWidth")
-        .and_then(|v| v.as_u64())
-        .map(|n| n as u32);
-    config.use_tabs = value
-        .get("useTabs")
-        .and_then(|v| v.as_bool())
-        .unwrap_or(false);
-    config.semi = value.get("semi").and_then(|v| v.as_bool());
-    config.single_quote = value.get("singleQuote").and_then(|v| v.as_bool());
-    config.trailing_comma = value
-        .get("trailingComma")
-        .and_then(|v| v.as_str())
-        .map(String::from);
-    config.bracket_spacing = value.get("bracketSpacing").and_then(|v| v.as_bool());
-    config.print_width = value
-        .get("printWidth")
-        .and_then(|v| v.as_u64())
-        .map(|n| n as u32);
-    config.arrow_parens = value
-        .get("arrowParens")
-        .and_then(|v| v.as_str())
-        .map(String::from);
-    config.end_of_line = value
-        .get("endOfLine")
-        .and_then(|v| v.as_str())
-        .map(String::from);
-    config.prose_wrap = value
-        .get("proseWrap")
-        .and_then(|v| v.as_str())
-        .map(String::from);
+    let config = PrettierConfig {
+        tab_width: value
+            .get("tabWidth")
+            .and_then(|v| v.as_u64())
+            .map(|n| n as u32),
+        use_tabs: value
+            .get("useTabs")
+            .and_then(|v| v.as_bool())
+            .unwrap_or(false),
+        semi: value.get("semi").and_then(|v| v.as_bool()),
+        single_quote: value.get("singleQuote").and_then(|v| v.as_bool()),
+        trailing_comma: value
+            .get("trailingComma")
+            .and_then(|v| v.as_str())
+            .map(String::from),
+        bracket_spacing: value.get("bracketSpacing").and_then(|v| v.as_bool()),
+        print_width: value
+            .get("printWidth")
+            .and_then(|v| v.as_u64())
+            .map(|n| n as u32),
+        arrow_parens: value
+            .get("arrowParens")
+            .and_then(|v| v.as_str())
+            .map(String::from),
+        end_of_line: value
+            .get("endOfLine")
+            .and_then(|v| v.as_str())
+            .map(String::from),
+        prose_wrap: value
+            .get("proseWrap")
+            .and_then(|v| v.as_str())
+            .map(String::from),
+    };
 
     Ok(config)
 }

{linthis-0.0.12 → linthis-0.0.13}/src/config/mod.rs

@@ -719,6 +719,7 @@ fn find_similar_field(input: &str, candidates: &[&str]) -> Option<String> {
 }
 
 /// Calculate Levenshtein distance between two strings
+#[allow(clippy::needless_range_loop)]
 fn levenshtein_distance(a: &str, b: &str) -> usize {
     let a_chars: Vec<char> = a.chars().collect();
     let b_chars: Vec<char> = b.chars().collect();

{linthis-0.0.12 → linthis-0.0.13}/src/fixers/cpplint.rs

@@ -140,7 +140,7 @@ impl CpplintFixer {
 
             // Run pip install with progress output
             let mut child = match Command::new(pip_cmd)
-                .args(&["install", "cpplint", "--upgrade"])
+                .args(["install", "cpplint", "--upgrade"])
                 .stdout(Stdio::piped())
                 .stderr(Stdio::piped())
                 .spawn()
@@ -155,7 +155,7 @@ impl CpplintFixer {
             // Read and display output
             if let Some(stderr) = child.stderr.take() {
                 let reader = BufReader::new(stderr);
-                for line in reader.lines().flatten() {
+                for line in reader.lines().map_while(Result::ok) {
                     // Filter and display relevant progress information
                     if line.contains("Collecting")
                         || line.contains("Downloading")
@@ -398,11 +398,10 @@ impl CpplintFixer {
                             }
                             modified = true;
                         }
-                    } else if self.config.header_guard_mode == HeaderGuardMode::PragmaOnce {
-                        if self.convert_to_pragma_once(&mut lines) {
+                    } else if self.config.header_guard_mode == HeaderGuardMode::PragmaOnce
+                        && self.convert_to_pragma_once(&mut lines) {
                             modified = true;
                         }
-                    }
                 }
                 "readability/todo" => {
                     if self.fix_todo_from_error(&mut lines, error) {
@@ -631,7 +630,7 @@ impl CpplintFixer {
 
         // Add #endif at the end
         // Ensure there's an empty line before #endif
-        if !lines.last().map_or(true, |l| l.trim().is_empty()) {
+        if !lines.last().is_none_or(|l| l.trim().is_empty()) {
             lines.push(String::new());
         }
         lines.push(format!("#endif  // {}", guard_name));
@@ -854,9 +853,7 @@ impl CpplintFixer {
         loop {
             // Find next // starting from search_start
             let rest = &line[search_start..];
-            let Some(rel_pos) = rest.find("//") else {
-                return None;
-            };
+            let rel_pos = rest.find("//")?;
 
             let abs_pos = search_start + rel_pos;
             let before_comment = &line[..abs_pos];
@@ -963,7 +960,7 @@ impl CpplintFixer {
 
         // Find the position of the lone semicolon (only whitespace before it)
         // Pattern: start with whitespace, then a semicolon, optionally followed by comment or whitespace
-        if let Some(re) = Regex::new(r"^(\s*);(\s*(?://.*)?)?$").ok() {
+        if let Ok(re) = Regex::new(r"^(\s*);(\s*(?://.*)?)?$") {
             if let Some(caps) = re.captures(line) {
                 let indent = caps.get(1).map(|m| m.as_str()).unwrap_or("");
                 let suffix = caps.get(2).map(|m| m.as_str()).unwrap_or("");
@@ -1038,7 +1035,7 @@ impl CpplintFixer {
         // Use regex to find = without proper spacing
         // Match: not preceded by space + = + not followed by space or =
         // But avoid ==, !=, <=, >=, +=, -=, etc.
-        if let Some(re) = Regex::new(r"([^\s=!<>+\-*/%&|^])=([^=\s])").ok() {
+        if let Ok(re) = Regex::new(r"([^\s=!<>+\-*/%&|^])=([^=\s])") {
             let result = re.replace_all(line, "$1 = $2").to_string();
             if result != *line {
                 lines[line_idx] = result;

{linthis-0.0.12 → linthis-0.0.13}/src/fixers/source.rs

@@ -92,9 +92,7 @@ impl SourceFixer {
         loop {
             // Find next // starting from search_start
             let rest = &line[search_start..];
-            let Some(rel_pos) = rest.find("//") else {
-                return None;
-            };
+            let rel_pos = rest.find("//")?;
 
             let abs_pos = search_start + rel_pos;
             let before_comment = &line[..abs_pos];
@@ -217,8 +215,8 @@ impl SourceFixer {
 
         let stdout = String::from_utf8_lossy(&output.stdout);
         for line in stdout.lines() {
-            if line.starts_with("author ") {
-                return Some(line[7..].to_string());
+            if let Some(author) = line.strip_prefix("author ") {
+                return Some(author.to_string());
             }
         }
 

{linthis-0.0.12 → linthis-0.0.13}/src/formatters/cpp.rs

@@ -521,7 +521,7 @@ impl CppFormatter {
             if bytes[i] == b'N' && bytes[i + 1] == b'S' {
                 let next_char = bytes[i + 2];
                 // Check if next char is uppercase A-Z (ASCII 65-90)
-                if (b'A'..=b'Z').contains(&next_char) {
+                if next_char.is_ascii_uppercase() {
                     // Make sure it's not part of a longer identifier before "NS"
                     // (i.e., NS should be at word boundary)
                     if i == 0 || !is_identifier_char(bytes[i - 1]) {

{linthis-0.0.12 → linthis-0.0.13}/src/interactive/menu.rs

@@ -695,22 +695,6 @@ fn read_line() -> String {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::Language;
-    use std::path::PathBuf;
-
-    fn make_test_issue(severity: Severity) -> LintIssue {
-        LintIssue::new(
-            PathBuf::from("test.cpp"),
-            42,
-            "Test message".to_string(),
-            severity,
-        )
-        .with_column(10)
-        .with_code("TEST001".to_string())
-        .with_source("test-linter".to_string())
-        .with_language(Language::Cpp)
-        .with_code_line("    int x = 42;".to_string())
-    }
 
     #[test]
     fn test_interactive_result_default() {

{linthis-0.0.12 → linthis-0.0.13}/src/interactive/nolint.rs

@@ -122,8 +122,8 @@ pub fn add_nolint_comment(issue: &LintIssue) -> NolintResult {
             let mut found_idx = None;
             let mut best_match_score: i32 = 0;
 
-            for i in search_start..search_end {
-                let line_trimmed = lines[i].trim();
+            for (i, line) in lines.iter().enumerate().skip(search_start).take(search_end - search_start) {
+                let line_trimmed = line.trim();
 
                 // Calculate base similarity score
                 let base_score: i32 = if line_trimmed == expected_trimmed {
@@ -143,7 +143,7 @@ pub fn add_nolint_comment(issue: &LintIssue) -> NolintResult {
                 };
 
                 // Apply distance penalty (prefer lines closer to original position)
-                let distance = if i > line_idx { i - line_idx } else { line_idx - i } as i32;
+                let distance = i.abs_diff(line_idx) as i32;
                 let score = base_score - (distance * 5);
 
                 // Only consider matches with good score (>= 400 for high confidence)
@@ -151,7 +151,7 @@ pub fn add_nolint_comment(issue: &LintIssue) -> NolintResult {
                     best_match_score = score;
                     found_idx = Some(i);
                     eprintln!("[DEBUG] Found match at line {}: base_score={}, distance={}, final_score={}, content={:?}",
-                             i + 1, base_score, distance, score, lines[i]);
+                             i + 1, base_score, distance, score, line);
                 }
             }
 

{linthis-0.0.12 → linthis-0.0.13}/src/lib.rs

@@ -192,7 +192,7 @@ pub enum LintisError {
     #[error("Cache error ({operation}): {message}")]
     Cache { operation: String, message: String },
 
-    #[error("Tool not available: {tool} ({language})")]
+    #[error("Tool not available: {tool} ({language}). {install_hint}")]
     ToolNotAvailable {
         tool: String,
         language: String,
@@ -443,7 +443,7 @@ impl Language {
             if bytes[i] == b'N' && bytes[i + 1] == b'S' {
                 let next_char = bytes[i + 2];
                 // Check if next char is uppercase A-Z (ASCII 65-90)
-                if (b'A'..=b'Z').contains(&next_char) {
+                if next_char.is_ascii_uppercase() {
                     // Make sure it's not part of a longer identifier before "NS"
                     // (i.e., NS should be at word boundary)
                     if i == 0 || !Self::is_identifier_char(bytes[i - 1]) {
@@ -1338,10 +1338,8 @@ pub fn run(options: &RunOptions) -> Result<RunResult> {
                 .collect();
 
             // Add format results
-            for format_result in format_results {
-                if let Some(fr) = format_result {
-                    result.add_format_result(fr);
-                }
+            for fr in format_results.into_iter().flatten() {
+                result.add_format_result(fr);
             }
         }
         // Clear progress line

{linthis-0.0.12 → linthis-0.0.13}/src/lsp/diagnostics.rs

@@ -110,7 +110,7 @@ mod tests {
         assert_eq!(diag.range.start.character, 4); // 0-indexed
         assert_eq!(diag.severity, Some(DiagnosticSeverity::WARNING));
         assert_eq!(diag.code, Some(NumberOrString::String("W0612".to_string())));
-        assert_eq!(diag.source, Some("ruff".to_string()));
+        assert_eq!(diag.source, Some("linthis-ruff".to_string()));
         assert!(diag.message.contains("Unused variable"));
     }
 

{linthis-0.0.12 → linthis-0.0.13}/src/lsp/document.rs

@@ -20,8 +20,10 @@ use tower_lsp::lsp_types::Url;
 #[derive(Debug, Clone)]
 pub struct DocumentState {
     /// The URI of the document.
+    #[allow(dead_code)]
     pub uri: Url,
     /// The file path on disk.
+    #[allow(dead_code)]
     pub path: PathBuf,
     /// The document version (incremented on each change).
     pub version: i32,
@@ -82,18 +84,21 @@ impl DocumentManager {
     }
 
     /// Get the state of a document.
+    #[allow(dead_code)]
     pub async fn get(&self, uri: &Url) -> Option<DocumentState> {
         let docs = self.documents.read().await;
         docs.get(uri).cloned()
     }
 
     /// Get the file path for a document URI.
+    #[allow(dead_code)]
     pub async fn get_path(&self, uri: &Url) -> Option<PathBuf> {
         let docs = self.documents.read().await;
         docs.get(uri).map(|s| s.path.clone())
     }
 
     /// Get all open document URIs.
+    #[allow(dead_code)]
     pub async fn all_uris(&self) -> Vec<Url> {
         let docs = self.documents.read().await;
         docs.keys().cloned().collect()

{linthis-0.0.12 → linthis-0.0.13}/src/main.rs

@@ -259,8 +259,8 @@ fn main() -> ExitCode {
                                 if std::fs::create_dir_all(&lang_dir).is_ok() {
                                     let target = lang_dir.join(filename);
                                     // Always update to latest plugin config
-                                    if std::fs::copy(&config.config_path, &target).is_ok() {
-                                        if cli.verbose {
+                                    if std::fs::copy(&config.config_path, &target).is_ok()
+                                        && cli.verbose {
                                             eprintln!(
                                                 "  - {}/{}: {} -> .linthis/configs/{}/{}",
                                                 config.language,
@@ -270,7 +270,6 @@ fn main() -> ExitCode {
                                                 filename.to_string_lossy()
                                             );
                                         }
-                                    }
                                 }
                             }
                         }

{linthis-0.0.12 → linthis-0.0.13}/src/tui/ui.rs

@@ -95,6 +95,7 @@ pub fn border_style(focused: bool) -> Style {
 }
 
 /// Format a file path for display
+#[allow(dead_code)]
 pub fn format_path(path: &std::path::Path, max_len: usize) -> String {
     let s = path.display().to_string();
     if s.len() <= max_len {

{linthis-0.0.12 → linthis-0.0.13}/tests/integration/common.rs

@@ -1,5 +1,7 @@
 //! Common test utilities for integration tests.
 
+#![allow(dead_code)]
+
 use std::path::Path;
 use std::process::{Command, Output};
 use tempfile::TempDir;