learning-credentials 0.5.3__tar.gz → 0.5.4__tar.gz

{learning_credentials-0.5.3 → learning_credentials-0.5.4}/CHANGELOG.rst

@@ -16,6 +16,15 @@ Unreleased
 
 *
 
+0.5.4 - 2026-11-10
+******************
+
+Fixed
+=====
+
+* PDF credential generation with ``pypdf>=7.0.0``. The overlay is now merged into the page after it is attached to
+  the ``PdfWriter``, because merging into a page that is not attached to a writer is no longer supported.
+
 0.5.3 - 2026-08-11
 ******************
 

{learning_credentials-0.5.3/learning_credentials.egg-info → learning_credentials-0.5.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: learning-credentials
-Version: 0.5.3
+Version: 0.5.4
 Summary: A pluggable service for preparing Open edX credentials.
 Author-email: OpenCraft <help@opencraft.com>
 License-Expression: AGPL-3.0-or-later
@@ -177,6 +177,15 @@ Unreleased
 
 *
 
+0.5.4 - 2026-11-10
+******************
+
+Fixed
+=====
+
+* PDF credential generation with ``pypdf>=7.0.0``. The overlay is now merged into the page after it is attached to
+  the ``PdfWriter``, because merging into a page that is not attached to a writer is no longer supported.
+
 0.5.3 - 2026-08-11
 ******************
 

{learning_credentials-0.5.3 → learning_credentials-0.5.4}/learning_credentials/generators.py

@@ -449,8 +449,8 @@ def generate_pdf_credential(credential: Credential, options: dict[str, Any], *,
         )
 
         overlay_pdf = PdfReader(io.BytesIO(pdf_canvas.getpdfdata()))
-        template.merge_page(overlay_pdf.pages[0])
-        pdf_writer.add_page(template)
+        page = pdf_writer.add_page(template)
+        page.merge_page(overlay_pdf.pages[0])
 
         url = _save_credential(pdf_writer, credential.uuid)
 

{learning_credentials-0.5.3 → learning_credentials-0.5.4/learning_credentials.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: learning-credentials
-Version: 0.5.3
+Version: 0.5.4
 Summary: A pluggable service for preparing Open edX credentials.
 Author-email: OpenCraft <help@opencraft.com>
 License-Expression: AGPL-3.0-or-later
@@ -177,6 +177,15 @@ Unreleased
 
 *
 
+0.5.4 - 2026-11-10
+******************
+
+Fixed
+=====
+
+* PDF credential generation with ``pypdf>=7.0.0``. The overlay is now merged into the page after it is attached to
+  the ``PdfWriter``, because merging into a page that is not attached to a writer is no longer supported.
+
 0.5.3 - 2026-08-11
 ******************
 

{learning_credentials-0.5.3 → learning_credentials-0.5.4}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "learning-credentials"
-version = "0.5.3"
+version = "0.5.4"
 description = "A pluggable service for preparing Open edX credentials."
 dynamic = ["readme"]
 requires-python = ">=3.11"

{learning_credentials-0.5.3 → learning_credentials-0.5.4}/tests/test_generators.py

@@ -542,6 +542,35 @@ def test_generate_pdf_credential(  # noqa: PLR0917
     mock_save_credential.assert_called_once()
 
 
+@pytest.mark.filterwarnings('error::DeprecationWarning')
+@patch('learning_credentials.generators._save_credential', return_value='credential_url')
+@patch('learning_credentials.generators.CredentialAsset.get_asset_by_slug')
+def test_generate_pdf_credential_merges_overlay_into_template(mock_get_asset_by_slug: Mock, mock_save_credential: Mock):
+    """Test that generate_pdf_credential merges the overlay into the template without using deprecated pypdf APIs."""
+    template_writer = PdfWriter()
+    template_writer.add_blank_page(width=842, height=595)
+    template_buffer = io.BytesIO()
+    template_writer.write(template_buffer)
+    mock_get_asset_by_slug.return_value = ContentFile(template_buffer.getvalue(), name='template.pdf')
+
+    credential = Mock(
+        user_full_name='Test User',
+        learning_context_name='Test Course',
+        verify_uuid=uuid4(),
+        created=Mock(),
+    )
+
+    with patch('learning_credentials.generators.get_localized_credential_date', return_value='April 1, 2021'):
+        result = generate_pdf_credential(credential, {'template': 'template'})
+
+    assert result == 'credential_url'
+    pdf_writer = mock_save_credential.call_args.args[0]
+    assert len(pdf_writer.pages) == 1
+    page_text = pdf_writer.pages[0].extract_text()
+    assert 'Test User' in page_text
+    assert 'Test Course' in page_text
+
+
 def test_generate_pdf_credential_no_template():
     """Test that generate_pdf_credential raises ValueError when no template is specified."""
     credential = Mock(learning_context_name='Test Course')